Re: [FFmpeg-devel] [RFC] [PATCH] avcodec/codec_par: Keep format channel layout if specified

2023-07-25 Thread Raphaël Zumer
Thanks for the reply; I wasn't looking to merge the RFC as-is, but rather to figure out the preferred approach, and most importantly make sure that there is no fundamental disagreement on suppressing codec-level metadata in situations where it conflicts with format-level. I will see which of

Re: [FFmpeg-devel] [RFC] [PATCH] avcodec/codec_par: Keep format channel layout if specified

2023-07-25 Thread Anton Khirnov
Quoting Vittorio Giovara > > Any comments on this patch? If no objections I'd like to push it at the end > of the week Sorry, not acceptable. This is the wrong place to do it. AVCodecParameters is a dumb container for parameters. It MUST NOT make any assumptions about who calls it or for what

Re: [FFmpeg-devel] [RFC] [PATCH] avcodec/codec_par: Keep format channel layout if specified

2023-07-25 Thread Vittorio Giovara
On Sat, Jul 15, 2023 at 4:51 PM Raphaël Zumer wrote: > Hello, > > Tagging this as RFC in case there is disagreement on the correct/desired > behavior. > > For context: > I am working with spatial audio and noticed that FFmpeg does not honor the > SA3D box metadata, which is used to signal

[FFmpeg-devel] [RFC] [PATCH] avcodec/codec_par: Keep format channel layout if specified

2023-07-15 Thread Raphaël Zumer
Hello, Tagging this as RFC in case there is disagreement on the correct/desired behavior. For context: I am working with spatial audio and noticed that FFmpeg does not honor the SA3D box metadata, which is used to signal ambisonic audio channel layouts. FFmpeg does parse the SA3D box and