Re: [FFmpeg-devel] Patch libavformat/aviobuf.c fixes data loss on named pipe reads

2017-05-13 Thread James Almer
On 5/13/2017 6:00 PM, Moritz Barsnick wrote: > On Fri, May 12, 2017 at 19:13:21 +, Rob Meyers wrote: >> Attaching the output of "git diff -p". > > That will work, but > $ git format-patch --signoff > is recommended: > https://ffmpeg.org/developer.html#Submitting-patches git format-patch is a

Re: [FFmpeg-devel] Patch libavformat/aviobuf.c fixes data loss on named pipe reads

2017-05-13 Thread Moritz Barsnick
On Fri, May 12, 2017 at 19:13:21 +, Rob Meyers wrote: > Attaching the output of "git diff -p". That will work, but $ git format-patch --signoff is recommended: https://ffmpeg.org/developer.html#Submitting-patches Your method lost the commit message (which was incorrectly worded anyway ;-)).

Re: [FFmpeg-devel] Patch libavformat/aviobuf.c fixes data loss on named pipe reads

2017-05-12 Thread Rob Meyers
Attaching the output of "git diff -p". On Fri, May 12, 2017 at 11:50 AM Michael Niedermayer wrote: > On Fri, May 12, 2017 at 06:31:19PM +, Rob Meyers wrote: > > Submitting a patch to fix a bug in ffmpeg found when reading data from a > > named pipe. In our test, a

Re: [FFmpeg-devel] Patch libavformat/aviobuf.c fixes data loss on named pipe reads

2017-05-12 Thread Michael Niedermayer
On Fri, May 12, 2017 at 06:31:19PM +, Rob Meyers wrote: > Submitting a patch to fix a bug in ffmpeg found when reading data from a > named pipe. In our test, a pipe sending twelve bytes in two 6 byte messages > results in the first 10 bytes being lost. We found the problem was > introduced

[FFmpeg-devel] Patch libavformat/aviobuf.c fixes data loss on named pipe reads

2017-05-12 Thread Rob Meyers
Submitting a patch to fix a bug in ffmpeg found when reading data from a named pipe. In our test, a pipe sending twelve bytes in two 6 byte messages results in the first 10 bytes being lost. We found the problem was introduced with this commit (2ca48e466675a8a3630061cd2c15325eab8eda97) on June 30,