Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-16 Thread Andreas Håkon
Hi, ‐‐‐ Original Message ‐‐‐ On Saturday, 10 de August de 2019 20:05, Andreas Håkon wrote: > Hi Gyan and Nicolas, > > ‐‐‐ Original Message ‐‐‐ > On Saturday, 10 de August de 2019 17:13, Nicolas George geo...@nsup.org wrote: > > > Gyan (12019-08-10): > > > > > Since both pts

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-10 Thread Andreas Håkon
Hi Gyan and Nicolas, ‐‐‐ Original Message ‐‐‐ On Saturday, 10 de August de 2019 17:13, Nicolas George wrote: > Gyan (12019-08-10): > > > Since both pts and dts are altered, avoid pts only labels. > > Dissenting opinion: PTS is the important thing, and there are lot of > places where we

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-10 Thread Nicolas George
Gyan (12019-08-10): > Since both pts and dts are altered, avoid pts only labels. Dissenting opinion: PTS is the important thing, and there are lot of places where we says PTS because TS is ambiguous (Transport Stream?). DTS is just an annoying technical tidbit that goes with PTS. Regards, --

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-10 Thread Gyan
On 09-08-2019 12:14 PM, Andreas Håkon wrote: Hi Gyan, Nicolas and Alexander, ‐‐‐ Original Message ‐‐‐ On Friday, 9 de August de 2019 3:18, Alexander Strasser wrote: [...] Gyan [...] Nicolas George [...] Alexander I appreciate your suggestions with the name. But, we

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-10 Thread Nicolas George
Andreas Håkon (12019-08-09): > I appreciate your suggestions with the name. But, we need to select one. > So I propose a short list: > > - "timeshift" (the current name) > - "pts_offset" > - "editpts" > > I don't like "ts_offset" as "ts" can be understood as Transport Stream. > I don't want

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-09 Thread Andreas Håkon
Hi Gyan, Nicolas and Alexander, ‐‐‐ Original Message ‐‐‐ On Friday, 9 de August de 2019 3:18, Alexander Strasser wrote: > > [...] > Gyan > > [...] > Nicolas George > > [...] > Alexander I appreciate your suggestions with the name. But, we need to select one. So I propose a

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-08 Thread Alexander Strasser
Hi Nicolas! On 2019-08-08 11:43 +0200, Nicolas George wrote: > Andreas Håkon (12019-08-08): > > > setpts or setts, similar to lavfi. > > > Then I proposse these two alternatives: > > > > 1) "editpts_bsf" > > 2) "setpts_bsf" > > > > The "_bsf" is not real, only to differenciate (here) from other

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-08 Thread Nicolas George
Andreas Håkon (12019-08-08): > > setpts or setts, similar to lavfi. > Then I proposse these two alternatives: > > 1) "editpts_bsf" > 2) "setpts_bsf" > > The "_bsf" is not real, only to differenciate (here) from other filters. > Which one do you prefer? editpts has no similarity with lavfi.

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-08 Thread Gyan
On 08-08-2019 02:16 PM, Nicolas George wrote: Alexander Strasser (12019-08-08): Maybe others have better suggestions. setpts or setts, similar to lavfi. This BSF only allows to apply a fixed offset whereas the setpts filter allows arbitrary expressions. Unless someone is planning to

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-08 Thread Andreas Håkon
Hi Nicolas, ‐‐‐ Original Message ‐‐‐ On Thursday, 8 de August de 2019 10:46, Nicolas George wrote: > Alexander Strasser (12019-08-08): > > > Maybe others have better suggestions. > > setpts or setts, similar to lavfi. Then I proposse these two alternatives: 1) "editpts_bsf" 2)

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-08 Thread Nicolas George
Alexander Strasser (12019-08-08): > Maybe others have better suggestions. setpts or setts, similar to lavfi. Although in lavfi I have a vague intention of merging all the set* filters into a single one. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-07 Thread Andreas Håkon
Hi Alexander, ‐‐‐ Original Message ‐‐‐ On Thursday, 8 de August de 2019 1:43, Alexander Strasser wrote: > On 2019-08-07 15:51 +, Andreas Håkon wrote: > > > Hi, > > This new version changes the name of the filter, and implements all > > suggestions. > > Thanks for renaming;

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-07 Thread Alexander Strasser
On 2019-08-07 15:51 +, Andreas Håkon wrote: > Hi, > > This new version changes the name of the filter, and implements all > suggestions. Sorry, I couldn't reply earlier. Thanks for renaming; "timeshift" sounds better to me, compared to the previous "timer". Other suggestions which I came

[FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-07 Thread Andreas Håkon
Hi, This new version changes the name of the filter, and implements all suggestions. Supersedes: https://patchwork.ffmpeg.org/patch/14195/ https://patchwork.ffmpeg.org/patch/13743/ https://patchwork.ffmpeg.org/patch/13699/ Regards. A.H. ---From 9e036e0a1dc20fd5c41686a48a5a0c2142f91de4 Mon Sep