Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Check for Tiled and Stripped TIFFs

2020-05-21 Thread Michael Niedermayer
On Thu, May 21, 2020 at 12:13:15PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-05-21 08:59:27) > > > > I dont see IS_IRAP_NAL() and IS_IDR_NAL() to check every field in the > > headers > > to be consistent with IDR / IRAP NALs, which is what the tiff code in this > > thread do

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Check for Tiled and Stripped TIFFs

2020-05-21 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-05-21 08:59:27) > > I dont see IS_IRAP_NAL() and IS_IDR_NAL() to check every field in the headers > to be consistent with IDR / IRAP NALs, which is what the tiff code in this > thread does kind off .. > > to match hevc, i could add something like > #define HAVE_T

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Check for Tiled and Stripped TIFFs

2020-05-21 Thread Michael Niedermayer
On Thu, Feb 27, 2020 at 12:07:16PM -0300, James Almer wrote: > On 2/27/2020 11:10 AM, Carl Eugen Hoyos wrote: > > Am Do., 27. Feb. 2020 um 15:05 Uhr schrieb Anton Khirnov > > : > >> > >> Quoting Michael Niedermayer (2020-02-19 16:49:51) > >>> TIFF 6 spec: "Do not use both strip-oriented and tile-o

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Check for Tiled and Stripped TIFFs

2020-02-27 Thread James Almer
On 2/27/2020 11:10 AM, Carl Eugen Hoyos wrote: > Am Do., 27. Feb. 2020 um 15:05 Uhr schrieb Anton Khirnov : >> >> Quoting Michael Niedermayer (2020-02-19 16:49:51) >>> TIFF 6 spec: "Do not use both strip-oriented and tile-oriented fields in >>> the same TIFF file." >>> >>> Fixes: null pointer use,

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Check for Tiled and Stripped TIFFs

2020-02-27 Thread Carl Eugen Hoyos
Am Do., 27. Feb. 2020 um 15:05 Uhr schrieb Anton Khirnov : > > Quoting Michael Niedermayer (2020-02-19 16:49:51) > > TIFF 6 spec: "Do not use both strip-oriented and tile-oriented fields in > > the same TIFF file." > > > > Fixes: null pointer use, crash > > Fixes: crash-762680f9d1b27f9b9085e12887a

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Check for Tiled and Stripped TIFFs

2020-02-27 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-02-19 16:49:51) > TIFF 6 spec: "Do not use both strip-oriented and tile-oriented fields in the > same TIFF file." > > Fixes: null pointer use, crash > Fixes: crash-762680f9d1b27f9b9085e12887ad44893fb2b020 > > Found-by: Shiziru > Signed-off-by: Michael Niedermay