Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-09 Thread James Almer
On 5/8/2017 7:00 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure | 2 + > doc/filters.texi | 23 ++ > libavfilter/Makefile | 1 + > libavfilter/af_afir.c | 535 >

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-09 Thread Paul B Mahol
On 5/9/17, Muhammad Faiz wrote: > On Tue, May 9, 2017 at 5:03 AM, Paul B Mahol wrote: >> On 5/8/17, Muhammad Faiz wrote: >>> On Mon, May 8, 2017 at 11:06 PM, Paul B Mahol wrote: On 5/8/17, Muhammad Faiz

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-08 Thread Muhammad Faiz
On Tue, May 9, 2017 at 5:03 AM, Paul B Mahol wrote: > On 5/8/17, Muhammad Faiz wrote: >> On Mon, May 8, 2017 at 11:06 PM, Paul B Mahol wrote: >>> On 5/8/17, Muhammad Faiz wrote: On Mon, May 8, 2017 at 6:59 PM, Paul B

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-08 Thread Paul B Mahol
On 5/8/17, Muhammad Faiz wrote: > On Mon, May 8, 2017 at 11:06 PM, Paul B Mahol wrote: >> On 5/8/17, Muhammad Faiz wrote: >>> On Mon, May 8, 2017 at 6:59 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-08 Thread Muhammad Faiz
On Mon, May 8, 2017 at 11:06 PM, Paul B Mahol wrote: > On 5/8/17, Muhammad Faiz wrote: >> On Mon, May 8, 2017 at 6:59 PM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> configure| 2 +

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-08 Thread Paul B Mahol
On 5/8/17, Muhammad Faiz wrote: > On Mon, May 8, 2017 at 6:59 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure| 2 + >> doc/filters.texi | 23 ++ >> libavfilter/Makefile | 1 + >>

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-08 Thread Muhammad Faiz
On Mon, May 8, 2017 at 6:59 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure| 2 + > doc/filters.texi | 23 ++ > libavfilter/Makefile | 1 + > libavfilter/af_afir.c| 544 >

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-08 Thread Muhammad Faiz
On Mon, May 8, 2017 at 3:43 PM, Paul B Mahol wrote: > On 5/8/17, Muhammad Faiz wrote: >> On Mon, May 8, 2017 at 1:22 AM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> configure| 2 + >>>

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-08 Thread Paul B Mahol
On 5/8/17, Muhammad Faiz wrote: > On Mon, May 8, 2017 at 1:22 AM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure| 2 + >> doc/filters.texi | 30 +++ >> libavfilter/Makefile | 1 + >>

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-08 Thread Muhammad Faiz
On Mon, May 8, 2017 at 1:22 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure| 2 + > doc/filters.texi | 30 +++ > libavfilter/Makefile | 1 + > libavfilter/af_afir.c| 541 >

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-06 Thread Muhammad Faiz
On Sat, May 6, 2017 at 2:30 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure| 2 + > doc/filters.texi | 10 + > libavfilter/Makefile | 1 + > libavfilter/af_afir.c| 484 >

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-06 Thread Muhammad Faiz
On Sun, May 7, 2017 at 2:49 AM, Paul B Mahol wrote: > On 5/6/17, Muhammad Faiz wrote: >> On Sat, May 6, 2017 at 2:33 AM, Paul B Mahol wrote: >>> On 5/5/17, Muhammad Faiz wrote: >>> Is pts handled correctly here? Seem

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-06 Thread Paul B Mahol
On 5/6/17, Muhammad Faiz wrote: > On Sat, May 6, 2017 at 2:33 AM, Paul B Mahol wrote: >> On 5/5/17, Muhammad Faiz wrote: >> Is pts handled correctly here? Seem it is not derived from input pts. >> > > It can not be derived in

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-06 Thread Muhammad Faiz
On Sat, May 6, 2017 at 3:54 PM, Paul B Mahol wrote: > On 5/6/17, Muhammad Faiz wrote: >> On Sat, May 6, 2017 at 2:30 AM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> configure| 2 + >>>

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-06 Thread Paul B Mahol
On 5/6/17, Muhammad Faiz wrote: > On Sat, May 6, 2017 at 2:30 AM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure| 2 + >> doc/filters.texi | 10 + >> libavfilter/Makefile | 1 + >>

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-05 Thread Muhammad Faiz
On Sat, May 6, 2017 at 2:30 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure| 2 + > doc/filters.texi | 10 + > libavfilter/Makefile | 1 + > libavfilter/af_afir.c| 484 >

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-05 Thread Muhammad Faiz
On Sat, May 6, 2017 at 2:33 AM, Paul B Mahol wrote: > On 5/5/17, Muhammad Faiz wrote: > Is pts handled correctly here? Seem it is not derived from input pts. > It can not be derived in any other way. >>> >>> Probably, at least, first pts

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-05 Thread Paul B Mahol
On 5/5/17, Muhammad Faiz wrote: Is pts handled correctly here? Seem it is not derived from input pts. >>> >>> It can not be derived in any other way. >> >> Probably, at least, first pts should be derived from input pts. >> Also, is time_base always 1/sample_rate? >> >>

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-05 Thread Paul B Mahol
On 5/3/17, Moritz Barsnick wrote: > On Mon, May 01, 2017 at 10:30:20 +0200, Paul B Mahol wrote: >> +.name = "afirfilter", > > Does a filter have any reason to have "filter" in its name? It seems > unusual. > Renamed. ___

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-05 Thread Muhammad Faiz
On Wed, May 3, 2017 at 4:12 PM, Muhammad Faiz wrote: > On Wed, May 3, 2017 at 1:47 AM, Paul B Mahol wrote: >> On 5/2/17, Muhammad Faiz wrote: >>> On Mon, May 1, 2017 at 3:30 PM, Paul B Mahol wrote: Signed-off-by: Paul

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-03 Thread Moritz Barsnick
On Mon, May 01, 2017 at 10:30:20 +0200, Paul B Mahol wrote: > +.name = "afirfilter", Does a filter have any reason to have "filter" in its name? It seems unusual. Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-03 Thread Muhammad Faiz
On Wed, May 3, 2017 at 1:47 AM, Paul B Mahol wrote: > On 5/2/17, Muhammad Faiz wrote: >> On Mon, May 1, 2017 at 3:30 PM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> configure | 2 +

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-02 Thread Paul B Mahol
On 5/2/17, Muhammad Faiz wrote: > On Mon, May 1, 2017 at 3:30 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure | 2 + >> doc/filters.texi| 10 ++ >> libavfilter/Makefile|

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-02 Thread Muhammad Faiz
On Mon, May 1, 2017 at 3:30 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure | 2 + > doc/filters.texi| 10 ++ > libavfilter/Makefile| 1 + > libavfilter/af_afirfilter.c | 409 >

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-01 Thread Paul B Mahol
On 5/1/17, Muhammad Faiz wrote: > On Mon, May 1, 2017 at 5:02 AM, Paul B Mahol wrote: [...] >> + >> +for (ch = 0; ch < s->nb_channels; ch++) { >> +dst = (float *)out->extended_data[ch]; >> +buf = (float

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-04-30 Thread Muhammad Faiz
On Mon, May 1, 2017 at 5:02 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi| 7 + > libavfilter/Makefile| 1 + > libavfilter/af_afirfilter.c | 411 > >