Re: [FFmpeg-devel] [PATCH] avformat/ivf: Change the length field to 32 bits

2019-10-02 Thread Raphaël Zumer
On Tue, 2019-10-01 at 15:57 -0400, Calvin Walton wrote: > On Tue, 2019-10-01 at 21:41 +0200, Carl Eugen Hoyos wrote: > > Am Di., 1. Okt. 2019 um 21:35 Uhr schrieb Raphaël Zumer < > > rzu...@tebako.net>: > > > On Tue, 2019-10-01 at 20:09 +0100, Derek Buitenhuis wrote: > > > > Why not just write

Re: [FFmpeg-devel] [PATCH] avformat/ivf: Change the length field to 32 bits

2019-10-01 Thread Calvin Walton
On Tue, 2019-10-01 at 21:41 +0200, Carl Eugen Hoyos wrote: > Am Di., 1. Okt. 2019 um 21:35 Uhr schrieb Raphaël Zumer < > rzu...@tebako.net>: > > On Tue, 2019-10-01 at 20:09 +0100, Derek Buitenhuis wrote: > > > On 01/10/2019 18:25, James Almer wrote: > > > > The value in the unused field will be

Re: [FFmpeg-devel] [PATCH] avformat/ivf: Change the length field to 32 bits

2019-10-01 Thread Carl Eugen Hoyos
Am Di., 1. Okt. 2019 um 21:35 Uhr schrieb Raphaël Zumer : > > On Tue, 2019-10-01 at 20:09 +0100, Derek Buitenhuis wrote: > > On 01/10/2019 18:25, James Almer wrote: > > > The value in the unused field will be 0x after this change > > > instead of 0, since you're writing 32 bits as duration

Re: [FFmpeg-devel] [PATCH] avformat/ivf: Change the length field to 32 bits

2019-10-01 Thread Raphaël Zumer
On Tue, 2019-10-01 at 20:09 +0100, Derek Buitenhuis wrote: > On 01/10/2019 18:25, James Almer wrote: > > The value in the unused field will be 0x after this change > > instead of 0, since you're writing 32 bits as duration instead of > > 64 > > where the high 32 bits (corresponding to the

Re: [FFmpeg-devel] [PATCH] avformat/ivf: Change the length field to 32 bits

2019-10-01 Thread Derek Buitenhuis
On 01/10/2019 18:25, James Almer wrote: > The value in the unused field will be 0x after this change > instead of 0, since you're writing 32 bits as duration instead of 64 > where the high 32 bits (corresponding to the unused field) are zeroed. > That means the ivf demuxer prior to this

Re: [FFmpeg-devel] [PATCH] avformat/ivf: Change the length field to 32 bits

2019-10-01 Thread Raphaël Zumer
Thank you for the review. I have left the encoded value as 64 bits and split the patch into two in the v2 just sent: one for the decoder change in field size, and one for the encoder comments. On Tue, 2019-10-01 at 14:25 -0300, James Almer wrote: > On 10/1/2019 2:05 PM, Raphaël Zumer wrote: > >

Re: [FFmpeg-devel] [PATCH] avformat/ivf: Change the length field to 32 bits

2019-10-01 Thread James Almer
On 10/1/2019 2:05 PM, Raphaël Zumer wrote: > Signed-off-by: Raphaël Zumer > --- > libavformat/ivfdec.c | 3 ++- > libavformat/ivfenc.c | 5 +++-- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavformat/ivfdec.c b/libavformat/ivfdec.c > index 40ae464b76..2fdb6f5a04 100644