Andrew Kelley:
> On 4/10/24 07:11, Andreas Rheinhardt wrote:
>> I don't
>> see a simplification of the Makefile.
>
> Relevant part from the diff:
>
> --- a/libavcodec/bsf/Makefile
> +++ b/libavcodec/bsf/Makefile
> @@ -45,5 +45,3 @@ OBJS-$(CONFIG_VP9_SUPERFRAME_BSF) +=
>
On 4/10/24 07:11, Andreas Rheinhardt wrote:
I don't
see a simplification of the Makefile.
Relevant part from the diff:
--- a/libavcodec/bsf/Makefile
+++ b/libavcodec/bsf/Makefile
@@ -45,5 +45,3 @@ OBJS-$(CONFIG_VP9_SUPERFRAME_BSF) +=
bsf/vp9_superframe.o
And the New Dictator have Risen!
On Wed, Apr 10, 2024 at 4:12 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Andrew Kelley:
> > Removes the special -I flag specified in the avcodec/bsf/ subdirectory.
> >
> > This makes code copy-pastable to other parts of the ffmpeg codebase,
Andrew Kelley:
> Removes the special -I flag specified in the avcodec/bsf/ subdirectory.
>
> This makes code copy-pastable to other parts of the ffmpeg codebase, as
> well as simplifying the build script.
If you want to make the code copy-pastable to other parts, you need to
disallow using the
Apr 10, 2024, 06:54 by an...@khirnov.net:
> Quoting James Almer (2024-04-10 03:23:46)
>
>> On 4/9/2024 10:11 PM, Andrew Kelley wrote:
>> > On 4/9/24 17:04, Lynne wrote:
>> >> LGTM.
>> >> That's how I wrote the AAC patchset as well.
>> >
>> > Thank you for the review, Lynne.
>> >
>> > What is the
Quoting James Almer (2024-04-10 03:23:46)
> On 4/9/2024 10:11 PM, Andrew Kelley wrote:
> > On 4/9/24 17:04, Lynne wrote:
> >> LGTM.
> >> That's how I wrote the AAC patchset as well.
> >
> > Thank you for the review, Lynne.
> >
> > What is the next step? I do not have commit access.
>
> Applied
On 4/9/2024 10:11 PM, Andrew Kelley wrote:
On 4/9/24 17:04, Lynne wrote:
LGTM.
That's how I wrote the AAC patchset as well.
Thank you for the review, Lynne.
What is the next step? I do not have commit access.
Applied it, thanks.
___
ffmpeg-devel
On 4/9/24 17:04, Lynne wrote:
LGTM.
That's how I wrote the AAC patchset as well.
Thank you for the review, Lynne.
What is the next step? I do not have commit access.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
Apr 9, 2024, 23:24 by and...@ziglang.org:
> Removes the special -I flag specified in the avcodec/bsf/ subdirectory.
>
> This makes code copy-pastable to other parts of the ffmpeg codebase, as
> well as simplifying the build script.
>
> It also reduces ambiguity, since there are many instances of
