Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-11 Thread Aaron Levinson
On 12/9/2017 11:25 PM, Rostislav Pehlivanov wrote: On 10 December 2017 at 02:41, Aaron Levinson wrote: On 12/9/2017 6:24 PM, Aaron Levinson wrote: On 12/9/2017 6:15 PM, Aaron Levinson wrote: On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote: W

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-10 Thread Michael Niedermayer
On Fri, Dec 08, 2017 at 07:42:50PM +0100, Michael Niedermayer wrote: > On Fri, Dec 08, 2017 at 08:46:52AM +0100, Mateusz wrote: > > After commit 3701d49 'error_resilience: remove avpriv_atomic usage' > > we have included windows.h in much more files and we should > > avoid conflicts with defines/fu

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-09 Thread Rostislav Pehlivanov
On 10 December 2017 at 02:41, Aaron Levinson wrote: > On 12/9/2017 6:24 PM, Aaron Levinson wrote: > >> On 12/9/2017 6:15 PM, Aaron Levinson wrote: >> >>> On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: >>> On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote: > W dniu 07.12.2017 o 22:58

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-09 Thread Aaron Levinson
On 12/9/2017 6:24 PM, Aaron Levinson wrote: On 12/9/2017 6:15 PM, Aaron Levinson wrote: On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote: W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: Am 07.12.2017 20:40 schrieb "Mateusz" : W dniu 07.12.2017 o 1

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-09 Thread Aaron Levinson
On 12/9/2017 6:15 PM, Aaron Levinson wrote: On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote: W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: Am 07.12.2017 20:40 schrieb "Mateusz" : W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze: On Thu, Dec 7, 2

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-09 Thread Aaron Levinson
On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote: W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: Am 07.12.2017 20:40 schrieb "Mateusz" : W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze: On Thu, Dec 7, 2017 at 2:02 AM, Mateusz wrote: After commi

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-09 Thread Hendrik Leppkes
On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote: > W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: >> Am 07.12.2017 20:40 schrieb "Mateusz" : >> >> W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze: >>> On Thu, Dec 7, 2017 at 2:02 AM, Mateusz wrote: After commit 3701d49 'error_resilience: rem

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-08 Thread Michael Niedermayer
On Fri, Dec 08, 2017 at 08:46:52AM +0100, Mateusz wrote: > After commit 3701d49 'error_resilience: remove avpriv_atomic usage' > we have included windows.h in much more files and we should > avoid conflicts with defines/function declarations. > > Signed-off-by: Mateusz Brzostek > --- > libavcode

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-07 Thread Mateusz
W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: > Am 07.12.2017 20:40 schrieb "Mateusz" : > > W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze: >> On Thu, Dec 7, 2017 at 2:02 AM, Mateusz wrote: >>> After commit 3701d49 'error_resilience: remove avpriv_atomic usage' >>> we have included windows.

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-07 Thread Hendrik Leppkes
Am 07.12.2017 20:40 schrieb "Mateusz" : W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze: > On Thu, Dec 7, 2017 at 2:02 AM, Mateusz wrote: >> After commit 3701d49 'error_resilience: remove avpriv_atomic usage' >> we have included windows.h in much more files and we should >> avoid conflicts with

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-07 Thread Mateusz
W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze: > On Thu, Dec 7, 2017 at 2:02 AM, Mateusz wrote: >> After commit 3701d49 'error_resilience: remove avpriv_atomic usage' >> we have included windows.h in much more files and we should >> avoid conflicts with defines/function declarations. >> >> We s

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-07 Thread Hendrik Leppkes
On Thu, Dec 7, 2017 at 2:02 AM, Mateusz wrote: > After commit 3701d49 'error_resilience: remove avpriv_atomic usage' > we have included windows.h in much more files and we should > avoid conflicts with defines/function declarations. > > We should declare compatible variables for atomic compat wrap

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread wm4
On Tue, 5 Dec 2017 22:38:11 +0100 Hendrik Leppkes wrote: > On Tue, Dec 5, 2017 at 8:23 PM, James Almer wrote: > > On 12/5/2017 8:12 AM, Hendrik Leppkes wrote: > >> On Tue, Dec 5, 2017 at 12:31 AM, Mateusz wrote: > >>> After some tests: > >>> 1) #undef far > >>> after #include is wrong -- i

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread Hendrik Leppkes
On Tue, Dec 5, 2017 at 8:23 PM, James Almer wrote: > On 12/5/2017 8:12 AM, Hendrik Leppkes wrote: >> On Tue, Dec 5, 2017 at 12:31 AM, Mateusz wrote: >>> After some tests: >>> 1) #undef far >>> after #include is wrong -- in oleauto.h is declaration >>> WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread James Almer
On 12/5/2017 8:12 AM, Hendrik Leppkes wrote: > On Tue, Dec 5, 2017 at 12:31 AM, Mateusz wrote: >> After some tests: >> 1) #undef far >> after #include is wrong -- in oleauto.h is declaration >> WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out_ BYTE FAR* pbOut); >> and 'FAR' is defined as 'far' which

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread Mateusz
W dniu 05.12.2017 o 12:12, Hendrik Leppkes pisze: > On Tue, Dec 5, 2017 at 12:31 AM, Mateusz wrote: >> After some tests: >> 1) #undef far >> after #include is wrong -- in oleauto.h is declaration >> WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out_ BYTE FAR* pbOut); >> and 'FAR' is defined as 'far' w

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread Mateusz
W dniu 05.12.2017 o 17:44, James Almer pisze: > On 12/5/2017 1:40 PM, Mateusz wrote: >> W dniu 05.12.2017 o 15:20, James Almer pisze: >>> On 12/4/2017 8:31 PM, Mateusz wrote: After some tests: 1) #undef far after #include is wrong -- in oleauto.h is declaration WINOLEAUTAPI Var

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread Hendrik Leppkes
On Tue, Dec 5, 2017 at 5:25 PM, James Almer wrote: > On 12/5/2017 1:13 PM, Hendrik Leppkes wrote: >> On Tue, Dec 5, 2017 at 3:20 PM, James Almer wrote: >>> On 12/4/2017 8:31 PM, Mateusz wrote: After some tests: 1) #undef far after #include is wrong -- in oleauto.h is declaration >

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread Rostislav Pehlivanov
On 5 December 2017 at 16:40, Mateusz wrote: > W dniu 05.12.2017 o 15:20, James Almer pisze: > > On 12/4/2017 8:31 PM, Mateusz wrote: > >> After some tests: > >> 1) #undef far > >> after #include is wrong -- in oleauto.h is declaration > >> WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out_ BYTE FAR*

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread James Almer
On 12/5/2017 1:40 PM, Mateusz wrote: > W dniu 05.12.2017 o 15:20, James Almer pisze: >> On 12/4/2017 8:31 PM, Mateusz wrote: >>> After some tests: >>> 1) #undef far >>> after #include is wrong -- in oleauto.h is declaration >>> WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out_ BYTE FAR* pbOut); >>> an

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread Mateusz
W dniu 05.12.2017 o 15:20, James Almer pisze: > On 12/4/2017 8:31 PM, Mateusz wrote: >> After some tests: >> 1) #undef far >> after #include is wrong -- in oleauto.h is declaration >> WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out_ BYTE FAR* pbOut); >> and 'FAR' is defined as 'far' which is define a

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread James Almer
On 12/5/2017 1:13 PM, Hendrik Leppkes wrote: > On Tue, Dec 5, 2017 at 3:20 PM, James Almer wrote: >> On 12/4/2017 8:31 PM, Mateusz wrote: >>> After some tests: >>> 1) #undef far >>> after #include is wrong -- in oleauto.h is declaration >>> WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out_ BYTE FAR*

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread Hendrik Leppkes
On Tue, Dec 5, 2017 at 3:20 PM, James Almer wrote: > On 12/4/2017 8:31 PM, Mateusz wrote: >> After some tests: >> 1) #undef far >> after #include is wrong -- in oleauto.h is declaration >> WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out_ BYTE FAR* pbOut); >> and 'FAR' is defined as 'far' which is de

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread James Almer
On 12/4/2017 8:31 PM, Mateusz wrote: > After some tests: > 1) #undef far > after #include is wrong -- in oleauto.h is declaration > WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out_ BYTE FAR* pbOut); > and 'FAR' is defined as 'far' which is define as empty. > > 2) #undef near > after #include works

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread Hendrik Leppkes
On Tue, Dec 5, 2017 at 12:31 AM, Mateusz wrote: > After some tests: > 1) #undef far > after #include is wrong -- in oleauto.h is declaration > WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out_ BYTE FAR* pbOut); > and 'FAR' is defined as 'far' which is define as empty. Yeah generally undefing all of

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-04 Thread Mateusz
After some tests: 1) #undef far after #include is wrong -- in oleauto.h is declaration WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out_ BYTE FAR* pbOut); and 'FAR' is defined as 'far' which is define as empty. 2) #undef near after #include works in ffmpeg but is danger -- see 1) 3) after git rever

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-04 Thread Mateusz
W dniu 04.12.2017 o 15:02, Derek Buitenhuis pisze: > On 12/4/2017 8:03 AM, Mateusz wrote: >> After commit 3701d49 'error_resilience: remove avpriv_atomic usage' >> we have included windows.h in much more files and we should >> avoid conflicts with defines/function declarations. >> >> Signed-off-by:

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-04 Thread Derek Buitenhuis
On 12/4/2017 8:03 AM, Mateusz wrote: > After commit 3701d49 'error_resilience: remove avpriv_atomic usage' > we have included windows.h in much more files and we should > avoid conflicts with defines/function declarations. > > Signed-off-by: Mateusz Brzostek > --- > libavcodec/jpegls.h | 4

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-03 Thread Mateusz
W dniu 03.12.2017 o 22:26, Michael Niedermayer pisze: > On Sat, Dec 02, 2017 at 09:50:26PM +0100, Mateusz wrote: >> After commit 3701d49 'error_resilience: remove avpriv_atomic usage' >> we have included windows.h in much more files and we should >> avoid conflicts with defines/function declaration

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-03 Thread Michael Niedermayer
On Sat, Dec 02, 2017 at 09:50:26PM +0100, Mateusz wrote: > After commit 3701d49 'error_resilience: remove avpriv_atomic usage' > we have included windows.h in much more files and we should > avoid conflicts with defines/function declarations. > > Signed-off-by: Mateusz Brzostek > --- > libavcode