On 3/13/2023 7:25 PM, Andreas Rheinhardt wrote:
James Almer:
On 3/9/2023 11:18 AM, Raphaël Zumer wrote:
Hi,
While I omitted adding v2/v3 here, I believe all comments on this set
of patches have been addressed so far, unless anyone strongly
disagrees with the rationale for moving dynamic HDR
James Almer:
> On 3/9/2023 11:18 AM, Raphaël Zumer wrote:
>> Hi,
>>
>> While I omitted adding v2/v3 here, I believe all comments on this set
>> of patches have been addressed so far, unless anyone strongly
>> disagrees with the rationale for moving dynamic HDR parsing and
>> serialization to
Quoting Raphaël Zumer (2023-03-12 22:50:27)
> I expanded on this in another email in the chain, but the buffer size needs
> to be communicated to the user, as it is not embedded in the payload. It
> seems needlessly convoluted to me to create a separate function solely to
> calculate the size
On 3/12/23 17:52, James Almer wrote:
> On 3/12/2023 6:50 PM, Raphaël Zumer wrote:
>> I expanded on this in another email in the chain, but the buffer size needs
>> to be communicated to the user, as it is not embedded in the payload. It
>> seems needlessly convoluted to me to create a separate
On 3/12/2023 6:50 PM, Raphaël Zumer wrote:
I expanded on this in another email in the chain, but the buffer size needs to
be communicated to the user, as it is not embedded in the payload. It seems
needlessly convoluted to me to create a separate function solely to calculate
the size of the
I expanded on this in another email in the chain, but the buffer size needs to
be communicated to the user, as it is not embedded in the payload. It seems
needlessly convoluted to me to create a separate function solely to calculate
the size of the buffer so that it can be allocated by the user
Quoting Raphaël Zumer (2023-03-02 22:43:29)
> +/**
> + * Serialize dynamic HDR10+ metadata to a user data registered ITU-T T.35
> buffer,
> + * excluding the country code and beginning with the terminal provider code.
> + * @param s A pointer containing the decoded AVDynamicHDRPlus structure.
> +
> From: ffmpeg-devel On Behalf Of Raphaël
> Zumer
> Sent: 2023年3月3日 5:43
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 2/2] avutil: add HDR10+ dynamic metadata
> serialization function
>
> Fixed brace style and moved inline buffer size calculation comments to a
> single
On 3/9/2023 11:18 AM, Raphaël Zumer wrote:
Hi,
While I omitted adding v2/v3 here, I believe all comments on this set of
patches have been addressed so far, unless anyone strongly disagrees with the
rationale for moving dynamic HDR parsing and serialization to libavutil or with
the function
Hi,
While I omitted adding v2/v3 here, I believe all comments on this set of
patches have been addressed so far, unless anyone strongly disagrees with the
rationale for moving dynamic HDR parsing and serialization to libavutil or with
the function signature.
Please let me know if I missed
On 3/2/23 15:24, Leo Izen wrote:
> On 3/2/23 14:25, Raphaël Zumer wrote:
>> Signed-off-by: Raphaël Zumer
>> ---
>> libavutil/hdr_dynamic_metadata.c | 146 +++
>> libavutil/hdr_dynamic_metadata.h | 11 +++
>> libavutil/version.h | 2 +-
>> 3 files
On 3/2/2023 8:24 PM, Leo Izen wrote:
> Why not put this in avcodec/dynamic_hdr10_plus.c? You reference
> put_bits.h which is in avcodec, so that can possibly be an issue, even
> though it is inlined (i.e. it sends the wrong message since avutil is
> supposed to not depend on avcodec).
put_bits
On 3/2/23 14:25, Raphaël Zumer wrote:
Signed-off-by: Raphaël Zumer
---
libavutil/hdr_dynamic_metadata.c | 146 +++
libavutil/hdr_dynamic_metadata.h | 11 +++
libavutil/version.h | 2 +-
3 files changed, 158 insertions(+), 1 deletion(-)
Why not
On 3/2/23 13:57, James Almer wrote:
> > The SEI for HEVC does keep the country code in the payload, but not AV1.
> Are you sure about HEVC? I just checked a sample and trace_headers
> reported this:
>
> [trace_headers] Prefix Supplemental Enhancement Information
> [trace_headers] 0
On 3/2/2023 3:33 PM, quietvoid wrote:> On 27/02/2023 12.34, Raphaël
Zumer wrote:
>
>> Resent due to my mail client incorrectly re-wrapping lines in the
>> version I sent earlier.
>> See the previous patch for context.
>>
>> Signed-off-by: Raphaël Zumer
>> ---
>>
On 3/2/23 13:33, quietvoid wrote:
> This patch series mentions that it would be used for AV1, however the AV1
> specification is clear that the payload does not contain the country code.
> https://aomediacodec.github.io/av1-hdr10plus/#hdr10plus-metadata, Figure 1.
>
> So far all the AV1 HDR10+
On 27/02/2023 12.34, Raphaël Zumer wrote:
Resent due to my mail client incorrectly re-wrapping lines in the version I
sent earlier.
See the previous patch for context.
Signed-off-by: Raphaël Zumer
---
libavutil/hdr_dynamic_metadata.c | 147 +++
17 matches
Mail list logo
