Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Michael Niedermayer
On Fri, Jan 16, 2015 at 08:48:59PM -0800, Philip Langdale wrote: On Fri, 16 Jan 2015 22:17:56 +0100 Nicolas George geo...@nsup.org wrote: Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : Right. It is display aspect ratio, not sample aspect ratio. And then you have the 45/44

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Nicolas George
L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : I haven't quite followed what's going on to decide whether Nvidia or FFmpeg is correct. FFmpeg is correct, there is absolutely no doubt about it: This active pixels nonsense is only relevant for certain very specific media, definitely not

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Philip Langdale
On Sat, 17 Jan 2015 19:27:17 + Kieran Kunhya kier...@obe.tv wrote: On 17 January 2015 at 18:14, Nicolas George geo...@nsup.org wrote: Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : On Fri, 16 Jan 2015 22:17:56 +0100 Nicolas George geo...@nsup.org wrote: Ok. I did this

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Kieran Kunhya
On 17 January 2015 at 18:14, Nicolas George geo...@nsup.org wrote: Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : On Fri, 16 Jan 2015 22:17:56 +0100 Nicolas George geo...@nsup.org wrote: Ok. I did this test and it produces correct results - SAR 133:221 which yields the correct

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Kieran Kunhya
FFmpeg is correct, there is absolutely no doubt about it: This active pixels nonsense is only relevant for certain very specific media, definitely not when encoding testsrc and decoding the result to showinfo. Demuxers or high-level tools may know when they are dealing with that kind of

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-16 Thread Philip Langdale
On 2015-01-15 23:48, Nicolas George wrote: Le septidi 27 nivôse, an CCXXIII, Timo Rothenpieler a écrit : +av_reduce(dw, dh, avctx-sample_aspect_ratio.num, avctx-sample_aspect_ratio.den, 4096); +ctx-init_encode_params.darHeight = dw; +ctx-init_encode_params.darWidth =

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-15 Thread Nicolas George
Le septidi 27 nivôse, an CCXXIII, Timo Rothenpieler a écrit : +av_reduce(dw, dh, avctx-sample_aspect_ratio.num, avctx-sample_aspect_ratio.den, 4096); +ctx-init_encode_params.darHeight = dw; +ctx-init_encode_params.darWidth = dh; Has this been actually tested? dar in