Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-24 Thread Tomas Härdin
mån 2023-06-19 klockan 00:36 +1200 skrev Kieran Kunhya: > On Sun, 18 Jun 2023 at 23:46, Paul B Mahol wrote: > > > > sdrdemux in libavformat will demodulate, do error correction then > > > return > > > AVPacket > > > with H.264 / Mpeg2 video or AAC or wahetever > > > That then will get passed to l

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-18 Thread Michael Niedermayer
On Sun, Jun 18, 2023 at 02:59:37PM +0200, Lynne wrote: > Jun 17, 2023, 20:37 by mich...@niedermayer.cc: > > > On Sat, Jun 17, 2023 at 08:08:11PM +0200, Paul B Mahol wrote: > > [...] > > > >> Which library handles compressed stuff? > >> > > > > For digital stuff like DAB/DVB/... > > > > sdrdemux in

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-18 Thread Lynne
Jun 18, 2023, 15:30 by h.lepp...@gmail.com: > On Sun, Jun 18, 2023 at 2:59 PM Lynne wrote: > >> >> Jun 17, 2023, 20:37 by mich...@niedermayer.cc: >> >> > On Sat, Jun 17, 2023 at 08:08:11PM +0200, Paul B Mahol wrote: >> > [...] >> > >> >> Which library handles compressed stuff? >> >> >> > >> > For

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-18 Thread Hendrik Leppkes
On Sun, Jun 18, 2023 at 2:59 PM Lynne wrote: > > Jun 17, 2023, 20:37 by mich...@niedermayer.cc: > > > On Sat, Jun 17, 2023 at 08:08:11PM +0200, Paul B Mahol wrote: > > [...] > > > >> Which library handles compressed stuff? > >> > > > > For digital stuff like DAB/DVB/... > > > > sdrdemux in libavfo

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-18 Thread Lynne
Jun 17, 2023, 20:37 by mich...@niedermayer.cc: > On Sat, Jun 17, 2023 at 08:08:11PM +0200, Paul B Mahol wrote: > [...] > >> Which library handles compressed stuff? >> > > For digital stuff like DAB/DVB/... > > sdrdemux in libavformat will demodulate, do error correction then return > AVPacket >

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-18 Thread Kieran Kunhya
On Sun, 18 Jun 2023 at 23:46, Paul B Mahol wrote: > > sdrdemux in libavformat will demodulate, do error correction then return > > AVPacket > > with H.264 / Mpeg2 video or AAC or wahetever > > That then will get passed to libavcodec, same as with any other demuxer. > Whilst I agree that there is

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-18 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 8:37 PM Michael Niedermayer wrote: > On Sat, Jun 17, 2023 at 08:08:11PM +0200, Paul B Mahol wrote: > [...] > > > Which library handles compressed stuff? > > For digital stuff like DAB/DVB/... > > sdrdemux in libavformat will demodulate, do error correction then return > AV

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Michael Niedermayer
On Sat, Jun 17, 2023 at 08:37:23PM +0200, Michael Niedermayer wrote: > On Sat, Jun 17, 2023 at 08:08:11PM +0200, Paul B Mahol wrote: > [...] > > > Which library handles compressed stuff? > > For digital stuff like DAB/DVB/... > > sdrdemux in libavformat will demodulate, do error correction then

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Michael Niedermayer
On Sat, Jun 17, 2023 at 08:08:11PM +0200, Paul B Mahol wrote: [...] > Which library handles compressed stuff? For digital stuff like DAB/DVB/... sdrdemux in libavformat will demodulate, do error correction then return AVPacket with H.264 / Mpeg2 video or AAC or wahetever That then will get pas

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Michael Niedermayer
On Sat, Jun 17, 2023 at 09:30:09AM -0400, Leo Izen wrote: > This is a nitpick, but can the commit message be something like: > > avformat: add Software Defined Radio support > > Upon casual glance, it could be confused for SDR as in Standard Dynamic > Range, when browsing the tree. Ultimately up2

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 2:48 PM Michael Niedermayer wrote: > Hi > > On Sat, Jun 17, 2023 at 01:08:45PM +0200, Paul B Mahol wrote: > [...] > > > But the biggest issue is your claim of demultiplexing, which your code > does > > not do, its done by called library. > > libsoapy is used just as a thin

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Leo Izen
This is a nitpick, but can the commit message be something like: avformat: add Software Defined Radio support Upon casual glance, it could be confused for SDR as in Standard Dynamic Range, when browsing the tree. Ultimately up2u, just my initial thoughts. - Leo Izen __

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Michael Niedermayer
Hi On Sat, Jun 17, 2023 at 01:08:45PM +0200, Paul B Mahol wrote: [...] > But the biggest issue is your claim of demultiplexing, which your code does > not do, its done by called library. libsoapy is used just as a thin and common interface to the SDR hardware If you comment all uses of libsoapy

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 10:46 AM Michael Niedermayer wrote: > On Sat, Jun 17, 2023 at 08:16:04AM +0200, Paul B Mahol wrote: > > Please no more pseudo demuxers. > > > > Use libavfilter API. > > sdrdemux takes a single linear stream of numbers containing multiple radio > stations and demuxes it int

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Michael Niedermayer
On Sat, Jun 17, 2023 at 08:16:04AM +0200, Paul B Mahol wrote: > Please no more pseudo demuxers. > > Use libavfilter API. sdrdemux takes a single linear stream of numbers containing multiple radio stations and demuxes it into individual streams (the stream can come from a file or a hardware devic

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-16 Thread Paul B Mahol
Please no more pseudo demuxers. Use libavfilter API. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscr