> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Derek Buitenhuis
> Sent: Friday, December 28, 2018 12:45 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH V3 2/3] avcodec/libx264: add support
> f
On 27/12/2018 11:06, Guo, Yejun wrote:
> +AVFrameSideData *sd = av_frame_get_side_data(frame,
> AV_FRAME_DATA_ROIS);
> +if (sd != NULL) {
Nit: `if (sd)` is convention.
> +qoffsets = (float*)av_mallocz_array(mbx * mby,
> sizeof(*qoffsets));
> +
