Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

On 6/15/17, Thomas Mundt wrote: > 2017-06-15 21:23 GMT+02:00 Nicolas George : > >> Le septidi 27 prairial, an CCXXV, Thomas Mundt a ecrit : >> > Hmm, before rewriting and sending this patch I asked if it would have a >> > chance to be pushed just to fix the

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-15 21:23 GMT+02:00 Nicolas George : > Le septidi 27 prairial, an CCXXV, Thomas Mundt a écrit : > > Hmm, before rewriting and sending this patch I asked if it would have a > > chance to be pushed just to fix the ticket which is open for a very long > > time. Your answer

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

Le septidi 27 prairial, an CCXXV, Thomas Mundt a écrit : > Hmm, before rewriting and sending this patch I asked if it would have a > chance to be pushed just to fix the ticket which is open for a very long > time. Your answer gave me the assumtion that you´re okay with it. > I thought your only

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-15 20:00 GMT+02:00 Nicolas George : > Le quintidi 25 prairial, an CCXXV, Thomas Mundt a écrit : > > Patch attached. This fixes ticket #2674. I inserted a FIXME message as a > > reminder. > > Please comment. > > I am sorry to say I do not like it. The timestamp computation

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

Le quintidi 25 prairial, an CCXXV, Thomas Mundt a écrit : > Patch attached. This fixes ticket #2674. I inserted a FIXME message as a > reminder. > Please comment. I am sorry to say I do not like it. The timestamp computation code in vf_fps is already quite complex, and this patch is making it

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-13 15:04 GMT+02:00 Thomas Mundt : > 2017-06-13 15:00 GMT+02:00 Nicolas George : > >> Le quintidi 25 prairial, an CCXXV, Thomas Mundt a écrit : >> > Live with the open ticket or with the modified patch? >> >> Either, actually, but I meant the modified

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-13 15:00 GMT+02:00 Nicolas George : > Le quintidi 25 prairial, an CCXXV, Thomas Mundt a écrit : > > Live with the open ticket or with the modified patch? > > Either, actually, but I meant the modified patch. > Okay, I´ll write the patch then and send it soon. Thanks and

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

Le quintidi 25 prairial, an CCXXV, Thomas Mundt a écrit : > Live with the open ticket or with the modified patch? Either, actually, but I meant the modified patch. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-13 14:46 GMT+02:00 Nicolas George : > Le quintidi 25 prairial, an CCXXV, Thoms Mundt a écrit : > > Since I dont see any solution or wip for this, I could modify my patch > and > > remove the use of pkt_duration. This would only work for constant frame > rate > > input,

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

Le quintidi 25 prairial, an CCXXV, Thoms Mundt a écrit : > Since I dont see any solution or wip for this, I could modify my patch and > remove the use of pkt_duration. This would only work for constant frame rate > input, but fixes ticket #2674 which is open for 4 years now. I can live with that.

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

/Nicolas George > schrieb am So, 2.4.2017:/ Le tridi 13 germinal, an CCXXV, Thomas Mundt a écrit : >/I found the use of this function in f_loop.c, so I thought it´s ok. / Well, it is a bug. I missed it when it was first committed.

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

>>>Nicolas George schrieb am So, 2.4.2017: > Fortunately, you do not need to change your e-mail provider and address, > you only need to change your mail software: just choose and install a > real and good mail client instead of relying on webmails. You will gain > a lot in

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

Le tridi 13 germinal, an CCXXV, Thomas Mundt a écrit : > Yes, I will switch to gmail... Fortunately, you do not need to change your e-mail provider and address, you only need to change your mail software: just choose and install a real and good mail client instead of relying on webmails. You will

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

>>Nicolas George schrieb am So, 2.4.2017: >> Will you also fix the ticket or shall I make a new patch then? > > I do not understand what you mean. So I think I misunderstood. Sorry, please ignore that sentence. > And maybe you should find a mail user agent that works and does

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

Le tridi 13 germinal, an CCXXV, Thomas Mundt a écrit : > OK, I´ll wait and use my patch locally meanwhile. Ok. > Will you also fix the ticket or shall I make a new patch then? I do not understand what you mean. And maybe you should find a mail user agent that works and does not break threads.

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

>>>Nicolas George schrieb am So, 2.4.2017: >>Le tridi 13 germinal, an CCXXV, Thomas Mundt a écrit : >... >> link->current_pts always returns the pts until the current (last) frame. >> I can calculate its duration for cfr video, but not for vfr. I need the pts >> until the

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

Le tridi 13 germinal, an CCXXV, Thomas Mundt a écrit : > I found the use of this function in f_loop.c, so I thought it´s ok. Well, it is a bug. I missed it when it was first committed. > link->current_pts always returns the pts until the current (last) frame. > I can calculate its duration for

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

>>>Nicolas George schrieb am Sa, 1.4.2017: > Le quartidi 4 germinal, an CCXXV, Thomas Mundt a écrit : >> v2: Use av_frame_get_pkt_duration to calculate count of duplication of last >> frame. >> Use average of the earlier pts steps when av_frame_get_pkt_duration is not >> set. >

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration=<98109900.4785518.1490351969...@mail.yahoo.com>

>>>Thomas Mundt schrieb am Fr, 24.3.2017: > Hi, > > > attached patch will fix ticket #2674. > Tested with examples from ticket 2674 and other files at various frame rates. > > v2: Use av_frame_get_pkt_duration to calculate count of duplication of last > frame. >

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

>>>Thomas Mundt schrieb am Fr, 24.3.2017: > Hi, > > > attached patch will fix ticket #2674. > Tested with examples from ticket 2674 and other files at various frame rates. > > v2: Use av_frame_get_pkt_duration to calculate count of duplication of last > frame. >

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

Le duodi 12 germinal, an CCXXV, Thomas Mundt a écrit : > Ping Replied to the patch itself. For some reason your mail is not connected to it. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

Le quartidi 4 germinal, an CCXXV, Thomas Mundt a écrit : > v2: Use av_frame_get_pkt_duration to calculate count of duplication of last > frame. > Use average of the earlier pts steps when av_frame_get_pkt_duration is not > set. Sorry for missing it earlier. pkt_duration is not used by lavfi.