Re: [FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

2016-03-05 Thread Mats Peterson
On 03/05/2016 06:14 PM, Michael Niedermayer wrote: On Sat, Mar 05, 2016 at 05:54:05PM +0100, Reimar Döffinger wrote: On Sat, Mar 05, 2016 at 02:32:56PM +0100, Mats Peterson wrote: On 03/05/2016 02:24 PM, Mats Peterson wrote: The original toon.avi doesn't contain xxpc chunks at keyframes

Re: [FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

2016-03-05 Thread Mats Peterson
On 03/05/2016 05:54 PM, Reimar Döffinger wrote: On Sat, Mar 05, 2016 at 02:32:56PM +0100, Mats Peterson wrote: On 03/05/2016 02:24 PM, Mats Peterson wrote: The original toon.avi doesn't contain xxpc chunks at keyframes either, if that can be of any comfort. It only contains two xxpc chunks,

Re: [FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

2016-03-05 Thread Michael Niedermayer
On Sat, Mar 05, 2016 at 12:21:14PM +0100, Mats Peterson wrote: > I've noticed that avienc.c is close to useless for use with stdout. > It only checks pb->seekable in a few places, and for example the > ff_end_tag() function uses avio_seek(), but that one is used in > several places where there is

Re: [FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

2016-03-05 Thread Reimar Döffinger
On Sat, Mar 05, 2016 at 02:32:56PM +0100, Mats Peterson wrote: > On 03/05/2016 02:24 PM, Mats Peterson wrote: > > > >The original toon.avi doesn't contain xxpc chunks at keyframes either, > >if that can be of any comfort. It only contains two xxpc chunks, at > >that. If you're able to invent

Re: [FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

2016-03-05 Thread Mats Peterson
On 03/05/2016 02:24 PM, Mats Peterson wrote: On 03/05/2016 12:21 PM, Mats Peterson wrote: I've noticed that avienc.c is close to useless for use with stdout. It only checks pb->seekable in a few places, and for example the ff_end_tag() function uses avio_seek(), but that one is used in several

Re: [FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

2016-03-05 Thread Mats Peterson
On 03/05/2016 01:18 PM, Mats Peterson wrote: On 03/05/2016 01:10 PM, Mats Peterson wrote: On 03/05/2016 12:21 PM, Mats Peterson wrote: I've noticed that avienc.c is close to useless for use with stdout. It only checks pb->seekable in a few places, and for example the ff_end_tag() function uses

Re: [FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

2016-03-05 Thread Mats Peterson
On 03/05/2016 01:10 PM, Mats Peterson wrote: On 03/05/2016 12:21 PM, Mats Peterson wrote: I've noticed that avienc.c is close to useless for use with stdout. It only checks pb->seekable in a few places, and for example the ff_end_tag() function uses avio_seek(), but that one is used in several

Re: [FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

2016-03-05 Thread Mats Peterson
On 03/05/2016 12:21 PM, Mats Peterson wrote: I've noticed that avienc.c is close to useless for use with stdout. It only checks pb->seekable in a few places, and for example the ff_end_tag() function uses avio_seek(), but that one is used in several places where there is no check for a seekable

Re: [FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

2016-03-05 Thread Mats Peterson
On 03/05/2016 12:41 PM, Mats Peterson wrote: On 03/05/2016 12:21 PM, Mats Peterson wrote: I've noticed that avienc.c is close to useless for use with stdout. It only checks pb->seekable in a few places, and for example the ff_end_tag() function uses avio_seek(), but that one is used in several

Re: [FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

2016-03-05 Thread Mats Peterson
On 03/05/2016 12:21 PM, Mats Peterson wrote: I've noticed that avienc.c is close to useless for use with stdout. It only checks pb->seekable in a few places, and for example the ff_end_tag() function uses avio_seek(), but that one is used in several places where there is no check for a seekable

Re: [FFmpeg-devel] [PATCH v5 1/4 v7] lavf/avienc: Add support for palette side data

2016-03-05 Thread Mats Peterson
On 03/05/2016 12:21 PM, Mats Peterson wrote: I've noticed that avienc.c is close to useless for use with stdout. It only checks pb->seekable in a few places, and for example the ff_end_tag() function uses avio_seek(), but that one is used in several places where there is no check for a seekable