Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-12-14 Thread Lou Logan
On Mon, Dec 14, 2015, at 12:24 PM, Ray Cole wrote: > Quite honestly I decided it isn't worth the frustration of trying to > submit a patch. It works for me and I'm happy with it. > > -- Ray Our guidelines and peer reviews may seem stringent, but consider it a quality control to help get the best

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-12-14 Thread Ray Cole
Quite honestly I decided it isn't worth the frustration of trying to submit a patch. It works for me and I'm happy with it. -- Ray On 12/14/2015 03:19 PM, Michael Niedermayer wrote: On Tue, Sep 29, 2015 at 11:02:33AM -0500, Ray Cole wrote: Here is an updated patch. I cleaned the code up to ho

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-12-14 Thread Michael Niedermayer
On Tue, Sep 29, 2015 at 11:02:33AM -0500, Ray Cole wrote: > Here is an updated patch. I cleaned the code up to hopefully be closer to > standards. It works well for me, but your mileage may vary... > > --- vf_decimate.c 2015-09-29 10:56:46.171698492 -0500 > +++ vf_decimatex.c2015-09-29 1

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-09-29 Thread Ray Cole
Here is an updated patch. I cleaned the code up to hopefully be closer to standards. It works well for me, but your mileage may vary... --- vf_decimate.c 2015-09-29 10:56:46.171698492 -0500 +++ vf_decimatex.c 2015-09-29 10:59:50.679695685 -0500 @@ -27,6 +27,7 @@ #define INPUT_MAIN

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-09-29 Thread Ray Cole
Thank you. I know I have a number of coding style things to clean up before this could be accepted (as well as removing some output I'm logging as info) but perhaps those familiar with the decimate filter can see if the changes being proposed make sense. -- Ray On 09/29/2015 07:32 AM, compn

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-09-29 Thread wm4
On Tue, 29 Sep 2015 06:42:53 -0500 Stephen Cole wrote: > Thank you for the responses. I assumed the comments would suffice for > discussing it initially so one wouldn't have to interpret the patch. I'll > produce a diff and resubmit. A patch is _much_ easier to read. __

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-09-29 Thread compn
On Mon, 28 Sep 2015 21:31:59 -0500 Ray Cole wrote: > This is the first time I've offered up code to any open source > project...so be gentle :-) ehe, patches are what the devs want, either git diff or diff -u... i've downloaded and diff'ed your filter to ffmpeg git master and attached it in thi

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-09-29 Thread Stephen Cole
Thank you for the responses. I assumed the comments would suffice for discussing it initially so one wouldn't have to interpret the patch. I'll produce a diff and resubmit. > On Sep 29, 2015, at 2:16 AM, Paul B Mahol wrote: > >> On 9/29/15, Ray Cole wrote: >> I hope this is the appropriate pl

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-09-29 Thread Carl Eugen Hoyos
Ray Cole gmail.com> writes: > I hope this is the appropriate place to propose an enhancement. Yes but please read https://ffmpeg.org/developer.html Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ff

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-09-29 Thread Anshul
On 09/29/2015 12:46 PM, Paul B Mahol wrote: On 9/29/15, Ray Cole wrote: I hope this is the appropriate place to propose an enhancement. This is the first time I've offered up code to any open source project...so be gentle :-) First, I love ffmpeg. Wonderful software and thank you for your ef

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-09-29 Thread Paul B Mahol
On 9/29/15, Ray Cole wrote: > I hope this is the appropriate place to propose an enhancement. This is the > first time I've offered up code to any open source project...so be gentle > :-) > > First, I love ffmpeg. Wonderful software and thank you for your efforts. > > I have been pulling down a nu