Re: [FFmpeg-devel] [PATCH 2/4] avcodec/a64multienc: don't set incorrect packet size

2015-02-23 Thread Andreas Cadhalpun
On 23.02.2015 01:41, Michael Niedermayer wrote: Subject: [PATCH 2/4] avcodec/a64multienc: don't set incorrect packet size This fixes invalid reads of the packet buffer in av_dup_packet. This leaves the packet size wrong for mc_use_5col = 0 The quoted commit broke the size calculation quite

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/a64multienc: use av_frame_ref instead of copying the frame

2015-02-23 Thread Andreas Cadhalpun
On 23.02.2015 01:56, Michael Niedermayer wrote: --- a/libavcodec/a64multienc.c +++ b/libavcodec/a64multienc.c @@ -317,7 +317,9 @@ static int a64multi_encode_frame(AVCodecContext *avctx, AVPacket *pkt, } else { /* fill up mc_meta_charset with data until lifetime exceeds */

Re: [FFmpeg-devel] [PATCH]Fix invalid memory accesses using the fade filter

2015-02-23 Thread Michael Niedermayer
On Mon, Feb 23, 2015 at 03:27:54AM +0100, Carl Eugen Hoyos wrote: Hi! Attached patch fixes a crash with the following command line: $ ffmpeg -loop 1 -i fate-suite/lena.pnm -vf format=yuva420p,fade -f null - Please comment, Carl Eugen vf_fade.c |5 - 1 file changed, 4

[FFmpeg-devel] [PATCH]Set bits_per_raw_sample for hqx

2015-02-23 Thread Carl Eugen Hoyos
Hi! Attached patch sets bits_per_raw_sample when decoding hqx. Please comment, Carl Eugen diff --git a/libavcodec/hqx.c b/libavcodec/hqx.c index c4b3bc6..44804cf 100644 --- a/libavcodec/hqx.c +++ b/libavcodec/hqx.c @@ -554,7 +554,7 @@ static int hqx_decode_frame(AVCodecContext *avctx, void

Re: [FFmpeg-devel] [PATCH 1/2] tests: add palettegen test

2015-02-23 Thread Michael Niedermayer
On Mon, Feb 23, 2015 at 01:57:00PM +0100, Clément Bœsch wrote: From: Clément Bœsch clem...@stupeflix.com --- tests/fate/filter-video.mak| 9 + tests/ref/fate/filter-palettegen-1 | 2 ++ tests/ref/fate/filter-palettegen-2 | 2 ++ 3 files changed, 13 insertions(+) create

[FFmpeg-devel] [PATCH 1/2] tests: add palettegen test

2015-02-23 Thread Clément Bœsch
From: Clément Bœsch clem...@stupeflix.com --- tests/fate/filter-video.mak| 9 + tests/ref/fate/filter-palettegen-1 | 2 ++ tests/ref/fate/filter-palettegen-2 | 2 ++ 3 files changed, 13 insertions(+) create mode 100644 tests/ref/fate/filter-palettegen-1 create mode 100644

[FFmpeg-devel] palette{gen,use} FATE tests

2015-02-23 Thread Clément Bœsch
Here are two tests for the recently added filters. I'm hopping that qsort will not cause any issue, otherwise we might need to switch to AV_QSORT (I'm thinking of the sort where multiple different values have the same score in palettegen). Also not sure whether framecrc needs a bitexact flag

Re: [FFmpeg-devel] [PATCH]Fix invalid memory accesses using the fade filter

2015-02-23 Thread Clément Bœsch
On Mon, Feb 23, 2015 at 01:59:45PM +0100, Michael Niedermayer wrote: On Mon, Feb 23, 2015 at 03:27:54AM +0100, Carl Eugen Hoyos wrote: Hi! Attached patch fixes a crash with the following command line: $ ffmpeg -loop 1 -i fate-suite/lena.pnm -vf format=yuva420p,fade -f null - Please

[FFmpeg-devel] [PATCH 2/2] tests: add paletteuse test

2015-02-23 Thread Clément Bœsch
From: Clément Bœsch clem...@stupeflix.com --- tests/fate/filter-video.mak | 12 + tests/ref/fate/filter-paletteuse-bayer | 72 + tests/ref/fate/filter-paletteuse-nodither | 72 +

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/4] avcodec/a64multienc: use av_frame_ref instead of copying the frame

2015-02-23 Thread Andreas Cadhalpun
On 23.02.2015 12:46, Luca Barbato wrote: On 23/02/15 12:23, Andreas Cadhalpun wrote: On 23.02.2015 01:56, Michael Niedermayer wrote: --- a/libavcodec/a64multienc.c +++ b/libavcodec/a64multienc.c @@ -317,7 +317,9 @@ static int a64multi_encode_frame(AVCodecContext *avctx, AVPacket *pkt, }

Re: [FFmpeg-devel] [PATCH]Silence warnings when compiling avfoundation

2015-02-23 Thread Thilo Borgmann
Attached patches fix different warnings when compiling libavdevice/avfoundation.o The first silences C90 warnings about mixed declaration and functions when using gcc, the second silences many undefined warnings when compiling for ios. First patch ok if tested. For the second, what is

[FFmpeg-devel] [PATCH] ffmpeg: Fix -vstats when coded_frame is not set

2015-02-23 Thread Michael Niedermayer
There are several encoders which do not set coded_frame Signed-off-by: Michael Niedermayer michae...@gmx.at --- ffmpeg.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index becd5df..c3a003e 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -1182,8 +1182,8

[FFmpeg-devel] [PATCH] avcodec/utils: Allocate dummy codec_frame for video encoders which do not allocate one

2015-02-23 Thread Michael Niedermayer
This should allow simplifying many encoders Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/utils.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index c5e6300..c6d588a 100644 --- a/libavcodec/utils.c +++

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Allocate dummy codec_frame for video encoders which do not allocate one

2015-02-23 Thread wm4
On Mon, 23 Feb 2015 17:19:16 +0100 Michael Niedermayer michae...@gmx.at wrote: This should allow simplifying many encoders Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/utils.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/utils.c

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Allocate dummy codec_frame for video encoders which do not allocate one

2015-02-23 Thread Michael Niedermayer
On Mon, Feb 23, 2015 at 06:15:15PM +0100, wm4 wrote: On Mon, 23 Feb 2015 17:19:16 +0100 Michael Niedermayer michae...@gmx.at wrote: This should allow simplifying many encoders Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/utils.c | 12 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Allocate dummy codec_frame for video encoders which do not allocate one

2015-02-23 Thread Michael Niedermayer
On Mon, Feb 23, 2015 at 06:49:36PM +0100, Michael Niedermayer wrote: On Mon, Feb 23, 2015 at 06:15:15PM +0100, wm4 wrote: On Mon, 23 Feb 2015 17:19:16 +0100 Michael Niedermayer michae...@gmx.at wrote: This should allow simplifying many encoders Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/paletteuse: add diff_mode

2015-02-23 Thread Clément Bœsch
On Thu, Feb 19, 2015 at 01:14:04AM +0100, Michael Niedermayer wrote: On Wed, Feb 18, 2015 at 03:46:24PM +0100, Clément Bœsch wrote: From: Clément Bœsch clem...@stupeflix.com TODO: bump minor --- doc/filters.texi| 15 + libavfilter/vf_paletteuse.c | 151

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/paletteuse: fix error dithering accuracy

2015-02-23 Thread Clément Bœsch
On Wed, Feb 18, 2015 at 03:46:23PM +0100, Clément Bœsch wrote: From: Clément Bœsch clem...@stupeflix.com --- libavfilter/vf_paletteuse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index

Re: [FFmpeg-devel] [CLT2015] FFmpeg at Chemnitzer Linux-Tage

2015-02-23 Thread Thilo Borgmann
Am 08.02.15 um 22:29 schrieb Alexander Strasser: Hello all, we applied for a booth at `Chemnitzer Linux-Tage' in Germany. Fortunately we were accepted again! The event will take place on 21st 22nd of March in Chemnitz. More information can be found here:

Re: [FFmpeg-devel] [PATCH] Socket options for librtmp

2015-02-23 Thread Michael Niedermayer
On Wed, Feb 11, 2015 at 07:33:43PM -0600, Cary Tetrick wrote: This reimplements a change authored by Brian Brice bbr...@gmail.com 2015-01-19 librtmp: Allow changing the socket send buffer size (Brian is aware of this change). also negates change by Michael Niedermayer michae...@gmx.at

Re: [FFmpeg-devel] [PATCH] Socket options for librtmp

2015-02-23 Thread Cary Tetrick
please ping this thread when this happens about the patch itself IIUC a user using old rtmpdump with new ffmpeg would loose the rtmp_buffer_size option. Would it make sense to support the old setsockopt() code for this case ? [...] That's a really good point. So the only real