I agree with the others. There's quite a lot of noise on the ML and having
some of
your trivial patches (e.g. replacing functions with FFmpeg defined ones)
merged into
one would help to decrease it.
>Currently I am trying to get rid of a
>lot of the last aspect to create a foundation for myself to
On 10/28/15, Matt Oliver wrote:
> On 5 October 2015 at 20:05, Matt Oliver wrote:
>
>> On 5 October 2015 at 19:29, Matt Oliver wrote:
>>
>>> On 30 September 2015 at 02:48, wm4 wrote:
>>>
On Wed, 23 Sep 2015 12:04:43 -0600
Roger Pack wrote:
> From 6a972dda58bd5ab31524cd4e5326
On Fri, Oct 30, 2015 at 07:10:52PM -0400, Ganesh Ajjanagadde wrote:
> qsort is called indirectly in filter_frame, suggesting its performance
> criticality. AV_QSORT is substantially faster due to the inlining of the
> comparison callback. Thus, the increase in performance should be worth
> the incr
On Fri, Oct 30, 2015 at 7:14 PM, Michael Niedermayer
wrote:
> On Thu, Oct 29, 2015 at 12:20:09AM -0400, Ganesh Ajjanagadde wrote:
>> This simplifies and cleans up the code.
>> Furthermore, it is much faster due to absence of the slow log computation.
>>
>> Signed-off-by: Ganesh Ajjanagadde
>> ---
On Fri, Oct 30, 2015 at 7:29 PM, Michael Niedermayer
wrote:
> On Fri, Oct 30, 2015 at 06:53:34PM -0400, Ganesh Ajjanagadde wrote:
>> On Fri, Oct 30, 2015 at 6:35 PM, Michael Niedermayer
>> wrote:
>> > From: Michael Niedermayer
>> >
>> > This should fix the build failure of avf_showcqt.c
>> >
>>
On Fri, Oct 30, 2015 at 7:33 PM, Michael Niedermayer
wrote:
> On Sat, Oct 31, 2015 at 12:14:44AM +0100, Hendrik Leppkes wrote:
>> On Fri, Oct 30, 2015 at 11:35 PM, Michael Niedermayer
>> wrote:
>> > From: Michael Niedermayer
>> >
>> > This should fix the build failure of avf_showcqt.c
>> >
>> >
On Sat, Oct 31, 2015 at 12:14:44AM +0100, Hendrik Leppkes wrote:
> On Fri, Oct 30, 2015 at 11:35 PM, Michael Niedermayer
> wrote:
> > From: Michael Niedermayer
> >
> > This should fix the build failure of avf_showcqt.c
> >
> > An alternative solution would be to add a check for fmin/fmax to
> >
On Fri, Oct 30, 2015 at 06:53:34PM -0400, Ganesh Ajjanagadde wrote:
> On Fri, Oct 30, 2015 at 6:35 PM, Michael Niedermayer wrote:
> > From: Michael Niedermayer
> >
> > This should fix the build failure of avf_showcqt.c
> >
> > An alternative solution would be to add a check for fmin/fmax to
> >
On Thu, Oct 29, 2015 at 12:20:09AM -0400, Ganesh Ajjanagadde wrote:
> This simplifies and cleans up the code.
> Furthermore, it is much faster due to absence of the slow log computation.
>
> Signed-off-by: Ganesh Ajjanagadde
> ---
> libavutil/rational.c | 4 ++--
> 1 file changed, 2 insertions(+
On Fri, Oct 30, 2015 at 11:35 PM, Michael Niedermayer wrote:
> From: Michael Niedermayer
>
> This should fix the build failure of avf_showcqt.c
>
> An alternative solution would be to add a check for fmin/fmax to fate-source
> and
> then to replace them by FFMIN/FFMAX, i can do that if preferred
qsort is called indirectly in filter_frame, suggesting its performance
criticality. AV_QSORT is substantially faster due to the inlining of the
comparison callback. Thus, the increase in performance should be worth
the increase in binary size.
Sample benchmark (x86-64, Haswell, GNU/Linux):
File: o
On Fri, Oct 30, 2015 at 6:35 PM, Michael Niedermayer wrote:
> From: Michael Niedermayer
>
> This should fix the build failure of avf_showcqt.c
>
> An alternative solution would be to add a check for fmin/fmax to fate-source
> and
> then to replace them by FFMIN/FFMAX, i can do that if preferred?
On Thu, Oct 29, 2015 at 02:05:53AM -0300, James Almer wrote:
> On 10/27/2015 9:56 PM, Michael Niedermayer wrote:
> > On Mon, Oct 26, 2015 at 12:32:58AM +0700, Muhammad Faiz wrote:
> >> On Sun, Oct 25, 2015 at 9:51 AM, Michael Niedermayer
> >> wrote:
> >>> On Sun, Oct 25, 2015 at 08:43:07AM +0700,
From: Michael Niedermayer
This should fix the build failure of avf_showcqt.c
An alternative solution would be to add a check for fmin/fmax to fate-source and
then to replace them by FFMIN/FFMAX, i can do that if preferred?
Untested due to lack of a affected platform
Signed-off-by: Michael Nied
On Fri, Oct 30, 2015 at 11:57:10PM +0700, Muhammad Faiz wrote:
> patch attached
> configure|2 +-
> libavfilter/Makefile |2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 10867dc567823f25a5cef17a30f5f8e60eaccc07
> 0001-avfilter-showcqt-fix-dependency-with-avformat.
On Fri, Oct 30, 2015 at 12:00:23 -0500, Kyle Swanson wrote:
> +- noise audio source
I actually anticipated this for quite some while, but thought I had
figured it out using some random source of input. I can't reproduce my
findings (or even my search), so thanks. :-)
> +@item duration, d
> +Speci
Hi,
On Fri, Oct 30, 2015 at 11:35 AM, Ganesh Ajjanagadde
wrote:
> Most, and perhaps all of them boil down to misunderstanding. This will
> hopefully improve over time. I apologize to all who did not like
> recent pushes from me. In fact, I can freely let go of my commit
> access if these were de
On Fri, 30 Oct 2015, Stefano Sabatini wrote:
On date Saturday 2015-10-24 22:42:12 +0200, Marton Balint encoded:
ffprobe.xsd already contains the tag element.
Signed-off-by: Marton Balint
---
ffprobe.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
[...]
LGTM, t
On Fri, Oct 30, 2015 at 12:26:55PM +, Lucas Andrade wrote:
> Em sex, 30 de out de 2015 às 07:44, Michael Niedermayer
> escreveu:
>
> > On Tue, Oct 27, 2015 at 11:28:32AM +, Lucas Andrade wrote:
> > > Here is the patch to backport it to release/2.8. To be fixed on 2.8.2.
> > > Anything els
On Fri, Oct 30, 2015 at 2:59 PM, Ronald S. Bultje wrote:
> Hi,
>
> On Fri, Oct 30, 2015 at 2:11 PM, Ganesh Ajjanagadde
> wrote:
>>
>> ISO C restricts enumerator values to the range of int. Thus (for instance)
>> 0x8000
>> unfortunately does not work, and throws a warning with -Wpedantic on
>>
Hi,
On Fri, Oct 30, 2015 at 2:11 PM, Ganesh Ajjanagadde
wrote:
> ISO C restricts enumerator values to the range of int. Thus (for instance)
> 0x8000
> unfortunately does not work, and throws a warning with -Wpedantic on
> clang 3.7.
>
> This fixes it by using alternative expressions that res
ISO C restricts enumerator values to the range of int. Thus (for instance)
0x8000
unfortunately does not work, and throws a warning with -Wpedantic on
clang 3.7.
This fixes it by using alternative expressions that result in identical
values but do not have this issue.
Tested with FATE.
Sign
On Fri, Oct 30, 2015 at 12:57 PM, Ganesh Ajjanagadde wrote:
> On Fri, Oct 30, 2015 at 6:07 AM, Michael Niedermayer
> wrote:
>> On Thu, Oct 15, 2015 at 08:01:56PM -0400, Ganesh Ajjanagadde wrote:
>>> Current code is fine, this just adds robustness.
>>>
>>> Signed-off-by: Ganesh Ajjanagadde
>>> --
On Fri, Oct 30, 2015 at 12:16 PM, Michael Niedermayer
wrote:
> On Tue, Oct 27, 2015 at 08:18:34PM -0400, Ganesh Ajjanagadde wrote:
>> av_gcd is now always defined regardless of input. This documents this
>> change in the "documented API". Two benefits (closely related):
>> 1. The function is robus
Le nonidi 9 brumaire, an CCXXIV, Kyle Swanson a écrit :
> Signed-off-by: Kyle Swanson
> ---
> Changelog| 1 +
> doc/filters.texi | 30 ++
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfilter/asrc_noise.c | 141
>
On 10/30/15, Kyle Swanson wrote:
> Signed-off-by: Kyle Swanson
> ---
> Changelog| 1 +
> doc/filters.texi | 30 ++
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfilter/asrc_noise.c | 141
asrc_anoisesrc
> ++
On Fri, 30 Oct 2015 16:15:30 +0100
Tobias Rapp wrote:
> On 30.10.2015 15:06, wm4 wrote:
> > On Fri, 30 Oct 2015 11:30:40 +0100
> > Tobias Rapp wrote:
> >
> >> On 29.10.2015 09:38, Tobias Rapp wrote:
> >>> Attached patch fixes file lock issues in my Windows application when a
> >>> child proc
Signed-off-by: Kyle Swanson
---
Changelog| 1 +
doc/filters.texi | 30 ++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/asrc_noise.c | 141 +++
libavfilter/version.h| 2 +-
6 fil
On Fri, Oct 30, 2015 at 6:07 AM, Michael Niedermayer
wrote:
> On Thu, Oct 15, 2015 at 08:01:56PM -0400, Ganesh Ajjanagadde wrote:
>> Current code is fine, this just adds robustness.
>>
>> Signed-off-by: Ganesh Ajjanagadde
>> ---
>> libavutil/wchar_filename.h | 1 +
>> 1 file changed, 1 insertion
patch attached
From 1902fc28da0b7d03e0f329397691006f9b432079 Mon Sep 17 00:00:00 2001
From: Muhammad Faiz
Date: Fri, 30 Oct 2015 23:35:02 +0700
Subject: [PATCH] avfilter/showcqt: fix dependency with avformat
---
configure| 2 +-
libavfilter/Makefile | 2 +-
2 files changed, 2 inserti
On Tue, Oct 27, 2015 at 08:18:34PM -0400, Ganesh Ajjanagadde wrote:
> av_gcd is now always defined regardless of input. This documents this
> change in the "documented API". Two benefits (closely related):
> 1. The function is robust, and there is no need to worry about INT64_MIN, etc.
>
> 2. Clie
On Fri, Oct 30, 2015 at 8:42 AM, Paul B Mahol wrote:
> On 10/30/15, Ganesh Ajjanagadde wrote:
>> Hi all,
>>
>> Apologies for the length of the email, but there is a lot of stuff I
>> would like to cover due to my absence on IRC or other venues for "non
>> patch related" discussion.
>>
>> There ha
On 30.10.2015 15:06, wm4 wrote:
On Fri, 30 Oct 2015 11:30:40 +0100
Tobias Rapp wrote:
On 29.10.2015 09:38, Tobias Rapp wrote:
Attached patch fixes file lock issues in my Windows application when a
child process is started with handle inheritance enabled (standard
input/output redirection) whi
On Fri, Oct 30, 2015 at 10:07 AM, Nicolas George wrote:
> Hi.
>
> I am not on IRC either, so I can not comment on what happen there. I hope I
> have not shown myself what you consider hostility on this list. I will try
> to explain what I think may irritate people in your actions on this list.
>
>
On Fri, Oct 30, 2015 at 01:42:30PM +0100, Paul B Mahol wrote:
> On 10/30/15, Ganesh Ajjanagadde wrote:
[...]
> > e) I have no personal interest in asm optimizations (to address a
> > suggestion on IRC). I do appreciate the hard work there, it just does
> > not appeal to me for reasons that I can a
On Thu, Oct 29, 2015 at 07:49:44PM -0400, Ganesh Ajjanagadde wrote:
[...]
> although you did explain to me where optimizations could be useful at
> an algorithmic level privately, I take this as an opportunity to
> request for general comments on places that people think could benefit
> from perfor
Hi.
I am not on IRC either, so I can not comment on what happen there. I hope I
have not shown myself what you consider hostility on this list. I will try
to explain what I think may irritate people in your actions on this list.
I will not comment on the issue of pushing without having addressed
On Fri, 30 Oct 2015 11:30:40 +0100
Tobias Rapp wrote:
> On 29.10.2015 09:38, Tobias Rapp wrote:
> > Attached patch fixes file lock issues in my Windows application when a
> > child process is started with handle inheritance enabled (standard
> > input/output redirection) while a FFmpeg transcodin
On 30.10.2015 11:54, Hendrik Leppkes wrote:
On Fri, Oct 30, 2015 at 11:30 AM, Tobias Rapp wrote:
On 29.10.2015 09:38, Tobias Rapp wrote:
Attached patch fixes file lock issues in my Windows application when a
child process is started with handle inheritance enabled (standard
input/output redir
On Fri, Oct 30, 2015 at 07:34:29AM -0400, Ganesh Ajjanagadde wrote:
[...]
TL;DR
Reviews are not meant to encourage, reviews are meant to find problems. A
good review is a review where problems are found and pointed out.
Sometimes, reviews mean suggesting way to find issues (which is then
generall
Hi,
I'll chime in on a few points.
On 10/30/2015 11:34 AM, Ganesh Ajjanagadde wrote:
> 1. "Sloppy" patches - I tend to give more verbose commit messages to
> explain rationale than many here. I also outlined why I did not post
> benchmarks initially. I myself still think they are unnecessary and
On Wed, Oct 28, 2015 at 05:39:39AM -0500, Rodger Combs wrote:
> ---
> tests/Makefile | 5 +
> tests/fate/avformat.mak | 1 +
> tests/lavf-regression.sh | 9 +
> tests/ref/lavf/crypto| 3 +++
> 4 files changed, 18 insertions(+)
> create mode 100644 tests/ref/lavf/crypto
On 10/30/15, Ganesh Ajjanagadde wrote:
> Hi all,
>
> Apologies for the length of the email, but there is a lot of stuff I
> would like to cover due to my absence on IRC or other venues for "non
> patch related" discussion.
>
> There has been a lot said and still being said regarding some patches
>
Em sex, 30 de out de 2015 às 07:44, Michael Niedermayer
escreveu:
> On Tue, Oct 27, 2015 at 11:28:32AM +, Lucas Andrade wrote:
> > Here is the patch to backport it to release/2.8. To be fixed on 2.8.2.
> > Anything else I should do?
> >
> > ps. Sorry, that's my first time on opensource projec
On Thu, Oct 29, 2015 at 8:31 PM, Andy Furniss wrote:
> Hendrik Leppkes wrote:
>>
>> On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin
>> wrote:
>>>
>>> VLC is using frame threading with hwaccel
>>
>>
>> Then they should fix their usage, its broken by design, as explained
>> in detail my post earlier in
Hi all,
Apologies for the length of the email, but there is a lot of stuff I
would like to cover due to my absence on IRC or other venues for "non
patch related" discussion.
There has been a lot said and still being said regarding some patches
I sent and associated discussion. Issues not related
Signed-off-by: Paul B Mahol
---
libavformat/segafilm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c
index b4f9b3d..9c346e6 100644
--- a/libavformat/segafilm.c
+++ b/libavformat/segafilm.c
@@ -247,6 +247,9 @@ static int film_read_header(AVF
Signed-off-by: Paul B Mahol
---
libavformat/segafilm.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c
index 9c346e6..6aef48e 100644
--- a/libavformat/segafilm.c
+++ b/libavformat/segafilm.c
@@ -93,6 +93,7 @@ static int fil
Signed-off-by: Paul B Mahol
---
libavformat/segafilm.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c
index 44fa683..b4f9b3d 100644
--- a/libavformat/segafilm.c
+++ b/libavformat/segafilm.c
@@ -239,6 +239,11 @@ static int
On Fri, Oct 30, 2015 at 11:30 AM, Tobias Rapp wrote:
> On 29.10.2015 09:38, Tobias Rapp wrote:
>>
>> Attached patch fixes file lock issues in my Windows application when a
>> child process is started with handle inheritance enabled (standard
>> input/output redirection) while a FFmpeg transcoding
On Thu, Oct 15, 2015 at 07:10:47PM -0400, Ganesh Ajjanagadde wrote:
> Signed-off-by: Ganesh Ajjanagadde
> ---
> libavutil/buffer.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/libavutil/buffer.h b/libavutil/buffer.h
> index b4399fd..e0dbc8a 100644
> --- a/libavutil/buffer.h
> +++
Le sextidi 6 brumaire, an CCXXIV, Michael Niedermayer a écrit :
> LGTM
Thanks, pushed.
Regards,
--
Nicolas George
signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo
On 29.10.2015 09:38, Tobias Rapp wrote:
Attached patch fixes file lock issues in my Windows application when a
child process is started with handle inheritance enabled (standard
input/output redirection) while a FFmpeg transcoding is running in the
parent process.
BTW: It would be great if the p
On Thu, Oct 15, 2015 at 09:31:59PM -0400, Ganesh Ajjanagadde wrote:
> This will trigger a few warnings (e.g in avfilter) that need to be
> fixed.
>
> Signed-off-by: Ganesh Ajjanagadde
> ---
> libswresample/swresample.h | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/libswresam
On Thu, Oct 15, 2015 at 08:01:56PM -0400, Ganesh Ajjanagadde wrote:
> Current code is fine, this just adds robustness.
>
> Signed-off-by: Ganesh Ajjanagadde
> ---
> libavutil/wchar_filename.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_f
On Thu, Oct 15, 2015 at 07:52:44PM -0400, Ganesh Ajjanagadde wrote:
> This triggers a few warnings that will need to be fixed - not that bad,
> the current code is mostly fine.
>
> Signed-off-by: Ganesh Ajjanagadde
> ---
> libavutil/parseutils.h | 5 +
> 1 file changed, 5 insertions(+)
iam
On Thu, Oct 15, 2015 at 07:47:47PM -0400, Ganesh Ajjanagadde wrote:
> This is going to trigger a lot of warnings all over the place that need
> fixing. Main culprits are in avfilter, when one tries to copy a frame
> without checking whether src and dest formats actually are compatible.
if a filter
---
tools/crypto_bench.c | 49 +
1 file changed, 41 insertions(+), 8 deletions(-)
diff --git a/tools/crypto_bench.c b/tools/crypto_bench.c
index 80d5f66..ce61af1 100644
--- a/tools/crypto_bench.c
+++ b/tools/crypto_bench.c
@@ -32,6 +32,7 @@
#includ
This also moves additional libcrypto ciphers to the new (faster) EVP API
---
tools/crypto_bench.c | 544 +++
1 file changed, 110 insertions(+), 434 deletions(-)
diff --git a/tools/crypto_bench.c b/tools/crypto_bench.c
index 8a468ba..80d5f66 100644
-
Before: crypto AES-128-CBC size: 1048576 runs: 1024 time: 16.224 +- 2.347
After: crypto AES-128-CBC size: 1048576 runs: 1024 time: 3.056 +- 0.366
---
tools/crypto_bench.c | 85 +---
1 file changed, 47 insertions(+), 38 deletions(-)
diff --gi
Le quartidi 4 brumaire, an CCXXIV, Marton Balint a écrit :
> I'd rather keep this as it is, the user has to control the metadata he wants
> in his output, we never promised there won't be additional packet string
> metadata in a certain format, and the way I see it only NUT muxer actually
> parses
Le quartidi 4 brumaire, an CCXXIV, Marton Balint a écrit :
> Hmm. I need this computed here for the next patch. Maybe we could calcualate
> the duration here and then update it in open_next_file as well?
That is probably possible somehow but a bit tricky. Can you explain why you
need the duration
Le quartidi 4 brumaire, an CCXXIV, Marton Balint a écrit :
> I used this many (25 1-frame segment) because this is also a seek test for
> open gop mxf. I can reduce it but in that case I will have to maintain my
> own out of tree tests for it which is counter-productive IMHO.
It seems that the you
On Tue, Oct 27, 2015 at 11:28:32AM +, Lucas Andrade wrote:
> Here is the patch to backport it to release/2.8. To be fixed on 2.8.2.
> Anything else I should do?
>
> ps. Sorry, that's my first time on opensource project, I'm a little
> confused that I needed to add it to the release branch.
>
On Fri, Oct 30, 2015 at 2:14 AM, P. van Gaans wrote:
> On 10/29/2015 09:42 AM, Paul B Mahol wrote:
>
>> On 10/29/15, P. van Gaans wrote:
>>
>>> You all know the CSI episodes where they read a license plate by
>>> "enhancing" some super-grainy security footage. Nonsense, right? Well,
>>> maybe no
diff --git a/ffmpeg.c b/ffmpeg.c
index f91fb7b..844a03c 100644
--- a/ffmpeg.c
+++ b/ffmpeg.c
@@ -3864,6 +3864,11 @@ static int process_input(int file_index)
if (pkt.dts != AV_NOPTS_VALUE)
pkt.dts *= ist->ts_scale;
+if (pkt.pts == AV_NOPTS_VALUE)
+pkt.pts = av_rescale_q(i
66 matches
Mail list logo
