Re: [FFmpeg-devel] [PATCH] movenc: Tag files generated with strict experimental with a warning

2016-12-06 Thread James Almer
On 12/2/2016 5:17 PM, James Almer wrote: > On 12/2/2016 5:00 PM, Vittorio Giovara wrote: >> This will simplify identifying files that were generated with >> unfinished/incomplete/non-standard specifications. >> >> Signed-off-by: Vittorio Giovara >> --- >>

Re: [FFmpeg-devel] [PATCH] movenc: Tag files generated with strict experimental with a warning

2016-12-06 Thread Vittorio Giovara
On Fri, Dec 2, 2016 at 3:00 PM, Vittorio Giovara wrote: > This will simplify identifying files that were generated with > unfinished/incomplete/non-standard specifications. > > Signed-off-by: Vittorio Giovara > --- > libavformat/movenc.c |

[FFmpeg-devel] [PATCH] lavu: Add AVSphericalMapping type and frame side data

2016-12-06 Thread Vittorio Giovara
While no decoder currently exports spherical information, this type represents a frame property that has to be passed through from container to frames. Signed-off-by: Vittorio Giovara --- The specification got updated while this was in the works. So I updated the

Re: [FFmpeg-devel] [PATCH v3] Added Turing codec interface for ffmpeg

2016-12-06 Thread wm4
On Thu, 1 Dec 2016 12:04:38 + Matteo Naccari wrote: > - This patch contains the changes to interface the Turing codec > (http://turingcodec.org/) to ffmpeg. The patch was modified to address > the comments in the review as follows: > - Added a pkg-config file

Re: [FFmpeg-devel] [PATCH v3] Added Turing codec interface for ffmpeg

2016-12-06 Thread James Almer
On 12/6/2016 11:03 AM, wm4 wrote: >> +static void add_option(const char* current_option, optionContext* >> option_ctx) >> +{ >> +int option_length = strlen(current_option); >> +if (option_ctx->buffer_filled + option_length + 1 > >> option_ctx->options_buffer_size) { >> +

Re: [FFmpeg-devel] [PATCH] movenc: Tag files generated with strict experimental with a warning

2016-12-06 Thread James Almer
On 12/6/2016 2:31 PM, Vittorio Giovara wrote: > On Tue, Dec 6, 2016 at 10:50 AM, James Almer wrote: >> On 12/2/2016 5:17 PM, James Almer wrote: >>> On 12/2/2016 5:00 PM, Vittorio Giovara wrote: This will simplify identifying files that were generated with

Re: [FFmpeg-devel] [PATCH 3/4] mov: Export spherical information

2016-12-06 Thread James Almer
On 12/6/2016 2:37 PM, Vittorio Giovara wrote: > On Tue, Dec 6, 2016 at 11:06 AM, James Almer wrote: >> On 11/30/2016 9:12 PM, James Almer wrote: >>> On 11/30/2016 8:36 PM, Vittorio Giovara wrote: This implements Spherical Video V1 and V2, as described in the

[FFmpeg-devel] [PATCH] avutil/tests: run the cpu_init.c test conditionally on HAVE_THREADS

2016-12-06 Thread Wan-Teh Chang
Also declare the main() function with void arguments because argc and argv are unused. These changes are suggested by Diego Biurrun and James Almer. Signed-off-by: Wan-Teh Chang --- libavutil/Makefile | 2 +- libavutil/tests/cpu_init.c | 9 +

Re: [FFmpeg-devel] [PATCH v3] Added Turing codec interface for ffmpeg

2016-12-06 Thread wm4
On Tue, 6 Dec 2016 11:35:49 -0300 James Almer wrote: > On 12/6/2016 11:03 AM, wm4 wrote: > >> +static void add_option(const char* current_option, optionContext* > >> option_ctx) > >> +{ > >> +int option_length = strlen(current_option); > >> +if

Re: [FFmpeg-devel] [PATCH] Update for Chromaprint 1.4

2016-12-06 Thread Hendrik Leppkes
On Tue, Dec 6, 2016 at 3:02 PM, Georgi D. Sotirov wrote: > Hello FFmpeg community, > > In new Chromaprint 1.4 (that was released 2016-12-03) type > ChromaprintContext is no longer void *, but empty structure (see commit > 2132e19 [1] from 2016-06-06 in BitBucket). This breaks

[FFmpeg-devel] [PATCH] Update for Chromaprint 1.4

2016-12-06 Thread Georgi D. Sotirov
Hello FFmpeg community, In new Chromaprint 1.4 (that was released 2016-12-03) type ChromaprintContext is no longer void *, but empty structure (see commit 2132e19 [1] from 2016-06-06 in BitBucket). This breaks compilation of libavformat/chromaprint.c, because member ctx of

[FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags()

2016-12-06 Thread Wan-Teh Chang
Make the one-time initialization in av_get_cpu_flags() thread-safe. The static variable |cpu_flags| in libavutil/cpu.c is read and written using normal load and store operations. These are considered as data races. The fix is to use atomic load and store operations. The fix can be verified by

[FFmpeg-devel] [PATCH 2/3] avformat/udp: Use avutil compat pthread_cond_timedwait.

2016-12-06 Thread Matt Oliver
Signed-off-by: Matt Oliver --- libavformat/udp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 3835f98..f8c861d 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -60,14 +60,14 @@ #define

[FFmpeg-devel] [PATCH 1/3] avutil/thread: Add pthread_cond_timedwait function.

2016-12-06 Thread Matt Oliver
Signed-off-by: Matt Oliver --- compat/os2threads.h | 24 compat/w32pthreads.h | 50 ++ libavutil/thread.h | 6 ++ 3 files changed, 80 insertions(+) diff --git a/compat/os2threads.h

[FFmpeg-devel] [PATCH 3/3] avformat/udp: Enable FIFO when using windows sockets.

2016-12-06 Thread Matt Oliver
Signed-off-by: Matt Oliver --- libavformat/udp.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index f8c861d..0e4766f 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -64,6 +64,14 @@

[FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags()

2016-12-06 Thread Wan-Teh Chang
Make the one-time initialization in av_get_cpu_flags() thread-safe. The static variable |cpu_flags| in libavutil/cpu.c is read and written using normal load and store operations. These are considered as data races. The fix is to use atomic load and store operations. The fix can be verified by

Re: [FFmpeg-devel] [PATCH] Fix build with LibreSSL

2016-12-06 Thread Matt Oliver
On 30 October 2016 at 17:57, Michael Forney wrote: > On 10/29/16, Matt Oliver wrote: > > This also seems a bit odd, why is libreSSL setting an openssl version > > number of 1.1.0 or higher when it doesnt actually conform to the > > corresponding

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-06 Thread Matt Oliver
On 4 December 2016 at 01:56, Matt Oliver wrote: > Indeed, in theory that would work. I always forget about these options. >> In my experience they do not work reliably, and I would argue against >> their use in portable code. For example, starting there: >>

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags()

2016-12-06 Thread Wan-Teh Chang
On Tue, Dec 6, 2016 at 10:41 AM, Wan-Teh Chang wrote: > Make the one-time initialization in av_get_cpu_flags() thread-safe. The > static variable |cpu_flags| in libavutil/cpu.c is read and written using > normal load and store operations. These are considered as data races. > The

Re: [FFmpeg-devel] [PATCH] aacdec: Allow SBR after DRC.

2016-12-06 Thread Alex Converse
On Tue, Dec 6, 2016 at 5:08 PM, Alex Converse wrote: > Fixes https://www2.iis.fraunhofer.de/AAC/7.1auditionOutLeader_v2_rtb.mp4 > > Reported-by: rcombs on IRC > --- > libavcodec/aacdec_template.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff

[FFmpeg-devel] [PATCH] aacdec: Allow SBR after DRC.

2016-12-06 Thread Alex Converse
Fixes https://www2.iis.fraunhofer.de/AAC/7.1auditionOutLeader_v2_rtb.mp4 Reported-by: rcombs on IRC --- libavcodec/aacdec_template.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index 8cfa34b..64d46e3 100644

Re: [FFmpeg-devel] [PATCH] yuv4mpegdec: fix leaking pkt in yuv4_read_packet

2016-12-06 Thread Michael Niedermayer
On Mon, Dec 05, 2016 at 11:08:44PM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/yuv4mpegdec.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/yuv4mpegdec.c

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: save the EXT-X-DISCONTINUITY from old list

2016-12-06 Thread Steven Liu
2016-12-06 7:47 GMT+08:00 Steven Liu : > when use fix ticket 2nd problem. > > command line test step: > rm -rf output*;./ffmpeg -i ~/Movies/objectC/facebook.mp4 -an -c:v copy > -f hls -hls_time 4 -hls_list_size 5 -hls_flags +delete_segments > -hls_flags +append_list

Re: [FFmpeg-devel] [PATCH 3/4] mov: Export spherical information

2016-12-06 Thread James Almer
On 11/30/2016 9:12 PM, James Almer wrote: > On 11/30/2016 8:36 PM, Vittorio Giovara wrote: >> This implements Spherical Video V1 and V2, as described in the >> spatial-media collection by Google. >> >> Signed-off-by: Vittorio Giovara >> --- >> This addresses all

Re: [FFmpeg-devel] [PATCH] Added test for libavcodec/avpacket.c

2016-12-06 Thread Michael Niedermayer
On Mon, Dec 05, 2016 at 10:22:41PM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavcodec/Makefile | 3 +- > libavcodec/tests/avpacket.c | 128 > > tests/fate/libavcodec.mak | 5 ++ > 3

Re: [FFmpeg-devel] [PATCH 3/4] mov: Export spherical information

2016-12-06 Thread Vittorio Giovara
On Tue, Dec 6, 2016 at 11:06 AM, James Almer wrote: > On 11/30/2016 9:12 PM, James Almer wrote: >> On 11/30/2016 8:36 PM, Vittorio Giovara wrote: >>> This implements Spherical Video V1 and V2, as described in the >>> spatial-media collection by Google. >>> >>> Signed-off-by:

Re: [FFmpeg-devel] [PATCH] movenc: Tag files generated with strict experimental with a warning

2016-12-06 Thread Vittorio Giovara
On Tue, Dec 6, 2016 at 10:50 AM, James Almer wrote: > On 12/2/2016 5:17 PM, James Almer wrote: >> On 12/2/2016 5:00 PM, Vittorio Giovara wrote: >>> This will simplify identifying files that were generated with >>> unfinished/incomplete/non-standard specifications. >>> >>>

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-12-06 Thread Wan-Teh Chang
On Thu, Nov 24, 2016 at 1:56 AM, wm4 wrote: > On Wed, 23 Nov 2016 11:40:25 -0800 > Wan-Teh Chang wrote: > >> On Tue, Nov 22, 2016 at 3:30 PM, wm4 wrote: >> > On Tue, 22 Nov 2016 23:57:15 +0100 >> > Michael Niedermayer

Re: [FFmpeg-devel] HRTF SOFA reader lib

2016-12-06 Thread Paul B Mahol
On 12/6/16, Christian Hoene wrote: > Hi, Hi, > > currently, we are writing a small library to read HRTF SOFA files. > https://github.com/choene/libmysofa > > It is intended for embedded devices or mobiles that have a small (code) > memory footprint. Of course, it

Re: [FFmpeg-devel] HRTF SOFA reader lib

2016-12-06 Thread Christian Hoene
Hi Paul, give me some more time until it passed all the tests. It is going to be ready for Christmas... Best, Christian > Paul B Mahol hat am 6. Dezember 2016 um 09:03 geschrieben: > > > On 12/6/16, Christian Hoene wrote: > > Hi, > > Hi,

Re: [FFmpeg-devel] [PATCH 0/4] More H.264 assembly (the sequel) [version 2]

2016-12-06 Thread Ronald S. Bultje
Hi, On Tue, Dec 6, 2016 at 7:04 AM, James Darnley wrote: > On 2016-12-05 19:32, James Darnley wrote: > > Fixed the problem Michael highlighted. Dropped the intra functions > until it > > becomes clear why their performance is unexpected. Updated the > benchmarks with > >

Re: [FFmpeg-devel] [PATCH 0/4] More H.264 assembly (the sequel) [version 2]

2016-12-06 Thread James Darnley
On 2016-12-05 19:32, James Darnley wrote: > Fixed the problem Michael highlighted. Dropped the intra functions until it > becomes clear why their performance is unexpected. Updated the benchmarks with > results from a Nehalem and used (slightly) more accurate data. > > Regarding the age of MMX:

Re: [FFmpeg-devel] [PATCH] Update for Chromaprint 1.4

2016-12-06 Thread Carl Eugen Hoyos
2016-12-06 15:02 GMT+01:00 Georgi D. Sotirov : > diff --git a/libavformat/chromaprint.c b/libavformat/chromaprint.c > index de73181..8c9a6c0 100644 > --- a/libavformat/chromaprint.c > +++ b/libavformat/chromaprint.c > @@ -39,11 +39,7 @@ typedef struct ChromaprintMuxContext { >

[FFmpeg-devel] [PATCH 1/2] avformat/webvttdec: Add support for HLS WebVTT MPEG timestamp map

2016-12-06 Thread Franklin Phillips
WebVTT subtitle files in HLS streams contain a header to synchronize the subtitles with the MPEG TS timestamps of the HLS stream. Add an AVOption to prefer MPEG TS style timestamps generated according to the mapping header, if available. Signed-off-by: Franklin Phillips

[FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-06 Thread Franklin Phillips
Each subtile segment is a WebVTT file and needs to be demuxed separately. These segments also contain a header to synchronize their timing with the MPEG TS stream so those timestamps are requested from the WebVTT demuxer through an AVOption. Signed-off-by: Franklin Phillips

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-06 Thread Franklin Phillips
Assuming the reason why my patch wasn't being merged was because it didn't use the X-TIMESTAMP-MAP, I have included the changes for that. Those changes were basically a merge of work done by anssi.hann...@iki.fi which is why I've cc'd them. ___

Re: [FFmpeg-devel] [PATCH] lavu: Add AVSphericalMapping type and frame side data

2016-12-06 Thread Vittorio Giovara
On Tue, Dec 6, 2016 at 10:46 AM, Vittorio Giovara wrote: > While no decoder currently exports spherical information, this type > represents a frame property that has to be passed through from container > to frames. > > Signed-off-by: Vittorio Giovara