Re: [FFmpeg-devel] [PATCH 2/9] ffmpeg: do packet ts rescaling in write_packet()

2017-02-14 14:08 GMT+01:00 Michael Niedermayer : > My concern are the growing number of regressions > (which implies more get added than fixed). From a purely quantitative pov this is correct. Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/9] ffmpeg: do packet ts rescaling in write_packet()

On Wed, 15 Feb 2017 11:48:36 +0100 Carl Eugen Hoyos wrote: > 2017-02-14 14:08 GMT+01:00 Michael Niedermayer : > > My concern are the growing number of regressions > > > (which implies more get added than fixed). > > From a purely quantitative pov

Re: [FFmpeg-devel] [PATCH] avfilter: implement halve filter

2017-02-14 20:44 GMT+01:00 Daniel Oberhoff : > filter strictly “halves” the image efficiently, which is often exactly what > is needed > likely much faster than using scale I am not a native speaker but this seems to imply you never tested the performance of the

Re: [FFmpeg-devel] deduplicated [PATCH] Cinepak: speed up decoding several-fold, depending on the scenario, by supporting multiple output pixel formats.

Hi Ronald, On Tue, Feb 14, 2017 at 09:46:55AM -0500, Ronald S. Bultje wrote: > > The huge difference in the amount of the data to be processed; in other > > words the very essence of the vector quantization technology where frame > > data is represented by a codebook, by design meant to be much

Re: [FFmpeg-devel] [PATCH 2/9] ffmpeg: do packet ts rescaling in write_packet()

2017-02-15 12:00 GMT+01:00 wm4 : > On Wed, 15 Feb 2017 11:48:36 +0100 > Carl Eugen Hoyos wrote: > >> 2017-02-14 14:08 GMT+01:00 Michael Niedermayer : >> > My concern are the growing number of regressions >> >> > (which implies

[FFmpeg-devel] [PATCH v2 4/8] ffmpeg: fix printing of filter input/output names

Broken by the previous Libav commit (even in Libav, thus a separate commit). Signed-off-by: wm4 --- ffmpeg_filter.c | 44 +--- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/ffmpeg_filter.c b/ffmpeg_filter.c index

[FFmpeg-devel] [PATCH v2 3/8] ffmpeg: init filtergraphs only after we have a frame on each input

From: Anton Khirnov This makes sure the actual stream parameters are used, which is important mainly for hardware decoding+filtering cases, which would previously require various weird workarounds to handle the fact that a fake software graph has to be constructed, but never

[FFmpeg-devel] [PATCH v2 1/8] ffmpeg: make sure packets put into the muxing FIFO are refcounted

Some callers (like do_subtitle_out()) call this with an AVPacket that is not refcounted. This can cause undefined behavior. Calling av_packet_move_ref() does not make a packet refcounted if it isn't yet. (And it can't be made to, because it always succeeds, and can't return ENOMEM.) Call

[FFmpeg-devel] [PATCH v2 2/8] ffmpeg: do packet ts rescaling in write_packet()

From: Anton Khirnov This will be useful in the following commit, after which the muxer timebase is not always available when encoding. This merges Libav commit 3e265ca. It was previously skipped. There is a minor change with setting the mux_timebase field only after the

[FFmpeg-devel] [PATCH v2 0/8] Merge lazy filter initialization in ffmpeg CLI

These patches merge the previously skipped Libav commits, which made avconv lazily initialize libavfilter graphs. This means the filters are initialized with the actual output format, instead of whatever libavformat reports. It's a prerequisite to making hardware decoding support saner, as

Re: [FFmpeg-devel] [PATCH v2 8/8] avcodec/cuvid: update hw_frames_ctx reference after get_format call

On Wed, 15 Feb 2017 10:24:23 +0100 wm4 wrote: > From: Timo Rothenpieler > > --- > libavcodec/cuvid.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/libavcodec/cuvid.c b/libavcodec/cuvid.c > index f5a49ce86f..a0682e3cdc

[FFmpeg-devel] [PATCH] avformat/mpl2dec: skip BOM when probing

Fixes #5442. Signed-off-by: Paul B Mahol --- libavformat/mpl2dec.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/mpl2dec.c b/libavformat/mpl2dec.c index 59589d5..dfcdf5a 100644 --- a/libavformat/mpl2dec.c +++ b/libavformat/mpl2dec.c @@ -23,6 +23,8 @@

[FFmpeg-devel] [PATCH v2 8/8] avcodec/cuvid: update hw_frames_ctx reference after get_format call

From: Timo Rothenpieler --- libavcodec/cuvid.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavcodec/cuvid.c b/libavcodec/cuvid.c index f5a49ce86f..a0682e3cdc 100644 --- a/libavcodec/cuvid.c +++ b/libavcodec/cuvid.c @@ -140,6 +140,19 @@ static int

[FFmpeg-devel] [PATCH v2 7/8] ffmpeg_cuvid: adapt for recent filter graph initialization changes

From: Timo Rothenpieler --- ffmpeg.c | 13 -- ffmpeg.h | 1 - ffmpeg_cuvid.c | 141 - 3 files changed, 30 insertions(+), 125 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index

[FFmpeg-devel] [PATCH v2 6/8] ffmpeg: restructure sending EOF to filters

From: Anton Khirnov Be more careful when an input stream encounters EOF when its filtergraph has not been configured yet. The current code would immediately mark the corresponding output streams as finished, while there may still be buffered frames waiting for frames to appear

Re: [FFmpeg-devel] [PATCH] avformat/mpl2dec: skip BOM when probing

On Wed, 15 Feb 2017 10:07:48 +0100 Paul B Mahol wrote: > On 2/15/17, wm4 wrote: > > On Sat, 11 Feb 2017 11:56:07 +0100 > > Paul B Mahol wrote: > > > >> Signed-off-by: Paul B Mahol > >> --- > >>

[FFmpeg-devel] [PATCH v2 5/8] ffmpeg: move flushing the queued frames to configure_filtergraph()

From: Anton Khirnov This is a more appropriate place for it, and will also be useful in the following commit. This merges Libav commit d2e56cf. It was previously skipped. Signed-off-by: wm4 --- ffmpeg.c| 11 --- ffmpeg_filter.c | 11

Re: [FFmpeg-devel] [PATCH] avformat/mpl2dec: skip BOM when probing

On 2/15/17, wm4 wrote: > On Sat, 11 Feb 2017 11:56:07 +0100 > Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> libavformat/mpl2dec.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git

Re: [FFmpeg-devel] [PATCH 0/9] Merge lazy filter initialization in ffmpeg CLI

On Tue, 14 Feb 2017 18:43:30 +0100 Michael Niedermayer wrote: > On Tue, Feb 14, 2017 at 06:11:22PM +0100, Michael Niedermayer wrote: > > On Mon, Feb 13, 2017 at 12:57:30PM +0100, Michael Niedermayer wrote: > > > On Mon, Feb 13, 2017 at 10:31:19AM +0100, wm4 wrote: > >

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

On 2/14/2017 11:20 PM, Vittorio Giovara wrote: > On Tue, Feb 14, 2017 at 6:54 PM, James Almer wrote: >> On 2/14/2017 5:52 PM, Vittorio Giovara wrote: >>> On Fri, Feb 10, 2017 at 6:25 PM, Michael Niedermayer >>> wrote: On Fri, Feb 10, 2017 at

Re: [FFmpeg-devel] AVFMT_FLAG_NOBUFFER not working on ffmpeg2.8 branch

the structure is different, it doesn't appear in ffmpeg3 On Wed, Feb 15, 2017 at 10:00 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Wed, Feb 15, 2017 at 08:24:24AM +0800, Shi Qiu wrote: > > no, it's different in ffmpeg3 > > which commit fixed it ? > > [...] > -- > Michael

Re: [FFmpeg-devel] [PATCH] wmaprodec: fix leaking fdsp on init failure

On Thu, Feb 16, 2017 at 12:56:38AM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/wmaprodec.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) should be ok thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] mpegaudiodec_template: fix leaking fdsp for mp3on4float

On Thu, Feb 16, 2017 at 12:39:17AM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/mpegaudiodec_template.c | 3 +++ > 1 file changed, 3 insertions(+) should be ok why was this not detected by fate ? are we lacking a test

[FFmpeg-devel] [PATCH] lavf/mov.c: Correct keyframe search in edit list to return the very first keyframe/frame with matching timestamp. Fixes ticket#5904

Signed-off-by: Sasi Inguva --- libavformat/mov.c | 12 1 file changed, 12 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index b5181775e7..2a7cbfe142 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2847,11 +2847,23 @@ static int64_t

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: set default http method to PUT when method is null

On Wed, Feb 15, 2017 at 11:45:49PM +0800, Steven Liu wrote: > When the http method is not set, the method will use POST for ts, > PUT for m3u8, it is not unify, now set it unify. > This ticket id: 5315 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 14

Re: [FFmpeg-devel] [PATCH v2 0/8] Merge lazy filter initialization in ffmpeg CLI

On 15/02/17 18:15, Carl Eugen Hoyos wrote: > 2017-02-15 17:47 GMT+01:00 wm4 : > >> What I don't want is that you post a new failing case approximately >> every 24 hours, with no end in sight, and with the implication that >> it's supposed to be fixed before merge. At this

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

On Wed, Feb 15, 2017 at 5:52 AM James Almer wrote: > On 2/14/2017 11:20 PM, Vittorio Giovara wrote: > > On Tue, Feb 14, 2017 at 6:54 PM, James Almer wrote: > >> On 2/14/2017 5:52 PM, Vittorio Giovara wrote: > >>> On Fri, Feb 10, 2017 at 6:25 PM, Michael

Re: [FFmpeg-devel] [PATCH v2 0/8] Merge lazy filter initialization in ffmpeg CLI

2017-02-15 17:47 GMT+01:00 wm4 : > What I don't want is that you post a new failing case approximately > every 24 hours, with no end in sight, and with the implication that > it's supposed to be fixed before merge. At this rate it could take > weeks, with every day

Re: [FFmpeg-devel] [PATCH 3/4] x86util: import MOVHL macro

On 2017-02-14 17:21, Henrik Gramner wrote: > On Mon, Feb 13, 2017 at 1:44 PM, James Darnley wrote: >> Originally committed to x264 in 1637239a by Henrik Gramner who has >> agreed to re-license it as LGPL. Original commit message follows. >> >> x86: Avoid some bypass delays

[FFmpeg-devel] [PATCHv2 1/4] spherical: Add tiled equirectangular type and projection-specific properties

Signed-off-by: Vittorio Giovara --- Updated with fate changes and more consistent names. Please CC. Vittorio doc/APIchanges | 5 +++ ffprobe.c | 11 +-- libavformat/dump.c | 10 ++

Re: [FFmpeg-devel] [PATCH v2 0/8] Merge lazy filter initialization in ffmpeg CLI

On Wed, 15 Feb 2017 17:17:03 +0100 Michael Niedermayer wrote: > On Wed, Feb 15, 2017 at 03:22:33PM +0100, Michael Niedermayer wrote: > > On Wed, Feb 15, 2017 at 10:24:15AM +0100, wm4 wrote: > > > These patches merge the previously skipped Libav commits, which made > > >

[FFmpeg-devel] [PATCH] avformat/hlsenc: set default http method to PUT when method is null

When the http method is not set, the method will use POST for ts, PUT for m3u8, it is not unify, now set it unify. This ticket id: 5315 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avfilter: implement halve filter

On 2017-02-14 22:25, Mark Thompson wrote: > On 14/02/17 19:44, Daniel Oberhoff wrote: >> filter strictly “halves” the image efficiently, which is often exactly what >> is needed >> likely much faster than using scale > > Did you benchmark this? How? > > $ time ./ffmpeg -f lavfi -i allyuv -vf

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: set default http method to PUT when method is null

On Wed, Feb 15, 2017 at 23:45:49 +0800, Steven Liu wrote: > +proto = avio_find_protocol_name(hls->basename); > +if (hls->method || (proto && !av_strcasecmp(proto, "http"))) { Would this also need to apply to https? (I'm not sure whether those protocols are distinguished.) > +

Re: [FFmpeg-devel] [PATCH] lavc: consider an error during decoder draining as EOF

On Wed, Feb 15, 2017 at 08:53:18AM +0100, wm4 wrote: > There is no reason that draining couldn't return an error or two. But > some decoders don't handle this very well, and might always return an > error. This can lead to API users getting into an infinite loop and > burning CPU, because no

Re: [FFmpeg-devel] [PATCH] avfilter: implement halve filter

On Tue, Feb 14, 2017 at 08:44:54PM +0100, Daniel Oberhoff wrote: > filter strictly “halves” the image efficiently, which is often exactly what > is needed > likely much faster than using scale > fully slice parallelized > > Signed-off-by: Daniel Oberhoff > --- >

[FFmpeg-devel] [PATCH] doc: correct-table-end-for-metadata-filter

Hi, At present, the 'file' option is shown as a possible choice of value for the 'expr' option in the metadata filter, due to a misplaced 'end table' directive. Corrected in patch. Regards, Mulvya 0001-doc-correct-table-end-for-metadata-filter.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] doc: correct-table-end-for-metadata-filter

On 2/15/17, Mulvya V wrote: > Hi, > > At present, the 'file' option is shown as a possible choice of value for > the 'expr' option in the metadata filter, due to a misplaced 'end table' > directive. Corrected in patch. > > Regards, > Mulvya > applied

[FFmpeg-devel] [PATCHv2 3/4] mkv: Export bounds and padding from spherical metadata

--- Updated according to James' review. Please CC. Vittorio libavformat/matroskadec.c | 69 -- tests/ref/fate/matroska-spherical-mono | 6 ++- 2 files changed, 71 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskadec.c

[FFmpeg-devel] [PATCHv2 2/4] mov: Export bounds and padding from spherical metadata

Update the fate test as needed. --- V2 bounds are validated and UINT32_MAX is used. Please CC. Vittorio libavformat/mov.c | 53 ++- tests/ref/fate/mov-spherical-mono | 6 - 2 files changed, 57 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCHv2 3/4] mkv: Export bounds and padding from spherical metadata

On 2/15/2017 1:29 PM, Vittorio Giovara wrote: > --- > Updated according to James' review. > Please CC. > Vittorio > > libavformat/matroskadec.c | 69 > -- > tests/ref/fate/matroska-spherical-mono | 6 ++- > 2 files changed, 71 insertions(+), 4

[FFmpeg-devel] [PATCH] bink: fix leaking last frame on error

Signed-off-by: Andreas Cadhalpun --- libavcodec/bink.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/bink.c b/libavcodec/bink.c index cc55870114..91004a6ae5 100644 --- a/libavcodec/bink.c +++ b/libavcodec/bink.c @@

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: set default http method to PUT when method is null

When the http method is not set, the method will use POST for ts, PUT for m3u8, it is not unify, now set it unify. This ticket id: 5315 Reviewed-by: Moritz Barsnick Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 27 ++- 1

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: set default http method to PUT when method is null

2017-02-16 4:19 GMT+08:00 Michael Niedermayer : > On Wed, Feb 15, 2017 at 11:45:49PM +0800, Steven Liu wrote: > > When the http method is not set, the method will use POST for ts, > > PUT for m3u8, it is not unify, now set it unify. > > This ticket id: 5315 > > > >

[FFmpeg-devel] [PATCH] mpegaudiodec_template: fix leaking fdsp for mp3on4float

Signed-off-by: Andreas Cadhalpun --- libavcodec/mpegaudiodec_template.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/mpegaudiodec_template.c b/libavcodec/mpegaudiodec_template.c index 1114428f33..53c09edced 100644 ---

[FFmpeg-devel] [PATCH] tiff: fix leaking yuv_line

Signed-off-by: Andreas Cadhalpun --- libavcodec/tiff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index efbd9791a5..474ea90015 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1386,6 +1386,7 @@ static

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

On Wed, Feb 15, 2017 at 8:52 AM, James Almer wrote: > On 2/14/2017 11:20 PM, Vittorio Giovara wrote: >> On Tue, Feb 14, 2017 at 6:54 PM, James Almer wrote: >>> On 2/14/2017 5:52 PM, Vittorio Giovara wrote: On Fri, Feb 10, 2017 at 6:25 PM, Michael

Re: [FFmpeg-devel] [PATCH] h264: Correctly initialize interlaced_frame if tff is set

On Tue, Feb 14, 2017 at 6:21 PM, Michael Niedermayer wrote: > On Sat, Feb 11, 2017 at 02:56:32AM +0100, Michael Niedermayer wrote: >> On Fri, Feb 10, 2017 at 05:21:00PM -0500, Vittorio Giovara wrote: >> > In particular cases, it is possible to initialize top_field_first >>

Re: [FFmpeg-devel] [PATCH v2 0/8] Merge lazy filter initialization in ffmpeg CLI

On Wed, Feb 15, 2017 at 10:24:15AM +0100, wm4 wrote: > These patches merge the previously skipped Libav commits, which made > avconv lazily initialize libavfilter graphs. This means the filters > are initialized with the actual output format, instead of whatever > libavformat reports. > > It's a

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

Le septidi 27 pluviôse, an CCXXV, James Almer a écrit : > If the spec changes, it will be the contents of the equi/cbmp/mesh. > By exporting them raw as extradata, said changes in the spec would > require no changes to our implementation. By this reasoning, we could as well replace libavformat by