Re: [FFmpeg-devel] [PATCH] vdpau: do not use buggy HEVC support by default

2017-08-07 Thread Manoj Bonda
Hi , HEVC issue for read-back API has been fixed and will be part of the upcoming drivers. Please help us understand the issue with the open gl interop. As per our understanding we are mapping the video surface to gl using the gl-interop and the app(mpv) will be doing the

Re: [FFmpeg-devel] [PATCH V2 1/4] lavc/vaapi_encode: Change the slice/parameter buffers to dynamic alloc.

2017-08-07 Thread Jun Zhao
On 2017/8/2 13:53, Jun Zhao wrote: > V2: Change the slice/parameter buffers to dynamic alloc and split > the mutil-slice support for AVC/HEVC. > ping? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avformat/avidec: Move packet skip after prefix and related checks

2017-08-07 Thread Michael Niedermayer
This fixes loosing packets Fixes: big.avi Signed-off-by: Michael Niedermayer --- libavformat/avidec.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index df52092067..9816a1dfac

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Mark Thompson
On 07/08/17 23:03, Jorge Ramirez wrote: > On 08/07/2017 11:55 PM, Mark Thompson wrote: >>> would you know where can I get this information from (qmin/qmx for the >>> other encoders)? >> From the relevant language standards. >> >> H.263 / MPEG-4 part 2: [1, 31]

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Mark Thompson
On 07/08/17 20:28, Jorge Ramirez wrote: > On 08/03/2017 01:53 AM, Mark Thompson wrote: >>> +AV_OPT_TYPE_INT,\ >>> +{.i64 = V4L2_MEMORY_MMAP},\ >>> +0, INT_MAX, FLAGS },\ >>> +{ "output_memory",\ >>> +"Output memory model: See V4L2_MEMORY_* in videodev2.h. This

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Mark Thompson
On 07/08/17 20:24, Jorge Ramirez wrote: > On 08/03/2017 01:53 AM, Mark Thompson wrote: >>> +default: >>> +return 0; >>> +} >>> + >>> +SET_V4L_EXT_CTRL(value, qmin, avctx->qmin, "minimum video quantizer >>> scale"); >>> +SET_V4L_EXT_CTRL(value, qmax, avctx->qmax, "maximum

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/07/2017 11:55 PM, Mark Thompson wrote: would you know where can I get this information from (qmin/qmx for the other encoders)? From the relevant language standards. H.263 / MPEG-4 part 2: [1, 31] (: PQUANT, GQUANT.) H.264 / MPEG-4 part 10 / AVC:

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/08/2017 12:01 AM, Mark Thompson wrote: great, thanks for that. The issue I have is that the V4L2 driver I am using to test - yes this needs to be detected by the decoder- has not implemented the feature yet. Will keep it in mind before sending the last series of the patchset. Are they

Re: [FFmpeg-devel] [PATCH] doc/filters: document the unstability of the shorthand options notation.

2017-08-07 Thread Michael Niedermayer
On Mon, Aug 07, 2017 at 11:03:51AM +0200, Nicolas George wrote: > > >Lets take a step back and look at this > > > > > >There are some rarely used options in multi input filters like > > >overlay which break. > > >Noone even noticed except me > > > > > >And you propose to declare the most used

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Mark Thompson
On 07/08/17 19:57, Jorge Ramirez wrote: > On 08/04/2017 03:32 PM, Mark Thompson wrote: >> On 04/08/17 14:06, Jorge Ramirez wrote: >>> On 08/04/2017 01:51 PM, Mark Thompson wrote: > +if (ret) > +return 0; > + > +return avpriv_v4l_dequeue(cap_pool, frame, NULL,

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Mark Thompson
On 07/08/17 19:51, Jorge Ramirez wrote: > On 08/04/2017 01:51 PM, Mark Thompson wrote: >>> +break; >>> +case AV_CODEC_ID_H263: >>> +qmin = MPEG_CID(H263_MIN_QP); >>> +qmax = MPEG_CID(H263_MAX_QP); >>> +break; >>> +case AV_CODEC_ID_VP8: >>> +case

Re: [FFmpeg-devel] [PATCH] doc/filters: document the unstability of the shorthand options notation.

2017-08-07 Thread Michael Niedermayer
On Mon, Aug 07, 2017 at 09:25:27AM +0200, Marton Balint wrote: > > > On Mon, 7 Aug 2017, Michael Niedermayer wrote: > > >On Sun, Aug 06, 2017 at 10:37:35AM +0200, Nicolas George wrote: > >>L'octidi 18 thermidor, an CCXXV, James Almer a écrit : > >>>What do you mean? What i suggested would be

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-07 Thread Dale Curtis
On Fri, Aug 4, 2017 at 4:40 PM, Rodger Combs wrote: > +sc->ctts_data = av_fast_realloc(sc->ctts_data, > >ctts_allocated_size, request_size); > ^ this line is incorrect; setting realloc's first arg to its return value > leaks the existing allocation in the OOM

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-07 Thread Dale Curtis
On Fri, Aug 4, 2017 at 4:38 PM, Michael Niedermayer wrote: > so theres no easy way to create a smaller file then 64mb ? > Ah no, I didn't realize you had a size limit; I just meant none of the existing clips were large enough / worked. I've truncated the clip at

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/03/2017 01:53 AM, Mark Thompson wrote: +AV_OPT_TYPE_INT,\ +{.i64 = V4L2_MEMORY_MMAP},\ +0, INT_MAX, FLAGS },\ +{ "output_memory",\ +"Output memory model: See V4L2_MEMORY_* in videodev2.h. This depends on the HW but default should work with most.",\ +

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/03/2017 01:53 AM, Mark Thompson wrote: +} + +dequeue: + +ret = avpriv_v4l_dequeue(cap_pool, NULL, pkt, timeout); +if (ret == AVERROR(EAGAIN)) +return 0; +if (!ret) +*got_packet = 1; + +return ret; +} Does this actually work for a long stream? You won't

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/03/2017 01:53 AM, Mark Thompson wrote: +default: +return 0; +} + +SET_V4L_EXT_CTRL(value, qmin, avctx->qmin, "minimum video quantizer scale"); +SET_V4L_EXT_CTRL(value, qmax, avctx->qmax, "maximum video quantizer scale"); + +return 0; +} This doesn't set

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/03/2017 01:53 AM, Mark Thompson wrote: +if (ret) +return 0; + +return avpriv_v4l_dequeue(cap_pool, frame, NULL, timeout); I feel like if the stream has a lot of delay then you will end up needing to wait for the timeout to get the required EAGAIN, which at 1s is very

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/03/2017 01:53 AM, Mark Thompson wrote: + +/* this will report the size of the frame back (see a4lbuf_to_avframe) */ +cap_pool->height = avctx->coded_height; +cap_pool->width = avctx->coded_width; Does coded_height/width need to be set to anything sensible here? That won't be

Re: [FFmpeg-devel] [vlc-devel] VideoLAN Dev Days 2017 Registration

2017-08-07 Thread Rostislav Pehlivanov
On 7 August 2017 at 18:40, Jean-Baptiste Kempf wrote: > Hello FFmpeg geeks and geekettes! > > Finally, I'd like to do a call for conferences, to present on Saturday > morning, as the previous years. > > I'd like to present a talk about the FFmpeg Opus encoder (which would also

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/03/2017 01:53 AM, Mark Thompson wrote: +return ret; +} + +av_log(log_ctx, AV_LOG_INFO, "Using device %s\n", tmpbuf); +ret = probe_and_set(s, log_ctx, 1); +s->devname = devname_save; This probing structure feels very fragile and possibly harmful (opening random

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/03/2017 01:53 AM, Mark Thompson wrote: +static int probe_and_set(V4Lm2mContext* s, void *log_ctx, int set) +{ +int fail_log_level = ( set ? AV_LOG_ERROR : AV_LOG_DEBUG); +int ret; + +s->fd = open(s->devname, O_RDWR, 0); O_NONBLOCK, given DQBUF is used as if it is? ack

Re: [FFmpeg-devel] [PATCH] doc/filters: document the unstability of the shorthand options notation.

2017-08-07 Thread Marton Balint
On Tue, 8 Aug 2017, Gyan wrote: On Mon, Aug 7, 2017 at 11:11 PM, John Warburton wrote: if an old FFmpeg script of mine breaks, as they have on a couple of occasions, isn't it logical for a user of the command line to go straight to the documentation, and the answer

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: fix alpha blending for planar formats with a transparent background

2017-08-07 Thread Marton Balint
On Sat, 5 Aug 2017, Michael Niedermayer wrote: On Fri, Aug 04, 2017 at 10:23:55AM +0200, Marton Balint wrote: When the background had an alpha channel, the old code in blend_plane calculated premultiplied alpha from the destination plane colors instead of the destination alpha. Also the

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/03/2017 01:53 AM, Mark Thompson wrote: +return AVERROR(errno); + +bp->streamon = (cmd == VIDIOC_STREAMON); + +return 0; +} + +int avpriv_v4l_enqueue(V4LBufferPool* bp, const AVFrame* f, const AVPacket* pkt) Just make separate functions. done in v4 thanks

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/03/2017 01:53 AM, Mark Thompson wrote: + +static int v4lbuf_to_avframe(AVFrame *frame, V4LBuffer *avbuf) +{ +int i, ret; + +av_frame_unref(frame); + +for (i = 0; i < avbuf->num_planes; i++) { +ret = v4l2bufref(avbuf, i, >buf[i]);> +if (ret) +return

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/04/2017 01:51 PM, Mark Thompson wrote: +break; +case AV_CODEC_ID_H263: +qmin = MPEG_CID(H263_MIN_QP); +qmax = MPEG_CID(H263_MAX_QP); +break; +case AV_CODEC_ID_VP8: +case AV_CODEC_ID_VP9: +qmin = MPEG_CID(VPX_MIN_QP); +qmax =

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-07 Thread Jorge Ramirez
On 08/04/2017 03:32 PM, Mark Thompson wrote: On 04/08/17 14:06, Jorge Ramirez wrote: On 08/04/2017 01:51 PM, Mark Thompson wrote: +if (ret) +return 0; + +return avpriv_v4l_dequeue(cap_pool, frame, NULL, timeout); +} What happens to the decoder if some parameters like

Re: [FFmpeg-devel] [PATCH] doc/filters: document the unstability of the shorthand options notation.

2017-08-07 Thread Gyan
On Mon, Aug 7, 2017 at 11:11 PM, John Warburton wrote: > if an old FFmpeg script of mine breaks, as they have on a couple of > occasions, isn't it logical for a user of the command line to go > straight to the documentation, and the answer (and the fix) always > seems to

Re: [FFmpeg-devel] [PATCH] doc/filters: document the unstability of the shorthand options notation.

2017-08-07 Thread John Warburton
On Mon, Aug 7, 2017 at 10:03 AM, Nicolas George wrote: >> >Lets take a step back and look at this >> > >> >There are some rarely used options in multi input filters like >> >overlay which break. >> >Noone even noticed except me ... > Now, to all that stated a negative opinion

[FFmpeg-devel] [vlc-devel] VideoLAN Dev Days 2017 Registration

2017-08-07 Thread Jean-Baptiste Kempf
Hello FFmpeg geeks and geekettes! Once again the time for VDD is approaching, and we would like to invite you to this year's edition, to be held in Paris. https://vdd.videolan.org/ This technical conference about open source multimedia, will see developers from VLC, x26*, libbluray, FFmpeg,

Re: [FFmpeg-devel] [PATCH 7/7] lavfi/vf_stack: move to activate design.

2017-08-07 Thread John Warburton
On Mon, Aug 7, 2017 at 10:08 AM, Nicolas George wrote: > > This issue seems fixed by these changes: > > https://ffmpeg.org/pipermail/ffmpeg-devel/2017-July/214306.html > > I thought it could only be triggered with the specific configuration > caused by dualinput, but you

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Fix inserting frames before current_frame.

2017-08-07 Thread Jacob Trimble
Ping On Thu, Jul 27, 2017 at 10:34 AM, Jacob Trimble wrote: > When using streaming input, it may be possible to see frames that appear > before the current_frame. When these frames are inserted into the > index, the current_frame needs to be updated so it is still pointing

Re: [FFmpeg-devel] [PATCH] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-08-07 Thread Thilo Borgmann
Am 07.08.17 um 01:31 schrieb sharpbai: > From: sharpbai > > feature: add scaleFactor attribute for avfoundation > added by: siyuan.w...@duobei.com > added by: yiren...@duobei.com > --- > doc/indevs.texi| 22 ++ > libavdevice/avfoundation.m |

[FFmpeg-devel] DXVA2 CreateVideoDecoder

2017-08-07 Thread gabriele salvati
Hi to all, I'm working on DXVA2 video decoding, I'm facing a problem with CreateVideoDecoder. I create a new video decoder every time a new video have to be decoded. I noticed that when I release the video decoder not all the allocated memory is properly released. By using VS2015 I found the

[FFmpeg-devel] Encoding less than a whole frame

2017-08-07 Thread James Darnley
I have a few vague questions I want to ask but keep in mind I have no knowledge of FFmpeg's APIs. It is my impression that encoding with avcodec requires a whole picture to be given to the encoder at any time. Has anyone ever started working on allowing avcodec to encode anything less than a

Re: [FFmpeg-devel] [PATCH 7/7] lavfi/vf_stack: move to activate design.

2017-08-07 Thread John Warburton
On Mon, Aug 7, 2017 at 10:08 AM, Nicolas George wrote: > > This issue seems fixed by these changes: > > https://ffmpeg.org/pipermail/ffmpeg-devel/2017-July/214306.html > ... > Also, it would help deciding stuff if you, as a user, told us: if you > had to write

Re: [FFmpeg-devel] [PATCH] avfilter/vf_premultiply: add inplace mode

2017-08-07 Thread Nicolas George
Le septidi 17 thermidor, an CCXXV, Paul B Mahol a écrit : > Hi, > > patch attached. > From f952d9a2c87f7c2387d509e986aee5adb424d9d2 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Fri, 4 Aug 2017 22:28:53 +0200 > Subject: [PATCH] avfilter/vf_premultiply: add inplace mode

Re: [FFmpeg-devel] [PATCH 7/7] lavfi/vf_stack: move to activate design.

2017-08-07 Thread Nicolas George
Le decadi 20 thermidor, an CCXXV, Gyan a écrit : > Obviously not for scripts written now or in the future by those who follow > this list, but old/delivered scripts may break and often those executing > them aren't the ones who composed them. But I hope they test them after upgrading their

Re: [FFmpeg-devel] [PATCH 7/7] lavfi/vf_stack: move to activate design.

2017-08-07 Thread Gyan
On Mon, Aug 7, 2017 at 2:38 PM, Nicolas George wrote: > > Also, it would help deciding stuff if you, as a user, told us: if you > had to write "scale=w=1536:h=512" instead of "scale=1536:512" to be > completely sure that your scripts will not break on upgrade, would you >

Re: [FFmpeg-devel] libavcodec/exr : add SSE2 simd for reorder pixels (WIP)

2017-08-07 Thread Martin Vignali
> > 64 runs seems way too few runs for reliable result. > Please try to run ffmpeg encoding for about a minute. > > About the patch: > > > +%include "libavutil/x86/x86util.asm" > > + > > +SECTION .text > > Please include "x86inc.asm" explicitly. > > > +INIT_XMM sse2 > > +cglobal reorder_pixels,

Re: [FFmpeg-devel] [PATCH 7/7] lavfi/vf_stack: move to activate design.

2017-08-07 Thread Nicolas George
Le nonidi 19 thermidor, an CCXXV, John Warburton a écrit : > Gentlemen, I am sorry to report that this particular patch to > lavfi/vf_stack.c breaks FFmpeg on-screen output when a vertical stack > (vstack) follows a horizontal stack (hstack). Below, please find a > chain to -filter_complex, cut

Re: [FFmpeg-devel] [PATCH] doc/filters: document the unstability of the shorthand options notation.

2017-08-07 Thread Nicolas George
> >Lets take a step back and look at this > > > >There are some rarely used options in multi input filters like > >overlay which break. > >Noone even noticed except me > > > >And you propose to declare the most used syntax from every filter > >unstable. > > > >This just doesnt add up, its like

[FFmpeg-devel] [PATCH] JPEG200 encoding : added option for changing default codeblock size

2017-08-07 Thread francesco
From: Francesco Cuzzocrea HI I think this time I've made correctly a patch. As in previous mail, I added option for changing codeblock size. I've inserted check on exponent sum as for ISO/IEC FCD 15444-1 --- libavcodec/j2kenc.c | 10 -- 1 file changed, 8

Re: [FFmpeg-devel] [PATCH] doc/filters: document the unstability of the shorthand options notation.

2017-08-07 Thread Marton Balint
On Mon, 7 Aug 2017, Michael Niedermayer wrote: On Sun, Aug 06, 2017 at 10:37:35AM +0200, Nicolas George wrote: L'octidi 18 thermidor, an CCXXV, James Almer a écrit : What do you mean? What i suggested would be done each time an option is removed or added anywhere but at the end, both of

[FFmpeg-devel] [PATCH] Add FITS Muxer

2017-08-07 Thread Paras Chadha
Signed-off-by: Paras Chadha --- Added a new line in img2enc to add support for writing frames into separate FITS files in a fashion similar to gif. The following command can be used for that: ffmpeg -i INPUT -c:v fits -f image2 "out%d.fits" libavformat/Makefile |

[FFmpeg-devel] [PATCH] Add FITS Encoder

2017-08-07 Thread Paras Chadha
Signed-off-by: Paras Chadha --- Moved header writing code to muxer Made the changes suggested Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 2 +- libavcodec/fitsenc.c | 130