Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > So it is. So unless you tell what exactly you mean I can not help you. My bad. > testsrc(2) are useless for lipsync testing, when one needs to know > exact time something is played in wrong time. Yes, testsrc alone is not enough. But you

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> So it is. So unless you tell what exactly you mean I can not help you. > > My bad. > >> testsrc(2) are useless for lipsync testing, when one needs to know >> exact time something is

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2017-08-19 9:24 GMT+02:00 Rodger Combs : > AVInputFormat ff_mov_demuxer = { > -.name = "mov,mp4,m4a,3gp,3g2,mj2", > +.name = "mov,mp4,m4a,3gp,3g2,mj2,heif,heic", Since it isn't necessary for the new feature: Please don't change this line.

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> Try harder to explain what you think. > > This "filter" has no input. All similar "filters" are called sources and > implemented in files named accordingly. So it is. So unless you tell

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

Le nonidi 29 thermidor, an CCXXV, Paul B Mahol a écrit : > Hi, > > patch attached. > From 8d3876499b93e61ec1aec39adfc3c3be8d622464 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Fri, 28 Apr 2017 20:18:38 +0200 > Subject: [PATCH] avfilter: add Audio Video Sync Test

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > And how would you show delay introduced with video source filter? > testsrc(2) does not show anything resembling that. I do not understand what you mean. The output of "ffmpeg -lavfi 'testsrc2;sine'" looks functionally identical to the

[FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

There's a decent chance this doesn't work on [pretty much anything other than the samples I tested it with], but I haven't found very many samples, and don't want to implement the rest of the features blind with nothing but a spec, and most of it's pretty over-the-top anyway. For some reason my

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > Try harder to explain what you think. This "filter" has no input. All similar "filters" are called sources and implemented in files named accordingly. > If you actually tried you would know. I am sorry, but I do not accept that as an

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > How do you know when beep and blink should happen in your example? > > What is blink for testsrc2? Where in testsrc2 you can see delay in numeric > form? Have you tried? You have a numeric timestamp and frame counter in the upper left

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> And how would you show delay introduced with video source filter? >> testsrc(2) does not show anything resembling that. > > I do not understand what you mean. The output of "ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

On 8/19/17, Nicolas George wrote: > Le nonidi 29 thermidor, an CCXXV, Paul B Mahol a écrit : >> Hi, >> >> patch attached. > >> From 8d3876499b93e61ec1aec39adfc3c3be8d622464 Mon Sep 17 00:00:00 2001 >> From: Paul B Mahol >> Date: Fri, 28 Apr 2017 20:18:38 +0200

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > That is not delay between blink and beep. But video timestamps. Since the beeps happen every second, the delay is the fractional part, or the remainder of the frame count divided by the frame rate. But if you think this arithmetic is too

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> That is not delay between blink and beep. But video timestamps. > > Since the beeps happen every second, the delay is the fractional part, > or the remainder of the frame count divided

Re: [FFmpeg-devel] [PATCH] opus_pvq_search: Restore the proper use of conditional define and simplify the function name suffix handling

On 19 August 2017 at 16:10, Ivan Kalvachev wrote: > Using named define properly documents the code paths. > It also avoids passing additional numbered arguments through > multiple levels of macro templates. > > The suffix handling is done by concatenation, like in > other

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pixlet: Fixes: undefined shift in av_mod_uintp2()

On 8/19/17, Michael Niedermayer wrote: > On Fri, Aug 18, 2017 at 06:21:56PM +0200, Paul B Mahol wrote: >> On 8/18/17, Michael Niedermayer wrote: >> > Fixes: runtime error: shift exponent 4294967289 is too large for 32-bit >> > type >> > 'int' >> >

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> Exact delay in number of frames and that converted to milliseconds. > > Already present. I asked you if you tested, obviously you did not. Sorry but where is that present? I nowhere can

[FFmpeg-devel] [PATCH] opus_pvq_search: Restore the proper use of conditional define and simplify the function name suffix handling

Using named define properly documents the code paths. It also avoids passing additional numbered arguments through multiple levels of macro templates. The suffix handling is done by concatenation, like in other asm functions and avoid having two separate "cglobal" defines. --- I have to point

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pixlet: Fixes: undefined shift in av_mod_uintp2()

On Fri, Aug 18, 2017 at 06:21:56PM +0200, Paul B Mahol wrote: > On 8/18/17, Michael Niedermayer wrote: > > Fixes: runtime error: shift exponent 4294967289 is too large for 32-bit type > > 'int' > > Fixes: 3030/clusterfuzz-testcase-minimized-4649809254285312 > > > >

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > Exact delay in number of frames and that converted to milliseconds. Already present. I asked you if you tested, obviously you did not. > Also one can not set custom delay between beep and blink. I already mentioned that. You can propose a

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> Sorry but where is that present? I nowhere can determine exact delay >> in number of frames versus sine beep. > > In the upper-left corner, you have a microsecond timestamp and a frame >

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > I like idea of having single A/V filter to do this job, not combinations where > users might become confused. I do not agree. Adding yet another filter causes confusion in itself. Not counting the extra boilerplate code (I suggest you

Re: [FFmpeg-devel] [PATCH] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

Hi, Am 18.08.17 um 15:44 schrieb sharp bai: > Thank you for your patient. I will follow your direction. > > Question 1: Your patch misses to cover the scale factor in case of a > device name string given by the user. > > The problem in mac os the screen to be catpured in avfoundation not > have

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> How do you know when beep and blink should happen in your example? >> >> What is blink for testsrc2? Where in testsrc2 you can see delay in numeric >> form? > > Have you tried? You have

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > Sorry but where is that present? I nowhere can determine exact delay > in number of frames versus sine beep. In the upper-left corner, you have a microsecond timestamp and a frame counter. > It is not sine but testsrc2 one that would need

Re: [FFmpeg-devel] [PATCH] vp9: set color range to MPEG for intraonly profile 0

Hi, On Fri, Aug 18, 2017 at 11:31 PM, James Zern wrote: > this is undocumented in the vp9 bitstream and decoding specification > doc, but matches libvpx > > Signed-off-by: James Zern > --- > libavcodec/vp9.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] opus_pvq_search: Restore the proper use of conditional define and simplify the function name suffix handling

On Sat, Aug 19, 2017 at 5:40 PM, Rostislav Pehlivanov wrote: > On 19 August 2017 at 16:10, Ivan Kalvachev wrote: > >> Using named define properly documents the code paths. >> It also avoids passing additional numbered arguments through >> multiple

[FFmpeg-devel] HLS + SAMPLE-AES

Hello everyone, I hope this is not out of the code of conduct, but I was hoping to motivate if someone would look into implementing this ticket: https://trac.ffmpeg.org/ticket/5375 I've found a project that relies on FFmpeg and does this, is under MIT license

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> I like idea of having single A/V filter to do this job, not combinations >> where >> users might become confused. > > I do not agree. Adding yet another filter causes confusion in

[FFmpeg-devel] [PATCH] avcodec/me_cmp: Fix crashes on ARM due to misalignment

Adds a diff_pixels_unaligned() Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872503 Signed-off-by: Michael Niedermayer --- libavcodec/me_cmp.c | 10 +- libavcodec/pixblockdsp.c | 1 + libavcodec/pixblockdsp.h | 5

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pixlet: Fixes: undefined shift in av_mod_uintp2()

On Sat, Aug 19, 2017 at 04:00:18PM +0200, Paul B Mahol wrote: > On 8/19/17, Michael Niedermayer wrote: > > On Fri, Aug 18, 2017 at 06:21:56PM +0200, Paul B Mahol wrote: > >> On 8/18/17, Michael Niedermayer wrote: > >> > Fixes: runtime error: shift

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/fic: Fixes signed integer overflow

On Fri, Aug 18, 2017 at 12:17:33AM +0200, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: 1037142357 + 1227025305 cannot > be represented in type 'int' > Fixes: 3024/clusterfuzz-testcase-minimized-5885660323905536 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v3] libavformat/mov: fix multiple stsd handling of files with edit list, fix #6584

On Sat, Aug 19, 2017 at 08:32:18AM +0800, Jiejun Zhang wrote: > On Fri, Aug 18, 2017 at 8:16 AM, Michael Niedermayer > wrote: > > > > seeking still fails with this and the sample from #6584 is that > > intended or a seperate issue ? > > I didn't see any failure using

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

On Fri, Aug 18, 2017 at 2:57 PM, Mailtrack Reminder wrote: > ⚠️ Your email to ffmpeg-devel@ffmpeg.org has not been opened yet. Be > reminded in 24H >

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

On Fri, Aug 18, 2017 at 03:57:45PM -0700, Dale Curtis wrote: > Anything else here? It'd be nice to get this landed soon if no one has any > other comments. it appears to not apply cleanly anymore > > - dale > > On Thu, Aug 10, 2017 at 1:02 PM, Dale Curtis > wrote: >

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

On Sun, Aug 20, 2017 at 12:48:30AM +0200, Michael Niedermayer wrote: > On Fri, Aug 18, 2017 at 03:57:45PM -0700, Dale Curtis wrote: > > Anything else here? It'd be nice to get this landed soon if no one has any > > other comments. > > it appears to not apply cleanly anymore seems caused by

Re: [FFmpeg-devel] [PATCH] lavf/bink: fix latest header and add all existing revisions

On Fri, Aug 18, 2017 at 07:45:16PM +0200, bananaman...@gmail.com wrote: > From: bnnm > > KB2 'i' found in Life is Strange (Xbox 360), rest verified against > binkconv.exe > > Signed-off-by: bnnm > --- > libavformat/bink.c | 17 +

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

On Thu, Aug 17, 2017 at 11:14:47PM -0700, Vitaly Buka wrote: > Signed integer overflow is undefined behavior. > Detected with clang and -fsanitize=signed-integer-overflow > > Signed-off-by: Vitaly Buka > --- > libavcodec/utils.c| 2 +- > libavformat/aviobuf.c | 4 +++-

[FFmpeg-devel] [PATCH] Fix signed integer overflows

Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka --- libavcodec/utils.c| 2 +- libavformat/aviobuf.c | 3 +++ libavformat/mov.c | 2 +- 3 files changed, 5 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] opus_pvq_search: Restore the proper use of conditional define and simplify the function name suffix handling

The issue has been resolved. The patch has been pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2]v7 Opus Pyramid Vector Quantization Search in x86 SIMD asm

On 6 August 2017 at 19:52, Ivan Kalvachev wrote: > This patch requires "Add macros used in opus_pvq_search to x86util.asm" > as 4 of the macros are moved there. > > 1. Cosmetics is completely redone. > > 2. I've left the align code as it is. > I found a really old nasm-2.07

Re: [FFmpeg-devel] [PATCH] lavf/bink: fix latest header and add all existing revisions

On Sun, Aug 20, 2017 at 01:51:07AM +0200, Michael Niedermayer wrote: > On Fri, Aug 18, 2017 at 07:45:16PM +0200, bananaman...@gmail.com wrote: > > From: bnnm > > > > KB2 'i' found in Life is Strange (Xbox 360), rest verified against > > binkconv.exe > > > >

[FFmpeg-devel] [PATCH] Fix signed integer overflows

Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka --- libavcodec/utils.c| 2 +- libavformat/aviobuf.c | 2 ++ libavformat/mov.c | 2 +- 3 files changed, 4 insertions(+), 2

[FFmpeg-devel] [PATCH] Add FITS Decoder

Signed-off-by: Paras Chadha --- Add FATE coverage Changelog | 1 + doc/general.texi | 2 + libavcodec/Makefile| 2 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h | 1 +

[FFmpeg-devel] [PATCH] Add FITS Muxer

Signed-off-by: Paras Chadha --- Add FATE coverage libavformat/Makefile | 1 + libavformat/allformats.c | 2 +- libavformat/fitsenc.c| 183 +++ libavformat/img2enc.c| 2 + tests/fate/avformat.mak | 1 +

[FFmpeg-devel] [PATCH] Add FITS Demuxer

Signed-off-by: Paras Chadha --- Add FATE coverage libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/fitsdec.c | 231 ++ libavformat/version.h | 2 +- tests/fate/demux.mak | 3 +

[FFmpeg-devel] [PATCH] Add FITS Encoder

Signed-off-by: Paras Chadha --- Add FATE coverage Changelog| 1 + doc/general.texi | 2 +- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 2 +- libavcodec/fitsenc.c | 130