Re: [FFmpeg-devel] [PATCH v2] avformat/hls: release mem resource to fix memleak

On 12/31/2017 6:19 AM, Derek Buitenhuis wrote: > Looking closer into the implementation of av_opt_get just kind of made me sad, > though. It has a bunch of unchecked allocations, such that it can return 0 but > have the string be NULL. I'll send a patch tomorrow to address that properly. Looks

Re: [FFmpeg-devel] [PATCH] Added missing break statements

On 12/31/2017 6:34 PM, Aleksa Savic wrote: > Signed-off-by: Aleksa Savic > --- > libavcodec/avs.c | 2 ++ > libavcodec/mpegvideo_enc.c | 1 + > libavformat/aiffdec.c | 1 + > libavformat/lmlm4.c| 1 + > 4 files changed, 5 insertions(+) > > diff

[FFmpeg-devel] [PATCH] Added missing break statements

Signed-off-by: Aleksa Savic --- libavcodec/avs.c | 2 ++ libavcodec/mpegvideo_enc.c | 1 + libavformat/aiffdec.c | 1 + libavformat/lmlm4.c| 1 + 4 files changed, 5 insertions(+) diff --git a/libavcodec/avs.c b/libavcodec/avs.c index

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

2017-12-31 22:26 GMT+01:00 Carl Eugen Hoyos : > 2017-12-31 22:17 GMT+01:00 Michael Niedermayer : >> On Sat, Dec 30, 2017 at 02:36:39PM +0100, Carl Eugen Hoyos wrote: >>> 2017-12-29 23:37 GMT+01:00 Carl Eugen Hoyos : >>> > 2017-11-28

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

2017-12-31 22:17 GMT+01:00 Michael Niedermayer : > On Sat, Dec 30, 2017 at 02:36:39PM +0100, Carl Eugen Hoyos wrote: >> 2017-12-29 23:37 GMT+01:00 Carl Eugen Hoyos : >> > 2017-11-28 21:32 GMT+01:00 Michael Niedermayer : >> >> On

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

On Sat, Dec 30, 2017 at 02:36:39PM +0100, Carl Eugen Hoyos wrote: > 2017-12-29 23:37 GMT+01:00 Carl Eugen Hoyos : > > 2017-11-28 21:32 GMT+01:00 Michael Niedermayer : > >> On Mon, Nov 27, 2017 at 05:24:14AM +0100, Carl Eugen Hoyos wrote: > > > >>>

Re: [FFmpeg-devel] [PATCH 3/6] mpeg: add experimental support for PSMF audio.

On Sun, Dec 31, 2017 at 05:46:04PM +0800, mi...@brew.sh wrote: > From: Maxim Poliakovski > > Changes by Misty De Meo : > > atrac3plus_parser: remove return statements for invalid data > > atrac3plus_parser: use libavcodec's oma > >

Re: [FFmpeg-devel] [PATCH 6/6] psmf: add FATE tests

On Sun, Dec 31, 2017 at 05:46:07PM +0800, mi...@brew.sh wrote: > From: Misty De Meo > > --- > tests/Makefile | 1 + > tests/fate/psmf.mak | 23 +++ > 2 files changed, 24 insertions(+) > create mode 100644 tests/fate/psmf.mak > > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

On 12/31/17, Derek Buitenhuis wrote: > On 12/31/2017 2:08 PM, Paul B Mahol wrote: > Why do they change? > Do I understand correctly that the files get bigger (~5%)? > If yes, wouldn't that indicate that the patch is not a good idea? Its because of

Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

On 12/31/2017 2:04 PM, Carl Eugen Hoyos wrote: > This is not helpful;-( > Is it so unlikely that the patch has small gain for gbr > (theoretically compensated by existing fast conversion > from gbr to rgb) but large impact for rgb (with slow > conversion from rgb into gbr)? I went and tested the

Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

On 12/31/2017 2:08 PM, Paul B Mahol wrote: Why do they change? Do I understand correctly that the files get bigger (~5%)? If yes, wouldn't that indicate that the patch is not a good idea? >>> >>> Its because of different scaling path. Have nothing to do with >>> good or bad idea. >>

Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

On 12/31/2017 2:21 PM, Carl Eugen Hoyos wrote: > The real-world issue I see is screen-recording. > > Given that these are small functions and the obvious user advantage > I really believe supporting both pix_fmts is the best solution. Generic RGB packing has no place inside the encoder and

Re: [FFmpeg-devel] [PATCH] tcp: properly return EOF

On Sat, 30 Dec 2017 13:22:37 -0800 Aaron Levinson wrote: > On 12/30/2017 8:44 AM, wm4 wrote: > > There is no POSIX error code for EOF - recv() signals EOF by simply > > returning 0. But libavformat recently changed its conventionts and > > "conventionts" ->

Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

2017-12-31 15:16 GMT+01:00 Paul B Mahol : > On 12/31/17, Carl Eugen Hoyos wrote: >> 2017-12-31 10:48 GMT+01:00 Paul B Mahol : >> >>> static void mangle_rgb_planes(uint8_t *dst[4], ptrdiff_t dst_stride, >> >> Why don't you add a new function

Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

On 12/31/17, Carl Eugen Hoyos wrote: > 2017-12-31 10:48 GMT+01:00 Paul B Mahol : > >> static void mangle_rgb_planes(uint8_t *dst[4], ptrdiff_t dst_stride, > > Why don't you add a new function mangle_gbr_planes() and > keep rgb encoding? The function is not

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: move the old decoding/encoding API under and ifdef

On 12/31/2017 10:07 AM, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > libavcodec/avcodec.h | 4 +++- > libavcodec/version.h | 5 - > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

2017-12-31 10:48 GMT+01:00 Paul B Mahol : > static void mangle_rgb_planes(uint8_t *dst[4], ptrdiff_t dst_stride, Why don't you add a new function mangle_gbr_planes() and keep rgb encoding? The function is not very large. Carl Eugen

Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

On 12/31/17, Carl Eugen Hoyos wrote: > 2017-12-31 14:49 GMT+01:00 Paul B Mahol : >> On 12/31/17, Carl Eugen Hoyos wrote: >>> 2017-12-31 10:48 GMT+01:00 Paul B Mahol : Signed-off-by: Paul B Mahol

Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

2017-12-31 14:49 GMT+01:00 Paul B Mahol : > On 12/31/17, Carl Eugen Hoyos wrote: >> 2017-12-31 10:48 GMT+01:00 Paul B Mahol : >>> Signed-off-by: Paul B Mahol >>> --- >>> libavcodec/utvideoenc.c | 47

Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

On 12/31/17, Carl Eugen Hoyos wrote: > 2017-12-31 10:48 GMT+01:00 Paul B Mahol : >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/utvideoenc.c | 47 +--- >> tests/ref/fate/utvideoenc_rgb_left| 100 >>

Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

2017-12-31 10:48 GMT+01:00 Paul B Mahol : > Signed-off-by: Paul B Mahol > --- > libavcodec/utvideoenc.c | 47 +--- > tests/ref/fate/utvideoenc_rgb_left| 100 > +- >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: mark AV_CODEC_CAP_SUBFRAMES as deprecated

On 31 December 2017 at 13:13, wm4 wrote: > On Sun, 31 Dec 2017 13:07:28 + > Rostislav Pehlivanov wrote: > > > The new decoding API supports 1 avpkt -> multiple avframes natively. > > > > Signed-off-by: Rostislav Pehlivanov >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: mark AV_CODEC_CAP_SUBFRAMES as deprecated

On Sun, 31 Dec 2017 13:07:28 + Rostislav Pehlivanov wrote: > The new decoding API supports 1 avpkt -> multiple avframes natively. > > Signed-off-by: Rostislav Pehlivanov > --- > libavcodec/avcodec.h | 3 +++ > 1 file changed, 3 insertions(+) > >

[FFmpeg-devel] [PATCH 2/2] avcodec: mark AV_CODEC_CAP_SUBFRAMES as deprecated

The new decoding API supports 1 avpkt -> multiple avframes natively. Signed-off-by: Rostislav Pehlivanov --- libavcodec/avcodec.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 5a27211b80..7e74c3b01c 100644 ---

[FFmpeg-devel] [PATCH 1/2] avcodec: move the old decoding/encoding API under and ifdef

Signed-off-by: Rostislav Pehlivanov --- libavcodec/avcodec.h | 4 +++- libavcodec/version.h | 5 - 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index c13deb599f..5a27211b80 100644 --- a/libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

Wu Zhiqiang (2017-12-30): > Thanks for the patch, it works fine to me. > Disable is good enough to prevent unnecessary wrap control. Thanks for the testing. Patch pushed. Regards, -- Nicolas George signature.asc Description: Digital signature ___

[FFmpeg-devel] [PATCH 3/6] mpeg: add experimental support for PSMF audio.

From: Maxim Poliakovski Changes by Misty De Meo : atrac3plus_parser: remove return statements for invalid data atrac3plus_parser: use libavcodec's oma atrac3plus_parser: pass along unexpected data unaltered Change by Michael "Bazz"

[FFmpeg-devel] [PATCH 5/6] mpeg: fix use of deprecated struct

From: Misty De Meo --- libavformat/mpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index a366ece0ed..210424faf3 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -547,8 +547,8 @@ redo:

[FFmpeg-devel] [PATCH 0/6] mpeg: add experimental support for PSMF audio.

From: Misty De Meo I think this version of the patch should address the issue. If frames can't be parsed, the original data is passed through unaltered. From what I can tell about the RIFF WAVE .at3 files, they don't use the format being parsed at all and don't require

[FFmpeg-devel] [PATCH] avcodec/utvideoenc: switch to planar RGB formats

Signed-off-by: Paul B Mahol --- libavcodec/utvideoenc.c | 47 +--- tests/ref/fate/utvideoenc_rgb_left| 100 +- tests/ref/fate/utvideoenc_rgb_median | 100 +-

[FFmpeg-devel] [PATCH 6/6] psmf: add FATE tests

From: Misty De Meo --- tests/Makefile | 1 + tests/fate/psmf.mak | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 tests/fate/psmf.mak diff --git a/tests/Makefile b/tests/Makefile index fd3713fe81..c569091fcb 100644 ---

[FFmpeg-devel] [PATCH 4/6] Fix detecting ATRAC3 audio from MPS files

From: Misty De Meo MPS files are MPEG files used on PSP Video discs. They lack the PSMF header used by .pms files, and so the special casing in the original patch fails to support their audio. This patch fixes this by unconditionally reading a new byte for the startcode for

[FFmpeg-devel] [PATCH 2/6] oma: move some constants into libavcodec

From: Misty De Meo Most of the constants in libavcodec/oma aren't specific to libavformat; moving them into libavcodec makes them available to libavcodec as well as keeping them compatible with libavformat. ff_oma_codec_tags uses a libavformat-specific type, so it has been

[FFmpeg-devel] [PATCH 1/6] fate: add atrac3p conversion test

From: Misty De Meo --- tests/fate/atrac.mak | 4 1 file changed, 4 insertions(+) diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak index acf79a539c..1707373890 100644 --- a/tests/fate/atrac.mak +++ b/tests/fate/atrac.mak @@ -31,6 +31,10 @@ FATE_ATRAC3P +=

Re: [FFmpeg-devel] [PATCH][RFC]lavu/mem: Do not realloc in av_fast_alloc() if size == min_size

On 12/30/17, Carl Eugen Hoyos wrote: > Hi! > > FFmpeg has an arbitrary allocation limit (2G iirc), av_fast_realloc() > increases the allocation even if the requested is equal the already > allocated size. I believe this can lead to unnecessary OOM (no > testcase) if the