[FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option - 2nd attempt

2018-12-17 Thread Adrian
Thanks for the explanation, now your intent is clear. I agree that keeping playlist file always as temp as long as it's a file protocol makes sense and won't do harm, though I'm still curious why original change to accept HLS_TEMP_FILE flag was sent to include and was included in official

Re: [FFmpeg-devel] [PATCH] avformat/nut: fix duration estimation by writting EOR packets

2018-12-17 Thread Michael Niedermayer
On Mon, Dec 17, 2018 at 07:32:49PM +0100, Paul B Mahol wrote: > On 12/17/18, Michael Niedermayer wrote: > > On Mon, Dec 17, 2018 at 06:04:40PM +0100, Paul B Mahol wrote: > >> Hi, > >> > >> patches attached. > > > >> nut.h|2 + > >> nutdec.c |3 ++ > >> nutenc.c | 87 > >>

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 21:52 GMT+01:00, Jan Ekström : > On Mon, Dec 17, 2018 at 10:49 PM Carl Eugen Hoyos > wrote: >> >> 2018-12-17 21:30 GMT+01:00, Jan Ekström : >> > On Mon, Dec 17, 2018 at 10:23 PM Carl Eugen Hoyos >> > wrote: >> >> >> >> 2018-12-17 21:17 GMT+01:00, Jan Ekström : >> >> > On Mon, Dec 17,

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Paul B Mahol
On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 21:35 GMT+01:00, Rostislav Pehlivanov : >> On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos wrote: >> >>> Hi! >>> >>> The Opus struct RawBitsContext is used in both the decoder and the >>> encoder. >>> The fact that *position is const avoids

Re: [FFmpeg-devel] [PATCH 2/2] lavf/mov: document the dvh1 codec switch based on hvcC availability

2018-12-17 Thread Paul B Mahol
On 12/3/18, Jan Ekström wrote: > --- > libavformat/mov.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index ec57a05803..497790522f 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -1903,6 +1903,11 @@ static int

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Paul B Mahol
On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : > >> The Opus struct RawBitsContext is used in both the decoder and the >> encoder. >> The fact that *position is const avoids warnings in the decoder where >> it points into the bitstream. The encoder writes

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Paul B Mahol
On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 22:29 GMT+01:00, Paul B Mahol : >> On 12/17/18, Carl Eugen Hoyos wrote: >>> 2018-12-17 22:26 GMT+01:00, Paul B Mahol : On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : > >> The Opus struct

Re: [FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option - 2nd attempt

2018-12-17 Thread Aleksey Skripka
Thanks for your attention, Adrian! just one moment, in hls_write_packet(): instead: +if (use_temp_file) { +hls_rename_temp_file(s, oc); should be: +if (use_temp_file && !(hls->flags & HLS_SINGLE_FILE)) +hls_rename_temp_file(s, oc); or we a killing

[FFmpeg-devel] [PATCH] avcodec/mips: [loongson] fix failed case: hevc-conformance-AMP_A_Samsung_* in loongson2k

2018-12-17 Thread gxw
The AV_INPUT_BUFFER_PADDING_SIZE has been increased to 64, but the value is still 32 in function ff_hevc_sao_edge_filter_8_msa. So, Modify the corresponding value to 64. Fate tests passed. --- libavcodec/mips/hevc_lpf_sao_msa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/vf_hwmap: make hwunmap from software frame work.

2018-12-17 Thread Mark Thompson
13/12/2018 01:50, Ruiling Song wrote: > This patch was used to fix the second hwmap filter issue: > [vaapi_frame] hwmap [software filters] hwmap [vaapi_frame] > For such case, we also need to allocate the hardware frame > and map it back to software. > > Signed-off-by: Ruiling Song > --- >

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Vittorio Giovara
On Mon, Dec 10, 2018 at 2:50 PM Mohammad Izadi wrote: > From: Mohammad Izadi > > The dynamic metadata contains data for color volume transform - > application 4 of SPMTE 2094-40:2016 standard. The data comes from HEVC in > the SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35. > > I'll add support to

[FFmpeg-devel] [PATCH]lavc/mjpegdec: Interpret three-component Adobe transform 0 also as RGB

2018-12-17 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #7625 for me. Please comment, Carl Eugen From be83e6c657b8d8e2a158747b58c4dbc6ba3cc516 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 17 Dec 2018 23:53:29 +0100 Subject: [PATCH] lavc/mjpegdec: Interpret three-component Adobe transform 0 also as RGB.

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: unset DTS/PTS for subtitle PES packets if PCR not available

2018-12-17 Thread Jan Ekström
On Mon, Dec 17, 2018 at 8:26 PM Michael Niedermayer wrote: > > On Sat, Dec 15, 2018 at 08:50:41PM +0200, Jan Ekström wrote: > > Fixes issues when a subtitle packet is received before PCR for the > > program has been received, leading to wildly jumping timestamps > > on the lavf client side as

Re: [FFmpeg-devel] [PATCH, v3] lavc/hevc_parser: cope with more leading_zero_8bits and update FATE

2018-12-17 Thread Fu, Linjie
> -Original Message- > From: Fu, Linjie > Sent: Monday, December 10, 2018 18:24 > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [PATCH,v3] lavc/hevc_parser: cope with more leading_zero_8bits > and update FATE > > Given that leading_zero_8bits can be included many times at the

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Vittorio Giovara
On Mon, Dec 17, 2018 at 5:53 PM Jan Ekström wrote: > On Tue, Dec 18, 2018 at 12:41 AM Vittorio Giovara > wrote: > > > > On Mon, Dec 10, 2018 at 2:50 PM Mohammad Izadi > wrote: > > > > > From: Mohammad Izadi > > > > > > The dynamic metadata contains data for color volume transform - > > >

Re: [FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

2018-12-17 Thread Ronak
> On Dec 17, 2018, at 4:35 PM, Aleksey Skripka wrote: > > Evening! > > First of all, about playlist writeout: > before 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6 - playlist was always(!) > creating via .tmp file. > after 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6 - playlists .tmp logic become >

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Jan Ekström
On Tue, Dec 18, 2018 at 12:58 AM Vittorio Giovara wrote: > > On Mon, Dec 17, 2018 at 5:53 PM Jan Ekström wrote: > > > On Tue, Dec 18, 2018 at 12:41 AM Vittorio Giovara > > wrote: > > > > > > I like > > VeryLongJavaLikeNamingForFunctionsAndDataTypesAsWellAsEnumsOfCourse > > > as much as the next

Re: [FFmpeg-devel] [PATCH] libavcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-17 Thread Michael Niedermayer
On Mon, Dec 17, 2018 at 05:13:05PM +0800, Steven Liu wrote: > After patch: > init nbits = 17, get 1 samples, duration: 15221 > Before patch: > init nbits = 17, get 1 samples, duration: 16105 > > test script: > DURATION=0 > for((i=0;i<1;i++)) do > ./libavcodec/tests/fft -n 17 &>output

[FFmpeg-devel] [PATCH] avcodec: add AV1 frame split bitstream filter

2018-12-17 Thread James Almer
This will be needed by the eventual native AV1 decoder. Signed-off-by: James Almer --- Missing Changelog entry, version bump configure| 1 + libavcodec/Makefile | 1 + libavcodec/av1_frame_split_bsf.c | 246 +++

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/vf_hwmap: make hwunmap from software frame work.

2018-12-17 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Mark Thompson > Sent: Tuesday, December 18, 2018 6:33 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavfi/vf_hwmap: make hwunmap from > software frame work. > >

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Jan Ekström
On Tue, Dec 18, 2018 at 12:41 AM Vittorio Giovara wrote: > > On Mon, Dec 10, 2018 at 2:50 PM Mohammad Izadi wrote: > > > From: Mohammad Izadi > > > > The dynamic metadata contains data for color volume transform - > > application 4 of SPMTE 2094-40:2016 standard. The data comes from HEVC in > >

Re: [FFmpeg-devel] avdevice/decklink: Fix seg fault in decklink

2018-12-17 Thread Marton Balint
On Mon, 17 Dec 2018, BIGLER Don (Framatome) wrote: Attached is a patch that fixes a potential segmentation fault in avdevice/decklink when used in a multi-threaded environment outside of ffmpeg. Because the capture_started flag is not set the stream is not closed properly. This can cause

Re: [FFmpeg-devel] NUT end timestamp

2018-12-17 Thread Michael Niedermayer
On Mon, Dec 17, 2018 at 11:24:43AM +0100, Paul B Mahol wrote: > On 12/14/18, Michael Niedermayer wrote: > > Hi > > > > replying to a comment from IRC here because "durandal_1707 has quit" so it > > wouldnt be seen, and might be interresting for others so not mailing > > private > > > >

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:02 GMT+01:00, Jan Ekström : > On Mon, Dec 17, 2018 at 10:57 PM Carl Eugen Hoyos > wrote: >> >> 2018-12-17 21:52 GMT+01:00, Jan Ekström : >> > On Mon, Dec 17, 2018 at 10:49 PM Carl Eugen Hoyos >> > wrote: >> >> >> >> 2018-12-17 21:30 GMT+01:00, Jan Ekström : >> >> > On Mon, Dec 17,

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Paul B Mahol
On 12/3/18, Jan Ekström wrote: > From: Rodger Combs > > These are registered identifiers at the MPEG-4 RA, which are > defined as to be utilized for Dolby Vision AVC/HEVC streams that > are not correctly presentable by standards-compliant AVC/HEVC players. > > According to the Dolby Vision

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : > The Opus struct RawBitsContext is used in both the decoder and the encoder. > The fact that *position is const avoids warnings in the decoder where > it points into the bitstream. The encoder writes into the same > pointer, attached cast silences

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:18 GMT+01:00, Jan Ekström : > On Mon, Dec 17, 2018 at 11:11 PM Carl Eugen Hoyos > wrote: >> >> 2018-12-17 22:02 GMT+01:00, Jan Ekström : >> > On Mon, Dec 17, 2018 at 10:57 PM Carl Eugen Hoyos >> > wrote: >> >> >> >> 2018-12-17 21:52 GMT+01:00, Jan Ekström : >> >> > On Mon, Dec 17,

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:27 GMT+01:00, Rodger Combs : > ffmpeg | branch: master | Rodger Combs | Mon Nov 5 > 10:26:24 2018 -0600| [6ebe88f3a4c427511eba7495896f4a57a2b4b529] | committer: > Jan Ekström > > lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264 > > These are registered identifiers

Re: [FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

2018-12-17 Thread Aleksey Skripka
Evening! First of all, about playlist writeout: before 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6 - playlist was always(!) creating via .tmp file. after 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6 - playlists .tmp logic become dependent on +temp_file flag. I suggest to return to original logic.

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Jan Ekström
On Mon, Dec 17, 2018 at 11:36 PM Carl Eugen Hoyos wrote: > > 2018-12-17 22:27 GMT+01:00, Rodger Combs : > > ffmpeg | branch: master | Rodger Combs | Mon Nov 5 > > 10:26:24 2018 -0600| [6ebe88f3a4c427511eba7495896f4a57a2b4b529] | committer: > > Jan Ekström > > > > lavf/isom: add Dolby Vision

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: unset DTS/PTS for subtitle PES packets if PCR not available

2018-12-17 Thread Michael Niedermayer
On Sat, Dec 15, 2018 at 08:50:41PM +0200, Jan Ekström wrote: > Fixes issues when a subtitle packet is received before PCR for the > program has been received, leading to wildly jumping timestamps > on the lavf client side as well as in the re-ordering logic. > > This usually happens in case of

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Jan Ekström
On Mon, Dec 17, 2018 at 3:47 PM Carl Eugen Hoyos wrote: > > 2018-12-17 7:58 GMT+01:00, Jan Ekström : > > On Mon, Dec 17, 2018, 03:02 Carl Eugen Hoyos > > >> 2018-12-17 1:58 GMT+01:00, Jan Ekström : > > >> > So as far as it's been possible to test this, that's been done > >> > >> Could you point

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 21:35 GMT+01:00, Rostislav Pehlivanov : > On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos wrote: > >> Hi! >> >> The Opus struct RawBitsContext is used in both the decoder and the >> encoder. >> The fact that *position is const avoids warnings in the decoder where >> it points into the

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Jan Ekström
On Mon, Dec 17, 2018 at 10:49 PM Carl Eugen Hoyos wrote: > > 2018-12-17 21:30 GMT+01:00, Jan Ekström : > > On Mon, Dec 17, 2018 at 10:23 PM Carl Eugen Hoyos > > wrote: > >> > >> 2018-12-17 21:17 GMT+01:00, Jan Ekström : > >> > On Mon, Dec 17, 2018 at 3:47 PM Carl Eugen Hoyos > >> > wrote: > >>

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Paul B Mahol
On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 22:02 GMT+01:00, Paul B Mahol : >> On 12/17/18, Carl Eugen Hoyos wrote: >>> 2018-12-17 21:35 GMT+01:00, Rostislav Pehlivanov : On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos wrote: > Hi! > > The Opus struct

Re: [FFmpeg-devel] [PATCH] libavcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 15:56 GMT+01:00, Steven Liu : > > >> On Dec 17, 2018, at 22:05, Carl Eugen Hoyos wrote: >> >> 2018-12-17 10:13 GMT+01:00, Steven Liu : >>> After patch: >>> init nbits = 17, get 1 samples, duration: 15221 >>> Before patch: >>> init nbits = 17, get 1 samples, duration: 16105 >>>

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:02 GMT+01:00, Paul B Mahol : > On 12/17/18, Carl Eugen Hoyos wrote: >> 2018-12-17 21:35 GMT+01:00, Rostislav Pehlivanov : >>> On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos >>> wrote: >>> Hi! The Opus struct RawBitsContext is used in both the decoder and the

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:45 GMT+01:00, Jan Ekström : > On Mon, Dec 17, 2018 at 11:36 PM Carl Eugen Hoyos > wrote: >> >> 2018-12-17 22:27 GMT+01:00, Rodger Combs : >> > ffmpeg | branch: master | Rodger Combs | Mon >> > Nov 5 >> > 10:26:24 2018 -0600| [6ebe88f3a4c427511eba7495896f4a57a2b4b529] | >> >

Re: [FFmpeg-devel] [PATCH] avcodec/h264_refs: reset MMCO when invalid mmco code is found

2018-12-17 Thread Mark Thompson
On 11/12/2018 14:28, Paul B Mahol wrote: > On 12/11/18, Carl Eugen Hoyos wrote: >> 2018-12-10 23:41 GMT+01:00, Mark Thompson : >>> On 09/12/2018 14:21, Mark Thompson wrote: On 09/12/2018 13:54, Paul B Mahol wrote: > On 12/9/18, Mark Thompson wrote: >> On 09/12/2018 08:52, Paul B

Re: [FFmpeg-devel] [PATCH] avformat/nut: fix duration estimation by writting EOR packets

2018-12-17 Thread Paul B Mahol
On 12/17/18, Michael Niedermayer wrote: > On Mon, Dec 17, 2018 at 06:04:40PM +0100, Paul B Mahol wrote: >> Hi, >> >> patches attached. > >> nut.h|2 + >> nutdec.c |3 ++ >> nutenc.c | 87 >> --- >> 3 files changed, 88

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 21:30 GMT+01:00, Jan Ekström : > On Mon, Dec 17, 2018 at 10:23 PM Carl Eugen Hoyos > wrote: >> >> 2018-12-17 21:17 GMT+01:00, Jan Ekström : >> > On Mon, Dec 17, 2018 at 3:47 PM Carl Eugen Hoyos >> > wrote: >> >> >> >> 2018-12-17 7:58 GMT+01:00, Jan Ekström : >> >> > On Mon, Dec 17,

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Jan Ekström
On Mon, Dec 17, 2018 at 11:02 PM Jan Ekström wrote: > > On Mon, Dec 17, 2018 at 10:57 PM Carl Eugen Hoyos wrote: > > > > 2018-12-17 21:52 GMT+01:00, Jan Ekström : > > > On Mon, Dec 17, 2018 at 10:49 PM Carl Eugen Hoyos > > > wrote: > > >> > > >> 2018-12-17 21:30 GMT+01:00, Jan Ekström : > > >>

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:29 GMT+01:00, Paul B Mahol : > On 12/17/18, Carl Eugen Hoyos wrote: >> 2018-12-17 22:26 GMT+01:00, Paul B Mahol : >>> On 12/17/18, Carl Eugen Hoyos wrote: 2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : > The Opus struct RawBitsContext is used in both the decoder and

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 21:17 GMT+01:00, Jan Ekström : > On Mon, Dec 17, 2018 at 3:47 PM Carl Eugen Hoyos wrote: >> >> 2018-12-17 7:58 GMT+01:00, Jan Ekström : >> > On Mon, Dec 17, 2018, 03:02 Carl Eugen Hoyos > > >> >> 2018-12-17 1:58 GMT+01:00, Jan Ekström : >> >> >> > So as far as it's been possible to

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Rostislav Pehlivanov
On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos wrote: > Hi! > > The Opus struct RawBitsContext is used in both the decoder and the encoder. > The fact that *position is const avoids warnings in the decoder where > it points into the bitstream. The encoder writes into the same > pointer, attached

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:26 GMT+01:00, Paul B Mahol : > On 12/17/18, Carl Eugen Hoyos wrote: >> 2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : >> >>> The Opus struct RawBitsContext is used in both the decoder and the >>> encoder. >>> The fact that *position is const avoids warnings in the decoder where >>>

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Jan Ekström
On Mon, Dec 17, 2018 at 11:47 PM Carl Eugen Hoyos wrote: > > 2018-12-17 22:45 GMT+01:00, Jan Ekström : > > On Mon, Dec 17, 2018 at 11:36 PM Carl Eugen Hoyos > > wrote: > >> > >> 2018-12-17 22:27 GMT+01:00, Rodger Combs : > >> > ffmpeg | branch: master | Rodger Combs | Mon > >> > Nov 5 > >> >

[FFmpeg-devel] avdevice/decklink: Fix seg fault in decklink

2018-12-17 Thread BIGLER Don (Framatome)
Attached is a patch that fixes a potential segmentation fault in avdevice/decklink when used in a multi-threaded environment outside of ffmpeg. Because the capture_started flag is not set the stream is not closed properly. This can cause a segmentation fault when the input callback is called

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: unset DTS/PTS for subtitle PES packets if PCR not available

2018-12-17 Thread Paul B Mahol
On 12/17/18, Michael Niedermayer wrote: > On Sat, Dec 15, 2018 at 08:50:41PM +0200, Jan Ekström wrote: >> Fixes issues when a subtitle packet is received before PCR for the >> program has been received, leading to wildly jumping timestamps >> on the lavf client side as well as in the re-ordering

Re: [FFmpeg-devel] NUT end timestamp

2018-12-17 Thread Paul B Mahol
On 12/17/18, Michael Niedermayer wrote: > On Mon, Dec 17, 2018 at 11:24:43AM +0100, Paul B Mahol wrote: >> On 12/14/18, Michael Niedermayer wrote: >> > Hi >> > >> > replying to a comment from IRC here because "durandal_1707 has quit" so >> > it >> > wouldnt be seen, and might be interresting for

Re: [FFmpeg-devel] [PATCH] avformat/nut: fix duration estimation by writting EOR packets

2018-12-17 Thread Paul B Mahol
On 12/17/18, Michael Niedermayer wrote: > On Mon, Dec 17, 2018 at 07:32:49PM +0100, Paul B Mahol wrote: >> On 12/17/18, Michael Niedermayer wrote: >> > On Mon, Dec 17, 2018 at 06:04:40PM +0100, Paul B Mahol wrote: >> >> Hi, >> >> >> >> patches attached. >> > >> >> nut.h|2 + >> >>

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Jan Ekström
On Mon, Dec 17, 2018 at 10:23 PM Carl Eugen Hoyos wrote: > > 2018-12-17 21:17 GMT+01:00, Jan Ekström : > > On Mon, Dec 17, 2018 at 3:47 PM Carl Eugen Hoyos wrote: > >> > >> 2018-12-17 7:58 GMT+01:00, Jan Ekström : > >> > On Mon, Dec 17, 2018, 03:02 Carl Eugen Hoyos >> > > >> >> 2018-12-17 1:58

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 21:53 GMT+01:00, Carl Eugen Hoyos : > 2018-12-17 21:35 GMT+01:00, Rostislav Pehlivanov : >> On Mon, 17 Dec 2018 at 01:47, Carl Eugen Hoyos >> wrote: >> >>> Hi! >>> >>> The Opus struct RawBitsContext is used in both the decoder and the >>> encoder. >>> The fact that *position is const

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Jan Ekström
On Mon, Dec 17, 2018 at 11:11 PM Carl Eugen Hoyos wrote: > > 2018-12-17 22:02 GMT+01:00, Jan Ekström : > > On Mon, Dec 17, 2018 at 10:57 PM Carl Eugen Hoyos > > wrote: > >> > >> 2018-12-17 21:52 GMT+01:00, Jan Ekström : > >> > On Mon, Dec 17, 2018 at 10:49 PM Carl Eugen Hoyos > >> > wrote: > >>

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Paul B Mahol
On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 22:27 GMT+01:00, Rodger Combs : >> ffmpeg | branch: master | Rodger Combs | Mon Nov >> 5 >> 10:26:24 2018 -0600| [6ebe88f3a4c427511eba7495896f4a57a2b4b529] | >> committer: >> Jan Ekström >> >> lavf/isom: add Dolby Vision sample entry codes for

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:37 GMT+01:00, Paul B Mahol : > On 12/17/18, Carl Eugen Hoyos wrote: >> 2018-12-17 22:29 GMT+01:00, Paul B Mahol : >>> On 12/17/18, Carl Eugen Hoyos wrote: 2018-12-17 22:26 GMT+01:00, Paul B Mahol : > On 12/17/18, Carl Eugen Hoyos wrote: >> 2018-12-17 2:47 GMT+01:00,

Re: [FFmpeg-devel] [PATCH] lavf/id3v2: fail read_apic on EOF reading mimetype

2018-12-17 Thread Michael Niedermayer
On Sun, Dec 16, 2018 at 09:42:49PM +0100, Tomas Härdin wrote: > fre 2018-12-14 klockan 13:44 -0800 skrev chcunningham: > > avio_read may return EOF, leaving the mimetype array unitialized. > > fail > > early when this occurs to avoid using the array in an unitialized > > state. > > --- > >  

Re: [FFmpeg-devel] [PATCH]lsws/utils: Split "emms_c(); " call in two lines

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 16:45 GMT+01:00, Nicolas George : > Carl Eugen Hoyos (2018-12-17): >> #ifndef emms_c >> -# define emms_c() while(0) >> +# define emms_c() while(0){} >> #endif > > That feels really wrong, or at least completely unusual. But not the > change you made, the original code: the usual

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Jan Ekström
On Mon, Dec 17, 2018 at 10:57 PM Carl Eugen Hoyos wrote: > > 2018-12-17 21:52 GMT+01:00, Jan Ekström : > > On Mon, Dec 17, 2018 at 10:49 PM Carl Eugen Hoyos > > wrote: > >> > >> 2018-12-17 21:30 GMT+01:00, Jan Ekström : > >> > On Mon, Dec 17, 2018 at 10:23 PM Carl Eugen Hoyos > >> > wrote: > >>

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-17 Thread Paul B Mahol
On 12/17/18, Carl Eugen Hoyos wrote: > 2018-12-17 22:26 GMT+01:00, Paul B Mahol : >> On 12/17/18, Carl Eugen Hoyos wrote: >>> 2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : >>> The Opus struct RawBitsContext is used in both the decoder and the encoder. The fact that *position is

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Jan Ekström
On Mon, Dec 17, 2018 at 11:23 PM Paul B Mahol wrote: > > On 12/3/18, Jan Ekström wrote: > > From: Rodger Combs > > > > These are registered identifiers at the MPEG-4 RA, which are > > defined as to be utilized for Dolby Vision AVC/HEVC streams that > > are not correctly presentable by

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 22:51 GMT+01:00, Jan Ekström : > On Mon, Dec 17, 2018 at 11:47 PM Carl Eugen Hoyos > wrote: >> >> 2018-12-17 22:45 GMT+01:00, Jan Ekström : >> > On Mon, Dec 17, 2018 at 11:36 PM Carl Eugen Hoyos >> > wrote: >> >> >> >> 2018-12-17 22:27 GMT+01:00, Rodger Combs : >> >> > ffmpeg |

Re: [FFmpeg-devel] [PATCH] avformat/nut: fix duration estimation by writting EOR packets

2018-12-17 Thread Michael Niedermayer
On Mon, Dec 17, 2018 at 06:04:40PM +0100, Paul B Mahol wrote: > Hi, > > patches attached. > nut.h|2 + > nutdec.c |3 ++ > nutenc.c | 87 > --- > 3 files changed, 88 insertions(+), 4 deletions(-) >

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Vittorio Giovara
On Tue, Dec 18, 2018 at 12:04 AM Mohammad Izadi wrote: > As Jan mentioned, we need to specify the kind of the HDR metadata. Here are > some alternatives: > > AVDynamicHDRPlus > AVSMPTE2094App4 (Application 4 is HDR10+ while Dolby is application 1) > AVHDRPlusMetadata > > Which one do you

Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: set pict_type to be I for IDR frames.

2018-12-17 Thread Li, Zhong
> libavcodec/qsvenc.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index > 931e994..96cf642 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -1377,11 +1377,10 @@ int ff_qsv_encode(AVCodecContext

Re: [FFmpeg-devel] [PATCH v4] libavfilter: add transpose_vaapi filter

2018-12-17 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Zhou, Zachary > Sent: Monday, December 3, 2018 6:56 PM > To: FFmpeg development discussions and patches > > Cc: Zhou, Zachary > Subject: Re: [FFmpeg-devel] [PATCH v4] libavfilter: add transpose_vaapi filter > > ping?

Re: [FFmpeg-devel] [PATCH] avcodec/mips: [loongson] fix failed case: hevc-conformance-AMP_A_Samsung_* in loongson2k

2018-12-17 Thread Shiyou Yin
>-Original Message- >From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] >On Behalf Of gxw >Sent: Tuesday, December 18, 2018 9:15 AM >To: ffmpeg-devel@ffmpeg.org >Cc: gxw >Subject: [FFmpeg-devel] [PATCH] avcodec/mips: [loongson] fix failed case:

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Mohammad Izadi
As Jan mentioned, we need to specify the kind of the HDR metadata. Here are some alternatives: AVDynamicHDRPlus AVSMPTE2094App4 (Application 4 is HDR10+ while Dolby is application 1) AVHDRPlusMetadata Which one do you prefer? -- Best, Mohammad On Mon, Dec 17, 2018 at 3:07 PM Jan Ekström

Re: [FFmpeg-devel] [PATCH] avfilter/af_apad: add pad_dur and whole_dur options

2018-12-17 Thread Paul B Mahol
On 12/16/18, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 18 +++--- > libavfilter/af_apad.c | 23 +-- > 2 files changed, 36 insertions(+), 5 deletions(-) Will apply ASAP! ___

[FFmpeg-devel] [PATCH] libavcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-17 Thread Steven Liu
After patch: init nbits = 17, get 1 samples, duration: 15221 Before patch: init nbits = 17, get 1 samples, duration: 16105 test script: DURATION=0 for((i=0;i<1;i++)) do ./libavcodec/tests/fft -n 17 &>output T_DURATION=`grep "duration" output | awk -F"=" '{ print $2}'` DURATION=`expr

Re: [FFmpeg-devel] NUT end timestamp

2018-12-17 Thread Paul B Mahol
On 12/14/18, Michael Niedermayer wrote: > Hi > > replying to a comment from IRC here because "durandal_1707 has quit" so it > wouldnt be seen, and might be interresting for others so not mailing > private > > michaelni: nut does not take into consideration duration of > last frame to return real

Re: [FFmpeg-devel] [PATCH]lsws/utils: Split "emms_c(); " call in two lines

2018-12-17 Thread Michael Niedermayer
On Mon, Dec 17, 2018 at 02:14:26AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a useless warning when compiling with clang on arm. > > Please comment, Carl Eugen > utils.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > fb6799bbc59d79d9dfba9f8661aaecbed568f3a5

[FFmpeg-devel] [PATCH] avcodec/mips: [loongson] enable MSA optimization for loongson platform.

2018-12-17 Thread Shiyou Yin
Set initialization order of MSA after MMI to make it work on loongson platform(msa is supported by loongson2k、3a4000 etc.). --- libavcodec/mips/blockdsp_init_mips.c| 6 +++--- libavcodec/mips/h264chroma_init_mips.c | 6 +++--- libavcodec/mips/h264dsp_init_mips.c | 6 +++---

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: unset DTS/PTS for subtitle PES packets if PCR not available

2018-12-17 Thread Jan Ekström
On Sat, Dec 15, 2018, 20:50 Jan Ekström Fixes issues when a subtitle packet is received before PCR for the > program has been received, leading to wildly jumping timestamps > on the lavf client side as well as in the re-ordering logic. > > This usually happens in case of multiplexes where the PCR

Re: [FFmpeg-devel] avformat/hls.c: Fix memory leak

2018-12-17 Thread Valery Kot
I just verified that patch is working. Build FFmpeg master with and without patch, run HLS live stream from Youtube (extracted by youtube_dl for Euronews live). ffmpeg -i

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize float yuv2plane1

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 8:37 GMT+01:00, Lauri Kasanen : > On Mon, 17 Dec 2018 01:03:36 +0100 > Carl Eugen Hoyos wrote: > >> 2018-12-16 10:06 GMT+01:00, Lauri Kasanen : >> > This function wouldn't benefit from VSX instructions, so I put it >> > under altivec. >> > >> > ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s

Re: [FFmpeg-devel] [PATCH]lsws/utils: Split "emms_c(); " call in two lines

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 13:24 GMT+01:00, Michael Niedermayer : > On Mon, Dec 17, 2018 at 02:14:26AM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes a useless warning when compiling with clang on arm. >> >> Please comment, Carl Eugen > >> utils.c |3 ++- >> 1 file changed, 2 insertions(+),

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-17 Thread Ronak Patel
> On Dec 13, 2018, at 9:15 PM, Ronak Patel > wrote: > > > >> On Dec 12, 2018, at 2:46 AM, Liu Steven wrote: >> >> >> 在 2018年12月12日,上午5:08,Ronak 写道: On Dec 11, 2018, at 3:28 PM, Gyan wrote: > On 12-12-2018 01:13 AM, Ronak wrote: > > Looks

Re: [FFmpeg-devel] [PATCH] libavcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 10:13 GMT+01:00, Steven Liu : > After patch: > init nbits = 17, get 1 samples, duration: 15221 > Before patch: > init nbits = 17, get 1 samples, duration: 16105 > > test script: > DURATION=0 > for((i=0;i<1;i++)) do > ./libavcodec/tests/fft -n 17 &>output > T_DURATION=`grep

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-17 Thread Carl Eugen Hoyos
2018-12-17 7:58 GMT+01:00, Jan Ekström : > On Mon, Dec 17, 2018, 03:02 Carl Eugen Hoyos >> 2018-12-17 1:58 GMT+01:00, Jan Ekström : >> > So as far as it's been possible to test this, that's been done >> >> Could you point me to a dva1 sample? > > I have not seen any dolby vision samples with avc

[FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

2018-12-17 Thread Adrian
Hello, after upgrading FFmpeg from 4.0 to 4.1 I noticed that temp files in HLS muxed stopped working. It looks like a regression introduced by 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6. I've prepared a patch and tested it cross-compiling for my project's target platform (ARM, Buildroot) and

Re: [FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

2018-12-17 Thread Adrian
Comments inline. Regards Adrian Guzowski W dniu 17.12.2018 o 16:56, Aleksey Skripka pisze: On 17 Dec 2018, at 18:45, Adrian wrote: IMO temp_file+single_file should be mutually exclusive - why would you want to have temp file when you're using only one file anyway? In this mode you would

Re: [FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

2018-12-17 Thread Aleksey Skripka
Greetings! Adrian, with your variant of patch in case of '-hls_flags +temp_file+single_file' no .tmp logic will be used. not sure what is better, but all previous versions was doing so. and also, i'm still sure, that for backward compatibility with all previous versions, index.m3u8 should

Re: [FFmpeg-devel] [PATCH] libavcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-17 Thread Steven Liu
> On Dec 17, 2018, at 22:05, Carl Eugen Hoyos wrote: > > 2018-12-17 10:13 GMT+01:00, Steven Liu : >> After patch: >> init nbits = 17, get 1 samples, duration: 15221 >> Before patch: >> init nbits = 17, get 1 samples, duration: 16105 >> >> test script: >> DURATION=0 >>

Re: [FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

2018-12-17 Thread Steven Liu
> On Dec 17, 2018, at 22:23, Adrian wrote: > > Hello, > > after upgrading FFmpeg from 4.0 to 4.1 I noticed that temp files in HLS muxed > stopped working. > It looks like a regression introduced by > 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6. I've prepared a patch and tested it >

Re: [FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

2018-12-17 Thread Adrian
Yeah, it does. My device is running as we speak and I do see tmp files being created and renamed once done. Regards Adrian Guzowski17 gru 2018 16:19 Steven Liu napisał(a): > > > On Dec 17, 2018, at 23:11, Adrian wrote: > > > > Looks like it, though I've fixed some inconsistencies in file

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize float yuv2plane1

2018-12-17 Thread Lauri Kasanen
On Mon, 17 Dec 2018 14:52:49 +0100 Carl Eugen Hoyos wrote: > >> Note that this function / this pix_fmt currently has no real use-case > >> afaict. > > > > Is there a list of which pix fmts are useful? Of course I don't want to > > waste both my and reviewers' time, if the format is considered

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-17 Thread Steven Liu
> On Dec 17, 2018, at 21:07, Ronak Patel > wrote: > >> >> On Dec 13, 2018, at 9:15 PM, Ronak Patel >> wrote: >> >> >> >>> On Dec 12, 2018, at 2:46 AM, Liu Steven wrote: >>> >>> >>> > 在 2018年12月12日,上午5:08,Ronak 写道: > > > On Dec 11, 2018, at 3:28 PM, Gyan wrote:

Re: [FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

2018-12-17 Thread Adrian
Looks like it, though I've fixed some inconsistencies in file checking too (i.e you're renaming file A, but checks file B for being able to be temp file) + added checking flag for HLS_SINGLE_FILE (it doesn't make sense to have HLS_TEMP_FILE | HLS_SINGLE_FILE). My bad I didn't check pending

Re: [FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

2018-12-17 Thread Steven Liu
> On Dec 17, 2018, at 23:11, Adrian wrote: > > Looks like it, though I've fixed some inconsistencies in file checking too > (i.e you're renaming file A, but checks file B for being able to be temp > file) + added checking flag for HLS_SINGLE_FILE (it doesn't make sense to > have

Re: [FFmpeg-devel] [PATCH]lsws/utils: Split "emms_c(); " call in two lines

2018-12-17 Thread Nicolas George
Carl Eugen Hoyos (2018-12-17): > #ifndef emms_c > -# define emms_c() while(0) > +# define emms_c() while(0){} > #endif That feels really wrong, or at least completely unusual. But not the change you made, the original code: the usual statement is: "do { statement } while (0)" And if you

Re: [FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

2018-12-17 Thread Adrian
IMO temp_file+single_file should be mutually exclusive - why would you want to have temp file when you're using only one file anyway? In this mode you would either pool for file changes or just get updated playlist with new byte range (and that one should be updated after video file). I

Re: [FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

2018-12-17 Thread Aleksey Skripka
> On 17 Dec 2018, at 18:45, Adrian wrote: > > IMO temp_file+single_file should be mutually exclusive - why would you want > to have temp file when you're using only one file anyway? In this mode you > would either pool for file changes or just get updated playlist with new byte > range