Re: [FFmpeg-devel] [PATCH]lavf/cafdec: Do not fail hard for files ending with junk

2019-01-15 Thread Paul B Mahol
On 1/15/19, Carl Eugen Hoyos wrote: > Hi! > > A user provided a real-life caf file ending with junk after the data > chunk, QuickTime reads such files. > > Please comment, Carl Eugen > NACK, there is data after junk bytes, which would get simply discarded with your patch.

[FFmpeg-devel] [PATCH v2] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-01-15 Thread Shaofei Wang
With new option "-abr_pipeline" It enabled multiple filter graph concurrency, which bring obove about 4%~20% improvement in some 1:N scenarios by CPU or GPU acceleration Below are some test cases and comparison as reference. (Hardware platform: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz) (Software: I

Re: [FFmpeg-devel] [PATCH V1 1/2] lavfi/vf_scale_vaapi: add scaling mode setting support.

2019-01-15 Thread Li, Zhong
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Monday, December 10, 2018 2:26 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V1 1/2] lavfi/vf_scale_vaapi: add scaling > mode setting support. >

Re: [FFmpeg-devel] [PATCH V1 1/2] lavfi/vf_scale_vaapi: add scaling mode setting support.

2019-01-15 Thread Li, Zhong
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Li, Zhong > Sent: Tuesday, January 15, 2019 5:58 PM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V1 1/2] lavfi/vf_scale_vaapi: add scaling > mode s

Re: [FFmpeg-devel] [PATCH v2] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-01-15 Thread Rostislav Pehlivanov
On Tue, 15 Jan 2019 at 09:24, Shaofei Wang wrote: > With new option "-abr_pipeline" > It enabled multiple filter graph concurrency, which bring obove about > 4%~20% improvement in some 1:N scenarios by CPU or GPU acceleration > > Below are some test cases and comparison as reference. > (Hardware

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add HCOM decoder

2019-01-15 Thread Carl Eugen Hoyos
2019-01-14 20:32 GMT+01:00, Paul B Mahol : > On 1/6/19, Carl Eugen Hoyos wrote: >> 2019-01-03 0:51 GMT+01:00, Rostislav Pehlivanov : >>> On Wed, 2 Jan 2019 at 19:02, Paul B Mahol wrote: >> >> +while (bits-- > 0) { + +if (current & 0x8000) { +

Re: [FFmpeg-devel] [PATCH]lavf/cafdec: Do not fail hard for files ending with junk

2019-01-15 Thread Carl Eugen Hoyos
2019-01-15 10:23 GMT+01:00, Paul B Mahol : > On 1/15/19, Carl Eugen Hoyos wrote: >> A user provided a real-life caf file ending with junk after the data >> chunk, QuickTime reads such files. >> >> Please comment, Carl Eugen >> > > NACK, there is data after junk bytes, which would get simply > dis

Re: [FFmpeg-devel] [PATCH]lavf/cafdec: Do not fail hard for files ending with junk

2019-01-15 Thread Paul B Mahol
On 1/15/19, Carl Eugen Hoyos wrote: > 2019-01-15 10:23 GMT+01:00, Paul B Mahol : >> On 1/15/19, Carl Eugen Hoyos wrote: > >>> A user provided a real-life caf file ending with junk after the data >>> chunk, QuickTime reads such files. >>> >>> Please comment, Carl Eugen >>> >> >> NACK, there is dat

Re: [FFmpeg-devel] [PATCH]lavf/cafdec: Do not fail hard for files ending with junk

2019-01-15 Thread Carl Eugen Hoyos
2019-01-15 12:53 GMT+01:00, Paul B Mahol : > On 1/15/19, Carl Eugen Hoyos wrote: >> 2019-01-15 10:23 GMT+01:00, Paul B Mahol : >>> On 1/15/19, Carl Eugen Hoyos wrote: >> A user provided a real-life caf file ending with junk after the data chunk, QuickTime reads such files. Ple

Re: [FFmpeg-devel] [PATCH v2] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-01-15 Thread Carl Eugen Hoyos
2019-01-15 11:30 GMT+01:00, Rostislav Pehlivanov : > On Tue, 15 Jan 2019 at 09:24, Shaofei Wang wrote: >> +#if HAVE_THREADS >> +if (!abr_pipeline) { >> +ret = reap_filters(1); >> +} else { >> +ret = pipeline_reap_filters(1, ifilter); >> +} >> > > Sa

Re: [FFmpeg-devel] [PATCH]lavf/cafdec: Do not fail hard for files ending with junk

2019-01-15 Thread Paul B Mahol
On 1/15/19, Carl Eugen Hoyos wrote: > 2019-01-15 12:53 GMT+01:00, Paul B Mahol : >> On 1/15/19, Carl Eugen Hoyos wrote: >>> 2019-01-15 10:23 GMT+01:00, Paul B Mahol : On 1/15/19, Carl Eugen Hoyos wrote: >>> > A user provided a real-life caf file ending with junk after the data > chu

Re: [FFmpeg-devel] [PATCH v2] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-01-15 Thread Rostislav Pehlivanov
On Tue, 15 Jan 2019 at 11:57, Carl Eugen Hoyos wrote: > 2019-01-15 11:30 GMT+01:00, Rostislav Pehlivanov : > > On Tue, 15 Jan 2019 at 09:24, Shaofei Wang > wrote: > > >> +#if HAVE_THREADS > >> +if (!abr_pipeline) { > >> +ret = reap_filters(1); > >> +} else { > >> +

Re: [FFmpeg-devel] [PATCH v2] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-01-15 Thread Carl Eugen Hoyos
2019-01-15 14:43 GMT+01:00, Rostislav Pehlivanov : > On Tue, 15 Jan 2019 at 11:57, Carl Eugen Hoyos wrote: > >> 2019-01-15 11:30 GMT+01:00, Rostislav Pehlivanov : >> > On Tue, 15 Jan 2019 at 09:24, Shaofei Wang >> wrote: >> >> >> +#if HAVE_THREADS >> >> +if (!abr_pipeline) { >> >> +

Re: [FFmpeg-devel] [PATCH v2] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-01-15 Thread Michael Niedermayer
On Tue, Jan 15, 2019 at 05:23:24PM -0500, Shaofei Wang wrote: > With new option "-abr_pipeline" > It enabled multiple filter graph concurrency, which bring obove about > 4%~20% improvement in some 1:N scenarios by CPU or GPU acceleration > > Below are some test cases and comparison as reference. >

Re: [FFmpeg-devel] [PATCH] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

2019-01-15 Thread Mohammad Izadi
Asking my questions again: Q(James): Does this mean each frame can potentially have a few different parameters if dimensions change between them? If that's the case, then creating new references for the same buffer will not be possible, as the buffer becomes non writable once there's more than one

Re: [FFmpeg-devel] [PATCH v2] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-01-15 Thread Marton Balint
On Tue, 15 Jan 2019, Carl Eugen Hoyos wrote: 2019-01-15 14:43 GMT+01:00, Rostislav Pehlivanov : On Tue, 15 Jan 2019 at 11:57, Carl Eugen Hoyos wrote: 2019-01-15 11:30 GMT+01:00, Rostislav Pehlivanov : > On Tue, 15 Jan 2019 at 09:24, Shaofei Wang wrote: >> +#if HAVE_THREADS >> +if

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2019-01-15 Thread Michael Niedermayer
On Thu, Jan 03, 2019 at 04:21:37PM +, Derek Buitenhuis wrote: > On 03/01/2019 01:33, Michael Niedermayer wrote: > > The file looks like 2 files concatenated, even with FLV main header between > > them. > > Yes, they all seem to be. I was under the impression FLV didn't have a header > to >

Re: [FFmpeg-devel] [PATCH] avcodec/lzw: Check for end of input

2019-01-15 Thread Michael Niedermayer
On Fri, Jan 11, 2019 at 11:46:11PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 11873/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-5093495044308992 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

[FFmpeg-devel] FFMPEG h264

2019-01-15 Thread Nadav Givoni
Guys, I'm new to this mailing list, so thanks in advance for any help you can provide. That said, I'm working on a project to convert FFMPEG (using emscripten) into WebAssembly (which already exists out in the interwebs: videoconverter.js). The conversion works, but now I have to 'tweak' the h26

[FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

2019-01-15 Thread michael . dirks
From: Michael Fabian 'Xaymar' Dirks Adds support for the pict_type field in AVFrame to amf_h264 and amf_h265 simultaneously. This field is needed in cases where the application wishes to override the frame type with another one, such as forcefully inserting a key frame for chapter markers or s

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2019-01-15 Thread Michael Niedermayer
On Sun, Dec 30, 2018 at 07:15:49PM +0100, Marton Balint wrote: > > > On Fri, 28 Dec 2018, Michael Niedermayer wrote: > > >On Wed, Dec 26, 2018 at 10:16:47PM +0100, Marton Balint wrote: > >> > >> > >>On Wed, 26 Dec 2018, Paul B Mahol wrote: > >> > >>>On 12/26/18, Michael Niedermayer wrote: > >>>

Re: [FFmpeg-devel] [PATCH 1/2] tools/target_dec_fate.sh: print some statistics

2019-01-15 Thread Michael Niedermayer
On Fri, Jan 04, 2019 at 08:29:36PM +0100, Michael Niedermayer wrote: > On Sat, Dec 29, 2018 at 10:47:16AM +0100, Moritz Barsnick wrote: > > On Sat, Dec 29, 2018 at 02:35:18 +0100, Michael Niedermayer wrote: > > > +CACHED=$((CACHED+1)) > > > > I believe this is the sort of math that won't w

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/ac3dec: Optimize frame start search

2019-01-15 Thread Michael Niedermayer
On Thu, Jan 10, 2019 at 01:37:07AM +0100, Michael Niedermayer wrote: > On Wed, Jan 09, 2019 at 09:40:05PM +0100, Carl Eugen Hoyos wrote: > > 2019-01-09 1:01 GMT+01:00, Michael Niedermayer : > > > > > +for (i= 1; i > > > This looks too inconsistent. > > locally done: > > -for (i= 1; i +

Re: [FFmpeg-devel] [PATCH 2/3] oavcodec/diracdec: Propagate errors from dirac_get_arith_uint()

2019-01-15 Thread Michael Niedermayer
On Wed, Jan 09, 2019 at 01:01:21AM +0100, Michael Niedermayer wrote: > Testcase: > 11663/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5636791864918016 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/dirac_arith: Treat overread as error

2019-01-15 Thread Michael Niedermayer
On Wed, Jan 09, 2019 at 01:01:22AM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 11663/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5636791864918016 > > Before:Executed > clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5636791864918016 > in 26006

Re: [FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

2019-01-15 Thread Michael Dirks
On 15.01.2019 23:05, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds support for the pict_type field in AVFrame to amf_h264 and amf_h265 simultaneously. This field is needed in cases where the application wishes to override the frame type with another one, such as for

Re: [FFmpeg-devel] [PATCH 1/2] tools/target_dec_fate.sh: print some statistics

2019-01-15 Thread Carl Eugen Hoyos
2019-01-15 23:36 GMT+01:00, Michael Niedermayer : > On Fri, Jan 04, 2019 at 08:29:36PM +0100, Michael Niedermayer wrote: >> On Sat, Dec 29, 2018 at 10:47:16AM +0100, Moritz Barsnick wrote: >> > On Sat, Dec 29, 2018 at 02:35:18 +0100, Michael Niedermayer wrote: >> > > +CACHED=$((CACHED+1)) >

Re: [FFmpeg-devel] [PATCH]lavf/rtpproto: Use correct path when including poll.h

2019-01-15 Thread Carl Eugen Hoyos
2019-01-14 18:24 GMT+01:00, Carl Eugen Hoyos : > Attached patch fixes a warning when compiling with musl. Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec/lagarith: Optimize case with singleton probability distribution

2019-01-15 Thread Michael Niedermayer
Fixes: Timeout Fixes: 10554/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LAGARITH_fuzzer-5739938067251200 In case of a Denial of Service attack, the attacker wants to maximize the load on the target per byte transmitted from the attacker. For such a DoS attack it is best for the attacker to

Re: [FFmpeg-devel] [PATCH V8 2/2] avcodec/libx264: add support for ROI-based encoding

2019-01-15 Thread Guo, Yejun
this patch set asks for pushing if no more concerns, thanks. > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Guo, Yejun > Sent: Friday, January 11, 2019 9:39 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject:

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add HCOM demuxer

2019-01-15 Thread James Almer
On 1/2/2019 3:53 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/hcom.c | 89 > 3 files changed, 91 insertions(+) > create mode 100644 libavformat/hcom.c

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-15 Thread Li, Zhong
> > Is it a possible way to show "not supported" info and set the option > > to default off instead of just hiding the option? > > > > Like: > > #if QSV_HAVE_VDENC > > { "low_power", "enable low power mode (experimental, many > > limitations by mfx version, HW platform, BRC modes, etc.)", > >

[FFmpeg-devel] [PATCH V9] libavfilter: add transpose_vaapi filter

2019-01-15 Thread Zachary Zhou
Swap width and height when do clock/cclock rotation Add reversal/hflip/vflip options ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -hwaccel_output_format vaapi -i input.264 -vf "transpose_vaapi=clock_flip" -c:v h264_vaapi output.h264 Signed-off-by: Zachary Zhou --- configure