Re: [FFmpeg-devel] [PATCH v2] avcodec/tak_parser: don't return error values

2019-07-20 Thread Michael Niedermayer
On Thu, Jul 18, 2019 at 07:37:57PM -0300, James Almer wrote: > The API does not allow it. > > Also set poutbuf and poutbuf_size to NULL/0 on error to avoid leaving > them uninitialized. > > Signed-off-by: James Almer > --- > libavcodec/tak_parser.c | 20 > 1 file changed,

[FFmpeg-devel] [PATCH] vp3data, mpc8huff: Make some arrays unsigned to prevent overflow

2019-07-20 Thread Andreas Rheinhardt
Some of the VP3 arrays (namely vp31_intra_y_dequant, vp31_intra_c_dequant and vp31_inter_dequant) are currently declared as array of (const) int8_t despite them being only used to directly initialize an array of uint8_t. vp31_inter_dequant even contains the value 128 which is not representible in

Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_h265: add support for Alpha Channel Info SEI messages

2019-07-20 Thread James Almer
On 7/20/2019 10:54 AM, Mark Thompson wrote: > On 09/07/2019 22:27, James Almer wrote: >> As defined in sections F.14.2.8 and F.14.3.8 >> >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_h2645.c| 1 + >> libavcodec/cbs_h265.h | 12 +++ >>

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2019-07-20 Thread Michael Niedermayer
On Thu, Jul 18, 2019 at 10:22:23PM +0200, Michael Niedermayer wrote: > On Thu, Jul 18, 2019 at 02:44:46PM +, Eoff, Ullysses A wrote: > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > > > Michael Niedermayer > > > On Mon, Jul 15, 2019 at 06:38:35PM +0800, Linjie

Re: [FFmpeg-devel] [PATCH v2] avcodec/tak_parser: don't return error values

2019-07-20 Thread James Almer
On 7/20/2019 1:29 PM, Michael Niedermayer wrote: > On Thu, Jul 18, 2019 at 07:37:57PM -0300, James Almer wrote: >> The API does not allow it. >> >> Also set poutbuf and poutbuf_size to NULL/0 on error to avoid leaving >> them uninitialized. >> >> Signed-off-by: James Almer >> --- >>

Re: [FFmpeg-devel] [PATCH] avcodec/dvbsubdec: Use ff_set_dimensions()

2019-07-20 Thread Michael Niedermayer
On Sat, Jul 20, 2019 at 11:02:35AM +0200, Paul B Mahol wrote: > On 7/20/19, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 65313 * 65313 cannot be represented in type > > 'int' > > Fixes: > > 15740/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DVBSUB_fuzzer-5641749164195840 >

Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_h265: add support for Alpha Channel Info SEI messages

2019-07-20 Thread Mark Thompson
On 09/07/2019 22:27, James Almer wrote: > As defined in sections F.14.2.8 and F.14.3.8 > > Signed-off-by: James Almer > --- > libavcodec/cbs_h2645.c| 1 + > libavcodec/cbs_h265.h | 12 +++ > libavcodec/cbs_h265_syntax_template.c | 29

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: resync to the next aac sample on invalid data instead of aborting

2019-07-20 Thread Carl Eugen Hoyos
> Am 20.07.2019 um 15:13 schrieb James Almer : > > Should fix ticket #6634 > > Signed-off-by: James Almer > --- > libavformat/aacdec.c | 44 +--- > 1 file changed, 29 insertions(+), 15 deletions(-) > > diff --git a/libavformat/aacdec.c

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: resync to the next aac sample on invalid data instead of aborting

2019-07-20 Thread James Almer
On 7/20/2019 12:33 PM, Carl Eugen Hoyos wrote: > > > >> Am 20.07.2019 um 15:13 schrieb James Almer : >> >> Should fix ticket #6634 >> >> Signed-off-by: James Almer >> --- >> libavformat/aacdec.c | 44 +--- >> 1 file changed, 29 insertions(+), 15

Re: [FFmpeg-devel] [PATCH 3/3] lavfi: add deshake_opencl filter

2019-07-20 Thread Michael Niedermayer
On Fri, Jul 19, 2019 at 07:19:17PM -0400, Jarek Samic wrote: > This filter is the subject of my GSoC project. > > This is a video stabilization / deshake filter (name undetermined, feel free > to discuss) that uses feature > point matching and RANSAC to determine a camera path, smooths the

[FFmpeg-devel] [PATCH] avformat/mov: fix return code for trun box with no sample entries

2019-07-20 Thread Gyan
Affected files can now be demuxed. Verified with John Stebbins. FATE passes. Gyan From 48175cd745f8abd0546487907c4596550e3c73bf Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 20 Jul 2019 23:44:14 +0530 Subject: [PATCH] avformat/mov: fix return code for trun box with no sample entries A

[FFmpeg-devel] [PATCH 1/4] avformat/vividas: forward errors from track_header()

2019-07-20 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/vividas.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavformat/vividas.c b/libavformat/vividas.c index 184d24f374..1895c75858 100644 --- a/libavformat/vividas.c +++ b/libavformat/vividas.c @@ -273,7 +273,7

[FFmpeg-devel] [PATCH 2/4] avformat/vividas: Check that value from ffio_read_varlen() does not overflow

2019-07-20 Thread Michael Niedermayer
Fixes: signed integer overflow: -1241665686 + -1340629419 cannot be represented in type 'int' Fixes: 15922/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5692826442006528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 4/4] avcodec/hqx: Check the input data against the image size

2019-07-20 Thread Michael Niedermayer
Fixes: Timeout (22 -> 7 sec) Fixes: 15173/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5662556846292992 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hqx.c | 4 1 file

[FFmpeg-devel] [PATCH 3/4] avcodec/utils: Check close before calling it

2019-07-20 Thread Michael Niedermayer
Fixes: NULL pointer dereference Fixes: 15733/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IDF_fuzzer-5658616977162240 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/utils.c | 2 +- 1

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/ffwavesynth: use uint32_t to compute difference, it is enough

2019-07-20 Thread Nicolas George
Nicolas George (12019-07-19): > Sorry, I thought I missed the spot and you already applied it. > > This patch could be merged with this one: > > avcodec/ffwavesynth: More correct cast in wavesynth_seek() > > but it is not very important. > > As for: > > avcodec/ffwavesynth: Fix backward

[FFmpeg-devel] [PATCH] avformat/aacdec: resync to the next aac sample on invalid data instead of aborting

2019-07-20 Thread James Almer
Should fix ticket #6634 Signed-off-by: James Almer --- libavformat/aacdec.c | 44 +--- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/libavformat/aacdec.c b/libavformat/aacdec.c index 8a5450880b..5b00b3f664 100644 ---

Re: [FFmpeg-devel] [PATCH 2/3] lavfi: modify avfilter_get_matrix to support separate scale factors

2019-07-20 Thread Nicolas George
Mark Thompson (12019-07-20): > Apologies for not noticing this when we talked about it earlier, but > this function is actually user-visible - it's global with an exported > prefix >

Re: [FFmpeg-devel] [PATCH 2/3] lavfi: modify avfilter_get_matrix to support separate scale factors

2019-07-20 Thread Mark Thompson
On 20/07/2019 00:19, Jarek Samic wrote: > --- > libavfilter/transform.c | 13 ++--- > libavfilter/transform.h | 30 +++--- > libavfilter/vf_deshake.c | 7 +-- > 3 files changed, 34 insertions(+), 16 deletions(-) > > diff --git a/libavfilter/transform.c

Re: [FFmpeg-devel] [PATCH] cbs_h2645: Fix infinite loop in more_rbsp_data

2019-07-20 Thread Mark Thompson
On 05/06/2019 03:18, Andreas Rheinhardt wrote: > cbs_h2645_read_more_rbsp_data does not handle malformed input very well: > 1. If there were <= 8 bits left in the bitreader, these bits were read > via show_bits. But show_bits requires the number of bits to be read to > be > 0 (internally it shifts

Re: [FFmpeg-devel] [PATCH v2 1/3] lavf/f_select: support scenecut with more pixel formats

2019-07-20 Thread Marton Balint
On Sat, 20 Jul 2019, Limin Wang wrote: On Fri, Jul 19, 2019 at 09:26:06PM +0200, Marton Balint wrote: On Fri, 19 Jul 2019, lance.lmw...@gmail.com wrote: >From: Limin Wang > >This patch haven't make other pixel format usable yet to make sure the test >result is same with rgb32 format. >

[FFmpeg-devel] [PATCH v3 3/3] lavf/f_select: make the more pixel format usable to avoid autoscale to rgb

2019-07-20 Thread lance . lmwang
From: Limin Wang Below is the tested results for the new added pixel format without autoscale to rgb24: 1. AV_PIX_FMT_YUVJ420P time ./ffprobe -of compact=p=0 -show_entries frame=pkt_pts:frame_tags -bitexact -f lavfi \

Re: [FFmpeg-devel] [PATCH] vp3data, mpc8huff: Make some arrays unsigned to prevent overflow

2019-07-20 Thread Peter Ross
On Sat, Jul 20, 2019 at 03:51:25PM +0200, Andreas Rheinhardt wrote: > Some of the VP3 arrays (namely vp31_intra_y_dequant, vp31_intra_c_dequant > and vp31_inter_dequant) are currently declared as array of (const) int8_t > despite them being only used to directly initialize an array of uint8_t. >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/hqx: Check the input data against the image size

2019-07-20 Thread Lynne
Jul 20, 2019, 11:08 PM by mich...@niedermayer.cc: > Fixes: Timeout (22 -> 7 sec) > Fixes: > 15173/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5662556846292992 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/hqx: Check the input data against the image size

2019-07-20 Thread Carl Eugen Hoyos
> Am 21.07.2019 um 00:36 schrieb Lynne : > > Jul 20, 2019, 11:08 PM by mich...@niedermayer.cc: > >> Fixes: Timeout (22 -> 7 sec) >> Fixes: >> 15173/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5662556846292992 >> >> Found-by: continuous fuzzing process >>

Re: [FFmpeg-devel] [PATCH v2 1/3] lavf/f_select: support scenecut with more pixel formats

2019-07-20 Thread Limin Wang
On Sat, Jul 20, 2019 at 09:36:37PM +0200, Marton Balint wrote: > > > On Sat, 20 Jul 2019, Limin Wang wrote: > > >On Fri, Jul 19, 2019 at 09:26:06PM +0200, Marton Balint wrote: > >> > >> > >>On Fri, 19 Jul 2019, lance.lmw...@gmail.com wrote: > >> > >>>From: Limin Wang > >>> > >>>This patch

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/hqx: Check the input data against the image size

2019-07-20 Thread Lynne
Jul 21, 2019, 12:31 AM by ceffm...@gmail.com: > > >> Am 21.07.2019 um 00:36 schrieb Lynne : >> >> Jul 20, 2019, 11:08 PM by mich...@niedermayer.cc: >> >>> Fixes: Timeout (22 -> 7 sec) >>> Fixes: >>> 15173/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5662556846292992 >>> >>>

[FFmpeg-devel] [PATCH v3 2/3] fate: change the scenecut fate threshold for one more scenecut scenes

2019-07-20 Thread lance . lmwang
From: Limin Wang why change .4 to .25, it's for: one scenecut(pkt_pts=20040) isn't detected by 0.4 threshold why not change to 0.25 instead of .3: it'll cause this scenecut(pkt_pts=20040) failed to detect after applied the next patch which enable yuvj420 for fate testing, it's better to catch

[FFmpeg-devel] [PATCH v3 1/3] lavf/f_select: support scenecut with more pixel formats

2019-07-20 Thread lance . lmwang
From: Limin Wang This patch haven't make other pixel format usable yet to make sure the test result is same with rgb32 format. Reviewed-by: Marton Balint Signed-off-by: Limin Wang --- libavfilter/f_select.c | 34 ++ 1 file changed, 30 insertions(+), 4

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: resync to the next aac sample on invalid data instead of aborting

2019-07-20 Thread James Almer
On 7/20/2019 12:41 PM, James Almer wrote: > On 7/20/2019 12:33 PM, Carl Eugen Hoyos wrote: >> >> >> >>> Am 20.07.2019 um 15:13 schrieb James Almer : >>> >>> Should fix ticket #6634 >>> >>> Signed-off-by: James Almer >>> --- >>> libavformat/aacdec.c | 44

[FFmpeg-devel] [PATCH] hevc_mp4toannexb: Do not duplicate parameter sets

2019-07-20 Thread Andriy Gelman
From: Andriy Gelman Fixes #7799 Currently, the mp4toannexb filter always inserts extradata at the start of each IRAP unit. This can lead to duplication of parameter sets if the demuxed packet from mdat atom already contains a version of the parameters. As in ticket #7799 this can also lead to

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/hqx: Check the input data against the image size

2019-07-20 Thread Carl Eugen Hoyos
> Something like this doesn't deserve anything but the lowest level of > criticism. But the lowest level of criticism is not allowed here. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/ffwavesynth: Check sample rate before use

2019-07-20 Thread Michael Niedermayer
On Fri, Jul 19, 2019 at 02:54:15PM +0200, Nicolas George wrote: > Michael Niedermayer (12019-07-15): > > Fixes: division by zero > > Fixes: > > 15725/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5641231956180992 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH, v3] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2019-07-20 Thread Nicolas George
Gyan (12019-07-20): > Since the auto scaling happens at the end of the graph Are you sure? IIRC, the scaling happens just after buffersrc. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH, v3] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2019-07-20 Thread Gyan
On 20-07-2019 01:16 PM, Nicolas George wrote: Gyan (12019-07-20): Since the auto scaling happens at the end of the graph Are you sure? IIRC, the scaling happens just after buffersrc. From the patch, 1) >  @@ -469,7 +469,7 @@ static int configure_output_video_filter(FilterGraph *fg,

Re: [FFmpeg-devel] [PATCH, v3] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2019-07-20 Thread Nicolas George
Gyan (12019-07-20): > From the patch, After checking, you are right. When that option is enabled, the filter graphs are still reinited. That makes it slightly less fragile than I thought. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: process show_frame/show_packets last

2019-07-20 Thread Michael Niedermayer
On Thu, Jul 18, 2019 at 03:55:11PM -0700, Aman Gupta wrote: > From: Aman Gupta > > When using `ffprobe -show_format -show_streams -show_packets`, > it makes more sense to omit static data about the file format > and streams before the long list of packets instead of at the > end. > >

Re: [FFmpeg-devel] [PATCH] avcodec/dvbsubdec: Use ff_set_dimensions()

2019-07-20 Thread Paul B Mahol
On 7/20/19, Michael Niedermayer wrote: > Fixes: signed integer overflow: 65313 * 65313 cannot be represented in type > 'int' > Fixes: > 15740/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DVBSUB_fuzzer-5641749164195840 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avformat/mux: correct error msg for when BSF filtering fails

2019-07-20 Thread Gyan
On 16-07-2019 06:11 PM, Gyan wrote: ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".