Re: [FFmpeg-devel] [PATCH v1] lavf/dump: add the valid check for consistent

2019-08-10 Thread Carl Eugen Hoyos
Am Sa., 10. Aug. 2019 um 16:59 Uhr schrieb : > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/dump.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/libavformat/dump.c b/libavformat/dump.c > index 1c44656..d3c0299 100644 > --- a/libavformat/dump.c >

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec/videotoolbox: add support for full range pixel formats

2019-08-10 Thread der richter
another ping for this. should i do anything else about this second part of the patch? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH]lavc/libx264: Cast bit_rate to int64_t to avoid an integer overflow

2019-08-10 Thread Carl Eugen Hoyos
Am Sa., 10. Aug. 2019 um 17:12 Uhr schrieb Carl Eugen Hoyos : > > Hi! > > Attached patch really fixes ticket #8071 for me. Simpler variant attached. Carl Eugen From e94234fb683b30518d96b1a36aba9e27c4cf9f1b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 10 Aug 2019 17:10:58 +0200

Re: [FFmpeg-devel] [PATCH]lavc/libx264: bit_rates > INT_MAX are not supported

2019-08-10 Thread Hendrik Leppkes
On Sat, Aug 10, 2019 at 5:11 PM Carl Eugen Hoyos wrote: > > Am Sa., 10. Aug. 2019 um 16:54 Uhr schrieb Hendrik Leppkes > : > > > > On Sat, Aug 10, 2019 at 2:43 PM Carl Eugen Hoyos wrote: > > > > > > Hi! > > > > > > Attached patch fixes ticket #8071. > > > > > > > You could allow the full range

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-10 Thread Andreas Håkon
Hi Gyan and Nicolas, ‐‐‐ Original Message ‐‐‐ On Saturday, 10 de August de 2019 17:13, Nicolas George wrote: > Gyan (12019-08-10): > > > Since both pts and dts are altered, avoid pts only labels. > > Dissenting opinion: PTS is the important thing, and there are lot of > places where we

[FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-10 Thread Marton Balint
PCR generation was based on counting packets for both CBR and VBR streams. Couting packets might have worked for CBR streams (when muxrate was specified) but it only took into account the packets of a service (or the packets of the PCR stream lately), so even that was problematic for multi program

[FFmpeg-devel] [PATCH 6/8] avformat/vividas: Fix another infinite loop

2019-08-10 Thread Michael Niedermayer
Not found by the fuzzer Signed-off-by: Michael Niedermayer --- libavformat/vividas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/vividas.c b/libavformat/vividas.c index a5f33181de..0c33ca2da8 100644 --- a/libavformat/vividas.c +++ b/libavformat/vividas.c @@

[FFmpeg-devel] [PATCH 1/8] avcodec/mpc8: Fix 32bit mask/enum

2019-08-10 Thread Michael Niedermayer
Fixes: left shift of 1 by 31 places cannot be represented in type 'int' Fixes: 15817/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPC8_fuzzer-5636626409062400 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 5/8] avformat/vividas: Fix infinite loop in header parser

2019-08-10 Thread Michael Niedermayer
Fixes: Timeout (Infinite -> Finite) Fixes: 16010/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5638616102993920 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/vividas.c | 3 +++ 1

[FFmpeg-devel] [PATCH 4/8] avcodec/ffwavesynth: Fixes invalid shift with pink noise seeking

2019-08-10 Thread Michael Niedermayer
Fixes: left shift of negative value -961533698048 Fixes: 16242/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5738550670131200 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [PATCH]lavc/frame_thread_encoder: Do not memcpy() from NULL

2019-08-10 Thread Carl Eugen Hoyos
Am So., 7. Juli 2019 um 14:04 Uhr schrieb Mark Thompson : > > On 02/07/2019 10:44, Carl Eugen Hoyos wrote: > > Am Di., 2. Juli 2019 um 08:31 Uhr schrieb Reimar Döffinger > > : > >> > >> On 01.07.2019, at 00:51, Carl Eugen Hoyos wrote: > > > >>> I believe attached patch fixes undefined behaviour

[FFmpeg-devel] [PATCH]lavc/libx264: bit_rates > INT_MAX are not supported

2019-08-10 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #8071. Please comment, Carl Eugen From 8fd6cc5727b824572ba2147dfeec6f00520c9f69 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 10 Aug 2019 14:40:23 +0200 Subject: [PATCH] lavc/libx264: bit_rates > INT_MAX are not supported. Fixes ticket #8071 ---

Re: [FFmpeg-devel] [PATCH v12 03/14] lavc/tiff: Convert DNGs to sRGB color space

2019-08-10 Thread Nick Renieris
> Why do you put all this color space convertion code into the decoders ? The color space conversion needs to happen, camera sensor data is linear. If it's not done images looks really dark as result. > Colorspace and pixel format convertion is generally done outside decoders. > The

[FFmpeg-devel] [PATCH v1] lavf/dump: add the valid check for consistent

2019-08-10 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dump.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 1c44656..d3c0299 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -328,6 +328,11 @@ static void

[FFmpeg-devel] [PATCH v2] avfilter/showinfo: support Content Light Level information

2019-08-10 Thread lance . lmwang
From: Limin Wang show real information instead of the unknown side data type message for HDR10 stream Signed-off-by: Limin Wang --- libavfilter/vf_showinfo.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-10 Thread Gyan
On 09-08-2019 12:14 PM, Andreas Håkon wrote: Hi Gyan, Nicolas and Alexander, ‐‐‐ Original Message ‐‐‐ On Friday, 9 de August de 2019 3:18, Alexander Strasser wrote: [...] Gyan [...] Nicolas George [...] Alexander I appreciate your suggestions with the name. But, we

Re: [FFmpeg-devel] [PATCH]lavc/libx264: bit_rates > INT_MAX are not supported

2019-08-10 Thread Carl Eugen Hoyos
Am Sa., 10. Aug. 2019 um 16:54 Uhr schrieb Hendrik Leppkes : > > On Sat, Aug 10, 2019 at 2:43 PM Carl Eugen Hoyos wrote: > > > > Hi! > > > > Attached patch fixes ticket #8071. > > > > You could allow the full range of bit_rate since its immediately > divided by 1000, couldn't you? New patch

Re: [FFmpeg-devel] [PATCH 1/6] avformat/mpegtsenc: fix incorrect PCR selection with multiple programs

2019-08-10 Thread Marton Balint
On Fri, 9 Aug 2019, Andreas Håkon wrote: Hi Marton, ‐‐‐ Original Message ‐‐‐ On Thursday, 8 de August de 2019 23:27, Marton Balint wrote: The MPEG-TS muxer had a serious bug related to the use of multiple programs: in that case, the PCR pid selection was incomplete for all

Re: [FFmpeg-devel] [PATCH 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-10 Thread Marton Balint
On Fri, 9 Aug 2019, Andreas Håkon wrote: Hi Marton, ‐‐‐ Original Message ‐‐‐ On Thursday, 8 de August de 2019 23:27, Marton Balint wrote: PCR generation was based on counting packets for both CBR and VBR streams. Couting packets might have worked for CBR streams (when muxrate was

[FFmpeg-devel] [PATCH 7/8] avutil/mathematics: Fix 2 overflows in av_add_stable()

2019-08-10 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long' Fixes: 16022/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5759796759756800 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 8/8] avcodec/dds: Use ff_set_dimensions()

2019-08-10 Thread Michael Niedermayer
Fixes: signed integer overflow: 2082471995 * 36 cannot be represented in type 'int' Fixes: 16025/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DDS_fuzzer-5136663778426880 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/8] avcodec/cavsdec: Limit the number of access units per packet to 2

2019-08-10 Thread Michael Niedermayer
Fixes: Timeout (122sec -> 13ms) Fixes: 15978/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CAVS_fuzzer-5148925004087296 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cavsdec.c | 4

[FFmpeg-devel] [PATCH 3/8] avcodec/ffwavesynth: Fix integer overflow for some corner case values

2019-08-10 Thread Michael Niedermayer
Fixes: left shift of negative value -14671840 Fixes: 16000/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5145977817661440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [PATCH v12 12/14] lavc/mjpegdec: Skip useless APPx marker on bayer images

2019-08-10 Thread Michael Niedermayer
On Sat, Aug 10, 2019 at 04:52:10PM +0300, Nick Renieris wrote: > The data the marker contains is only 2 bytes and they're 0x in the > samples above. I don't know what they're for. ok then please call them unknown and not useless in the comments thanks [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH]lavc/libx264: Cast bit_rate to int64_t to avoid an integer overflow

2019-08-10 Thread Carl Eugen Hoyos
Am Sa., 10. Aug. 2019 um 17:35 Uhr schrieb Carl Eugen Hoyos : > > Am Sa., 10. Aug. 2019 um 17:12 Uhr schrieb Carl Eugen Hoyos > : > > > > Hi! > > > > Attached patch really fixes ticket #8071 for me. > > Simpler variant attached. Patch applied. Carl Eugen

Re: [FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-10 Thread Nicolas George
Marton Balint (12019-08-08): > Current 4k limit is definitely causing errors, the users are not aware of > it, because it is not intuitive. > > I don't see why increasing the limit to 2 GB which is something that we will > hardly ever hit is worse than current status which causes actual issues. >

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: make transfer_fnc initialized for unsupport function

2019-08-10 Thread Limin Wang
ping the change! On Thu, Jul 18, 2019 at 06:59:35AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > The current function will report one error message, but the caller func > haven't check it, so change the default to process as AVCOL_TRC_UNSPECIFIED. > > Signed-off-by: Limin

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-10 Thread Nicolas George
Andreas Håkon (12019-08-09): > I appreciate your suggestions with the name. But, we need to select one. > So I propose a short list: > > - "timeshift" (the current name) > - "pts_offset" > - "editpts" > > I don't like "ts_offset" as "ts" can be understood as Transport Stream. > I don't want

Re: [FFmpeg-devel] [PATCH]lavf/dump: Fix cpb bitrate types after next major bump

2019-08-10 Thread James Almer
On 8/10/2019 9:47 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a compilation warning when compiling without > FF_API_UNSANITIZED_BITRATES. > > Please comment, Carl Eugen > > > 0001-lavf-dump-Fix-cpb-bitrate-type-after-next-major-bump.patch > > From

Re: [FFmpeg-devel] [PATCH] avcodec/encode: only allow undersized audio frames if they are the last

2019-08-10 Thread Marton Balint
On Sun, 4 Aug 2019, Marton Balint wrote: On Sat, 3 Aug 2019, Lynne wrote: Aug 3, 2019, 9:40 PM by c...@passwd.hu: Otherwise the user might get a silence padded frame in the beginning or in the middle of the encoding. Some other bug uncovered this: ./ffmpeg -loglevel verbose -y -f

Re: [FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-10 Thread Marton Balint
On Sat, 10 Aug 2019, Nicolas George wrote: Marton Balint (12019-08-08): Current 4k limit is definitely causing errors, the users are not aware of it, because it is not intuitive. I don't see why increasing the limit to 2 GB which is something that we will hardly ever hit is worse than

Re: [FFmpeg-devel] [PATCH v1] avfilter/f_select: yuv will use Y plane only for scenecut detect

2019-08-10 Thread Marton Balint
On Sun, 11 Aug 2019, lance.lmw...@gmail.com wrote: From: Limin Wang It'll improve about +0.1 threshold for scenecut detect Signed-off-by: Limin Wang --- libavfilter/f_select.c | 5 - tests/ref/fate/filter-metadata-scenedetect | 16 2 files changed,

Re: [FFmpeg-devel] [PATCH v12 10/14] lavc/tiff: Support decoding of DNGs with single-component JPEGs

2019-08-10 Thread Nick Renieris
> after this commit the code dies when used with ffplay with floating point > exceptions I tried this on Ubuntu and I can't repro, it works fine. Maybe something I changed locally fixed it, please re-test on the new revision I'll send in a bit. ___

Re: [FFmpeg-devel] [PATCH]lavc/vc2enc_dwt: Avoid left-shifting a negative value

2019-08-10 Thread Carl Eugen Hoyos
Am Mi., 3. Juli 2019 um 21:59 Uhr schrieb Carl Eugen Hoyos : > > Am Mi., 3. Juli 2019 um 21:24 Uhr schrieb Michael Niedermayer > : > > > > On Tue, Jul 02, 2019 at 11:40:52AM +0200, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch intends to fix ticket #7985. > > > > > > Please comment,

Re: [FFmpeg-devel] [PATCH]lavc/libx264: bit_rates > INT_MAX are not supported

2019-08-10 Thread Hendrik Leppkes
On Sat, Aug 10, 2019 at 2:43 PM Carl Eugen Hoyos wrote: > > Hi! > > Attached patch fixes ticket #8071. > You could allow the full range of bit_rate since its immediately divided by 1000, couldn't you? - Hendrik ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH]lavc/libx264: bit_rates > INT_MAX are not supported

2019-08-10 Thread Hendrik Leppkes
On Sat, Aug 10, 2019 at 4:53 PM Hendrik Leppkes wrote: > > On Sat, Aug 10, 2019 at 2:43 PM Carl Eugen Hoyos wrote: > > > > Hi! > > > > Attached patch fixes ticket #8071. > > > > You could allow the full range of bit_rate since its immediately > divided by 1000, couldn't you? > The full range

Re: [FFmpeg-devel] [PATCH v1] avfilter/showinfo: support Content Light Level information

2019-08-10 Thread Limin Wang
On Fri, Aug 09, 2019 at 11:12:35AM +0200, Nicolas George wrote: > Limin Wang (12019-08-09): > > IMO, the medata memory is allocate by > > av_content_light_metadata_create_side_data() api, it's valid already, > > there is no need to check the size. > > Unless somebody made a programming mistake

[FFmpeg-devel] [PATCH]lavc/libx264: Cast bit_rate to int64_t to avoid an integer overflow

2019-08-10 Thread Carl Eugen Hoyos
Hi! Attached patch really fixes ticket #8071 for me. Please comment, Carl Eugen From e94234fb683b30518d96b1a36aba9e27c4cf9f1b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 10 Aug 2019 17:10:58 +0200 Subject: [PATCH] lavc/libx264: Cast bit_rate to int64_t to avoid an integer

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-10 Thread Nicolas George
Gyan (12019-08-10): > Since both pts and dts are altered, avoid pts only labels. Dissenting opinion: PTS is the important thing, and there are lot of places where we says PTS because TS is ambiguous (Transport Stream?). DTS is just an annoying technical tidbit that goes with PTS. Regards, --

[FFmpeg-devel] [PATCH v2 1/2] lavf/dump: use error log level for invalid size

2019-08-10 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dump.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index 1c44656..68ce9a8 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -210,7 +210,7 @@ static

[FFmpeg-devel] [PATCHv2 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-10 Thread Marton Balint
We do this by switching to AVBPrint. v2: Also set IO context error flag in case of ENOMEM. Signed-off-by: Marton Balint --- doc/APIchanges| 3 +++ libavformat/avio.h| 5 - libavformat/aviobuf.c | 16 +++- libavformat/version.h | 2 +- 4 files changed, 19

Re: [FFmpeg-devel] [PATCH v1] lavf/dump: add the valid check for consistent

2019-08-10 Thread Limin Wang
On Sat, Aug 10, 2019 at 05:14:18PM +0200, Carl Eugen Hoyos wrote: > Am Sa., 10. Aug. 2019 um 16:59 Uhr schrieb : > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/dump.c | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git

[FFmpeg-devel] [PATCH v2 2/2] lavf/dump: add the valid check for consistent

2019-08-10 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dump.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 68ce9a8..4b18032 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -328,6 +328,11 @@ static void

[FFmpeg-devel] [PATCH v1] avfilter/f_select: yuv will use Y plane only for scenecut detect

2019-08-10 Thread lance . lmwang
From: Limin Wang It'll improve about +0.1 threshold for scenecut detect Signed-off-by: Limin Wang --- libavfilter/f_select.c | 5 - tests/ref/fate/filter-metadata-scenedetect | 16 2 files changed, 12 insertions(+), 9 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH]lavc/libx264: bit_rates > INT_MAX are not supported

2019-08-10 Thread Carl Eugen Hoyos
Am Sa., 10. Aug. 2019 um 17:36 Uhr schrieb Hendrik Leppkes : > > On Sat, Aug 10, 2019 at 5:11 PM Carl Eugen Hoyos wrote: > > > > Am Sa., 10. Aug. 2019 um 16:54 Uhr schrieb Hendrik Leppkes > > : > > > > > > On Sat, Aug 10, 2019 at 2:43 PM Carl Eugen Hoyos > > > wrote: > > > > > > > > Hi! > > > >

Re: [FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

2019-08-10 Thread Michael Niedermayer
On Thu, Aug 08, 2019 at 11:59:12AM +0200, Nicolas George wrote: > Michael Niedermayer (12019-08-08): > > This provides an alternative to retry counters. > > Useful if there is no reasonable maximum number of iterations and > > no ordering that naturally avoids loops. > > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH]lavf/dump: Fix cpb bitrate types after next major bump

2019-08-10 Thread Carl Eugen Hoyos
Am Sa., 10. Aug. 2019 um 17:01 Uhr schrieb James Almer : > > On 8/10/2019 9:47 AM, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes a compilation warning when compiling without > > FF_API_UNSANITIZED_BITRATES. > > > > Please comment, Carl Eugen > > > > > >

Re: [FFmpeg-devel] [PATCH v12 12/14] lavc/mjpegdec: Skip useless APPx marker on bayer images

2019-08-10 Thread Michael Niedermayer
On Fri, Aug 09, 2019 at 07:29:57PM +0300, Nick Renieris wrote: > From: Nick Renieris > > Samples: > - Embedded JPEG images in the DNG images here: > https://www.photographyblog.com/previews/pentax_k1_photos > > Signed-off-by: Nick Renieris > --- > libavcodec/mjpegdec.c | 11 +-- > 1

Re: [FFmpeg-devel] [PATCH v12 12/14] lavc/mjpegdec: Skip useless APPx marker on bayer images

2019-08-10 Thread Nick Renieris
The data the marker contains is only 2 bytes and they're 0x in the samples above. I don't know what they're for. Στις Σάβ, 10 Αυγ 2019 στις 3:16 μ.μ., ο/η Michael Niedermayer έγραψε: > > On Fri, Aug 09, 2019 at 07:29:57PM +0300, Nick Renieris wrote: > > From: Nick Renieris > > > > Samples:

Re: [FFmpeg-devel] [PATCH v12 10/14] lavc/tiff: Support decoding of DNGs with single-component JPEGs

2019-08-10 Thread Michael Niedermayer
On Fri, Aug 09, 2019 at 07:29:55PM +0300, Nick Renieris wrote: > From: Nick Renieris > > This enables decoding of DNG images generated by the 'DJI Zenmuse X7' > digital camera > Samples: https://www.dji.com/gr/zenmuse-x7/info#downloads > > Signed-off-by: Nick Renieris > --- >

[FFmpeg-devel] [PATCH]lavf/dump: Fix cpb bitrate types after next major bump

2019-08-10 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a compilation warning when compiling without FF_API_UNSANITIZED_BITRATES. Please comment, Carl Eugen From 48f7c57037206fe734bd45dc12c6140220afe34f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 10 Aug 2019 14:43:58 +0200 Subject: [PATCH] lavf/dump: Fix cpb

Re: [FFmpeg-devel] [PATCH v12 03/14] lavc/tiff: Convert DNGs to sRGB color space

2019-08-10 Thread Paul B Mahol
On Sat, Aug 10, 2019 at 2:42 PM Michael Niedermayer wrote: > On Fri, Aug 09, 2019 at 07:29:48PM +0300, Nick Renieris wrote: > > From: Nick Renieris > > > > Signed-off-by: Nick Renieris > > --- > > libavcodec/tiff.c | 34 +++--- > > 1 file changed, 23 insertions(+),

Re: [FFmpeg-devel] [PATCH v12 05/14] lavc/jpegtables: Handle multiple mappings to the same value

2019-08-10 Thread Michael Niedermayer
On Fri, Aug 09, 2019 at 07:29:50PM +0300, Nick Renieris wrote: > From: Nick Renieris > > Some JPEGs [1] have incorrect DHT entries that map 2 codes to > the same value. > > The second (last) mapping does not ever actually appear in the > code stream, therefore ignoring any mappings after the

Re: [FFmpeg-devel] [PATCH v12 01/14] lavc/mjpegdec: Decode Huffman-coded lossless JPEGs embedded in DNGs

2019-08-10 Thread Nick Renieris
I assume you're talking about the "if (!s->bayer || mb_x) {"... code. 1) The special case there happens for the first line, not row like the code you mentioned. 2) The loop is "width*height*component" in this order, so I'm not sure how I would something for the first line outside. 3) It depends

Re: [FFmpeg-devel] [PATCH v12 03/14] lavc/tiff: Convert DNGs to sRGB color space

2019-08-10 Thread Michael Niedermayer
On Fri, Aug 09, 2019 at 07:29:48PM +0300, Nick Renieris wrote: > From: Nick Renieris > > Signed-off-by: Nick Renieris > --- > libavcodec/tiff.c | 34 +++--- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c >

Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures

2019-08-10 Thread Nicolas George
Lynne (12019-08-10): > >> +typedef struct AVEncodeInfoBlock{ > >> +/** > >> + * Distance in luma pixels from the top-left corner of the visible > >> frame > >> + * to the top-left corner of the block. > >> + * Can be negative if top/right padding is present on the coded frame. >

Re: [FFmpeg-devel] [PATCH v12 01/14] lavc/mjpegdec: Decode Huffman-coded lossless JPEGs embedded in DNGs

2019-08-10 Thread Michael Niedermayer
On Fri, Aug 09, 2019 at 07:29:46PM +0300, Nick Renieris wrote: > From: Nick Renieris > > Main image data in DNGs is usually comprised of tiles, each of which is a > Huffman-encoded lossless JPEG. > > Tested for ljpeg regressions with: > `ffmpeg -f lavfi -i testsrc=d=1 -vcodec ljpeg test.avi` >

Re: [FFmpeg-devel] [PATCH v12 03/14] lavc/tiff: Convert DNGs to sRGB color space

2019-08-10 Thread Nicolas George
Paul B Mahol (12019-08-10): > It is part of DNG specification. Do you want to not follow DNG > specification? The specification cannot specify what part of FFmpeg's code does the conversion. -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH v12 05/14] lavc/jpegtables: Handle multiple mappings to the same value

2019-08-10 Thread Nick Renieris
I haven't seen any files with sym!=0, just thought I'd solve the general case. I'll change only for sym==0. Can always be changed later if any such samples are found. Στις Σάβ, 10 Αυγ 2019 στις 4:11 μ.μ., ο/η Michael Niedermayer έγραψε: > > On Fri, Aug 09, 2019 at 07:29:50PM +0300, Nick

[FFmpeg-devel] [PATCH v13 11/14] lavc/tiff: Decode 14-bit DNG images

2019-08-10 Thread Nick Renieris
From: Nick Renieris Sample file: https://drive.google.com/open?id=0B4JyRT3Lth5HVndyOTVOdWktM3J4TFEydTk1MnY3RWlpSzVB Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/libavcodec/tiff.c

Re: [FFmpeg-devel] [PATCH]lavf/rawenc: Only accept the appropriate stream type for raw muxers

2019-08-10 Thread Carl Eugen Hoyos
Am Mo., 1. Juli 2019 um 00:47 Uhr schrieb Carl Eugen Hoyos : > > Am Mo., 1. Juli 2019 um 00:40 Uhr schrieb Carl Eugen Hoyos > : > > > > Hi! > > > > Attached patch fixes ticket #7979 for me. > > Now attached. Ping. Carl Eugen ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH v13 08/14] lavc/tiff: Force DNG pixel data endianness on an edge case

2019-08-10 Thread Nick Renieris
From: Nick Renieris Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 174ca168c6..9d20763186 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1038,6 +1038,18 @@ static int

[FFmpeg-devel] [PATCH v13 13/14] lavc/tiff: Support DNGs with striped (non-tiled) JPEGs images

2019-08-10 Thread Nick Renieris
From: Nick Renieris DNG samples here can now be decoded: - https://www.photographyblog.com/previews/pentax_k1_photos Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 73 +++ 1 file changed, 42 insertions(+), 31 deletions(-) diff --git

[FFmpeg-devel] [PATCH v13 12/14] lavc/mjpegdec: Skip unknown APPx marker on bayer images

2019-08-10 Thread Nick Renieris
From: Nick Renieris Samples: - Embedded JPEG images in the DNG images here: https://www.photographyblog.com/previews/pentax_k1_photos Signed-off-by: Nick Renieris --- libavcodec/mjpegdec.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavcodec/mjpegdec.c

[FFmpeg-devel] [PATCH v13 06/14] lavc/tiff: Fix edge case with full-length/width tiles

2019-08-10 Thread Nick Renieris
From: Nick Renieris In an image [1], the height was equal to the tile length (full-height tile) and after `height % tile_length` was applied to them with the current code, it resulted in the operating tile_length to be 0. This commit makes this leftover logic only applies if it's necessary.

[FFmpeg-devel] [PATCH v13 10/14] lavc/tiff: Support decoding of DNGs with single-component JPEGs

2019-08-10 Thread Nick Renieris
From: Nick Renieris This enables decoding of DNG images generated by the 'DJI Zenmuse X7' digital camera Samples: https://www.dji.com/gr/zenmuse-x7/info#downloads Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 61 +++ 1 file changed, 51

[FFmpeg-devel] [PATCH v13 07/14] lavc/tiff: Don't apply strips-related logic to tiled images

2019-08-10 Thread Nick Renieris
From: Nick Renieris Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 37fda15162..174ca168c6 100644 --- a/libavcodec/tiff.c +++

[FFmpeg-devel] [PATCH v13 14/14] lavc/tiff: Default-initialize WhiteLevel DNG tag value

2019-08-10 Thread Nick Renieris
From: Nick Renieris Initialized to `(2 ^ BitsPerSample) - 1` as per the DNG Specification. Also make sure that `BlackLevel < WhiteLevel`. This fixes decoding for "X7 CinemaDNG" samples here: - https://www.dji.com/gr/zenmuse-x7/info#downloads Signed-off-by: Nick Renieris ---

[FFmpeg-devel] [PATCH v13 09/14] lavc/mjpegdec: Enable decoding of single-component bayer images

2019-08-10 Thread Nick Renieris
From: Nick Renieris Also, ensure no false positives when determining DNG bayer images, by setting them in tiff.c instead of relying on a heuristic. There's no way to determine this just from the JPEG data, so we have to pass this information from outside the MJPEG decoder. Signed-off-by: Nick

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vp56: Consider the alpha start as end of the prior header

2019-08-10 Thread Peter Ross
On Tue, Aug 06, 2019 at 11:30:02PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (23sec -> 71ms) > Fixes: > 15661/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP6A_fuzzer-6257865947348992 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v12 10/14] lavc/tiff: Support decoding of DNGs with single-component JPEGs

2019-08-10 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 12:57:17AM +0300, Nick Renieris wrote: > > after this commit the code dies when used with ffplay with floating point > > exceptions > > I tried this on Ubuntu and I can't repro, it works fine. > Maybe something I changed locally fixed it, please re-test on the new >

Re: [FFmpeg-devel] [PATCH]lavc/r210enc: Fix undefined behaviour encoding r10k

2019-08-10 Thread Carl Eugen Hoyos
Am Mo., 1. Juli 2019 um 20:27 Uhr schrieb Michael Niedermayer : > > On Mon, Jul 01, 2019 at 01:08:34PM +0200, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes an invalid left shift reported in ticket #7982. > > > > Please comment, Carl Eugen > > > r210enc.c |6 +++--- > > 1 file

[FFmpeg-devel] [PATCH v13 01/14] lavc/mjpegdec: Decode Huffman-coded lossless JPEGs embedded in DNGs

2019-08-10 Thread Nick Renieris
From: Nick Renieris Main image data in DNGs is usually comprised of tiles, each of which is a Huffman-encoded lossless JPEG. Tested for ljpeg regressions with: `ffmpeg -f lavfi -i testsrc=d=1 -vcodec ljpeg test.avi` `ffmpeg test.avi out.avi` The modified code in ljpeg_decode_rgb_scan runs

[FFmpeg-devel] [PATCH v13 02/14] lavc/tiff: Decode embedded JPEGs in DNG images

2019-08-10 Thread Nick Renieris
From: Nick Renieris Used a technique similar to lavc/tdsc.c for invoking the MJPEG decoder. This commit adds support for: - DNG tiles - DNG tile huffman lossless JPEG decoding - DNG 8-bpp ("packed" as dcraw calls it) decoding - DNG color scaling [1] - LinearizationTable tag - BlackLevel tag

[FFmpeg-devel] [PATCH v13 03/14] lavc/tiff: Convert DNGs to sRGB color space

2019-08-10 Thread Nick Renieris
From: Nick Renieris Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index d5673abb19..a118c37c41 100644 --- a/libavcodec/tiff.c +++

[FFmpeg-devel] [PATCH v13 05/14] lavc/jpegtables: Handle multiple mappings to the same value

2019-08-10 Thread Nick Renieris
From: Nick Renieris Some JPEGs [1] have incorrect DHT entries that map 2 codes to the same value. The second (last) mapping does not ever actually appear in the code stream, therefore ignoring any mappings after the first one fixes this. Without this, an "mjpeg_decode_dc: bad vlc: 0:0" error

[FFmpeg-devel] [PATCH v13 04/14] lavc/tiff: Apply color scaling to uncompressed DNGs

2019-08-10 Thread Nick Renieris
From: Nick Renieris Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index a118c37c41..4620508d53 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@