Re: [FFmpeg-devel] [PATCH]lavf/sga: Fix several format specifiers

2021-03-04 Thread Moritz Barsnick
On Thu, Mar 04, 2021 at 20:37:26 +0100, Carl Eugen Hoyos wrote: > attached patch fixes a few warnings when compiling for 32bit. > av_log(s, AV_LOG_DEBUG, "START %s\n", where); > -av_log(s, AV_LOG_DEBUG, "pos: %lX\n", avio_tell(s->pb)); > +av_log(s, AV_LOG_DEBUG, "pos: %"PRIX64"\n",

Re: [FFmpeg-devel] [PATCH]lavf/sga: Fix several format specifiers

2021-03-04 Thread Moritz Barsnick
On Thu, Mar 04, 2021 at 22:47:57 +0100, Carl Eugen Hoyos wrote: > > #include > > It is included through common.h - do we add it to every C file > that would need it if common.h were not included? Okay, that's quite indirectly and implicitly via libavutil/internal.h. I don't know the policy on

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext: add support to allow hardware to ref/unref frame

2021-03-04 Thread Suji Velupillai
Thank you Hendrik for your feedback. Let me look into it addressing it. Thank you Suji On Thu, Mar 4, 2021 at 12:11 AM Hendrik Leppkes wrote: > On Thu, Mar 4, 2021 at 7:20 AM wrote: > > > > From: Patrick Rault > > > > Add support to allow attached hardware to add/remove reference to the > >

Re: [FFmpeg-devel] [PATCH]lavf/sga: Fix several format specifiers

2021-03-04 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH]lavf/sga: Fix several format specifiers

2021-03-04 Thread Carl Eugen Hoyos
Am Do., 4. März 2021 um 22:23 Uhr schrieb Moritz Barsnick : > > On Thu, Mar 04, 2021 at 20:37:26 +0100, Carl Eugen Hoyos wrote: > > attached patch fixes a few warnings when compiling for 32bit. > > > av_log(s, AV_LOG_DEBUG, "START %s\n", where); > > -av_log(s, AV_LOG_DEBUG, "pos: %lX\n",

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext: add support to allow hardware to ref/unref frame

2021-03-04 Thread James Almer
On 3/4/2021 3:19 AM, suji.velupil...@broadcom.com wrote: From: Patrick Rault Add support to allow attached hardware to add/remove reference to the frame buffer mirroring the ffmpeg. Signed-off-by: Patrick Rault Signed-off-by: Suji Velupillai --- libavutil/frame.c | 7 ++-

[FFmpeg-devel] [PATCH]lavf/sga: Fix several format specifiers

2021-03-04 Thread Carl Eugen Hoyos
Hi, attached patch fixes a few warnings when compiling for 32bit. Please comment, Carl Eugen From c9941035b19d52fe8d8cbe2183fec823ea7a59d4 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 4 Mar 2021 20:34:36 +0100 Subject: [PATCH] lavf/sga: Silence several warnings because of wrong

Re: [FFmpeg-devel] [PATCH] lscrdec: add copyright header

2021-03-04 Thread Paul B Mahol
Copyright goes above, not bellow: This file is part or FFmpeg. On Thu, Mar 4, 2021 at 10:05 AM Anton Khirnov wrote: > As requested by the author. > --- > libavcodec/lscrdec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/lscrdec.c b/libavcodec/lscrdec.c > index

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: change toolkit_version metadata field to toolkit_version_num

2021-03-04 Thread Marton Balint
On Fri, 26 Feb 2021, Tomas Härdin wrote: lör 2021-02-20 klockan 00:17 +0100 skrev Marton Balint: It only got added recently, and the new name makes it consistent with product_version_num in the next patch. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 2 +-

Re: [FFmpeg-devel] [PATCH] lscrdec: add copyright header

2021-03-04 Thread James Almer
On 3/4/2021 6:05 AM, Anton Khirnov wrote: As requested by the author. --- libavcodec/lscrdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/lscrdec.c b/libavcodec/lscrdec.c index e706dda9da..bb0cb6c7d6 100644 --- a/libavcodec/lscrdec.c +++ b/libavcodec/lscrdec.c @@ -1,6

Re: [FFmpeg-devel] [PATCH 0/4] avcodec Loongson-2 MMI fixes

2021-03-04 Thread Jiaxun Yang
在 2021/2/23 下午2:47, 殷时友 写道: 2021年2月19日 下午1:28,Jiaxun Yang 写道: Get MMI optimizations build for Loongson-2 again. Tested on Loongson-2 and Loongson-3A. Jiaxun Yang (4): avutil/mips: Use MMI_{L,S}QC1 macro in {SAVE,RECOVER}_REG avutil/mips: Extract load store with shift C1 pair marco

Re: [FFmpeg-devel] [PATCH] avutils/hwcontext_qsv: set the source device in qsv_device_create

2021-03-04 Thread Guangxin Xu
On Tue, Feb 23, 2021 at 9:34 AM Guangxin Xu wrote: > > > On Mon, Feb 22, 2021 at 5:17 PM Soft Works wrote: > >> >> >> > -Original Message- >> > From: ffmpeg-devel On Behalf Of Xu >> > Guangxin >> > Sent: Monday, February 22, 2021 9:45 AM >> > To: ffmpeg-devel@ffmpeg.org >> > Cc: Xu

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext: add support to allow hardware to ref/unref frame

2021-03-04 Thread Hendrik Leppkes
On Thu, Mar 4, 2021 at 7:20 AM wrote: > > From: Patrick Rault > > Add support to allow attached hardware to add/remove reference to the > frame buffer mirroring the ffmpeg. > > Signed-off-by: Patrick Rault > Signed-off-by: Suji Velupillai New API additions should include an explanation of

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Moritz Barsnick
On Wed, Mar 03, 2021 at 22:09:12 +0200, Jan Ekström wrote: > Thus, I will be pulling this set in Soon (probably tomorrow). Thus if > anyone still wishes to have a say, I recommend doing it earlier than > later. > + * Copyright (c) 2020 24i Is 24i a company? Just wondering. Also, I'm not sure

Re: [FFmpeg-devel] [PATCH v1] avformat/rtsp: fix https://trac.ffmpeg.org/ticket/7517

2021-03-04 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > gaojiang...@live.com > Sent: 2021年3月4日 15:39 > To: ffmpeg-devel@ffmpeg.org > Cc: Jiangjie Gao > Subject: [FFmpeg-devel] [PATCH v1] avformat/rtsp: fix > https://trac.ffmpeg.org/ticket/7517 > > From: Jiangjie Gao > >

Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

2021-03-04 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Guo, > Yejun > Sent: 2021年3月1日 23:47 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref > private_ref when frame leaves libavfilter > > > > >

Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

2021-03-04 Thread Anton Khirnov
Quoting Guo, Yejun (2021-03-04 09:48:14) > Hi, I think option 2 might be the good choice for now. Given past experience, I am very much not a fan of "for now" solutions. They tend to ossify and remain in place for years (I have seen at least one "//temporary hack" remain unchanged for over 10

Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

2021-03-04 Thread Nicolas George
Guo, Yejun (12021-03-04): > For option 1.1, it is not allowed because .h file (structs for bounding box) > for side > data is not exported. > > For option 1.2, to avoid the possible risk of API breaking, we need a > versioning > management, and the code such as BoundingBoxV1 and BoundingBoxV2

[FFmpeg-devel] [PATCH] lscrdec: add copyright header

2021-03-04 Thread Anton Khirnov
As requested by the author. --- libavcodec/lscrdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/lscrdec.c b/libavcodec/lscrdec.c index e706dda9da..bb0cb6c7d6 100644 --- a/libavcodec/lscrdec.c +++ b/libavcodec/lscrdec.c @@ -1,6 +1,8 @@ /* * This file is part of FFmpeg. *

[FFmpeg-devel] [PATCH] avutil/hwcontext: add support to allow hardware to ref/unref frame

2021-03-04 Thread suji . velupillai
From: Patrick Rault Add support to allow attached hardware to add/remove reference to the frame buffer mirroring the ffmpeg. Signed-off-by: Patrick Rault Signed-off-by: Suji Velupillai --- libavutil/frame.c | 7 ++- libavutil/hwcontext.c | 21 +

Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

2021-03-04 Thread Paul B Mahol
On Mon, Mar 1, 2021 at 4:46 PM Guo, Yejun wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > Nicolas > > George > > Sent: 2021年3月1日 23:07 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: >

Re: [FFmpeg-devel] [PATCH v1] avformat/rtsp: fix https://trac.ffmpeg.org/ticket/7517

2021-03-04 Thread Moritz Barsnick
On Thu, Mar 04, 2021 at 15:38:56 +0800, gaojiang...@live.com wrote: > Subject: avformat/rtsp: fix https://trac.ffmpeg.org/ticket/7517 Please write what you actually do in the first line summary of the commit message, and mention the trac ticket in the body. > +AVDictionary *opts =

Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

2021-03-04 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Paul B > Mahol > Sent: 2021年3月4日 17:26 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref > private_ref when frame leaves libavfilter > > On Mon, Mar 1,

[FFmpeg-devel] [PATCH] avfilter/f_ebuf128: add all sample rates support

2021-03-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/f_ebur128.c | 58 + 1 file changed, 36 insertions(+), 22 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index e81520838d..01767c5729 100644 --- a/libavfilter/f_ebur128.c +++

Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

2021-03-04 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: 2021年3月4日 17:45 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref > private_ref when frame leaves libavfilter > > Quoting Guo,

Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

2021-03-04 Thread Paul B Mahol
On Thu, Mar 4, 2021 at 12:44 PM Guo, Yejun wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Paul B > > Mahol > > Sent: 2021年3月4日 17:26 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aadec: Use smaller scope for variables, remove initializations

2021-03-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > avio_get_str always zero terminates the strings it reads. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/aadec.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libavformat/aadec.c b/libavformat/aadec.c > index

Re: [FFmpeg-devel] [PATCH 1/5] tests/fate: Don't keep unnecessary temp files

2021-03-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Some FATE tests use files created by other FATE tests as input files; > this mostly affects the seek tests which use files from vsynth_lena as > well as acodec-pcm as input files. In order to make this possible the > temporary files of all the vsynth* and all acodec-pcm tests

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/parser: Schedule av_parser_change for removal

2021-03-04 Thread Anton Khirnov
Quoting James Almer (2021-03-02 13:50:58) > Can we document this to prevent future pointless discussions about what > is and what is not the correct process? And for the sake of everyone's > sanity, don't summon the TC to solve a conflict about if we should add a > line to two files or just

Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

2021-03-04 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: 2021年3月4日 16:58 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref > private_ref when frame leaves libavfilter > > Guo, Yejun

[FFmpeg-devel] [PATCH] avfilter/f_ebur128: add all sample rates support

2021-03-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/f_ebur128.c | 73 ++--- 1 file changed, 46 insertions(+), 27 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index e81520838d..55913bac1d 100644 --- a/libavfilter/f_ebur128.c +++

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Jan Ekström
On Thu, Mar 4, 2021 at 11:57 AM Moritz Barsnick wrote: > > On Wed, Mar 03, 2021 at 22:09:12 +0200, Jan Ekström wrote: > > Thus, I will be pulling this set in Soon (probably tomorrow). Thus if > > anyone still wishes to have a say, I recommend doing it earlier than > > later. > > > + * Copyright

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Moritz Barsnick
On Thu, Mar 04, 2021 at 15:52:13 +0200, Jan Ekström wrote: > I... just am not so sure in this case splitting the TTML writer and > the TTML encoder from each other makes sense. I agree. In very many cases, muxer and encoder, or demuxer and decoder are only useful together. Yet I have observed

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Jan Ekström
On Thu, Mar 4, 2021, 16:43 Moritz Barsnick wrote: > On Thu, Mar 04, 2021 at 15:52:13 +0200, Jan Ekström wrote: > > I... just am not so sure in this case splitting the TTML writer and > > the TTML encoder from each other makes sense. > > I agree. In very many cases, muxer and encoder, or demuxer

Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

2021-03-04 Thread Nicolas George
Guo, Yejun (12021-03-04): > Agree, side data based solution is what we will finally use, and also > my original code. I think so too. > There's no industry standard which defines the specification of > bounding box. Mist industry standards suck anyway, it is best that we can define things

[FFmpeg-devel] [PATCH 2/8] avcodec/decode: Return early upon failure

2021-03-04 Thread Andreas Rheinhardt
Allows to remove one level of indentation. Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 5e5d0c7066..db6ee9cb04 100644 --- a/libavcodec/decode.c +++

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Jan Ekström
On Thu, Mar 4, 2021 at 4:52 PM Jan Ekström wrote: > > On Thu, Mar 4, 2021, 16:43 Moritz Barsnick wrote: >> >> On Thu, Mar 04, 2021 at 15:52:13 +0200, Jan Ekström wrote: >> > I... just am not so sure in this case splitting the TTML writer and >> > the TTML encoder from each other makes sense. >>

[FFmpeg-devel] [PATCH 1/8] avcodec/decode: constify the source packet parameter in extract_packet_props()

2021-03-04 Thread Andreas Rheinhardt
From: James Almer Signed-off-by: James Almer --- libavcodec/decode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index d445ac75b0..5e5d0c7066 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -144,7 +144,7 @@

[FFmpeg-devel] [PATCH 8/8] avcodec/qsvdec: Make functions used only here static, remove header

2021-03-04 Thread Andreas Rheinhardt
Forgotten after d78ecf10bd745cb69a71b32419e0661bfdcfb1fd. (Also mark some AVPackets as const.) Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 1 - libavcodec/qsvdec.c | 83 +++ libavcodec/qsvdec.h | 86

[FFmpeg-devel] [PATCH 7/8] avcodec/decode: Reindent after previous commits

2021-03-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 68 ++--- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 04cb050dc7..db0030bfd6 100644 --- a/libavcodec/decode.c +++

[FFmpeg-devel] [PATCH 5/8] avcodec/decode: Avoid stack packets when decoding subtitles

2021-03-04 Thread Andreas Rheinhardt
Use AVCodecInternal.buffer_pkt (previously only used in avcodec_send_packet) instead of stack packets when decoding subtitles. Also stop sharing side-data between packets and use the user-supplied packet directly for decoding when possible (no subtitle decoder ever modifies the packet it is

[FFmpeg-devel] [PATCH 6/8] avcodec/decode: Don't needlessly copy side-data for subtitles

2021-03-04 Thread Andreas Rheinhardt
AVCodecInternal.last_pkt_props is not used when decoding subtitles; ergo it makes no sense to set it at all. Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 84c4039836..04cb050dc7

Re: [FFmpeg-devel] [PATCH 4/8] avcodec: Constify some AVPackets

2021-03-04 Thread James Almer
On 3/4/2021 12:42 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- Of all the decoders using the simple decode API (i.e. with .decode set) only imm5 seems to modify its input packet (which is fine given that it is not the user-supplied reference); Having that decoder make a

[FFmpeg-devel] [PATCH 4/8] avcodec: Constify some AVPackets

2021-03-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Of all the decoders using the simple decode API (i.e. with .decode set) only imm5 seems to modify its input packet (which is fine given that it is not the user-supplied reference); libfdk_aac's API is not const-correct, so as-is it is not compatible with

[FFmpeg-devel] [PATCH 3/8] avcodec/decode: Check size before opening iconv

2021-03-04 Thread Andreas Rheinhardt
Avoids closing iconv when the size check fails. Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index db6ee9cb04..c976795311 100644 --- a/libavcodec/decode.c +++

Re: [FFmpeg-devel] [PATCH 5/8] avcodec/decode: Avoid stack packets when decoding subtitles

2021-03-04 Thread James Almer
On 3/4/2021 12:42 PM, Andreas Rheinhardt wrote: Use AVCodecInternal.buffer_pkt (previously only used in avcodec_send_packet) instead of stack packets when decoding subtitles. Also stop sharing side-data between packets and use the user-supplied packet directly for decoding when possible (no

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/decode: constify the source packet parameter in extract_packet_props()

2021-03-04 Thread James Almer
On 3/4/2021 12:42 PM, Andreas Rheinhardt wrote: From: James Almer Signed-off-by: James Almer --- libavcodec/decode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) I'll take this as a LGTM from you, so pushed. diff --git a/libavcodec/decode.c b/libavcodec/decode.c index

[FFmpeg-devel] [PATCH v7 4/5] avcodec: add TTML encoder

2021-03-04 Thread Jan Ekström
From: Jan Ekström Enables encoding of other subtitle formats into TTML paragraphs. Signed-off-by: Jan Ekström --- Changelog | 1 + doc/general_contents.texi | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/ttmlenc.c | 210

[FFmpeg-devel] [PATCH v7 3/5] avcodec: enable usage of err_recognition for encoders

2021-03-04 Thread Jan Ekström
From: Jan Ekström Enables the usage of such values as AV_EF_EXPLODE in encoders, which can be useful in cases such as subtitle encoders where they have the responsibility to validate the correctness of an incoming ASS dialog line. Signed-off-by: Jan Ekström --- doc/APIchanges | 3

[FFmpeg-devel] [PATCH v7 2/5] ffprobe: switch to av_bprint_escape for XML escaping

2021-03-04 Thread Jan Ekström
From: Jan Ekström Additionally update the result of the ffprobe XML writing test. Signed-off-by: Jan Ekström --- fftools/ffprobe.c | 32 +++- tests/ref/fate/ffprobe_xml | 2 +- 2 files changed, 12 insertions(+), 22 deletions(-) diff --git

[FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: add forgotten flags to mpeg4_options

2021-03-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/mpeg4videodec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index fd985f0430..2ca804fdc6 100644 --- a/libavcodec/mpeg4videodec.c +++ b/libavcodec/mpeg4videodec.c @@

Re: [FFmpeg-devel] [PATCH 3/8] avcodec/decode: Check size before opening iconv

2021-03-04 Thread James Almer
On 3/4/2021 12:42 PM, Andreas Rheinhardt wrote: Avoids closing iconv when the size check fails. Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/decode: Don't needlessly copy side-data for subtitles

2021-03-04 Thread James Almer
On 3/4/2021 12:42 PM, Andreas Rheinhardt wrote: AVCodecInternal.last_pkt_props is not used when decoding subtitles; ergo it makes no sense to set it at all. Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/decode.c

Re: [FFmpeg-devel] [PATCH 2/8] avcodec/decode: Return early upon failure

2021-03-04 Thread James Almer
On 3/4/2021 12:42 PM, Andreas Rheinhardt wrote: Allows to remove one level of indentation. Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index

[FFmpeg-devel] [PATCH v7 0/5] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Jan Ekström
I've intentionally kept this initial version simple (no styling etc) to focus on the basics. As this goes through review, additional features can be added (I had initial PoC for styling implemented some time around previous VDD), and there is another patch set in my queue which would then add

[FFmpeg-devel] [PATCH v7 1/5] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-03-04 Thread Jan Ekström
From: Stefano Sabatini Base escaping only escapes values required for base character data according to part 2.4 of XML, and if additional flags are added single and double quotes can additionally be escaped in order to handle single and double quoted attributes. Co-authored-by: Jan Ekström

Re: [FFmpeg-devel] [PATCH] avcodec/speedhq: fix decoding non 444 subsampling when width is not multiple of 16

2021-03-04 Thread Paul B Mahol
will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v7 5/5] avformat: add TTML muxer

2021-03-04 Thread Jan Ekström
From: Jan Ekström Enables writing TTML documents or encoded TTML paragraphs as such documents. Additionally, a test for the combined TTML encoder and muxer has been added to validate that the components still work. Signed-off-by: Jan Ekström --- Changelog | 2 +-

[FFmpeg-devel] [PATCH 2/7] avformat/wtvdec: Check size in SBE2_STREAM_DESC_EVENT / stream2_guid

2021-03-04 Thread Michael Niedermayer
Fixes: signed integer overflow: 539033600 - -1910497124 cannot be represented in type 'int' Fixes: 30928/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-5922630966312960 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 5/7] tools/target_dec_fuzzer: Compute CLUT for DVBSUB only once

2021-03-04 Thread Michael Niedermayer
Fixes: Timeout Fixes: 30845/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DVBSUB_fuzzer-5744263725973504 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file

[FFmpeg-devel] [PATCH 3/7] avcodec/setts_bsf: Check timebase

2021-03-04 Thread Michael Niedermayer
Fixes: Division by 0 Fixes: 30952/clusterfuzz-testcase-minimized-ffmpeg_BSF_SETTS_fuzzer-6601016202100736 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/setts_bsf.c | 2 +- 1 file changed, 1

[FFmpeg-devel] [PATCH 4/7] avcodec/dvbsubdec: Support computing clut only once

2021-03-04 Thread Michael Niedermayer
This avoids crafted files from consuming excessive resources recomputing the clut after each pixel change Signed-off-by: Michael Niedermayer --- libavcodec/dvbsubdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c index

[FFmpeg-devel] [PATCH 6/7] tools/target_dec_fuzzer: Adjust threshold for H264

2021-03-04 Thread Michael Niedermayer
Fixes: Timeout (too long -> 3sec) Fixes: 28047/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-4662727980875776 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c |

[FFmpeg-devel] [PATCH 1/7] avformat/utils: Fix integer overflow with duration_gcd in ff_rfps_calculate()

2021-03-04 Thread Michael Niedermayer
Fixes: signed integer overflow: 136323327 * 281474976710656 cannot be represented in type 'long' Fixes: 30913/clusterfuzz-testcase-minimized-ffmpeg_dem_IVF_fuzzer-5753392189931520 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 7/7] avformat/cafdec: Do not build an index if all packets are the same

2021-03-04 Thread Michael Niedermayer
Fixes: Timeout Fixes: 28214/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-6495999421579264 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/cafdec.c | 23 ++- 1

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/dvbsubdec: Support computing clut only once

2021-03-04 Thread Marton Balint
On Thu, 4 Mar 2021, Michael Niedermayer wrote: This avoids crafted files from consuming excessive resources recomputing the clut after each pixel change Signed-off-by: Michael Niedermayer --- libavcodec/dvbsubdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) PLease update