Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-20 19:18, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska/WebM muxing. The option enables users and developers to change the precision of the time stamps in the Matroska/WebM container up to 1

[FFmpeg-devel] [PATCH 1/3] avformat/moflex: Initialize format

2021-05-20 Thread Michael Niedermayer
Fixes: CID1477423 Uninitialized scalar variable Signed-off-by: Michael Niedermayer --- libavformat/moflex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/moflex.c b/libavformat/moflex.c index 0adb5f4864..dd4e7e0726 100644 --- a/libavformat/moflex.c +++

[FFmpeg-devel] [PATCH 3/3] avformat/avio: Check av_opt_copy() for failure

2021-05-20 Thread Michael Niedermayer
Fixes: CID1477416 Unchecked return value Signed-off-by: Michael Niedermayer --- libavformat/avio.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index 2974f4b2b4..6be6f9bf97 100644 --- a/libavformat/avio.c +++

[FFmpeg-devel] [PATCH 2/3] Remove format (Alternative solution for CID1477423)

2021-05-20 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/moflex.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/moflex.c b/libavformat/moflex.c index dd4e7e0726..234b0fb06e 100644 --- a/libavformat/moflex.c +++ b/libavformat/moflex.c @@ -172,7 +172,6 @@ static int

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-20 19:59, Nicolas George wrote: Michael Fabian 'Xaymar' Dirks (12021-05-20): The issue can't be fixed Then you should not be hiding the warning. It means something. I was asked to fix or remove it. Removing it breaks Matroska files entirely. Fixing it is not possible. What other

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-20 20:54, Nicolas George wrote: Michael Fabian 'Xaymar' Dirks (12021-05-20): Well, it's a combination of many things really, not bad math itself. 1ms works perfectly for the frame rates of 1, 2, 4, 5, 8, 10, 20, 25, 40, 50, 100, 125, 200, 250, 500, and 1000. For any other rate, you

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-21 02:45, James Almer wrote: On 5/20/2021 9:29 PM, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available options for Matroska muxing. The option enables users and developers to change the precision of the time stamps in the

[FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread michael . dirks
From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska muxing. The option enables users and developers to change the precision of the time stamps in the Matroska container up to 1 nanosecond, which can aid with the proper detection of constant and

[FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread michael . dirks
From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available options for Matroska muxing. The option enables users and developers to change the precision of the time stamps in the Matroska container up to 1 nanosecond, which can aid with the proper detection of constant and

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-21 01:42, James Almer wrote: On 5/20/2021 8:24 PM, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska muxing. The option enables users and developers to change the precision of the time stamps in the

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread James Almer
On 5/20/2021 7:20 PM, Lynne wrote: May 20, 2021, 20:08 by jamr...@gmail.com: On 5/20/2021 3:00 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-20 19:26, James Almer wrote: On 5/20/2021 2:18 PM, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread James Almer
On 5/20/2021 8:24 PM, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska muxing. The option enables users and developers to change the precision of the time stamps in the Matroska container up to 1 nanosecond,

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-20 23:47, James Almer wrote: On 5/20/2021 4:35 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-20 21:16, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska/WebM muxing. The option enables users

[FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread michael . dirks
From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska/WebM muxing. The option enables users and developers to change the precision of the time stamps in the Matroska/WebM container up to 1 nanosecond, which can aid with the proper detection of

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread James Almer
On 5/20/2021 7:04 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-20 23:47, James Almer wrote: On 5/20/2021 4:35 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-20 21:16, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available

[FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread michael . dirks
From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska/WebM muxing. The option enables users and developers to change the precision of the time stamps in the Matroska/WebM container up to 1 nanosecond, which can aid with the proper detection of

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-20 21:16, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska/WebM muxing. The option enables users and developers to change the precision of the time stamps in the Matroska/WebM container up to 1

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread James Almer
On 5/20/2021 9:29 PM, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available options for Matroska muxing. The option enables users and developers to change the precision of the time stamps in the Matroska container up to 1 nanosecond,

[FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread michael . dirks
From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska/WebM muxing. The option enables users and developers to change the precision of the time stamps in the Matroska/WebM container up to 1 nanosecond, which can aid with the proper detection of

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread James Almer
On 5/20/2021 7:57 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-21 00:37, James Almer wrote: On 5/20/2021 7:33 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-21 00:30, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-21 00:25, James Almer wrote: On 5/20/2021 7:20 PM, Lynne wrote:

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-21 00:30, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-21 00:25, James Almer wrote: On 5/20/2021 7:20 PM, Lynne wrote: May 20, 2021, 20:08 by jamr...@gmail.com: On 5/20/2021 3:00 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-20 19:26, James Almer wrote: On 5/20/2021

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread James Almer
On 5/20/2021 4:35 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-20 21:16, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska/WebM muxing. The option enables users and developers to change the precision of

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-20 19:38, Nicolas George wrote: Michael Fabian 'Xaymar' Dirks (12021-05-20): Unfortunately I was not able to get rid of the new cluster spam, so I moved it down a few logging levels into "verbose". So you silenced the warning, but did not fix the issue it was warning about. If you

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Lynne
May 20, 2021, 20:08 by jamr...@gmail.com: > On 5/20/2021 3:00 PM, Michael Fabian 'Xaymar' Dirks wrote: > >> On 2021-05-20 19:26, James Almer wrote: >> >>> On 5/20/2021 2:18 PM, michael.di...@xaymar.com wrote: >>> From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-20 20:14, Nicolas George wrote: Michael Fabian 'Xaymar' Dirks (12021-05-20): The default precision for Matroska is 1ms not 1µs. 1µs is plenty enough, but 1ms is not. I am not even convinced that most problems with 1ms are not caused by bad math, but I am willing to see proof.

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-21 00:25, James Almer wrote: On 5/20/2021 7:20 PM, Lynne wrote: May 20, 2021, 20:08 by jamr...@gmail.com: On 5/20/2021 3:00 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-20 19:26, James Almer wrote: On 5/20/2021 2:18 PM, michael.di...@xaymar.com wrote: From: Michael

Re: [FFmpeg-devel] [PATCH v2] avformat/flvdec: use milisecond precision for parsing timestamps

2021-05-20 Thread Marton Balint
On Sun, 16 May 2021, Anton Khirnov wrote: Quoting Marton Balint (2021-05-14 21:28:06) Also use helper function to set the timestamp. Maybe we could also use nanosecond precision, but there were some float rounding concerns. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 11

Re: [FFmpeg-devel] [PATCH] Add nit flag support v.2

2021-05-20 Thread Marton Balint
On Tue, 18 May 2021, Ubaldo Porcheddu wrote: Signed-off-by: Ubaldo Porcheddu --- doc/muxers.texi | 7 +++- libavformat/mpegtsenc.c | 100 +--- 2 files changed, 101 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-20 19:26, James Almer wrote: On 5/20/2021 2:18 PM, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska/WebM muxing. The option enables users and developers to change the precision of the time stamps in

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread James Almer
On 5/20/2021 7:33 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-21 00:30, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-21 00:25, James Almer wrote: On 5/20/2021 7:20 PM, Lynne wrote: May 20, 2021, 20:08 by jamr...@gmail.com: On 5/20/2021 3:00 PM, Michael Fabian 'Xaymar' Dirks

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-20 20:23, James Almer wrote: On 5/20/2021 2:59 PM, Nicolas George wrote: Michael Fabian 'Xaymar' Dirks (12021-05-20): The issue can't be fixed Then you should not be hiding the warning. It means something. It means that the container does not support values bigger than INT16_MAX

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-20 21:20, Nicolas George wrote: Michael Fabian 'Xaymar' Dirks (12021-05-20): There are plenty of reasons to know the actual frame rate with high precision. Editing software needs to know this to initialize effects, timelines and projects. I doubt they do that without building an

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Michael Fabian 'Xaymar' Dirks
On 2021-05-21 00:37, James Almer wrote: On 5/20/2021 7:33 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-21 00:30, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-21 00:25, James Almer wrote: On 5/20/2021 7:20 PM, Lynne wrote: May 20, 2021, 20:08 by jamr...@gmail.com: On 5/20/2021

[FFmpeg-devel] [PATCH] lavf/dashenc.c: Fix creating audio-only HLS playlists

2021-05-20 Thread Przemysław Sobala
With audio/video HLS playlists, audio chunklists are treated as alternative renditions for video chunklists. This is wrong for audio-only HLS playlists. fixes: 9252 --- libavformat/dashenc.c | 137 ++ 1 file changed, 84 insertions(+), 53 deletions(-)

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread James Almer
On 5/20/2021 3:00 PM, Michael Fabian 'Xaymar' Dirks wrote: On 2021-05-20 19:26, James Almer wrote: On 5/20/2021 2:18 PM, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska/WebM muxing. The option enables users

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Nicolas George
Michael Fabian 'Xaymar' Dirks (12021-05-20): > The issue can't be fixed Then you should not be hiding the warning. It means something. I have yet to see a convincing explanation of a case where 1µs would not be enough, by the way. AFAICS, the issue is mostly people handling rounding incorrectly;

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Nicolas George
Michael Fabian 'Xaymar' Dirks (12021-05-20): > Unfortunately I was not able to get rid of the new cluster spam, so I > moved it down a few logging levels into "verbose". So you silenced the warning, but did not fix the issue it was warning about. If you were a physician, you would just have

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Nicolas George
Michael Fabian 'Xaymar' Dirks (12021-05-20): > There are plenty of reasons to know the actual frame rate with high > precision. > Editing software needs to know this to initialize effects, timelines > and projects. I doubt they do that without building an index in the first place. > Players need

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Nicolas George
Michael Fabian 'Xaymar' Dirks (12021-05-20): > At the current time there aren't many editors that support Matroska, > but Black Magic Design DaVinci Resolve is one of them. Resolve > approximates the 60 fps footage to be 59.94 fps, which is close but > not exact - off by just 0.06 seconds. This is

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread James Almer
On 5/20/2021 2:18 PM, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds "timestamp_precision" to the available option for Matroska/WebM muxing. The option enables users and developers to change the precision of the time stamps in the Matroska/WebM container up to 1

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Nicolas George
Michael Fabian 'Xaymar' Dirks (12021-05-20): > The default precision for Matroska is 1ms not 1µs. 1µs is plenty > enough, but 1ms is not. I am not even convinced that most problems with 1ms are not caused by bad math, but I am willing to see proof. Regards, -- Nicolas George signature.asc

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread James Almer
On 5/20/2021 2:59 PM, Nicolas George wrote: Michael Fabian 'Xaymar' Dirks (12021-05-20): The issue can't be fixed Then you should not be hiding the warning. It means something. It means that the container does not support values bigger than INT16_MAX for block timestamps (relative to the

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-05-20 Thread Nicolas George
Michael Fabian 'Xaymar' Dirks (12021-05-20): > Well, it's a combination of many things really, not bad math itself. > 1ms works perfectly for the frame rates of 1, 2, 4, 5, 8, 10, 20, 25, > 40, 50, 100, 125, 200, 250, 500, and 1000. For any other rate, you > will have to look at the actual

Re: [FFmpeg-devel] [PATCH v2] avcodec/vaapi_av1: pass full buffer size for each tile

2021-05-20 Thread Jan Ekström
On Wed, May 19, 2021 at 5:24 AM Fei Wang wrote: > > Previously, only the size of a given tile was passed, making the > offset and size marked in VASliceParameterBufferAV1 invalid with > multiple tiles. > > Signed-off-by: Fei Wang > --- > Change: > 1. update commit message. > >

Re: [FFmpeg-devel] [PATCH v2] avcodec/vaapi_av1: pass full buffer size for each tile

2021-05-20 Thread Jan Ekström
On Thu, May 20, 2021 at 5:08 PM Jan Ekström wrote: > > On Wed, May 19, 2021 at 5:24 AM Fei Wang wrote: > > > > Previously, only the size of a given tile was passed, making the > > offset and size marked in VASliceParameterBufferAV1 invalid with > > multiple tiles. > > > > Signed-off-by: Fei Wang