Re: [FFmpeg-devel] [PATCH 04/10] fftools/cmdutils: split common option handlers into their own file

2022-03-20 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-03-17 16:30:04) > Anton Khirnov: > > --- > > fftools/Makefile |2 +- > > fftools/cmdutils.c | 1399 +-- > > fftools/cmdutils.h | 202 --- > > fftools/ffmpeg_opt.c |1 + > >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/opt: add missing case for AV_OPT_TYPE_CHLAYOUT in av_opt_free()

2022-03-20 Thread Michael Niedermayer
On Fri, Mar 18, 2022 at 10:00:17PM +, James Almer wrote: > ffmpeg | branch: master | James Almer | Fri Mar 18 > 18:46:40 2022 -0300| [327efa66331ebdc0087c6b656059a8df2f404019] | committer: > James Almer > > avutil/opt: add missing case for AV_OPT_TYPE_CHLAYOUT in av_opt_free() > > Fixes po

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mxfdec: Check count in mxf_read_strong_ref_array()

2022-03-20 Thread Tomas Härdin
lör 2022-03-19 klockan 23:50 +0100 skrev Michael Niedermayer: > On Mon, Mar 14, 2022 at 08:19:51PM +0100, Tomas Härdin wrote: > > sön 2022-03-13 klockan 00:52 +0100 skrev Michael Niedermayer: > > > Signed-off-by: Michael Niedermayer > > > --- > > >  libavformat/mxfdec.c | 8 +++- > > >  1 file

[FFmpeg-devel] [PATCH 2/4] avformat/cafdec: Do not store empty keys in read_info_chunk()

2022-03-20 Thread Michael Niedermayer
Fixes: Timeout Fixes: 45543/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5684953164152832 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/cafdec.c | 2 ++ 1 file changed, 2 insertions

[FFmpeg-devel] [PATCH 1/4] avformat/alp: Check num_channels

2022-03-20 Thread Michael Niedermayer
Fixes: division by 0 Fixes: 45615/clusterfuzz-testcase-minimized-ffmpeg_dem_ALP_fuzzer-582660348405350 Fixes: 45625/clusterfuzz-testcase-minimized-ffmpeg_dem_ALP_fuzzer-4821437943250944 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-of

[FFmpeg-devel] [PATCH 4/4] avformat/aqtitledec: Skip unrepresentable durations

2022-03-20 Thread Michael Niedermayer
Fixes: signed integer overflow: -5 - 9223372036854775807 cannot be represented in type 'long' Fixes: 45665/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-475618463934054 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mich

[FFmpeg-devel] [PATCH 3/4] avformat/apm: Check channels

2022-03-20 Thread Michael Niedermayer
Fixes: division by 0 Fixes: 45643/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-495905188864.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/apm.c | 2 +- 1 file changed, 1 in

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mxfdec: Check count in mxf_read_strong_ref_array()

2022-03-20 Thread Michael Niedermayer
On Sun, Mar 20, 2022 at 02:05:41PM +0100, Tomas Härdin wrote: > lör 2022-03-19 klockan 23:50 +0100 skrev Michael Niedermayer: [...] > > > > > > > > > > > + > > > > +    //avio_read() used int > > > > +    if (c > INT_MAX / sizeof(UID)) > > > > +    return AVERROR_PATCHWELCOME; > > > > +    *

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-20 Thread James Almer
On 3/19/2022 10:47 AM, Anton Khirnov wrote: Quoting James Almer (2022-03-19 04:04:07) The function is not meant to clear codec parameters, and the lavf demux code relies on this behavior. Maybe it shouldn't? Which code is it exactly? The parser included by demux.c. That file calls avcodec_c

Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/opt: add missing case for AV_OPT_TYPE_CHLAYOUT in av_opt_free()

2022-03-20 Thread James Almer
On 3/20/2022 8:29 AM, Michael Niedermayer wrote: On Fri, Mar 18, 2022 at 10:00:17PM +, James Almer wrote: ffmpeg | branch: master | James Almer | Fri Mar 18 18:46:40 2022 -0300| [327efa66331ebdc0087c6b656059a8df2f404019] | committer: James Almer avutil/opt: add missing case for AV_OPT_

Re: [FFmpeg-devel] [PATCH 1/3] avformat/slndec: add support to set channel layout

2022-03-20 Thread James Almer
On 3/19/2022 10:52 AM, Anton Khirnov wrote: Quoting James Almer (2022-03-18 23:19:05) Signed-off-by: James Almer --- libavformat/pcmdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c index dcd13787d5..a2bcfc2814 100644 -

Re: [FFmpeg-devel] [PATCH 4/4] ffmpeg: replace custom channel_layout code with an SpecifierOpt based one

2022-03-20 Thread James Almer
On 3/19/2022 3:29 PM, Michael Niedermayer wrote: On Fri, Mar 18, 2022 at 07:47:48PM -0300, James Almer wrote: This is cleaner and allows fine tuning which stream the option is applied to. Signed-off-by: James Almer --- fftools/ffmpeg.h | 2 ++ fftools/ffmpeg_opt.c | 84 +

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-20 Thread James Almer
On 3/19/2022 4:50 AM, Hendrik Leppkes wrote: On Sat, Mar 19, 2022 at 4:04 AM James Almer wrote: The function is not meant to clear codec parameters, and the lavf demux code relies on this behavior. Regression since 327efa66331ebdc0087c6b656059a8df2f404019. Signed-off-by: James Almer --- li

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-20 Thread James Almer
On 3/20/2022 2:03 PM, James Almer wrote: On 3/19/2022 10:47 AM, Anton Khirnov wrote: Quoting James Almer (2022-03-19 04:04:07) The function is not meant to clear codec parameters, and the lavf demux code relies on this behavior. Maybe it shouldn't? Which code is it exactly? The parser

[FFmpeg-devel] [PATCH 1/7] avformat/pcmdec: deprecate channels option

2022-03-20 Thread James Almer
And ensure ch_layout has priority if set over channels, until the latter is gone. Signed-off-by: James Almer --- libavformat/pcmdec.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c index dcd13787d5..962faad4

[FFmpeg-devel] [PATCH 2/7 v2] avformat/pcmdec: add support to set channel layout in sln demuxer

2022-03-20 Thread James Almer
Deprecate the channels option, and ensure ch_layout has priority if set over channels, until the latter is gone. Signed-off-by: James Almer --- libavformat/pcmdec.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c index 962faad

[FFmpeg-devel] [PATCH 3/7 v2] avformat/dfpwmdec: add support to set channel layout

2022-03-20 Thread James Almer
Deprecate the channels option, and ensure ch_layout has priority if set over channels, until the latter is gone. Signed-off-by: James Almer --- libavformat/dfpwmdec.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/libavformat/dfpwmdec.c b/libavformat/

[FFmpeg-devel] [PATCH 4/7 v2] avformat/test/seek: set ch_layout instead of channels

2022-03-20 Thread James Almer
Signed-off-by: James Almer --- No changes since last version. libavformat/tests/seek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tests/seek.c b/libavformat/tests/seek.c index e0067a64fc..94a72d9422 100644 --- a/libavformat/tests/seek.c +++ b/libavformat/test

[FFmpeg-devel] [PATCH 5/7 v2] ffmpeg: replace custom channel_layout code with an SpecifierOpt based one

2022-03-20 Thread James Almer
This is cleaner and allows fine tuning which stream the option is applied to. Signed-off-by: James Almer --- No changes since last version. fftools/ffmpeg.h | 2 ++ fftools/ffmpeg_opt.c | 84 ++-- 2 files changed, 36 insertions(+), 50 deletions(-) d

[FFmpeg-devel] [PATCH 6/7] ffmpeg: add a ch_layout option as an alias to channel_layout

2022-03-20 Thread James Almer
This ensures it's parsed as a CLI option instead of the AVCodecContext AVOption. Signed-off-by: James Almer --- fftools/ffmpeg_opt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index f5c759c6d1..720a3cc46a 100644 --- a/fftoo

[FFmpeg-devel] [PATCH 7/7] ffmpeg: deprecate the ac option

2022-03-20 Thread James Almer
Same as the AVCodecContext option. Signed-off-by: James Almer --- fftools/ffmpeg.h | 2 ++ fftools/ffmpeg_opt.c | 8 2 files changed, 10 insertions(+) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 1e14bf9fa9..d0bc4b6afb 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h

Re: [FFmpeg-devel] [PATCH 7/7] ffmpeg: deprecate the ac option

2022-03-20 Thread Nicolas George
James Almer (12022-03-20): > Same as the AVCodecContext option. > > Signed-off-by: James Almer > --- > fftools/ffmpeg.h | 2 ++ > fftools/ffmpeg_opt.c | 8 > 2 files changed, 10 insertions(+) I do not like this: it requires more typing from the user, even with the "short" alias in

Re: [FFmpeg-devel] [PATCH 7/7] ffmpeg: deprecate the ac option

2022-03-20 Thread James Almer
On 3/20/2022 4:44 PM, Nicolas George wrote: James Almer (12022-03-20): Same as the AVCodecContext option. Signed-off-by: James Almer --- fftools/ffmpeg.h | 2 ++ fftools/ffmpeg_opt.c | 8 2 files changed, 10 insertions(+) I do not like this: it requires more typing from the

[FFmpeg-devel] [PATCH 7/7] ffmpeg: make the ac option set the demuxer's ch_layout AVOption

2022-03-20 Thread James Almer
channels is deprecated on all supported raw demuxers. Signed-off-by: James Almer --- fftools/ffmpeg_opt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 720a3cc46a..b3edbf9885 100644 --- a/fftools/ffmpeg_opt.c +++ b/ffto

Re: [FFmpeg-devel] [PATCH 7/7] ffmpeg: make the ac option set the demuxer's ch_layout AVOption

2022-03-20 Thread Nicolas George
James Almer (12022-03-20): > channels is deprecated on all supported raw demuxers. > > Signed-off-by: James Almer > --- > fftools/ffmpeg_opt.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) I like this version much better. Thanks. > diff --git a/fftools/ffmpeg_opt.c b/fftools/ff

[FFmpeg-devel] [PATCH 7/7] ffmpeg: make the ac option set the demuxer's ch_layout AVOption

2022-03-20 Thread James Almer
channels is deprecated on all supported raw demuxers. Signed-off-by: James Almer --- fftools/ffmpeg_opt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 720a3cc46a..213a34eadc 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftool

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-20 Thread Hendrik Leppkes
On Sun, Mar 20, 2022 at 7:52 PM James Almer wrote: > > On 3/19/2022 4:50 AM, Hendrik Leppkes wrote: > > On Sat, Mar 19, 2022 at 4:04 AM James Almer wrote: > >> > >> The function is not meant to clear codec parameters, and the lavf demux > >> code > >> relies on this behavior. > >> Regression sin

Re: [FFmpeg-devel] [PATCH] avcodec/opus: always use ambisonic layout for mapping family 2

2022-03-20 Thread Michael Niedermayer
On Thu, Mar 17, 2022 at 10:43:15PM -0300, James Almer wrote: > No need to use a Custom layout when the non diegetic channels can be > described as a standard mask. > > Signed-off-by: James Almer > --- > libavcodec/opus.c | 17 +++-- > 1 file changed, 3 insertions(+), 14 deletions(-)

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-20 Thread James Almer
On 3/20/2022 7:01 PM, Hendrik Leppkes wrote: On Sun, Mar 20, 2022 at 7:52 PM James Almer wrote: On 3/19/2022 4:50 AM, Hendrik Leppkes wrote: On Sat, Mar 19, 2022 at 4:04 AM James Almer wrote: The function is not meant to clear codec parameters, and the lavf demux code relies on this beh

Re: [FFmpeg-devel] [PATCH] avcodec/opus: always use ambisonic layout for mapping family 2

2022-03-20 Thread James Almer
On 3/20/2022 7:09 PM, Michael Niedermayer wrote: On Thu, Mar 17, 2022 at 10:43:15PM -0300, James Almer wrote: No need to use a Custom layout when the non diegetic channels can be described as a standard mask. Signed-off-by: James Almer --- libavcodec/opus.c | 17 +++-- 1 file ch

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-20 Thread Marton Balint
On Sun, 20 Mar 2022, James Almer wrote: On 3/20/2022 7:01 PM, Hendrik Leppkes wrote: On Sun, Mar 20, 2022 at 7:52 PM James Almer wrote: On 3/19/2022 4:50 AM, Hendrik Leppkes wrote: On Sat, Mar 19, 2022 at 4:04 AM James Almer wrote: The function is not meant to clear codec parame

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-20 Thread James Almer
On 3/20/2022 7:34 PM, Marton Balint wrote: On Sun, 20 Mar 2022, James Almer wrote: On 3/20/2022 7:01 PM, Hendrik Leppkes wrote:  On Sun, Mar 20, 2022 at 7:52 PM James Almer wrote:  On 3/19/2022 4:50 AM, Hendrik Leppkes wrote:  On Sat, Mar 19, 2022 at 4:04 AM James Almer wrote:  The

Re: [FFmpeg-devel] [PATCH] ffplay: don't shadow global variable

2022-03-20 Thread Marton Balint
On Wed, 16 Mar 2022, Zhao Zhili wrote: --- fftools/ffplay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 92ad7ce1a6..b583225d53 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -1454,13 +1454,13 @@ static void check_ex

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-20 Thread Marton Balint
On Sun, 20 Mar 2022, James Almer wrote: On 3/20/2022 7:34 PM, Marton Balint wrote: On Sun, 20 Mar 2022, James Almer wrote: On 3/20/2022 7:01 PM, Hendrik Leppkes wrote:  On Sun, Mar 20, 2022 at 7:52 PM James Almer wrote:  On 3/19/2022 4:50 AM, Hendrik Leppkes wrote:  On Sat, Ma

[FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread James Almer
It can uninitialize fields that may still be used after the context was closed, so do it instead in avcodec_free_context(). Signed-off-by: James Almer --- libavcodec/avcodec.c | 1 - libavcodec/options.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/avcodec.c b

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread Andreas Rheinhardt
James Almer: > It can uninitialize fields that may still be used after the context was > closed, > so do it instead in avcodec_free_context(). > > Signed-off-by: James Almer > --- > libavcodec/avcodec.c | 1 - > libavcodec/options.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread James Almer
On 3/20/2022 8:26 PM, Andreas Rheinhardt wrote: James Almer: It can uninitialize fields that may still be used after the context was closed, so do it instead in avcodec_free_context(). Signed-off-by: James Almer --- libavcodec/avcodec.c | 1 - libavcodec/options.c | 2 +- 2 files change

[FFmpeg-devel] [PATCH 2/5] avcodec/mlpdec: Use 64bit for channel layout

2022-03-20 Thread Michael Niedermayer
Fixes: shift exponent 33 is too large for 32-bit type 'int' Fixes: 45645/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-5651350182035456 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- l

[FFmpeg-devel] [PATCH 1/5] avformat/hls: Check target_duration

2022-03-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 77 * 100 cannot be represented in type 'long long' Fixes: 45545/clusterfuzz-testcase-minimized-ffmpeg_dem_HLS_fuzzer-6438101247983616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by

[FFmpeg-devel] [PATCH 3/5] avformat/asfdec_f: Check packet_frag_timestamp

2022-03-20 Thread Michael Niedermayer
Fixes: signed integer overflow: -9223372036854775808 - 4607 cannot be represented in type 'long' Fixes: 45685/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5280102802391040 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-b

[FFmpeg-devel] [PATCH 4/5] avformat/bfi: Check offsets better

2022-03-20 Thread Michael Niedermayer
Fixes: signed integer overflow: -2145378272 - 538976288 cannot be represented in type 'int' Fixes: 45690/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5015496544616448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mi

[FFmpeg-devel] [PATCH 5/5] avformat/aviobuf: Check buf_size in ffio_ensure_seekback()

2022-03-20 Thread Michael Niedermayer
buffer_size is an int Fixes: signed integer overflow: 9223372036854775754 + 32767 cannot be represented in type 'long' Fixes: 45691/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5263458831040512 Signed-off-by: Michael Niedermayer --- libavformat/aviobuf.c | 3 +++ 1 file changed, 3

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread Andreas Rheinhardt
James Almer: > > > On 3/20/2022 8:26 PM, Andreas Rheinhardt wrote: >> James Almer: >>> It can uninitialize fields that may still be used after the context >>> was closed, >>> so do it instead in avcodec_free_context(). >>> >>> Signed-off-by: James Almer >>> --- >>>   libavcodec/avcodec.c | 1 - >

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/mlpdec: Use 64bit for channel layout

2022-03-20 Thread James Almer
On 3/20/2022 8:30 PM, Michael Niedermayer wrote: Fixes: shift exponent 33 is too large for 32-bit type 'int' Fixes: 45645/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-5651350182035456 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/proj

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-20 Thread Andreas Rheinhardt
James Almer: > The function is not meant to clear codec parameters, and the lavf demux code > relies on this behavior. > Regression since 327efa66331ebdc0087c6b656059a8df2f404019. > > Signed-off-by: James Almer > --- > libavcodec/avcodec.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread James Almer
On 3/20/2022 8:34 PM, Andreas Rheinhardt wrote: James Almer: On 3/20/2022 8:26 PM, Andreas Rheinhardt wrote: James Almer: It can uninitialize fields that may still be used after the context was closed, so do it instead in avcodec_free_context(). Signed-off-by: James Almer ---   libavcodec

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hls: add AVFMT_NO_BYTE_SEEK flag

2022-03-20 Thread Marton Balint
On Wed, 16 Mar 2022, Zhao Zhili wrote: After d6ac6650b91, ffplay failed to seek HLS stream with AVSEEK_FLAG_BYTE enabled by default. --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 06bc46c23f..a01529 1006

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/pixlet: Avoid signed integer overflow in scaling in filterfn()

2022-03-20 Thread Michael Niedermayer
On Tue, Oct 27, 2020 at 05:21:18PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 11494 * 107374182400 cannot be > represented in type 'long' > Fixes: > 26586/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PIXLET_fuzzer-5752633970917376 > > Found-by: continuous fuzzin

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/mlpdec: Use 64bit for channel layout

2022-03-20 Thread Michael Niedermayer
On Sun, Mar 20, 2022 at 08:34:32PM -0300, James Almer wrote: > > > On 3/20/2022 8:30 PM, Michael Niedermayer wrote: > > Fixes: shift exponent 33 is too large for 32-bit type 'int' > > Fixes: > > 45645/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-5651350182035456 > > > > Found

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/x86/vf_blend: use unaligned movs for output

2022-03-20 Thread Marton Balint
On Fri, 18 Mar 2022, Paul B Mahol wrote: lgtm Thanks, applied. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread Marton Balint
On Sun, 20 Mar 2022, James Almer wrote: On 3/20/2022 8:34 PM, Andreas Rheinhardt wrote: James Almer: On 3/20/2022 8:26 PM, Andreas Rheinhardt wrote: James Almer: It can uninitialize fields that may still be used after the context was closed, so do it instead in avcodec_free_context

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread Marton Balint
On Mon, 21 Mar 2022, Marton Balint wrote: On Sun, 20 Mar 2022, James Almer wrote: On 3/20/2022 8:34 PM, Andreas Rheinhardt wrote: James Almer: On 3/20/2022 8:26 PM, Andreas Rheinhardt wrote: James Almer: It can uninitialize fields that may still be used after the context w

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread James Almer
On 3/20/2022 9:05 PM, Marton Balint wrote: On Mon, 21 Mar 2022, Marton Balint wrote: On Sun, 20 Mar 2022, James Almer wrote:  On 3/20/2022 8:34 PM, Andreas Rheinhardt wrote:   James Almer:   On 3/20/2022 8:26 PM, Andreas Rheinhardt wrote:   James Almer:   It can uninitialize fields t

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread Andreas Rheinhardt
Marton Balint: > > > On Mon, 21 Mar 2022, Marton Balint wrote: > >> >> >> On Sun, 20 Mar 2022, James Almer wrote: >> >>>  On 3/20/2022 8:34 PM, Andreas Rheinhardt wrote:   James Almer: > > >   On 3/20/2022 8:26 PM, Andreas Rheinhardt wrote: >>   James Almer: >>>   It can

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread Marton Balint
On Sun, 20 Mar 2022, James Almer wrote: On 3/20/2022 9:05 PM, Marton Balint wrote: On Mon, 21 Mar 2022, Marton Balint wrote: On Sun, 20 Mar 2022, James Almer wrote:  On 3/20/2022 8:34 PM, Andreas Rheinhardt wrote:   James Almer:   On 3/20/2022 8:26 PM, Andreas Rheinhardt wrot

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread James Almer
On 3/20/2022 9:21 PM, Marton Balint wrote: On Sun, 20 Mar 2022, James Almer wrote: On 3/20/2022 9:05 PM, Marton Balint wrote:  On Mon, 21 Mar 2022, Marton Balint wrote:  On Sun, 20 Mar 2022, James Almer wrote:   On 3/20/2022 8:34 PM, Andreas Rheinhardt wrote:    James Almer:    O

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-20 Thread Andreas Rheinhardt
James Almer: > On 3/20/2022 8:34 PM, Andreas Rheinhardt wrote: >> James Almer: >>> >>> >>> On 3/20/2022 8:26 PM, Andreas Rheinhardt wrote: James Almer: > It can uninitialize fields that may still be used after the context > was closed, > so do it instead in avcodec_free_context().

[FFmpeg-devel] [PATCH] doc/examples/muxing: Remove outdated comment

2022-03-20 Thread Andreas Rheinhardt
This comment only applies to the scenario in which one uses the AVCodecContexts embedded in AVStreams. Yet this code sample stopped doing so in 9897d9f4e074cdc6c7f2409885ddefe300f18dc7; and the last major version bump even removed the public AVCodecContexts in AVStreams. So just remove this comment

Re: [FFmpeg-devel] [PATCH 1/5] avformat/hls: Check target_duration

2022-03-20 Thread Steven Liu
Michael Niedermayer 于2022年3月21日周一 07:31写道: > > Fixes: signed integer overflow: 77 * 100 cannot be > represented in type 'long long' > Fixes: > 45545/clusterfuzz-testcase-minimized-ffmpeg_dem_HLS_fuzzer-6438101247983616 > > Found-by: continuous fuzzing process > https://github.co

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_time_delta to cut segment at before hls_time

2022-03-20 Thread zhilizhao(赵志立)
> On Mar 18, 2022, at 8:20 PM, Steven Liu wrote: > > From: Steven Liu > > There have some video stream usually cannot get precise duration, > for example: > > command: > ffmpeg -i input.mp4 -c copy -copyts -f hls -hls_time 5 -hls_list_size 0 > -hls_segment_type mpegts -t 20 a.m3u8 > > the

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: enable LowDelayBRC and MaxFrameSizeI/MaxFrameSizeP for more accurate bitrate control

2022-03-20 Thread Xiang, Haihao
On Thu, 2022-03-10 at 10:11 +, He, Fan F wrote: > Feature introduction of LowDelayBRC, MaxFrameSizeI and MaxFrameSizeP could be > found here: > https://github.com/Intel-Media-SDK/MediaSDK/blob/master/doc/mediasdk-man.md > > Signed-off-by: Dmitry Ermilov > Signed-off-by: Fan F He > --- > doc

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: enable LowDelayBRC and MaxFrameSizeI/MaxFrameSizeP for more accurate bitrate control

2022-03-20 Thread zhilizhao(赵志立)
> On Mar 10, 2022, at 6:11 PM, He, Fan F > wrote: > > Feature introduction of LowDelayBRC, MaxFrameSizeI and MaxFrameSizeP could be > found here: > https://github.com/Intel-Media-SDK/MediaSDK/blob/master/doc/mediasdk-man.md > > Signed-off-by: Dmitry Ermilov > Signed-off-by: Fan F He > ---

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_time_delta to cut segment at before hls_time

2022-03-20 Thread Steven Liu
"zhilizhao(赵志立)" 于2022年3月21日周一 11:55写道: > > > > > On Mar 18, 2022, at 8:20 PM, Steven Liu wrote: > > > > From: Steven Liu > > > > There have some video stream usually cannot get precise duration, > > for example: > > > > command: > > ffmpeg -i input.mp4 -c copy -copyts -f hls -hls_time 5 -hls_li

Re: [FFmpeg-devel] [PATCH 2/2] fate/h264: add test case for h264-loss_packet_for_prev_frame_num_offset

2022-03-20 Thread Steven Liu
> 2022年2月16日 下午4:54,Steven Liu 写道: > > > >> 2022年2月16日 下午4:51,Steven Liu 写道: >> >> From: Steven Liu >> >> Signed-off-by: Steven Liu >> --- >> tests/fate/h264.mak | 2 ++ >> ...h264-loss_packet_for_prev_frame_num_offset | 23 +++ >> 2 files changed