-Message d'origine-
De : ffmpeg-devel De la part de Tomas Härdin
Envoyé : lundi 19 février 2024 11:40
À : FFmpeg development discussions and patches
Objet : Re: [FFmpeg-devel] [PATCH] [MXF] - Add "footer_with_hmd" option
fre 2024-02-09 klockan 11:58 +0100 skrev Cédric Le Barz:
> Add
On Wed, 14 Feb 2024, Martin Storsjö wrote:
Contrary to the existing "fate-checkasm", this always prints the
tool output, and runs all tests at once instead of splitting it up
per target group. This is more useful when the user expects to
look directly at the tool output, instead of being part
---
Changelog | 1 +
doc/ffmpeg.texi | 75 ---
fftools/ffmpeg.h | 31 --
fftools/ffmpeg_filter.c | 14 -
fftools/ffmpeg_mux.c | 5 --
fftools/ffmpeg_mux_init.c | 75 +--
fftools/ffmpeg_opt.c
Signed-off-by: J. Dekker
---
tests/checkasm/hevc_deblock.c | 246 +-
1 file changed, 215 insertions(+), 31 deletions(-)
diff --git a/tests/checkasm/hevc_deblock.c b/tests/checkasm/hevc_deblock.c
index 66fc8d5646..91e57f5cf5 100644
---
Over/underflow in some cases.
Signed-off-by: J. Dekker
---
libavcodec/x86/hevcdsp_init.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c
index 31e81eb11f..11cb1b3bfd 100644
---
---
fftools/ffmpeg.c | 12 +---
fftools/ffmpeg_dec.c | 11 ---
fftools/ffmpeg_enc.c | 6 ++
fftools/ffmpeg_filter.c | 24 ++--
fftools/ffmpeg_mux.c | 3 +--
fftools/ffmpeg_mux_init.c | 9 +++--
6 files changed, 25
It can be triggered when send_to_enc_thread() returns AVERROR(ENOMEM).
Propagate the error to the caller instead.
Reported-by: Andreas Rheinhardt
---
fftools/ffmpeg_sched.c | 31 +--
1 file changed, 17 insertions(+), 14 deletions(-)
diff --git
---
fftools/ffmpeg_sched.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c
index d91968822f..cb9d8c6905 100644
--- a/fftools/ffmpeg_sched.c
+++ b/fftools/ffmpeg_sched.c
@@ -2035,13 +2035,11 @@ int sch_dec_send(Scheduler
Benched using single-threaded full decode on an Ampere Altra.
Bpp Before After Speedup
8 73,3s 65,2s 1.124x
10 114,2s 104,0s 1.098x
12 125,8s 115,7s 1.087x
Signed-off-by: J. Dekker
---
libavcodec/aarch64/hevcdsp_deblock_neon.S | 421 ++
On 21/02/2024 14:11, Tomas Härdin wrote:
mxfdec can detect cases where there will be two separate fields in one
KLV,
In practice the issue is not to detect I2 case in mxfdec (it saves us
only a little during probing of the first frame, but I could add such
signaling in a patch after this
Feb 21, 2024, 12:34 by j...@itanimul.li:
> Signed-off-by: J. Dekker
> ---
> doc/outdevs.texi| 2 +-
> libavdevice/opengl_enc.c| 11 +++
> libavdevice/version_major.h | 2 ++
> 3 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/doc/outdevs.texi
On Wed, Feb 21, 2024 at 02:39:42AM +0100, Jean-Baptiste Kempf wrote:
> Yo,
>
> On Tue, 20 Feb 2024, at 15:31, Michael Niedermayer wrote:
> > I did hear (at fosdem?)
> > about the idea to switch from rsync to git for managing the fate samples
> > i thought the idea sounds interresting but isnt
The output of TX is extremely verbose and makes it harder to find other debug
log messages, so only print it at trace level.
Signed-off-by: James Almer
---
libavutil/tx.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavutil/tx.c b/libavutil/tx.c
index
On Wed, 21 Feb 2024, J. Dekker wrote:
Benched using single-threaded full decode on an Ampere Altra.
Bpp Before After Speedup
8 73,3s 65,2s 1.124x
10 114,2s 104,0s 1.098x
12 125,8s 115,7s 1.087x
Signed-off-by: J. Dekker
---
libavcodec/aarch64/hevcdsp_deblock_neon.S | 421
This is still J2K specific rather than handling it properly for all
codecs all at once.
mxfdec can detect cases where there will be two separate fields in one
KLV, and the decoder(s) can if I'm not mistaken be instructed to decode
into an AVFrame with stride and offset set up for interlaced
On Tue, 20 Feb 2024 20:43:30 +0200 Jan Ekström wrote:
> Do note that the idea was that this would only be for management of
> the main archive, so it would not affect clients/runners rsync'ing
> from the main archive.
>
> Of course clients which want to sync directly from git could do that,
>
Signed-off-by: J. Dekker
---
doc/outdevs.texi| 8 +++-
libavdevice/sdl2.c | 10 ++
libavdevice/version_major.h | 2 ++
3 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/doc/outdevs.texi b/doc/outdevs.texi
index 941429a8c8..9ee857528e 100644
---
Signed-off-by: J. Dekker
---
doc/outdevs.texi| 2 +-
libavdevice/opengl_enc.c| 11 +++
libavdevice/version_major.h | 2 ++
3 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/doc/outdevs.texi b/doc/outdevs.texi
index f0484bbf8f..941429a8c8 100644
---
ons 2024-02-21 klockan 08:47 +0100 skrev Cédric Le Barz:
>
>
> -Message d'origine-
> De : ffmpeg-devel De la part de
> Tomas Härdin
> Envoyé : lundi 19 février 2024 11:40
> À : FFmpeg development discussions and patches
>
> Objet : Re: [FFmpeg-devel] [PATCH] [MXF] - Add
On 21 Feb 2024, at 15:38, Niklas Haas wrote:
> On Tue, 20 Feb 2024 20:43:30 +0200 Jan Ekström wrote:
>> Do note that the idea was that this would only be for management of
>> the main archive, so it would not affect clients/runners rsync'ing
>> from the main archive.
>>
>> Of course clients
It causes write_option() to return 0 when calling func_arg() fails.
---
fftools/cmdutils.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 5e181a0d85..3d613a4018 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -339,8 +339,6 @@ static
Feb 21, 2024, 15:43 by jamr...@gmail.com:
> The output of TX is extremely verbose and makes it harder to find other debug
> log messages, so only print it at trace level.
>
> Signed-off-by: James Almer
> ---
> libavutil/tx.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
On 2/21/2024 1:32 PM, Lynne wrote:
Feb 21, 2024, 15:43 by jamr...@gmail.com:
The output of TX is extremely verbose and makes it harder to find other debug
log messages, so only print it at trace level.
Signed-off-by: James Almer
---
libavutil/tx.c | 10 +-
1 file changed, 5
On Tue, Feb 20, 2024 at 03:49:22AM +0100, Michael Niedermayer wrote:
> Fixes: out of array access.
>
> Earlier code assumes that a unscaled bayer to yuvj420 converter exists
> but the later code then skips yuvj420
>
> Signed-off-by: Michael Niedermayer
> ---
> libswscale/utils.c | 3 ++-
> 1
Le tiistaina 6. helmikuuta 2024, 17.56.32 EET flow gg a écrit :
>
Did you try to compute integral absolute values with the ad-hoc (floating
point) instruction instead of vneg/vmax? It should work since the sign is in
the same place, though I don't know if it will be faster.
--
レミ・デニ-クールモン
Anton Khirnov:
> ---
> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
> index 3f21815ba2..669c878c7f 100644
> --- a/tests/fate/ffmpeg.mak
> +++ b/tests/fate/ffmpeg.mak
> @@ -1,28 +1,3 @@
> -FATE_MAPCHAN-$(call FILTERDEMDECENCMUX, PAN, WAV, PCM_S16LE, PCM_S16LE, WAV,
> MD5_PROTOCOL) +=
Andreas Rheinhardt:
> It is undefined behaviour (see C11, 6.10.3 (4); see also
> 14dd0a9057019e97ff9438f6cc1502f6922acb85).
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/cbs_vp8.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git
On Tue, Feb 20, 2024 at 03:49:21AM +0100, Michael Niedermayer wrote:
> Suggested by: Niklas Haas in Ticket10824
>
> Fixes: Assertion failure
> Fixes: Ticket10824
>
> This reverts commit cedf589c09c567b72bf4c1a58db53d94622567e1.
> ---
> libswscale/swscale.c | 2 +-
> libswscale/utils.c | 10
On Fri, Feb 16, 2024 at 01:41:35PM -0800, Dale Curtis wrote:
> On Thu, Feb 15, 2024 at 2:35 PM Michael Niedermayer
> wrote:
>
> > FFMIN/MAX can evaluate their arguments multiple times so avio_rb32() might
> > be executed more than once
> >
>
> Thanks. Good catch. Fixed.
> mov.c |7 +++
On Sat, Feb 17, 2024 at 06:09:46PM +0100, Michael Niedermayer wrote:
> Fixes: out of array read
> Signed-off-by: Michael Niedermayer
> ---
> libswscale/utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
will apply patchset
[...]
--
Michael GnuPG fingerprint:
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/h264dec.c | 23 +--
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c
> index 9f5893c512..5cffeafc6b 100644
> --- a/libavcodec/h264dec.c
Andreas Rheinhardt:
> Postponed in 9f4708c22def8a0f13c3b2bc39baca928bb58aaa
> because the sample had not been uploaded at that time.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> tests/fate/image.mak | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git
Hello,
Le maanantaina 19. helmikuuta 2024, 13.13.43 EET flow gg a écrit :
> The reason for using m1+le8 instead of stride load + larger group
> multipliers is the same as in "[FFmpeg-devel] [PATCH 1/7] lavc/me_cmp: R-V
> V pix_abs."
>
> In the test, there is
>
> #define src (buf + 2 *
On Tue, 20 Feb 2024, Allan Cady via ffmpeg-devel wrote:
When the silencedetect audio filter is run against long files, the
output timestamps gradually lose precision as the scan proceeds further
into the file. This is because the output format specifier ("%.6g" in
libavutil/timestamp.h)
The SEI message read/write functions are called
via function pointers where the SEI message-specific
context is passed as void*. But the actual function
definitions use a pointer to their proper context
in place of void*, making the calls undefined behaviour.
Clang UBSan 17 warns about this.
This
av_get_sample/pix_fmt() return their respective enums
and are therefore not of the type int (*)(const char*),
yet they are called as-if they were of this type.
This works in practice, but is actually undefined behaviour.
With Clang 17 UBSan these violations are flagged, affecting lots
of tests.
Signed-off-by: Andreas Rheinhardt
---
fftools/ffprobe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index aa1153e709..95643f9a23 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -789,7 +789,7 @@ static inline int
I had a similar thought, as all timestamps would have the same issue.
This is my first contribution here, and I don't know the code very well, so I
was being cautious. I'm open to expanding the scope, but I'm sure I would need
some help doing it right and not breaking things.
For starters, I'm
This vp8dsp.h is from libavcodec/aarch64/vp8dsp.h
It simply changes AARCH64 to RISCV
libavcodec/arm/vp8dsp.h uses a similar method (arm in this header file
added 4 lines of other arm function declarations)
I want to simply use the same pattern
Rémi Denis-Courmont 于2024年2月22日周四 02:02写道：
> Hello,
Jpeg2000 decoder is decoding in native endian, so let's use the same workaround
as in fate-mxf-probe-applehdr10.
Fixes ticket #10868.
Signed-off-by: Marton Balint
---
tests/fate/mxf.mak | 2 +-
tests/ref/fate/mxf-probe-j2k | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Allows to avoid casting const away.
Signed-off-by: Andreas Rheinhardt
---
fftools/ffprobe.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 95643f9a23..e63935baba 100644
--- a/fftools/ffprobe.c
+++
Signed-off-by: Connor Worley
---
libavutil/Makefile | 2 +
libavutil/hashtable.c | 192
libavutil/hashtable.h | 40
libavutil/tests/hashtable.c | 108
4 files changed, 342 insertions(+)
create mode 100644
Offers a modest performance gain due to the switch from naive linear
probling to robin hood.
Signed-off-by: Connor Worley
---
libavcodec/dxvenc.c | 121
1 file changed, 33 insertions(+), 88 deletions(-)
diff --git a/libavcodec/dxvenc.c
The calls to the sei_decoded_picture_hash read and write functions
are performed with four pointer arguments; just because one
of them is unused by the callees does not mean that they
can be omitted: This is undefined behaviour.
(This was not recognized because the SEI_MESSAGE_RW macro
contains
This makes ffprobe match the rest of the codebase.
Signed-off-by: Andreas Rheinhardt
---
fftools/ffprobe.c | 47 ---
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 31081d19e2..ea225f14ab
Signed-off-by: Andreas Rheinhardt
---
fftools/ffprobe.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index e63935baba..31081d19e2 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -1860,7 +1860,8 @@ static void
.macro vabsaddu dst src tmp
- vneg.v \tmp, \src
- vmax.vv \tmp, \src, \tmp
+ vfabs.v \tmp, \src
vwaddu.wv \dst, \dst, \tmp
.endm
After making this change, the tests did not pass. I'm not quite clear on
how to understand the
Feb 21, 2024, 17:38 by jamr...@gmail.com:
> On 2/21/2024 1:32 PM, Lynne wrote:
>
>> Feb 21, 2024, 15:43 by jamr...@gmail.com:
>>
>>> The output of TX is extremely verbose and makes it harder to find other
>>> debug
>>> log messages, so only print it at trace level.
>>>
>>> Signed-off-by: James
From: Zhao Zhili
---
libavcodec/evc.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/libavcodec/evc.h b/libavcodec/evc.h
index 9711c760fe..e493455a42 100644
--- a/libavcodec/evc.h
+++ b/libavcodec/evc.h
@@ -141,15 +141,6 @@ enum {
// A.4.1: table A.1 allows at most 600 slice
On 2024-02-20 04:39 pm, Anton Khirnov wrote:
As for determining conflict of interest in case of dishonest TC
members, I don't think there is a general solution for it.
This is not about dishonesty. Imagine a TC member genuinely does not
self-assess or agree to a conflict of interest, does
On Thu, Feb 22, 2024 at 2:42 PM Zhao Zhili wrote:
>
> From: Zhao Zhili
>
> ---
> libavcodec/evc.h | 9 -
> 1 file changed, 9 deletions(-)
>
> diff --git a/libavcodec/evc.h b/libavcodec/evc.h
> index 9711c760fe..e493455a42 100644
> --- a/libavcodec/evc.h
> +++ b/libavcodec/evc.h
> @@
On 2/22/2024 12:16 AM, Lynne wrote:
I see...
If you keep the "Transform tree" printout on debug, lgtm.
Done. Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link
From: Wu Jianhua
Introduction at https://ieeexplore.ieee.org/document/9408666
passed files:
10b444_A_Kwai_3.bit
10b444_B_Kwai_3.bit
CodingToolsSets_D_Tencent_2.bit
IBC_A_Tencent_2.bit
IBC_B_Tencent_2.bit
IBC_C_Tencent_2.bit
IBC_D_Tencent_2.bit
IBC_E_Tencent_1.bit
From: Wu Jianhua
Co-authored-by: Nuo Mi
---
libavcodec/vvc/vvc_ctu.c | 76 +-
libavcodec/vvc/vvc_ctu.h | 1 +
libavcodec/vvc/vvc_mvs.c | 113 ++-
libavcodec/vvc/vvc_mvs.h | 2 +
4 files changed, 177 insertions(+), 15 deletions(-)
*** BLURB HERE ***
Nuo Mi (8):
avcodec/vvcdec: refact out deblock_bs to reduce duplicate code
avcodec/vvcdec: set CuPredMode table for chroma
avcodec/vvcdec: deblock_bs, fix intra check for IBC
avcodec/vvcdec: cabac, fix non_inter_flag, pred_mode_flag, amvr_shift
for IBC
For IBC, we'll utilize the check_available function.
However, neither MVP nor merge mode need to check the motion estimation region.
Let's rename it to avoid confusion.
---
libavcodec/vvc/vvc_mvs.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git
follow the spec
---
libavcodec/vvc/vvc_ctu.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c
index 36f98f5f2b..2e48f7bed8 100644
--- a/libavcodec/vvc/vvc_ctu.c
+++ b/libavcodec/vvc/vvc_ctu.c
@@ -1227,9 +1227,12 @@
From: Wu Jianhua
Signed-off-by: Wu Jianhua
Signed-off-by: Nuo Mi
---
libavcodec/vvc/vvc_ctu.c | 9 +--
libavcodec/vvc/vvc_ctu.h | 3 +++
libavcodec/vvc/vvc_mvs.c | 53 ++--
3 files changed, 44 insertions(+), 21 deletions(-)
diff --git
---
libavcodec/vvc/vvc_ctu.c | 2 +-
libavcodec/vvc/vvc_mvs.c | 4 ++--
libavcodec/vvc/vvc_mvs.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c
index b78a1417c7..00476c81e4 100644
--- a/libavcodec/vvc/vvc_ctu.c
+++
Intra Block Copy relies on reconstructed pixels from the current frame.
We skip IBC during the inter prediction stage and handle it during the
reconstruction stage.
---
libavcodec/vvc/vvc_inter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/vvc/vvc_inter.c
fix IBC_E_Tencent_1.bit
---
libavcodec/vvc/vvc_ctu.c | 24 +++-
libavcodec/vvc/vvc_intra.c | 6 --
2 files changed, 19 insertions(+), 11 deletions(-)
diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c
index 00476c81e4..2cf6e82f26 100644
---
---
libavcodec/vvc/vvc_filter.c | 176 +++-
1 file changed, 55 insertions(+), 121 deletions(-)
diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c
index 5fa711c9e0..ca541fd997 100644
--- a/libavcodec/vvc/vvc_filter.c
+++
---
libavcodec/vvc/vvc_cabac.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/vvc/vvc_cabac.c b/libavcodec/vvc/vvc_cabac.c
index 4342dfc342..5e24a1b677 100644
--- a/libavcodec/vvc/vvc_cabac.c
+++ b/libavcodec/vvc/vvc_cabac.c
@@ -1196,10 +1196,10 @@
An Intra Block Copy clip may use different modes for luma and chroma.
For example, MODE_IBC for luma and MODE_INTRA for chroma.
We have to check luma and chroma CuPredMode (cpm) separately.
---
libavcodec/vvc/vvc_filter.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
64 matches
Mail list logo
