Re: [FFmpeg-devel] [PATCH 1/3] avcodec/Makefile: Remove redundant dependencies on hevc_data.o

2024-03-28 Thread Andreas Rheinhardt
Andreas Rheinhardt: > hevc_data.c only provides ff_hevc_diag_scan tables and > neither the QSV HEVC encoder nor the HEVC parser use these > directly and the indirect dependency is already accounted > for in the dependencies of the hevcparse subsystem since >

Re: [FFmpeg-devel] [PATCH v3 1/6] avcodec/mpeg12dec: extract only one type of CC substream

2024-03-28 Thread Anton Khirnov
Quoting Marth64 (2024-03-12 07:00:00) > In MPEG-2 user data, there can be different types of Closed Captions > formats embedded (A53, SCTE-20, or DVD). The current behavior of the > CC extraction code in the MPEG-2 decoder is to not be aware of > multiple formats if multiple exist, therefore

[FFmpeg-devel] [PATCH] lavc/vaapi_encode: convert from lambda to qp

2024-03-28 Thread Xiang, Haihao
From: Haihao Xiang When AV_CODEC_FLAG_QSCALE is set, the value of avctx->global_quality is lambda. Signed-off-by: Haihao Xiang --- libavcodec/vaapi_encode.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index

Re: [FFmpeg-devel] [PATCH] V2 tests/fate/filter-audio.mak: add test for ATEMPO audio filter

2024-03-28 Thread Anton Khirnov
Quoting Rajiv Harlalka (2024-03-21 11:13:46) > Please find an updated patch for tests on the atempo audio filter > > From 30475d6f076d5236ee534002fffb01958ef0dfc1 Mon Sep 17 00:00:00 2001 > From: Rajiv Harlalka > Date: Thu, 21 Mar 2024 13:35:29 +0530 > Subject: [PATCH v2]

Re: [FFmpeg-devel] [RFC] Channels

2024-03-28 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-03-27 22:54:14) > On Fri, Mar 22, 2024 at 11:29:31AM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-03-22 03:25:25) > [...] > > > alternative is "wont fix" for all such cases, > > > > IMO it's not, in general, a bug, so EWONTFIX is the

[FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-28 Thread tong1 . wu-at-intel . com
From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0). Signed-off-by: Tong Wu --- libavcodec/hevc_ps.c | 20

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-28 Thread Hendrik Leppkes
On Thu, Mar 28, 2024 at 10:12 AM wrote: > > From: Tong Wu > > HEVCHdrParams* receives a pointer which points to a dynamically > allocated memory block. It causes the memcmp always returning 1. > Add a function to do the comparision. A condition is also added to > avoid malloc(0). > >

[FFmpeg-devel] [PATCH v1] lavc/vaapi_encode: Add VAAPI version check for BLBRC

2024-03-28 Thread fei . w . wang-at-intel . com
From: Fei Wang Fix build fail when VAAPI version less than 0.39.2. Signed-off-by: Fei Wang --- libavcodec/vaapi_encode.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 940f0678a5..c4b5411e68

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: Fix error code in decode_extradata

2024-03-28 Thread Anton Khirnov
Quoting Zhao Zhili (2024-03-26 03:59:00) > From: Zhao Zhili > > --- > libavcodec/h264_parse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c > index 3378650fd5..09d3b9dc05 100644 > --- a/libavcodec/h264_parse.c > +++

[FFmpeg-devel] [PATCH] avcodec/ac3: Implement float_to_fixed24 for aarch64 neon

2024-03-28 Thread Geoff Hill
Tested on AWS Graviton2 (t4g.medium), NixOS 23.11, GCC 12.3: float_to_fixed24_c: 2462.7 float_to_fixed24_neon: 513.5 Signed-off-by: Geoff Hill --- libavcodec/aarch64/Makefile | 2 ++ libavcodec/aarch64/ac3dsp_init_aarch64.c | 36 +++

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/demux: stop calling avcodec_close()

2024-03-28 Thread Anton Khirnov
Quoting Kieran Kunhya (2024-03-27 15:13:12) > On Wed, 27 Mar 2024 at 14:03, Michael Niedermayer > wrote: > > > On Fri, Feb 09, 2024 at 03:19:58PM +, Anton Khirnov wrote: > > > ffmpeg | branch: master | Anton Khirnov | Thu Feb > > 1 08:57:24 2024 +0100|

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000htdec: Check M_b / magp before using it in a shift

2024-03-28 Thread Tomas Härdin
tor 2024-03-28 klockan 03:48 +0100 skrev Michael Niedermayer: > On Wed, Mar 27, 2024 at 11:13:48AM +0100, Tomas Härdin wrote: > > mån 2024-03-25 klockan 21:04 +0100 skrev Michael Niedermayer: > > > On Mon, Mar 25, 2024 at 08:13:13PM +0100, Michael Niedermayer > > > wrote: > > > > On Thu, Mar 21,

Re: [FFmpeg-devel] [PATCH 3/7 v4] avutil/frame: use the same data pointer as the source entry when cloning side data

2024-03-28 Thread Anton Khirnov
Quoting James Almer (2024-03-28 04:12:06) > src->data does not need to match src->buf->data When does it not? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] [PATCH 3/7 v4] avutil/frame: use the same data pointer as the source entry when cloning side data

2024-03-28 Thread Anton Khirnov
Quoting James Almer (2024-03-28 12:33:47) > On 3/28/2024 8:29 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-03-28 04:12:06) > >> src->data does not need to match src->buf->data > > > > When does it not? > > It always matches for side data allocated by us within the libraries, > but

Re: [FFmpeg-devel] [PATCH] avfilter: fix YUV colorspace negotiation for YUVJ

2024-03-28 Thread Niklas Haas
On Mon, 25 Mar 2024 16:10:55 +0100 Niklas Haas wrote: > On Mon, 25 Mar 2024 14:40:44 +0100 Niklas Haas wrote: > > From: Niklas Haas > > > > Ironically, despite being introduced to make YUVJ unnecessary, the new > > YUV negotiation logic failed to actually negotiate YUVJ formats > > themselves

[FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-28 Thread tong1 . wu-at-intel . com
From: Tong Wu HEVCHdrParams* receives a pointer which points to a dynamically allocated memory block. It causes the memcmp always returning 1. Add a function to do the comparision. A condition is also added to avoid malloc(0). Signed-off-by: Tong Wu --- libavcodec/hevc_ps.c | 20

Re: [FFmpeg-devel] [PATCH 6/7 v4] avcodec/decode: make the AVFrameSideData helper wrappers not depend on frames

2024-03-28 Thread Anton Khirnov
Quoting James Almer (2024-03-28 04:12:09) > They will be useful to fill arrays stored in other structs. > > Signed-off-by: James Almer > --- > libavcodec/av1dec.c | 7 +-- > libavcodec/cri.c| 3 +- > libavcodec/decode.c | 99 +++-- >

Re: [FFmpeg-devel] [PATCH v2 8/8] avcodec/dovi_rpu: attach ext blocks to frames

2024-03-28 Thread Niklas Haas
On Sat, 23 Mar 2024 20:19:57 +0100 Niklas Haas wrote: > From: Niklas Haas > > --- > libavcodec/dovi_rpu.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c > index b3defd87bda..2b4d2b470c2 100644 > ---

[FFmpeg-devel] [PATCH 7/7 v5] avcodec/hevcdec: export global side data in AVCodecContext

2024-03-28 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.h | 2 +- libavcodec/h2645_sei.c | 215 + libavcodec/h2645_sei.h | 2 + libavcodec/hevcdec.c | 4 + libavcodec/pthread_frame.c | 11 ++ 5 files changed, 141 insertions(+), 93

[FFmpeg-devel] [PATCH 5/7 v5] avutil/mastering_display_metadata: add a new allocator function that returns a size

2024-03-28 Thread James Almer
av_mastering_display_metadata_alloc() is not useful in scenarios where you need to know the runtime size of AVMasteringDisplayMetadata. Signed-off-by: James Almer --- libavutil/mastering_display_metadata.c | 13 + libavutil/mastering_display_metadata.h | 9 + 2 files

[FFmpeg-devel] [PATCH 6/7 v5] avcodec/decode: add AVFrameSideData helper wrappers that don't depend on frames

2024-03-28 Thread James Almer
They will be useful to fill arrays stored in other structs. Signed-off-by: James Almer --- libavcodec/decode.c | 106 libavcodec/decode.h | 24 ++ 2 files changed, 112 insertions(+), 18 deletions(-) diff --git a/libavcodec/decode.c

[FFmpeg-devel] [PATCH 4/7 v5] avutil/frame: add helper to remove side data of a given type from an array

2024-03-28 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 6 ++ libavutil/frame.h | 5 + 2 files changed, 11 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index d37f1511e8..10b9f7fa94 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -937,6 +937,12 @@ const

Re: [FFmpeg-devel] [PATCH] libavformat/flac_picture: Don't return AVERROR_INVALIDDATA for errors with flac picture mimetype

2024-03-28 Thread Michael Niedermayer
On Wed, Mar 27, 2024 at 01:05:52PM -0700, Dale Curtis wrote: > Bump on this patch -- it still applies cleanly. We're still seeing files in > the wild like this. will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add MJPEG support

2024-03-28 Thread Andreas Rheinhardt
gnattu via ffmpeg-devel: > For example: > ./ffmpeg -hwaccel videotoolbox\ >-i INPUT -c:v mjpeg_videotoolbox\ > out.mp4 > > This encoder does not have many options and can only use ``-q:v` to control > quality. > > Signed-off-by: Gnattu OC > --- > Changelog| 1 + >

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: remove `if ((ret = ...) < 0)` pattern

2024-03-28 Thread Marth64
Thanks all for the feedback. I think I took the idea too literally here, and agree in retrospect it’s not necessary at this point. The good news is while I made this change, I didn’t find any pre-existing bugs in this demuxer due to using the pattern. (Because while I was writing it, I had made

Re: [FFmpeg-devel] [PATCH 3/4] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-28 Thread Antoine Soulier via ffmpeg-devel
I don't think it's "easy" seekable. We cannot move to an arbitrary position: - There is no start-code - The frame size can be variable (not generated by the proposed encoder implementation, but allowed). The only possibility I see is checking that the frame size looks valid for multiple frames.

Re: [FFmpeg-devel] Fwd: [PATCH] fftools/ffplay: split filters & show modes cycling into separate keys

2024-03-28 Thread Ondřej Fiala
Just want to make sure, since I am aware of some cases of large commercial email providers blocking my email provider... did anyone with a gmail address receive this patch? Thanks, Ondřej On Tue Mar 26, 2024 at 3:18 AM CET, Ondřej Fiala wrote: > I am forwarding a patch from December that seems

[FFmpeg-devel] [PATCH 2/7 v5] avutil/frame: add a flag to allow overwritting existing entries

2024-03-28 Thread James Almer
Enable it only for side data types that don't allow more than one entry. Signed-off-by: James Almer --- libavutil/frame.c | 59 +-- libavutil/frame.h | 30 +++- libavutil/tests/side_data_array.c | 52

[FFmpeg-devel] [PATCH 3/7 v5] avutil/frame: use the same data information as the source entry when cloning side data

2024-03-28 Thread James Almer
src->{data,size} does not need to match src->buf->{data,size}. Signed-off-by: James Almer --- libavutil/frame.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 9c3569db0e..d37f1511e8 100644 ---

[FFmpeg-devel] [PATCH 1/7 v5] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-28 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 19 +++ libavutil/frame.h | 24 2 files changed, 43 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index ef1613c344..87cc8450c8 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@

Re: [FFmpeg-devel] [PATCH v3 1/6] avcodec/mpeg12dec: extract only one type of CC substream

2024-03-28 Thread Marth64
>Is it not possible to extract all of them simultaneously? Each of the extractable CC bitstreams would need to be exposed as an independent eia608 AVStream, because each represents a distinct stream. They can’t be commingled (which is what this patch addressed). I’m not sure of a way to sanely

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: split filters & show modes cycling into separate keys

2024-03-28 Thread epirat07
On 28 Mar 2024, at 17:46, Ondřej Fiala wrote: > Just want to make sure, since I am aware of some cases of large commercial > email > providers blocking my email provider... did anyone with a gmail address > receive > this patch? > Yes > Thanks, > Ondřej > > On Tue Mar 26, 2024 at 3:18 AM

Re: [FFmpeg-devel] [PATCH 6/7 v4] avcodec/decode: make the AVFrameSideData helper wrappers not depend on frames

2024-03-28 Thread James Almer
On 3/28/2024 8:32 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-28 04:12:09) They will be useful to fill arrays stored in other structs. Signed-off-by: James Almer --- libavcodec/av1dec.c | 7 +-- libavcodec/cri.c| 3 +- libavcodec/decode.c | 99

[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add MJPEG support

2024-03-28 Thread gnattu via ffmpeg-devel
For example: ./ffmpeg -hwaccel videotoolbox\ -i INPUT -c:v mjpeg_videotoolbox\ out.mp4 This encoder does not have many options and can only use ``-q:v` to control quality. Signed-off-by: Gnattu OC --- Changelog| 1 + configure| 2 ++

Re: [FFmpeg-devel] [PATCH 1/7 v4] avutil/frame: add a flag to allow overwritting existing entries

2024-03-28 Thread Anton Khirnov
Quoting James Almer (2024-03-28 04:12:04) > Enable it only for side data types that don't allow more than one entry. > > Signed-off-by: James Almer > --- > libavutil/frame.c | 59 --- > libavutil/frame.h | 27 +- >

[FFmpeg-devel] [PATCH v11 6/8] libavformat/webp: add WebP demuxer

2024-03-28 Thread Thilo Borgmann via ffmpeg-devel
From: Josef Zlomek Adds the demuxer of animated WebP files. It supports non-animated, animated, truncated, and concatenated files. Reading from a pipe (and other non-seekable inputs) is also supported. The WebP demuxer splits the input stream into packets containing one frame. It also marks the

[FFmpeg-devel] [PATCH v11 8/8] avcodec/webp: export XMP metadata

2024-03-28 Thread Thilo Borgmann via ffmpeg-devel
--- libavcodec/webp.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 832ede52fc..b9feaa5bf0 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -38,8 +38,8 @@ * @author Josef

Re: [FFmpeg-devel] [RFC] Channels

2024-03-28 Thread Tomas Härdin
fre 2024-03-22 klockan 03:25 +0100 skrev Michael Niedermayer: > Hi all > > we have code like > st->codecpar->ch_layout.nb_channels = avio_rb32(pb); > > and then somewhere there is some code that uses this by first > allocating > an array and that then hits OOM > (it was this here: >     map =

Re: [FFmpeg-devel] [PATCH 2/2] examples/decode_filter_video: Add loop for draining the filtergraph

2024-03-28 Thread Tobias Rapp
On 27/03/2024 14:04, Tobias Rapp wrote: On 27/03/2024 13:53, Anton Khirnov wrote: Quoting Tobias Rapp (2024-03-27 13:46:40) On 27/03/2024 13:06, Stefano Sabatini wrote: On date Wednesday 2024-03-27 11:51:31 +0100, Tobias Rapp wrote: Depending on the filters used the filtergraph can produce

Re: [FFmpeg-devel] [PATCH 2/7 v4] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-28 Thread Anton Khirnov
Quoting James Almer (2024-03-28 04:12:05) > Signed-off-by: James Almer > --- > libavutil/frame.c | 53 +++ > libavutil/frame.h | 34 ++ > 2 files changed, 87 insertions(+) > > diff --git a/libavutil/frame.c

Re: [FFmpeg-devel] [PATCH 6/7 v4] avcodec/decode: make the AVFrameSideData helper wrappers not depend on frames

2024-03-28 Thread Anton Khirnov
Quoting James Almer (2024-03-28 12:36:37) > On 3/28/2024 8:32 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-03-28 04:12:09) > >> They will be useful to fill arrays stored in other structs. > >> > >> Signed-off-by: James Almer > >> --- > >> libavcodec/av1dec.c | 7 +-- > >>

Re: [FFmpeg-devel] [PATCH 2/7 v4] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-28 Thread James Almer
On 3/28/2024 8:27 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-28 04:12:05) Signed-off-by: James Almer --- libavutil/frame.c | 53 +++ libavutil/frame.h | 34 ++ 2 files changed, 87 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH 2/7 v4] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-28 Thread Anton Khirnov
Quoting James Almer (2024-03-28 12:49:08) > On 3/28/2024 8:27 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-03-28 04:12:05) > >> Signed-off-by: James Almer > >> --- > >> libavutil/frame.c | 53 +++ > >> libavutil/frame.h | 34

[FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder

2024-03-28 Thread Mark Samuelson
Thank you for the notes, here is a new patch that incorporates your suggestions. You are right, the default value of 12 for gop_size is suprising, I didn't know about it before now. --- libavcodec/mf_utils.h | 5 + libavcodec/mfenc.c| 33 +++-- 2 files

Re: [FFmpeg-devel] [PATCH v2 0/8] Dolby Vision extension block parsing

2024-03-28 Thread Niklas Haas
On Sat, 23 Mar 2024 20:19:49 +0100 Niklas Haas wrote: > Changes since v1: > - Rebased onto master > - Dropped av_dovi_metadata_alloc_ext(), instead statically allocate > space for 32 extension blocks (AV_DOVI_MAX_EXT_BLOCKS) > - Removed misleading comment on nlq_pivots > - Fix memory leak on

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of memcmp losing effectiveness

2024-03-28 Thread Wu, Tong1
>From: ffmpeg-devel On Behalf Of >Hendrik Leppkes >Sent: Thursday, March 28, 2024 5:43 PM >To: FFmpeg development discussions and patches de...@ffmpeg.org> >Subject: Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of >memcmp losing effectiveness > >On Thu, Mar 28, 2024 at 10:12 AM

Re: [FFmpeg-devel] [PATCH 2/7 v4] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-28 Thread James Almer
On 3/28/2024 9:19 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-28 12:49:08) On 3/28/2024 8:27 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-28 04:12:05) Signed-off-by: James Almer --- libavutil/frame.c | 53 +++

Re: [FFmpeg-devel] [PATCH 3/7 v4] avutil/frame: use the same data pointer as the source entry when cloning side data

2024-03-28 Thread James Almer
On 3/28/2024 8:29 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-28 04:12:06) src->data does not need to match src->buf->data When does it not? It always matches for side data allocated by us within the libraries, but those are not the only callers, so this function should honor the

Re: [FFmpeg-devel] [PATCH 1/7 v4] avutil/frame: add a flag to allow overwritting existing entries

2024-03-28 Thread Anton Khirnov
Quoting James Almer (2024-03-28 12:41:40) > On 3/28/2024 8:23 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-03-28 04:12:04) > >> Enable it only for side data types that don't allow more than one entry. > >> > >> Signed-off-by: James Almer > >> --- > >> libavutil/frame.c

[FFmpeg-devel] [PATCH v11 4/8] libavcodec/webp: add support for animated WebP

2024-03-28 Thread Thilo Borgmann via ffmpeg-devel
From: Josef Zlomek Fixes: 4907 Adds support for decoding of animated WebP. The WebP decoder adds the animation related features according to the specs: https://developers.google.com/speed/webp/docs/riff_container#animation The frames of the animation may be smaller than the image canvas.

[FFmpeg-devel] [PATCH v11 3/8] avcodec/bsf: Add awebp2webp bitstream filter

2024-03-28 Thread Thilo Borgmann via ffmpeg-devel
Splits a packet containing a webp animations into one non-compliant packet per frame of the animation. Skips RIFF and WEBP chunks for those packets except for the first. Copyies ICC, EXIF and XMP chunks first into each of the packets except for the first. --- configure | 1

[FFmpeg-devel] [PATCH v11 5/8] avcodec/webp: make init_canvas_frame static

2024-03-28 Thread Thilo Borgmann via ffmpeg-devel
--- libavcodec/webp.c | 142 +++--- 1 file changed, 70 insertions(+), 72 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 293bb485de..832ede52fc 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -1379,7 +1379,76 @@ static int

[FFmpeg-devel] [PATCH v11 0/8] webp: add support for animated WebP decoding

2024-03-28 Thread Thilo Borgmann via ffmpeg-devel
VP8 decoder decoupled again The whole animated sequence goes into one packet The (currently public) bitstream filter splits animations up into non-conformant packets Now with XMP metadata support (as string, like MOV) Patch 5/8 is still there for making changes in lavc/webp reviewable but shall

[FFmpeg-devel] [PATCH v11 7/8] fate: add test for animated WebP

2024-03-28 Thread Thilo Borgmann via ffmpeg-devel
--- tests/fate/image.mak | 3 +++ tests/ref/fate/webp-anim | 22 ++ 2 files changed, 25 insertions(+) create mode 100644 tests/ref/fate/webp-anim diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 7c0e0fec08..4620d65b3f 100644 --- a/tests/fate/image.mak +++

[FFmpeg-devel] [PATCH v11 1/8] avcodec/webp: remove unused definitions

2024-03-28 Thread Thilo Borgmann via ffmpeg-devel
--- libavcodec/webp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 9308ea2b69..2301699e5a 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -59,8 +59,6 @@ #define VP8X_FLAG_ALPHA 0x10 #define VP8X_FLAG_ICC

[FFmpeg-devel] [PATCH v11 2/8] avcodec/webp: separate VP8 decoding

2024-03-28 Thread Thilo Borgmann via ffmpeg-devel
--- libavcodec/webp.c | 50 +-- 1 file changed, 44 insertions(+), 6 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 2301699e5a..d6af48585e 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -194,6 +194,7 @@ typedef struct

Re: [FFmpeg-devel] [PATCH 3/4] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-28 Thread Paul B Mahol
This format actually supports seeking. The proposed solution here is sub-optimal. On Wed, Mar 27, 2024 at 11:22 PM Antoine Soulier via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for > test purpose. This is the format

Re: [FFmpeg-devel] [PATCH] avfilter/vf_colorspace: use colorspace negotiation API

2024-03-28 Thread Nicolas Gaullier
>De : Nicolas Gaullier >Envoyé : lundi 25 mars 2024 18:59 > >Fixes a regression due to the fact that the colorspace filter does not use the >new API introduced by 8c7934f73ab6c568acaa. >The scale filter uses it since 45e09a30419cc2a7251e, and the setparams filter >since 3bf80df3ccd32aed23f0. >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_colorspace: use colorspace negotiation API

2024-03-28 Thread Nicolas Gaullier
>>Example: >>ffmpeg -f lavfi -i testsrc -vf setparams=color_primaries=bt470bg: >>color_trc=smpte170m:colorspace=bt470bg,colorspace=bt709:range=tv,scale >>,showinfo -f null -frames 1 - >> >>Before: >> color_range:unknown color_space:unknown color_primaries:bt709 ... >>After: >> color_range:tv

Re: [FFmpeg-devel] [PATCH] tests/audiogen: Fix total RIFF chunk size

2024-03-28 Thread Tobias Rapp
On 26/03/2024 13:33, Tobias Rapp wrote: On 15/03/2024 09:53, Tobias Rapp wrote: The "RIFF" identifier and chunk size fields should not be included within the size value. ---   tests/audiogen.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/audiogen.c

Re: [FFmpeg-devel] [PATCH 1/7 v4] avutil/frame: add a flag to allow overwritting existing entries

2024-03-28 Thread James Almer
On 3/28/2024 8:23 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-28 04:12:04) Enable it only for side data types that don't allow more than one entry. Signed-off-by: James Almer --- libavutil/frame.c | 59 --- libavutil/frame.h

Re: [FFmpeg-devel] [PATCH 1/7 v4] avutil/frame: add a flag to allow overwritting existing entries

2024-03-28 Thread James Almer
On 3/28/2024 9:21 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-28 12:41:40) On 3/28/2024 8:23 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-28 04:12:04) Enable it only for side data types that don't allow more than one entry. Signed-off-by: James Almer ---

[FFmpeg-devel] [PATCH v5 1/1] avformat/demux: Add duration_probesize AVOption

2024-03-28 Thread Nicolas Gaullier
Yet another probesize used to get the durations when estimate_timings_from_pts is required. It is aimed at users interested in better durations probing for itself, or because using avformat_find_stream_info indirectly and requiring exact values: for concatdec for example, especially if

[FFmpeg-devel] [PATCH v5 0/1] avformat/demux: Add duration_probesize AVOption

2024-03-28 Thread Nicolas Gaullier
V5 including all Stefano's feedback. Notes: - I have largely reworked the texi, I hope the use case is more clear. - I have rewrote "250K up to 16M" to "25 up to 16M" to be clear about the K/M units. - @seealso seems not supported in my doxy environment, so I simply moved all the @sa to @see

Re: [FFmpeg-devel] [PATCH 3/4] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-28 Thread Stefano Sabatini
On date Wednesday 2024-03-27 22:21:44 +, ffmpeg-devel Mailing List wrote: > A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for > test purpose. This is the format implemented here. > > Signed-off-by: Antoine Soulier > --- > doc/muxers.texi | 6 ++ >

[FFmpeg-devel] [PATCH v10 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-28 Thread Marth64
RCWT (Raw Captions With Time) is a format native to ccextractor, a commonly used OSS tool for processing 608/708 Closed Captions (CC). RCWT can be used to archive the original extracted CC bitstream. The muxer was added in January 2024. In this commit, add the demuxer. One can now demux RCWT

[FFmpeg-devel] [PATCH v10 4/5] doc/muxers: refresh the RCWT muxer's doc to be consistent with the demuxer

2024-03-28 Thread Marth64
Signed-off-by: Marth64 --- doc/muxers.texi | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index a10a8e216f..4161401059 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -3038,19 +3038,18 @@ ogg files can

[FFmpeg-devel] [PATCH v10 0/5] RCWT Closed Captions demuxer (v10)

2024-03-28 Thread Marth64
Since v7/8: * Addresses last known feedback (about av_assert call) * Changelog entry removed, since v7.0 is cut and there is no "next" space yet (will make patch once available) Signed-off-by: Marth64 -- 2.34.1 ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH v10 1/5] avformat/subtitles: extend ff_subtitles_queue_insert() to support not yet available events

2024-03-28 Thread Marth64
If ff_subtitles_queue_insert() were given a NULL buffer with 0 length, it would still attempt to grow the packet or memcpy depending on if merge option is enabled. In this commit, allow passing a NULL buffer with 0 length without attempting to do such operations. This way, if a subtitle demuxer

[FFmpeg-devel] [PATCH v10 3/5] avformat/rcwtenc: remove repeated documentation

2024-03-28 Thread Marth64
The high level summary of RCWT can be delegated doc/muxers, which makes it easier to maintain and more consistent with the documentation of the demuxer. Signed-off-by: Marth64 --- libavformat/rcwtenc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavformat/rcwtenc.c

[FFmpeg-devel] [PATCH v10 5/5] doc/indevs: update CC extraction example to use RCWT muxer

2024-03-28 Thread Marth64
Signed-off-by: Marth64 --- doc/indevs.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index d1b2bacf8b..fc14737181 100644 --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -1069,9 +1069,9 @@ ffplay -f lavfi

[FFmpeg-devel] [PATCH 1/2] configure,etc: unify shebang usage

2024-03-28 Thread J. Dekker
Signed-off-by: J. Dekker --- configure | 3 ++- doc/texidep.pl| 2 +- ffbuild/libversion.sh | 1 + tests/fate-run.sh | 2 +- tests/fate.sh | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 2d46ef0b9c..d332f18e3d

Re: [FFmpeg-devel] [PATCH v9 0/5] RCWT Closed Captions demuxer (v9)

2024-03-28 Thread Marth64
Stefano, v10 coming shortly. Thank you! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 4/4] Changelog: Add LC3/LC3plus decoding/encoding support

2024-03-28 Thread Stefano Sabatini
On date Wednesday 2024-03-27 22:21:45 +, ffmpeg-devel Mailing List wrote: > Signed-off-by: Antoine Soulier > --- > Changelog | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Changelog b/Changelog > index 934241a965..2282f8ca76 100644 > --- a/Changelog > +++ b/Changelog > @@ -37,6

Re: [FFmpeg-devel] [PATCH v9 0/5] RCWT Closed Captions demuxer (v9)

2024-03-28 Thread Stefano Sabatini
On date Tuesday 2024-03-26 17:07:01 +0100, Stefano Sabatini wrote: > On date Tuesday 2024-03-26 10:29:18 -0500, Marth64 wrote: > > Ping if possible. The patches still apply. 3 of the 5 patches are > > documentation only and the demuxer itself is much smaller now. The muxer > > already made it in,

Re: [FFmpeg-devel] [PATCH] avformat/flac_picture: print a warning when mimetype is unknown

2024-03-28 Thread Michael Niedermayer
On Thu, Mar 28, 2024 at 05:08:42PM -0300, James Almer wrote: > It's not an error since bba6df9ac7bd8386d92e1a7f5c737ca4e575fcc. > > Signed-off-by: James Almer > --- > libavformat/flac_picture.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 2/2] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-28 Thread Andreas Rheinhardt
Antoine Soulier via ffmpeg-devel: > A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for > test purpose. This is the format implemented here. > > Signed-off-by: Antoine Soulier > --- > Changelog| 1 + > doc/muxers.texi | 6 ++ >

[FFmpeg-devel] [PATCH 2/2] configure: simplify bigendian check

2024-03-28 Thread J. Dekker
Signed-off-by: J. Dekker --- configure | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/configure b/configure index d332f18e3d..0ff1ff0335 100755 --- a/configure +++ b/configure @@ -6108,11 +6108,7 @@ extern_prefix=${sym%%ff_extern*} check_cc pragma_deprecated ""

Re: [FFmpeg-devel] [PATCH 2/3] lavf/srtdec: Permit streaming input

2024-03-28 Thread Tomas Härdin
Here as well From 6d0684ca6fe02d80fc07a622fb85445a6917c29f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Thu, 28 Mar 2024 22:15:18 +0100 Subject: [PATCH 2/3] lavf/srtdec: Permit streaming input This is largely a rewrite. Read packets in srt_read_packet() rather than

Re: [FFmpeg-devel] [PATCH 1/3] lavf/subtitles: Do not eat \n\n

2024-03-28 Thread Tomas Härdin
Oops, forgot to actually attach the patch From fccc13f728c50a676d20f3ca5b822fa1da60b259 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Thu, 28 Mar 2024 20:30:37 +0100 Subject: [PATCH 1/3] lavf/subtitles: Do not eat \n\n --- libavformat/subtitles.c | 15 ++- 1

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-28 Thread Stefano Sabatini
On date Wednesday 2024-03-27 22:21:43 +, ffmpeg-devel Mailing List wrote: > The LC3 audio codec is the default codec of Bluetooth LE audio. > This is a wrapper over the liblc3 library (https://github.com/google/liblc3). > > Signed-off-by: Antoine Soulier > --- > doc/encoders.texi |

Re: [FFmpeg-devel] Fixes #10509

2024-03-28 Thread Poorva
> On Tue, Mar 26, 2024 at 2:36 AM Poorva <2003gaikarpoo...@gmail.com> wrote: >> >> > > On Mon, Mar 25, 2024 at 2:04 AM Marton Balint wrote: >> >> >> >> On Sun, 24 Mar 2024, Poorva wrote: >> >> > From 0874a55ad33bb4df2789cbafc5247c0ae3d97e6a Mon Sep 17 00:00:00 2001 >> > From: PoorvaGaikar >> >

[FFmpeg-devel] [PATCH 2/2] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-28 Thread Antoine Soulier via ffmpeg-devel
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for test purpose. This is the format implemented here. Signed-off-by: Antoine Soulier --- Changelog| 1 + doc/muxers.texi | 6 ++ libavformat/Makefile | 2 + libavformat/allformats.c | 2 +

[FFmpeg-devel] [PATCH 1/2] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

2024-03-28 Thread Antoine Soulier via ffmpeg-devel
The LC3 audio codec is the default codec of Bluetooth LE audio. This is a wrapper over the liblc3 library (https://github.com/google/liblc3). Signed-off-by: Antoine Soulier --- Changelog | 4 + configure | 6 ++ doc/encoders.texi | 57

[FFmpeg-devel] [PATCH 2/3] lavf/srtdec: Permit streaming input

2024-03-28 Thread Tomas Härdin
I am once again asking more people on this list to peruse https://langsec.org/ /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

[FFmpeg-devel] [PATCH 3/3] lavf/subtitles: Unfix ticket #5032

2024-03-28 Thread Tomas Härdin
Obviously the most controversial patch in this set. I'd like to know what program exactly that produced the broken file in ticket #5032 so that we can send the guilty party to parsing jail More seriously, eating any run of CR CR CR... is incredibly broken and is part of the reason for the

Re: [FFmpeg-devel] [PATCH 1/4] configure: Add option for enabling LC3/LC3plus wrapper

2024-03-28 Thread Stefano Sabatini
On date Wednesday 2024-03-27 22:21:42 +, ffmpeg-devel Mailing List wrote: > Signed-off-by: Antoine Soulier > --- > configure | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/configure b/configure > index 2a1d22310b..4262b96117 100755 > --- a/configure > +++ b/configure > @@

[FFmpeg-devel] [PATCH] avformat/flac_picture: print a warning when mimetype is unknown

2024-03-28 Thread James Almer
It's not an error since bba6df9ac7bd8386d92e1a7f5c737ca4e575fcc. Signed-off-by: James Almer --- libavformat/flac_picture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flac_picture.c b/libavformat/flac_picture.c index 20df0192d4..c9f3f11edd 100644 ---

Re: [FFmpeg-devel] [PATCH 3/4] avformat/lc3: Add file format for LC3/LC3plus transport

2024-03-28 Thread Paul B Mahol
On Thu, Mar 28, 2024 at 5:40 PM Antoine Soulier wrote: > I don't think it's "easy" seekable. > We cannot move to an arbitrary position: > - There is no start-code > Not relevant. > - The frame size can be variable (not generated by the proposed encoder > implementation, but allowed). > Not

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/hls.c: support in-stream ID3 metadata update.

2024-03-28 Thread Romain Beauxis
On Mon, Mar 25, 2024, 19:58 Romain Beauxis wrote: > This patch adds support for updating HLS metadata passed as ID3 frames. > > This seems like a pretty straight-forward improvement. Updating the > metadaata of the first stream seems to be the mechanism is other places > in the code and works as

Re: [FFmpeg-devel] [PATCH] V2 tests/fate/filter-audio.mak: add test for ATEMPO audio filter

2024-03-28 Thread Rajiv Harlalka
On Thu, 28 Mar 2024 at 1:52 PM, Anton Khirnov wrote: > > atempo uses floats for processing, are you sure this > will produce > > exactly the same results everywhere? Tried replicating in some available environments I had and it worked fine, though could not relate with the test not working

[FFmpeg-devel] [PATCH 01/18] avcodec/mips/ac3dsp_mips: Add missing includes

2024-03-28 Thread Andreas Rheinhardt
Likely broken in d7a75d21635eab4f4a1efea22945933059c2e36f. Signed-off-by: Andreas Rheinhardt --- libavcodec/mips/ac3dsp_mips.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/mips/ac3dsp_mips.c b/libavcodec/mips/ac3dsp_mips.c index e97a412922..cc49ba3888 100644 ---

[FFmpeg-devel] [PATCH 11/18] lib*/version: Use static_assert for static asserts

2024-03-28 Thread Andreas Rheinhardt
Also update the checks that guard against inserting a new enum entry in the middle of a range. Signed-off-by: Andreas Rheinhardt --- libavcodec/version.c| 16 +++- libavdevice/version.c | 5 +++-- libavfilter/version.c | 5 +++-- libavformat/version.c | 5 +++--

[FFmpeg-devel] [PATCH 06/18] postproc/postprocess: Don't generally include arch-specific headers

2024-03-28 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libpostproc/postprocess.c | 3 ++- libpostproc/postprocess_template.c | 5 - 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libpostproc/postprocess.c b/libpostproc/postprocess.c index 0586e458b4..8f4de8b1e1 100644 ---

[FFmpeg-devel] [PATCH 17/18] avutil/internal: Move avpriv_set_systematic_pal2 decl to imgutils_internal.h

2024-03-28 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/bmpenc.c | 2 +- libavcodec/gif.c | 1 + libavcodec/pcxenc.c | 2 +- libavcodec/xwdenc.c | 1 + libavfilter/framepool.c | 1 + libavfilter/vf_scale.c| 1 + libavformat/av1.c | 1

[FFmpeg-devel] [PATCH 13/18] avcodec/arm/mpegvideo_arm: Use static_assert to check offsets

2024-03-28 Thread Andreas Rheinhardt
Also move AV_CHECK_OFFSET to its only user, namely lavc/arm/mpegvideo_arm.c and rename it to CHECK_OFFSET. Signed-off-by: Andreas Rheinhardt --- libavcodec/arm/mpegvideo_arm.c | 20 libavutil/internal.h | 8 2 files changed, 12 insertions(+), 16

[FFmpeg-devel] [PATCH 16/18] avutil/hwcontext_vulkan: Include hwcontext.h

2024-03-28 Thread Andreas Rheinhardt
struct Foo * declares a new type (namely struct Foo) if there is no declaration of struct Foo already visible in the current scope; otherwise it is just a pointer to an element of the already declared type "struct Foo". There is a gotcha with the first case: struct Foo is only declared in its

[FFmpeg-devel] [PATCH 15/18] avutil/internal: Move FF_MEMORY_POISON to its only user

2024-03-28 Thread Andreas Rheinhardt
Namely mem.c. Signed-off-by: Andreas Rheinhardt --- libavutil/internal.h | 2 -- libavutil/mem.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/internal.h b/libavutil/internal.h index 5772b8a612..fe0b9d7a24 100644 --- a/libavutil/internal.h +++

[FFmpeg-devel] [PATCH 14/18] avutil/internal: Move libm inclusion to the beginning

2024-03-28 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/internal.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavutil/internal.h b/libavutil/internal.h index e0b2c74b21..5772b8a612 100644 --- a/libavutil/internal.h +++ b/libavutil/internal.h @@ -40,6 +40,7 @@ #include

[FFmpeg-devel] [PATCH 08/18] avcodec/msmpeg4: Don't include x86-specific header unconditionally

2024-03-28 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/msmpeg4.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/msmpeg4.c b/libavcodec/msmpeg4.c index a2c4c57728..e327bf36a7 100644 --- a/libavcodec/msmpeg4.c +++ b/libavcodec/msmpeg4.c @@ -27,13 +27,17 @@ *

  1   2   >