The 2 which has been changed to an 8 in the array length expression is
the maximum value of sps_bitdepth_minus8. This was missed when updating
to VVCv2, which increased this maximum from 2 to 8.
Signed-off-by: Frank Plowman
---
libavcodec/vvc/intra.c | 12
1 file changed, 8
On Mon, 8 Apr 2024, J. Dekker wrote:
The preferred way to use LTO is --enable-lto but often times packagers
still end up with -flto in cflags for various reasons. Using grep
on binary object files is brittle and relies on specific object
representation, which in the case of LLVM bitcode,
Rémi Denis-Courmont (12024-04-09):
> Switching to an own Gitlab instance would simplify code review (that's
> why I'm in favour) but it will add more burden on system admins, and
> make joining the project harder.
Over the last fifteen months, I have updated GitLab sixteen times for
security
Make intermediate result 64-bits to avoid an overflow before the right
shift.
Signed-off-by: Frank Plowman
---
libavcodec/vvc/intra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/vvc/intra.c b/libavcodec/vvc/intra.c
index e515fb9710..5ac7d02c80 100644
---
The size variable here is taken as gospel for the bounds of the input
buffer in later logic. Clamp it to ensure that the returned region
does not extend past that allocated in the underlying GetBitContext,
even in the case entry point offsets are signalled in the bitstream.
Also assert this for
Hi,
>From: ffmpeg-devel On Behalf Of Renan
>Lavarec via ffmpeg-devel
>Sent: Monday, April 8, 2024 11:27 PM
>To: ffmpeg-devel@ffmpeg.org
>Cc: Renan Lavarec
>Subject: [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d12va: wait the texture is
>used before to free it.
>
>From: Renan Lavarec
On Mon, 8 Apr 2024, J. Dekker wrote:
In some cases, these scripts can be called directly by packagers, and
some systems require the interpreter to be explicit.
It is unclear to me which of the changes are needed and for what reason,
please elaborate much more in the commit message.
Is it
The API is similar to the ThreadFrame API, with the exception
that it no longer has an included AVFrame and that it has its
own mutexes and condition variables which makes it more independent
of pthread_frame.c. One can wait on anything via a ThreadProgress.
One just has to ensure that the
Michael Niedermayer:
> On Mon, Apr 08, 2024 at 10:13:40PM +0200, Andreas Rheinhardt wrote:
>> Frame-threaded decoders with inter-frame dependencies
>> use the ThreadFrame API for syncing. It works as follows:
>>
>> During init each thread allocates an AVFrame for every
>> ThreadFrame.
>>
>> Thread
From: Niklas Haas
And make it public.
For encoding, users may also be interested in the configured level and
compatibility ID. So generalize the dv_profile field and just expose the
whole configuration record.
This makes the already rather reductive ff_dovi_update_cfg() function
almost wholly
Changes since v1:
- Moved dolbyvision option from AVCodecContext to DOVIContext, and
add an explicit option only to codecs that use it
- Changed its type to AV_OPT_TYPE_BOOL
- Made it control decoding as well as encoding, so you can use
`-dolbyvision off` as an input option to suppress it
-
Signed-off-by: James Almer
---
libavcodec/libsvtav1.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
index 105c3369c0..6ff893cf10 100644
--- a/libavcodec/libsvtav1.c
+++ b/libavcodec/libsvtav1.c
@@ -486,6 +486,7 @@ static
From: Niklas Haas
This version is seven years old, and present in Debian oldoldstable,
Ubuntu 20.04 and Leap 15.0.
Allows cleaning up the file substantially. In particular, this is
motivated by the desire to stop relying on init_static_data.
---
configure| 2 +-
Note that the config.sh file is left without a shebang, this file is
supposed to be sourced into the current environment.
This commit is purely cosmetic.
Signed-off-by: J. Dekker
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index
This commit is purely cosmetic.
Signed-off-by: J. Dekker
---
tests/fate-run.sh | 2 +-
tests/fate.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/fate-run.sh b/tests/fate-run.sh
index 9863e4f2d9..6ae0320c60 100755
--- a/tests/fate-run.sh
+++
This commit is purely cosmetic.
Signed-off-by: J. Dekker
---
doc/texidep.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/texidep.pl b/doc/texidep.pl
index 099690378e..33e6c7c53e 100644
--- a/doc/texidep.pl
+++ b/doc/texidep.pl
@@ -1,4 +1,4 @@
-#! /usr/bin/env perl
On Tue, 9 Apr 2024, J. Dekker wrote:
Note that the config.sh file is left without a shebang, this file is
supposed to be sourced into the current environment.
This commit is purely cosmetic.
Signed-off-by: J. Dekker
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Add functions:
ff_abs_pow34_lsx
ff_aac_quantize_bands_lsx
./ffmpeg -f s16le -ac 2 -i ../../1.pcm -c:a aac -f null -
before:37.5x
after:48.1x
---
libavcodec/aacencdsp.h| 3 +
libavcodec/loongarch/Makefile | 2 +
libavcodec/loongarch/aacencdsp.S
Add functions:
vector_fmul_window_lsx
butterflies_float_lsx
vector_fmul_scalar_lsx
./ffmpeg -i ../../1.aac -f null -
before:482x
after:523x
---
libavutil/float_dsp.c | 2 +
libavutil/float_dsp.h | 1 +
libavutil/loongarch/Makefile
On Sat, 06 Apr 2024 22:28:26 +0200 Michael Niedermayer
wrote:
> On Fri, Apr 05, 2024 at 07:44:52PM +0200, Niklas Haas wrote:
> > From: Niklas Haas
> >
> > This version is four years old, and present in Debian oldstable, Ubuntu
> > 22.04 and Leap 15.1.
>
> Ubuntu 20.04 has general support till
From: Niklas Haas
This is based on HEVC only, H.264/AV1 use their own (hopefully correctly
signalled) profiles.
---
libavcodec/dovi_rpu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c
index 267e52ceb66..4da711d763e 100644
From: Niklas Haas
---
libavcodec/libsvtav1.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
index 105c3369c0f..cd62103dba4 100644
--- a/libavcodec/libsvtav1.c
+++ b/libavcodec/libsvtav1.c
@@ -23,6 +23,7 @@
From: Niklas Haas
This could be used by codecs to selectively disable parsing Dolby Vision
RPUs, and is cheap to support.
---
libavcodec/av1dec.c | 1 +
libavcodec/dovi_rpu.c | 6 ++
libavcodec/dovi_rpu.h | 2 ++
libavcodec/hevcdec.c | 1 +
libavcodec/libdav1d.c | 1 +
5 files changed,
From: Niklas Haas
The code was written under the misguided assumption that these fields
would only be present when the value changes, however this does not
match the actual patent specification, which says that streams are
required to either always signal this metadata, or never signal it.
That
From: Niklas Haas
This was never set in ff_dovi_ctx_replace(), leading to possibly
out-of-date when copying from a sub-thread to the main thread.
---
libavcodec/dovi_rpu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c
index
> 2024年3月27日 03:31，Michael Niedermayer 写道：
>
> On Tue, Mar 26, 2024 at 11:11:00AM +0800, Shiyou Yin wrote:
>>
>>> 2024年3月16日 11:03，Shiyou Yin 写道：
>>>
>>> [PATCH 1/3] swscale: [LA] Optimize range convert for yuvj420p.
>>> [PATCH 2/3] swscale: [LA] Optimize yuv2plane1_8_c.
>>> [PATCH 3/3]
Add functions:
ff_abs_pow34_lsx
ff_aac_quantize_bands_lsx
./ffmpeg -f s16le -ac 2 -i ../../1.pcm -c:a aac -f null -
before:37.5x
after:48.1x
---
libavcodec/aacencdsp.h| 3 +
libavcodec/loongarch/Makefile | 2 +
libavcodec/loongarch/aacencdsp.S
From: Niklas Haas
This function takes a decoded AVDOVIMetadata struct and turns it back
into a binary RPU. Verified using existing tools, and matches the
bitstream in official reference files.
I decided to just roll the EMDF and NAL encapsulation into this function
because the end user will
From: Niklas Haas
Since this is guarded behind strict unofficial, we should warn if the
user feeds a dolby vision stream to this muxer, as it will otherwise
result in a broken file.
---
libavformat/movenc.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git
From: Niklas Haas
We need to set up the configuration struct appropriately based on the
codec type, colorspace metadata, and presence/absence of an EL (though,
we currently don't support an EL).
When present, we use the signalled RPU data header to help infer (and
validate) the right values.
From: Niklas Haas
---
libavcodec/libaomenc.c | 28
1 file changed, 28 insertions(+)
diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c
index 4a71bba9c9c..b43a902a384 100644
--- a/libavcodec/libaomenc.c
+++ b/libavcodec/libaomenc.c
@@ -43,6 +43,7 @@
From: Niklas Haas
libx265 supports these natively, we just need to attach the generated
NALs to the x265picture, as well as setting the appropriate DV profile.
---
libavcodec/libx265.c | 40
1 file changed, 40 insertions(+)
diff --git
On Mon, 08 Apr 2024 14:57:13 +0200 Niklas Haas wrote:
> From: Niklas Haas
>
> All hail get_supported_config()
> ---
> libavcodec/allcodecs.c | 7 +--
> libavcodec/codec_internal.h | 8
> 2 files changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/libavcodec/allcodecs.c
Martin Storsjö writes:
> On Tue, 9 Apr 2024, J. Dekker wrote:
>
>> Note that the config.sh file is left without a shebang, this file is
>> supposed to be sourced into the current environment.
>>
>> This commit is purely cosmetic.
>>
>> Signed-off-by: J. Dekker
>> ---
>> configure | 2 +-
>> 1
On Mon, 08 Apr 2024 14:57:17 +0200 Niklas Haas wrote:
> From: Niklas Haas
>
> For avcodec_get_supported_config(), which requires this value be set on
> the actual ost->enc_ctx being queried.
> ---
> fftools/ffmpeg_filter.c | 16 ++--
> 1 file changed, 6 insertions(+), 10
On Mon, Apr 8, 2024 at 11:15 PM Frank Plowman wrote:
> On 08/04/2024 15:12, Nuo Mi wrote:
> > On Mon, Apr 8, 2024 at 4:37 PM Frank Plowman
> wrote:
> >
> >> On 07/04/2024 15:48, James Almer wrote:
> >>> On 4/7/2024 10:38 AM, Nuo Mi wrote:
> On Sun, Apr 7, 2024 at 11:05 AM James Almer
>
The implicit interpreter is dependent on the environment, and isn't
guaranteed to be /bin/sh. Some packagers call this script directly, and
in certain environments such as containers using qemu-user through
binfmt_misc emulation on Linux it doesn't fallback to /bin/sh.
To fix these cases we add
The preferred way to use LTO is --enable-lto but often times packagers
still end up with -flto in cflags for various reasons. Using grep
on binary object files is brittle and relies on specific object
representation, which in the case of LLVM bitcode, debug information or
other intermediary
Martin Storsjö writes:
> Before: Cortex A53 A72 A78
> ac3_sum_square_bufferfly_float_neon: 1005.7 516.5 224.5
> After:
> ac3_sum_square_bufferfly_float_neon: 981.7 504.5 223.2
> ---
> libavcodec/aarch64/ac3dsp_neon.S | 16
> 1 file
On 4/4/2024 7:29 AM, Martin Storsjö wrote:
This is based on a spec at https://aomediacodec.github.io/id3-emsg/,
further based on ISO/IEC 23009-1:2019.
Within libavformat, timed ID3 metadata (already supported by the
mpegts demuxer and muxer) is handled as a separate data AVStream
with codec
On 4/3/2024 10:45 PM, arch1t3cht wrote:
> Can I bump this? It's my first time sending a patch here so let me know
> if I did something wrong.
To me, it LGTM, but I would like someone more experience in H.264 internals
to OK it, too - possibly Michael?
- Derek
On Tue, 09 Apr 2024 17:37:32 +0200 Andreas Rheinhardt
wrote:
> Niklas Haas:
> > From: Niklas Haas
> >
> > This is based on HEVC only, H.264/AV1 use their own (hopefully correctly
> > signalled) profiles.
> > ---
> > libavcodec/dovi_rpu.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2
On Tue, 09 Apr 2024 17:36:30 +0200 Andreas Rheinhardt
wrote:
> Niklas Haas:
> > From: Niklas Haas
> >
> > This was never set in ff_dovi_ctx_replace(), leading to possibly
> > out-of-date when copying from a sub-thread to the main thread.
> > ---
>
> Sub-thread to the main thread?
exclude_guest is currently only supported on x86. However, not
specifying 'exclude_guest' implies that you can count guest events
should you run one. This creates an ABI issue whereby some non-x86
kernels require specifying exclude_guest = 1 explicitly.
Signed-off-by: J. Dekker
---
On Tue, Apr 9, 2024 at 3:04 AM James Almer wrote:
> On 4/8/2024 3:20 PM, Frank Plowman wrote:
> > num_units_in_tick and time_scale are both 32-bit unsigned integers.
> > Storing them as ints was causing overflows.
> >
> > Signed-off-by: Frank Plowman
> > ---
> > libavcodec/vvc_parser.c | 4
Hi James,
On Tue, Apr 9, 2024, 09:05 James Almer wrote:
> Signed-off-by: James Almer
> ---
> libavcodec/libsvtav1.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> index 105c3369c0..6ff893cf10 100644
> ---
mån 2024-04-08 klockan 13:13 -0500 skrev Romain Beauxis:
> On Wed, Apr 3, 2024, 11:39 Kieran Kunhya via ffmpeg-devel <
> ffmpeg-devel@ffmpeg.org> wrote:
>
> > Hi Raphael,
> >
> > I was the author of the tweet and I gave a short talk about this
> > topic at
> > Demuxed at a video conference last
mån 2024-04-08 klockan 16:40 +0200 skrev Nicolas George:
> Tomas Härdin (12024-04-08):
> > We could always start licensing the project under a less permissive
> > license like the GPL or the AGPL and then charge for exceptions.
> > This
> > tactic goes by the name of license trolling, and was
mån 2024-04-08 klockan 21:46 +0200 skrev Marton Balint:
>
>
> On Mon, 8 Apr 2024, Tomas Härdin wrote:
>
> > tor 2024-04-04 klockan 00:51 +0200 skrev Michael Niedermayer:
> > > Fixes: Assertion b >=0 failed at libavutil/mathematics.c:62
> > > Fixes: 67811/clusterfuzz-testcase-minimized-
> > >
On Tue, Apr 9, 2024 at 10:57 PM Romain Beauxis
wrote:
> [Apologies for continuing the conversation, Rémi]
>
> Le mar. 9 avr. 2024 à 14:05, Tomas Härdin a écrit :
>
> > mån 2024-04-08 klockan 13:13 -0500 skrev Romain Beauxis:
> > > On Wed, Apr 3, 2024, 11:39 Kieran Kunhya via ffmpeg-devel <
> >
> +#!/bin/sh
Might I suggest `#!/usr/bin/env sh` instead for this case?
I tend to prefer it from a portability and usability perspective,
but I can imagine for sh it might not matter.
I am not close to the patch that you are working on.
But thought to throw this out there in case there is a
On 4/9/2024 10:11 PM, Andrew Kelley wrote:
On 4/9/24 17:04, Lynne wrote:
LGTM.
That's how I wrote the AAC patchset as well.
Thank you for the review, Lynne.
What is the next step? I do not have commit access.
Applied it, thanks.
___
ffmpeg-devel
On Mon, Apr 08, 2024 at 02:57:18PM +0200, Niklas Haas wrote:
> From: Niklas Haas
>
> The only meaningful difference between choose_pix_fmts and the default
> code was the inclusion of an extra branch for `keep_pix_fmt` being true.
>
> However, in this case, we either:
> 1. Force the specific
Regardless -- it can be left as is . I digress from the topic.
Thank you,
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org
On 4/9/24 17:04, Lynne wrote:
LGTM.
That's how I wrote the AAC patchset as well.
Thank you for the review, Lynne.
What is the next step? I do not have commit access.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
From: Haihao Xiang
libva2 doesn't require a fixed surface-array any more, so we may use
dynamic frame pool for decoding when libva2 is available, which allows a
downstream element stores more frames from VAAPI decoders and fixes the
error below:
$ ffmpeg -hwaccel vaapi -hwaccel_output_format
From: Haihao Xiang
This can avoid to exhaust the buffers within outlink when libva2 is
available.
For example:
$ ffmpeg -hwaccel_output_format vaapi -hwaccel vaapi -i input.mp4 \
-vf 'scale_vaapi=w=720:h=480' -c:v hevc_vaapi -f null -
...
[vf#0:0 @ 0x55acad91f400] Error while filtering: Cannot
i got this idea from postresql, a very small sql database server
i see ffmpeg is broken down into optimized asm libraries for embedding
in c etc programs, and i know a few things about asm, ie, hardware
registers on cpu+, pump in data into a register, get data out, think
it goes down the system
On Tue, Apr 9, 2024 at 11:52 PM Marth64 wrote:
> > +#!/bin/sh
> Might I suggest `#!/usr/bin/env sh` instead for this case?
> I tend to prefer it from a portability and usability perspective,
> but I can imagine for sh it might not matter.
/bin/sh exists on virtually every *NIX system whereas
Quoting James Almer (2024-04-10 03:23:46)
> On 4/9/2024 10:11 PM, Andrew Kelley wrote:
> > On 4/9/24 17:04, Lynne wrote:
> >> LGTM.
> >> That's how I wrote the AAC patchset as well.
> >
> > Thank you for the review, Lynne.
> >
> > What is the next step? I do not have commit access.
>
> Applied
> so that seems like a terrible idea that would achieve
> the opposite result.
I respectfully disagree.
Neither approach is universal or POSIX specified.
So while I agree it can be left as-is since only
a basic Bourne shell is needed, I would not just
dismiss it/write it off as a terrible idea.
Apr 9, 2024, 23:24 by and...@ziglang.org:
> Removes the special -I flag specified in the avcodec/bsf/ subdirectory.
>
> This makes code copy-pastable to other parts of the ffmpeg codebase, as
> well as simplifying the build script.
>
> It also reduces ambiguity, since there are many instances of
On Mon, Apr 08, 2024 at 02:57:20PM +0200, Niklas Haas wrote:
> From: Niklas Haas
>
> To convert between color spaces/ranges, if needed by the codec
> properties.
> ---
> fftools/ffmpeg_filter.c | 34 ++
> 1 file changed, 34 insertions(+)
I presume this is
Le mar. 9 avr. 2024 à 18:46, Paul B Mahol a écrit :
> On Tue, Apr 9, 2024 at 10:57 PM Romain Beauxis
> wrote:
>
> > [Apologies for continuing the conversation, Rémi]
> >
> > Le mar. 9 avr. 2024 à 14:05, Tomas Härdin a écrit :
> >
> > > mån 2024-04-08 klockan 13:13 -0500 skrev Romain Beauxis:
>
[Apologies for continuing the conversation, Rémi]
Le mar. 9 avr. 2024 à 14:05, Tomas Härdin a écrit :
> mån 2024-04-08 klockan 13:13 -0500 skrev Romain Beauxis:
> > On Wed, Apr 3, 2024, 11:39 Kieran Kunhya via ffmpeg-devel <
> > ffmpeg-devel@ffmpeg.org> wrote:
> >
> > > Hi Raphael,
> > >
> > >
On Tue, 9 Apr 2024, Tomas Härdin wrote:
mån 2024-04-08 klockan 21:46 +0200 skrev Marton Balint:
On Mon, 8 Apr 2024, Tomas Härdin wrote:
> tor 2024-04-04 klockan 00:51 +0200 skrev Michael Niedermayer:
> > Fixes: Assertion b >=0 failed at libavutil/mathematics.c:62
> > Fixes:
Removes the special -I flag specified in the avcodec/bsf/ subdirectory.
This makes code copy-pastable to other parts of the ffmpeg codebase, as
well as simplifying the build script.
It also reduces ambiguity, since there are many instances of same-named
header files existing in both libavformat/
67 matches
Mail list logo
