Re: [FFmpeg-devel] Branchpoint tags

2014-12-02 Thread Michael Niedermayer
On Sun, Sep 14, 2014 at 07:12:56PM +0200, Michael Niedermayer wrote: > Hi > > Should we add git tags to the revissions where releases are branched > off ? > > that way a "git describe" on master would look like: > n2.5-dev-3-gb227be3 > instead of: > n2.0-11670-gb227be3 > > (or any other tag than

Re: [FFmpeg-devel] [PATCH] web/legal: move Legal Threats to bottom of page

2014-12-02 Thread Timothy Gu
On Tue, Dec 2, 2014 at 3:53 PM, Lou Logan wrote: > This places Legal Threats under all of the more useful stuff. > > Signed-off-by: Lou Logan > --- > src/legal | 23 +++ > 1 file changed, 11 insertions(+), 12 deletions(-) OK. [...] Timothy _

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: use avcodec_copy_context before avcodec_open2 and open both ctxs

2014-12-02 Thread Michael Niedermayer
On Wed, Dec 03, 2014 at 02:02:21AM +0100, Lukasz Marek wrote: > On 03.12.2014 01:53, Michael Niedermayer wrote: > >On Wed, Dec 03, 2014 at 01:39:12AM +0100, Lukasz Marek wrote: > >>On 03.12.2014 00:35, Michael Niedermayer wrote: > >>>On Tue, Dec 02, 2014 at 07:27:33PM +0100, Lukasz Marek wrote: > >

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: use avcodec_copy_context before avcodec_open2 and open both ctxs

2014-12-02 Thread Lukasz Marek
On 03.12.2014 01:53, Michael Niedermayer wrote: On Wed, Dec 03, 2014 at 01:39:12AM +0100, Lukasz Marek wrote: On 03.12.2014 00:35, Michael Niedermayer wrote: On Tue, Dec 02, 2014 at 07:27:33PM +0100, Lukasz Marek wrote: avcodec_copy_context make dest context unopened. ffmpeg treats it as opene

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: use avcodec_copy_context before avcodec_open2 and open both ctxs

2014-12-02 Thread Michael Niedermayer
On Wed, Dec 03, 2014 at 01:39:12AM +0100, Lukasz Marek wrote: > On 03.12.2014 00:35, Michael Niedermayer wrote: > >On Tue, Dec 02, 2014 at 07:27:33PM +0100, Lukasz Marek wrote: > >>avcodec_copy_context make dest context unopened. > >>ffmpeg treats it as opened. > >> > >>Signed-off-by: Lukasz Marek

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c refactor resolving MultiDescriptor and remove essence group hack

2014-12-02 Thread Mark Reid
I think this is a better way to deal with single frame essence data then my previous way. --- libavformat/mxfdec.c | 62 1 file changed, 38 insertions(+), 24 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 0c88a8a..

Re: [FFmpeg-devel] [PATCH] h264_i386: Optimize decode_significance_8x8_x86 for 64 bit.

2014-12-02 Thread Michael Niedermayer
On Sat, Nov 22, 2014 at 02:09:01PM +0100, Reimar Döffinger wrote: > On Mon, Nov 17, 2014 at 01:41:13PM +0100, Michael Niedermayer wrote: > > On Mon, Nov 17, 2014 at 08:19:32AM +0100, Reimar Döffinger wrote: > > > On 17.11.2014, at 02:37, Michael Niedermayer wrote: > > > > On Sat, Nov 15, 2014 at 0

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: use avcodec_copy_context before avcodec_open2 and open both ctxs

2014-12-02 Thread Lukasz Marek
On 03.12.2014 00:35, Michael Niedermayer wrote: On Tue, Dec 02, 2014 at 07:27:33PM +0100, Lukasz Marek wrote: avcodec_copy_context make dest context unopened. ffmpeg treats it as opened. Signed-off-by: Lukasz Marek --- ffmpeg.c | 29 - 1 file changed, 20 insertio

Re: [FFmpeg-devel] [PATCH] lavc/options: don't copy priv context when it is not AVOption object

2014-12-02 Thread Michael Niedermayer
On Wed, Dec 03, 2014 at 01:24:55AM +0100, Lukasz Marek wrote: > On 03.12.2014 01:15, Michael Niedermayer wrote: > >On Wed, Dec 03, 2014 at 12:06:47AM +0100, Lukasz Marek wrote: > >>This prevents potential crash when opt API is used without a class. > >> > >>Signed-off-by: Lukasz Marek > >>--- > >>

Re: [FFmpeg-devel] [PATCH] lavc/options: don't copy priv context when it is not AVOption object

2014-12-02 Thread Lukasz Marek
On 03.12.2014 01:15, Michael Niedermayer wrote: On Wed, Dec 03, 2014 at 12:06:47AM +0100, Lukasz Marek wrote: This prevents potential crash when opt API is used without a class. Signed-off-by: Lukasz Marek --- libavcodec/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH] lavc/options: don't copy priv context when it is not AVOption object

2014-12-02 Thread Michael Niedermayer
On Wed, Dec 03, 2014 at 12:06:47AM +0100, Lukasz Marek wrote: > This prevents potential crash when opt API is used without a class. > > Signed-off-by: Lukasz Marek > --- > libavcodec/options.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/options.c b/libavc

Re: [FFmpeg-devel] [PATCH] lavf/oggenc: use meaningful error codes

2014-12-02 Thread Michael Niedermayer
On Wed, Dec 03, 2014 at 12:36:23AM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavformat/oggenc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you sh

[FFmpeg-devel] [PATCH] web/legal: move Legal Threats to bottom of page

2014-12-02 Thread Lou Logan
This places Legal Threats under all of the more useful stuff. Signed-off-by: Lou Logan --- src/legal | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/src/legal b/src/legal index cb88149..c235d31 100644 --- a/src/legal +++ b/src/legal @@ -1,15 +1,3 @@

Re: [FFmpeg-devel] Patch for heap corruption run time error in decklink_common.cpp

2014-12-02 Thread Michael Niedermayer
On Wed, Dec 03, 2014 at 12:35:32AM +0100, Ramiro Polla wrote: > > On 02.12.2014 20:28, Jon bae wrote: > >Ok here a second run, I try to follow the instruction from Carl Eugen. > >This is the first patch for decklink_common.cpp. It fix this error: > > > >Unhandled exception at 0x76FA410

[FFmpeg-devel] [PATCH] lavf/oggenc: use meaningful error codes

2014-12-02 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavformat/oggenc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/oggenc.c b/libavformat/oggenc.c index dda229e..f3413c5 100644 --- a/libavformat/oggenc.c +++ b/libavformat/oggenc.c @@ -348,7 +348,7 @@ static int ogg_bu

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: use avcodec_copy_context before avcodec_open2 and open both ctxs

2014-12-02 Thread Michael Niedermayer
On Tue, Dec 02, 2014 at 07:27:33PM +0100, Lukasz Marek wrote: > avcodec_copy_context make dest context unopened. > ffmpeg treats it as opened. > > Signed-off-by: Lukasz Marek > --- > ffmpeg.c | 29 - > 1 file changed, 20 insertions(+), 9 deletions(-) > > diff --git a

Re: [FFmpeg-devel] Patch for heap corruption run time error in decklink_common.cpp

2014-12-02 Thread Ramiro Polla
On 02.12.2014 20:28, Jon bae wrote: Ok here a second run, I try to follow the instruction from Carl Eugen. This is the first patch for decklink_common.cpp. It fix this error: Unhandled exception at 0x76FA4102 (ntdll.dll) in ffmpeg.exe: 0xC374: A heap has been corrupted (para

[FFmpeg-devel] [PATCH] lavc/options: don't copy priv context when it is not AVOption object

2014-12-02 Thread Lukasz Marek
This prevents potential crash when opt API is used without a class. Signed-off-by: Lukasz Marek --- libavcodec/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/options.c b/libavcodec/options.c index 7f9fb07..42ef754 100644 --- a/libavcodec/options.c +++ b/

[FFmpeg-devel] [PATCH] lavu/opt: handle NULL during class comparsion

2014-12-02 Thread Lukasz Marek
av_opt_copy compares classes to avoid copying between mismatched objects. This protection fails when dest class is NULL. Signed-off-by: Lukasz Marek --- libavutil/opt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index d873bd2..0e42f

Re: [FFmpeg-devel] Patch for device list error in decklink_common.cpp

2014-12-02 Thread Ramiro Polla
On 02.12.2014 20:30, Jon bae wrote: Here is the other patch for decklink_common.cpp. It fix the error: COM initialization failed [decklink @ 02e5b520] Could not create DeckLink iterator dummy: Immediate exit request From 203eba2fad14dd6d84552d6c22899792e80b53bb Mon Sep 17 00:00:0

Re: [FFmpeg-devel] [PATCH 1/3] ffserver_config: remove useless defaults

2014-12-02 Thread Lukasz Marek
On 02.12.2014 16:12, Reynaldo H. Verdejo Pinochet wrote: Looks OK. Feel free to push. pushed whole patchset, thx ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Christophe Gisquet
Hi, 2014-12-02 14:31 GMT+01:00 Benoit Fouet : > Fixes ticket #4148 Please try that one instead. As all your changes have been reverted, I've put myself as the only author. I've left your "signed-off-by", but I'm not sure of its purpose now. Christophe From 76ddca41e1f4ab4df348b64ddbf63c58153c8c

[FFmpeg-devel] Patch for device list error in decklink_common.cpp

2014-12-02 Thread Jon bae
Here is the other patch for decklink_common.cpp. It fix the error: COM initialization failed [decklink @ 02e5b520] Could not create DeckLink iterator dummy: Immediate exit request Regards Jonathan >From 203eba2fad14dd6d84552d6c22899792e80b53bb Mon Sep 17 00:00:00 2001 From: Jonathan B

[FFmpeg-devel] Patch for heap corruption run time error in decklink_common.cpp

2014-12-02 Thread Jon bae
Ok here a second run, I try to follow the instruction from Carl Eugen. This is the first patch for decklink_common.cpp. It fix this error: Unhandled exception at 0x76FA4102 (ntdll.dll) in ffmpeg.exe: 0xC374: A heap has been corrupted (parameters: 0x7701B4B0). Regards

Re: [FFmpeg-devel] [PATCH 2/2] configure: add a note about pkg-config --static.

2014-12-02 Thread Michael Niedermayer
On Tue, Dec 02, 2014 at 07:15:41PM +0100, Nicolas George wrote: > Le duodi 12 frimaire, an CCXXIII, Michael Niedermayer a écrit : > > should i merge them or should i wait ? > > (iam asking as your reply isnt entirely clear about that) > > Sorry about that. Please merge, unless you spot something w

[FFmpeg-devel] [PATCH] avfilter/tinterlace: merge code with interlace

2014-12-02 Thread Clément Bœsch
--- After this commit, interlace doesn't behave the same if the input frames are already interlaced. Does anyone wants me to keep this behaviour? Also, the PTS adjustments might be different, but I didn't follow the current discussions about it so I can't tell what people want. --- libavfilter/Ma

Re: [FFmpeg-devel] [PATCH 2/2] lavc/options: fix leaks in avcodec_copy_context

2014-12-02 Thread Lukasz Marek
On 27 November 2014 at 17:56, Lukasz Marek wrote: > On 27 November 2014 at 04:17, Michael Niedermayer > wrote: > >> On Thu, Nov 27, 2014 at 12:43:57AM +0100, Lukasz Marek wrote: >> > On 24.11.2014 05:16, Lukasz Marek wrote: >> > >Signed-off-by: Lukasz Marek >> > >--- >> > > libavcodec/options.

[FFmpeg-devel] [PATCH 2/2] ffmpeg: use avcodec_copy_context before avcodec_open2 and open both ctxs

2014-12-02 Thread Lukasz Marek
avcodec_copy_context make dest context unopened. ffmpeg treats it as opened. Signed-off-by: Lukasz Marek --- ffmpeg.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index b44401f..4fa9f1e 100644 --- a/ffmpeg.c +++ b/ffmpeg.c

[FFmpeg-devel] [PATCH 1/2] libavcodec/options: print a warning when copying open context

2014-12-02 Thread Lukasz Marek
Context copied from open context cannot be treated as opened. avcodec_open2 modifies context so reopening it is also questionable. It is worth to warn when it happens. Signed-off-by: Lukasz Marek --- libavcodec/options.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/options.c

Re: [FFmpeg-devel] [PATCH 2/2] configure: add a note about pkg-config --static.

2014-12-02 Thread Nicolas George
Le duodi 12 frimaire, an CCXXIII, Michael Niedermayer a écrit : > should i merge them or should i wait ? > (iam asking as your reply isnt entirely clear about that) Sorry about that. Please merge, unless you spot something wrong in the way. Regards, -- Nicolas George signature.asc Descripti

Re: [FFmpeg-devel] [PATCH 2/2] configure: add a note about pkg-config --static.

2014-12-02 Thread Michael Niedermayer
On Tue, Dec 02, 2014 at 06:50:37PM +0100, Nicolas George wrote: > Le duodi 12 frimaire, an CCXXIII, Michael Niedermayer a écrit : > > LGTM > > Thanks, pushed both to my tree with "return 1" and hopefully improved commit > message for the second. should i merge them or should i wait ? (iam asking

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

2014-12-02 Thread Michael Niedermayer
On Tue, Dec 02, 2014 at 05:38:21PM +, Vittorio Giovara wrote: > On Tue, Dec 2, 2014 at 5:31 PM, Michael Niedermayer wrote: > > On Mon, Dec 01, 2014 at 11:01:05PM +0100, Michael Niedermayer wrote: > >> Reported-by: Vittorio Giovara > >> Inspired by discussion with Kieran Kunhya > >> Signed-of

Re: [FFmpeg-devel] [PATCH 2/2] configure: add a note about pkg-config --static.

2014-12-02 Thread Nicolas George
Le duodi 12 frimaire, an CCXXIII, Michael Niedermayer a écrit : > LGTM Thanks, pushed both to my tree with "return 1" and hopefully improved commit message for the second. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

2014-12-02 Thread Vittorio Giovara
On Tue, Dec 2, 2014 at 5:31 PM, Michael Niedermayer wrote: > On Mon, Dec 01, 2014 at 11:01:05PM +0100, Michael Niedermayer wrote: >> Reported-by: Vittorio Giovara >> Inspired by discussion with Kieran Kunhya >> Signed-off-by: Michael Niedermayer >> --- >> libavfilter/tinterlace.h|1 + >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

2014-12-02 Thread Michael Niedermayer
On Mon, Dec 01, 2014 at 11:01:05PM +0100, Michael Niedermayer wrote: > Reported-by: Vittorio Giovara > Inspired by discussion with Kieran Kunhya > Signed-off-by: Michael Niedermayer > --- > libavfilter/tinterlace.h|1 + > libavfilter/vf_tinterlace.c | 25 +++-- > 2

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

2014-12-02 Thread Vittorio Giovara
On Tue, Dec 2, 2014 at 4:02 PM, Michael Niedermayer wrote: > If theres a problem in tinterlace as you keep hinting at, could you > please explain what this problem is or provide a testcase that shows > the problem? The problem is that tinterlace does not really interlace, not a single mode does.

Re: [FFmpeg-devel] [PATCH] doc/filters: Add ascii graphics to clarify what the currently implemented tinterlace modes do

2014-12-02 Thread Michael Niedermayer
On Tue, Dec 02, 2014 at 05:02:49PM +, tim nicholson wrote: > On 02/12/14 15:33, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > doc/filters.texi | 131 > > ++ > > 1 file changed, 131 insertions(+) > > > > dif

Re: [FFmpeg-devel] [PATCH 2/2] configure: add a note about pkg-config --static.

2014-12-02 Thread Michael Niedermayer
On Tue, Dec 02, 2014 at 02:16:56PM +0100, Nicolas George wrote: > Try to detect "$cc -static" without "pkg-config --static". > Also always print when a library that was not found was > detected using pkg-config. > > Signed-off-by: Nicolas George > --- > configure | 6 +- > 1 file changed, 5

Re: [FFmpeg-devel] [PATCH] doc/filters: Add ascii graphics to clarify what the currently implemented tinterlace modes do

2014-12-02 Thread tim nicholson
On 02/12/14 15:33, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/filters.texi | 131 > ++ > 1 file changed, 131 insertions(+) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 8c16c7a..0ea3955 100644 >

Re: [FFmpeg-devel] Fix bug for POWER LE: avcodec/ppc/lossless_audiodsp_altivec.c

2014-12-02 Thread Michael Niedermayer
On Tue, Dec 02, 2014 at 03:55:58PM +0800, rongyan wrote: > Hi, > We propose this patch to fix lossless audio bugs for POWER8 little endian. > The passed test cases change from 2292/2328 to 2296/2328‍. > > > > ‍‍ > > > Thanks for your review. > Rong Yan > lossless_audiodsp_altivec.c | 31

Re: [FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Carl Eugen Hoyos
Jon bae gmail.com> writes: > that means that the patch is at the moment not useful?! I believe it is very useful! To get it into the FFmpeg git repository, please: Split the patch in two (one patch per issue). Remove the tab. Fix the indentation. Do not change av_log() into fprintf(). Do not mo

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

2014-12-02 Thread Michael Niedermayer
On Tue, Dec 02, 2014 at 01:55:08PM +, Vittorio Giovara wrote: > On Mon, Dec 1, 2014 at 9:55 PM, Michael Niedermayer wrote: > > > > I dont think the patch will apply cleanly there, also > > If correct timestamps are the main reason for vf_interlace, then why > > was tinterlace not fixed instead

Re: [FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Jon bae
Hello Carl, that means that the patch is at the moment not useful?! This code comes from the decklink sdk and there was also the FAILED() defined, I think. I have the code from here: http://ffmpeg.zeranoe.com/forum/viewtopic.php?f=10&t=1823&start=10#p7580 and there they say it works. When is ok fo

Re: [FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Carl Eugen Hoyos
Jon bae gmail.com> writes: > I hope is all right, I never did before a > git format-patch... You used git format-patch perfectly, thank you. Your patch introduces tabs, they cannot be committed to FFmpeg. You can find tabs with "tools/patcheck", a script that is part of the source. Please d

Re: [FFmpeg-devel] [PATCH 3/3] ffserver_config: print warning when using default value

2014-12-02 Thread Reynaldo H. Verdejo Pinochet
OK to push too. Thanks a lot. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/3] ffserver_config: set defaults basing on absence of set value

2014-12-02 Thread Reynaldo H. Verdejo Pinochet
Looks OK too. -- Reynaldo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] doc/filters: Add ascii graphics to clarify what the currently implemented tinterlace modes do

2014-12-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/filters.texi | 131 ++ 1 file changed, 131 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 8c16c7a..0ea3955 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -8537,33 +8537,

[FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Jon bae
Hello everybody, on the Zeranoe forum we find out that there is two bugs in the decklink_common.cpp file. I build I patch and want to send them now to you. I hope is all right, I never did before a git format-patch... Regards! Jonathan fix-device_list-and-COM-initialization-failed_in decklink_c

Re: [FFmpeg-devel] [PATCH 1/3] ffserver_config: remove useless defaults

2014-12-02 Thread Reynaldo H. Verdejo Pinochet
Looks OK. Feel free to push. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/apngdec: exit probing when skipping is not possible.

2014-12-02 Thread Michael Niedermayer
On Tue, Dec 02, 2014 at 11:24:21AM +0100, Benoit Fouet wrote: > --- > Found an infinite loop on probing while zzuf'ing. > --- > libavformat/apngdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC7870

Re: [FFmpeg-devel] [PATCH] ffserver: use avcodec_copy_context to copy context

2014-12-02 Thread Reynaldo H. Verdejo Pinochet
Should be OK. Thanks. -- Reynaldo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] apng: move shared header from avformat to avcodec.

2014-12-02 Thread Michael Niedermayer
On Tue, Dec 02, 2014 at 09:21:47AM +0100, Benoit Fouet wrote: > --- > {libavformat => libavcodec}/apng.h | 6 +++--- > libavcodec/pngdec.c| 2 +- > libavformat/apngdec.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > rename {libavformat => libavcodec}/ap

Re: [FFmpeg-devel] [PATCH 2/2] configure: add a note about pkg-config --static.

2014-12-02 Thread tim nicholson
On 02/12/14 13:16, Nicolas George wrote: > Try to detect "$cc -static" without "pkg-config --static". > Also always print when a library that was not found was > detected using pkg-config. I was slightly confused by what you meant here, but looking at the code I think you mean that if a library wa

Re: [FFmpeg-devel] [PATCH] libavcodec/pngdec: support 'previous' dispose operation for APNG.

2014-12-02 Thread Benoit Fouet
Le 02/12/2014 15:21, Michael Niedermayer a écrit : On Tue, Dec 02, 2014 at 08:44:02AM +0100, Benoit Fouet wrote: Hi, On December 1, 2014 11:34:44 PM GMT+01:00, Michael Niedermayer wrote: On Mon, Dec 01, 2014 at 11:41:41AM +0100, Benoit Fouet wrote: --- Tested against all the materials I hav

Re: [FFmpeg-devel] [RFC]Print the GUID also as shown in the Windows Registry

2014-12-02 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > Attached patch produces an output for GUIDs that is more similar > > to the relevant documentations. > should be ok The patch was merged. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpe

Re: [FFmpeg-devel] [PATCH] libavcodec/pngdec: support 'previous' dispose operation for APNG.

2014-12-02 Thread Michael Niedermayer
On Tue, Dec 02, 2014 at 08:44:02AM +0100, Benoit Fouet wrote: > Hi, > > On December 1, 2014 11:34:44 PM GMT+01:00, Michael Niedermayer > wrote: > >On Mon, Dec 01, 2014 at 11:41:41AM +0100, Benoit Fouet wrote: > >> --- > >> Tested against all the materials I have at hand. > >> There is an artifac

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

2014-12-02 Thread Vittorio Giovara
On Mon, Dec 1, 2014 at 9:55 PM, Michael Niedermayer wrote: > > I dont think the patch will apply cleanly there, also > If correct timestamps are the main reason for vf_interlace, then why > was tinterlace not fixed instead of taking a subset of its features > and creating a new filter out of that

[FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Fixes ticket #4148 Signed-off-by: Christophe Gisquet Signed-off-by: Benoit Fouet --- Add TODO Update function prototype documentation Mention ticket 4148 --- libavcodec/pngdsp.h | 2 ++ libavcodec/x86/pngdsp.asm | 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/li

Re: [FFmpeg-devel] [PATCH 1/2] configure: add optional pkg-config helper and use it.

2014-12-02 Thread Benoit Fouet
Hi, - Mail original - > The require variant dies if the package is not present. > The check variant does not import the flags to the used list. > The new variant imports the flags if the package is present > but does not die if it is not. > The new call graph is: require -> use -> check. >

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Hi, - Mail original - > Benoit Fouet free.fr> writes: > > [...] > > Please mention ticket #4148 (if it is related). > It is, just forgot about it. Also, I should be changing the libavcodec/pngdsp.h to no more mention the alignment constraints (or at least document that, for now, unal

[FFmpeg-devel] [PATCH 1/2] configure: add optional pkg-config helper and use it.

2014-12-02 Thread Nicolas George
The require variant dies if the package is not present. The check variant does not import the flags to the used list. The new variant imports the flags if the package is present but does not die if it is not. The new call graph is: require -> use -> check. Use use_pkg_config for libx264 and libsmb

[FFmpeg-devel] [PATCH 2/2] configure: add a note about pkg-config --static.

2014-12-02 Thread Nicolas George
Try to detect "$cc -static" without "pkg-config --static". Also always print when a library that was not found was detected using pkg-config. Signed-off-by: Nicolas George --- configure | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index af89e05..

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Hi, - Mail original - > Hi, > > 2014-12-02 13:51 GMT+01:00 Benoit Fouet : > > Signed-off-by: Christophe Gisquet > > Signed-off-by: Benoit Fouet > > While I suggested that the change be written like this, I didn't > think > long about that specific code, and overall, I really don't thin

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Christophe Gisquet
Hi, 2014-12-02 13:51 GMT+01:00 Benoit Fouet : > Signed-off-by: Christophe Gisquet > Signed-off-by: Benoit Fouet While I suggested that the change be written like this, I didn't think long about that specific code, and overall, I really don't think this change is what should be applied. Though y

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Carl Eugen Hoyos
Benoit Fouet free.fr> writes: [...] Please mention ticket #4148 (if it is related). Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Signed-off-by: Christophe Gisquet Signed-off-by: Benoit Fouet --- libavcodec/x86/pngdsp.asm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/pngdsp.asm b/libavcodec/x86/pngdsp.asm index 8e23ccf..76b93a9 100644 --- a/libavcodec/x86/pngdsp.asm +++ b/libavcode

Re: [FFmpeg-devel] [PATCH 1/3] ffserver_config: remove useless defaults

2014-12-02 Thread Lukasz Marek
On 27 November 2014 at 00:49, Lukasz Marek wrote: > Options are already set to its defaults by AVOption API. > The only difference is for qmin, new default is 2, ffserver set to 3. > It is dead code because if condition is not meet unless user set option to > 0. > Meeting condition would mean tha

Re: [FFmpeg-devel] [PATCH] PSMF audio support, trac ticket #3233

2014-12-02 Thread Maxim Polijakowski
+#include "libavformat/oma.h" libavformat can use things from libavcodec but libavcodec cannot use things from libavformat as it doesnt depend on it, libavcodec can be used alone without libavformat so some things may need to be moved to libavcodec in a seperate patch before this The four oma ta

Re: [FFmpeg-devel] [PATCH] PSMF audio support, trac ticket #3233

2014-12-02 Thread Maxim Polijakowski
+avctx->sample_rate= ctx->sample_rate; +avctx->block_align= ctx->frame_size; +avctx->bit_rate = ctx->sample_rate * ctx->frame_size * 8 / 2048; +avctx->channels = ff_oma_chid_to_num_channels[ctx->channel_id - 1]; +avctx->channel_layout

[FFmpeg-devel] [PATCH] avformat/apngdec: exit probing when skipping is not possible.

2014-12-02 Thread Benoit Fouet
--- Found an infinite loop on probing while zzuf'ing. --- libavformat/apngdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c index 189480e..d97b015 100644 --- a/libavformat/apngdec.c +++ b/libavformat/apngdec.c @@ -87,7 +87,7 @@

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

2014-12-02 Thread tim nicholson
On 01/12/14 22:32, Kieran Kunhya wrote: > Sent from my mobile device > [...] > > I would strongly advise all users of these filters generate their own > timestamps. Which would require much better documentation of such usage. (e.g. the only references to the use of genpts inn ffmpeg docs are

[FFmpeg-devel] [PATCH] apng: move shared header from avformat to avcodec.

2014-12-02 Thread Benoit Fouet
--- {libavformat => libavcodec}/apng.h | 6 +++--- libavcodec/pngdec.c| 2 +- libavformat/apngdec.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) rename {libavformat => libavcodec}/apng.h (93%) diff --git a/libavformat/apng.h b/libavcodec/apng.h similarity