Re: [FFmpeg-devel] [PATCH] avcodec/bitstream: replace qsort with AV_QSORT

2015-10-17 Thread Michael Niedermayer
On Sat, Oct 17, 2015 at 09:30:01PM -0400, Ganesh Ajjanagadde wrote: > Commit 3a0a2f33a6c955823fa4fb12c0b49cd29a496659 claims large performance > advantages for AV_QSORT over libc's qsort. The reason is that I suspect > that libc's qsort (at least on non LTO builds, like the typical FFmpeg config) >

Re: [FFmpeg-devel] [PATCH] avcodec/bitstream: replace qsort with AV_QSORT

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 9:30 PM, Ganesh Ajjanagadde wrote: > Commit 3a0a2f33a6c955823fa4fb12c0b49cd29a496659 claims large performance > advantages for AV_QSORT over libc's qsort. The reason is that I suspect > that libc's qsort (at least on non LTO builds, like the typical FFmpeg config) > can't i

[FFmpeg-devel] [PATCH] avcodec/bitstream: replace qsort with AV_QSORT

2015-10-17 Thread Ganesh Ajjanagadde
Commit 3a0a2f33a6c955823fa4fb12c0b49cd29a496659 claims large performance advantages for AV_QSORT over libc's qsort. The reason is that I suspect that libc's qsort (at least on non LTO builds, like the typical FFmpeg config) can't inline the comparison callback: https://stackoverflow.com/questions/5

Re: [FFmpeg-devel] [PATCH 2/4] x86: fpel: Remove erroneous ff_put_pixels8_mmxext prototype

2015-10-17 Thread Michael Niedermayer
On Sat, Oct 17, 2015 at 04:48:59PM -0700, Timothy Gu wrote: > This function does not exist. > --- > libavcodec/x86/fpel.h | 2 -- > 1 file changed, 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is the form of government in w

[FFmpeg-devel] [PATCH 2/2] pixblockdsp: Use memcpy for get_pixels_16_c

2015-10-17 Thread Timothy Gu
Before: 15543 decicycles in get_pixels, 4193214 runs, 1090 skips After: 5713 decicycles in get_pixels, 8387564 runs, 1044 skips --- libavcodec/pixblockdsp.c | 38 - libavcodec/pixblockdsp_template.c | 40 ---

[FFmpeg-devel] [PATCH 1/2] dnxhdenc: Optimize get_pixels_8x4_sym for 10-bit

2015-10-17 Thread Timothy Gu
This reverts commit 628e6d0164febc8e69b0f10dfa487e8a2dd1a28a and uses a better fix. Before: 4483 decicycles in get_pixels_8x4_sym, 131032 runs, 40 skips After: 2569 decicycles in get_pixels_8x4_sym, 131054 runs, 18 skips --- libavcodec/dnxhdenc.c | 24 1 file c

Re: [FFmpeg-devel] [PATCH] compat/solaris/make_sunver.pl: Use /usr/bin/env perl instead of /usr/bin/perl

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 8:41 PM, Michael Niedermayer wrote: > From: Michael Niedermayer > > This is how the other perl scripts in git call perl > > Signed-off-by: Michael Niedermayer > --- > compat/solaris/make_sunver.pl |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[FFmpeg-devel] [PATCH] vc1dsp: Port ff_vc1_put_ver_16b_shift2_mmx to yasm

2015-10-17 Thread Timothy Gu
This function is only used within other inline asm functions, hence the HAVE_MMX_INLINE guard. Per recent discussions, we should not worry about the performance of inline asm-only builds. --- The conversion process has to start _somewhere_... Difference from previous version: use mova/h, correct

[FFmpeg-devel] [PATCH] compat/solaris/make_sunver.pl: Use /usr/bin/env perl instead of /usr/bin/perl

2015-10-17 Thread Michael Niedermayer
From: Michael Niedermayer This is how the other perl scripts in git call perl Signed-off-by: Michael Niedermayer --- compat/solaris/make_sunver.pl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/solaris/make_sunver.pl b/compat/solaris/make_sunver.pl index 929bdda.

[FFmpeg-devel] [PATCH 3/3] avutil/camellia: use EINVAL instead of -1 for the return code of av_camellia_init()

2015-10-17 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/camellia.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/camellia.c b/libavutil/camellia.c index 483eed2..f21ca12 100644 --- a/libavutil/camellia.c +++ b/libavutil/camellia.c @@ -354,7 +354,7 @@ av_cold int av_camelli

[FFmpeg-devel] [PATCH 2/3] avutil/sha: use EINVAL instead of -1 for the return code of av_sha_init()

2015-10-17 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/sha.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/sha.c b/libavutil/sha.c index 9963043..748bb9c 100644 --- a/libavutil/sha.c +++ b/libavutil/sha.c @@ -305,7 +305,7 @@ av_cold int av_sha_init(AVSHA *ctx, int bits)

[FFmpeg-devel] [PATCH 2/2] avutil/camellia: use EINVAL instead of -1 for the return code of av_camellia_init()

2015-10-17 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/camellia.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/camellia.c b/libavutil/camellia.c index 483eed2..f21ca12 100644 --- a/libavutil/camellia.c +++ b/libavutil/camellia.c @@ -354,7 +354,7 @@ av_cold int av_camelli

[FFmpeg-devel] [PATCH 1/2] avutil/sha: use EINVAL instead of -1 for the return code of av_sha_init()

2015-10-17 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/sha.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/sha.c b/libavutil/sha.c index 9963043..748bb9c 100644 --- a/libavutil/sha.c +++ b/libavutil/sha.c @@ -305,7 +305,7 @@ av_cold int av_sha_init(AVSHA *ctx, int bits)

[FFmpeg-devel] [PATCH 1/3] avutil/cast5: use EINVAL instead of -1 for the return code of av_cast5_init()

2015-10-17 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/cast5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/cast5.c b/libavutil/cast5.c index 98aa19d..a47697b 100644 --- a/libavutil/cast5.c +++ b/libavutil/cast5.c @@ -459,7 +459,7 @@ av_cold int av_cast5_init(AVCAST5* cs

Re: [FFmpeg-devel] [PATCH 6/6] avutil/des: use EINVAL instead of -1 for the return code of av_des_init()

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 7:49 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Oct 17, 2015 at 7:40 PM, Ganesh Ajjanagadde > wrote: >> >> On Sat, Oct 17, 2015 at 7:39 PM, Ganesh Ajjanagadde >> wrote: >> > Signed-off-by: Ganesh Ajjanagadde >> > --- >> > libavutil/des.c | 2 +- >> > 1 file changed,

[FFmpeg-devel] [PATCH 4/4] vc1dsp: Port ff_vc1_put_ver_16b_shift2_mmx to yasm

2015-10-17 Thread Timothy Gu
This function is only used within other inline asm functions, hence the HAVE_MMX_INLINE guard. Per recent discussions, we should not worry about the performance of inline asm-only builds. --- libavcodec/x86/vc1dsp.asm | 89 - libavcodec/x86/vc1dsp_mmx.

[FFmpeg-devel] [PATCH 3/4] x86: vc1dsp_mmx: Move yasm initiation steps to vc1dsp_init

2015-10-17 Thread Timothy Gu
That's where all yasm initiation steps are. Also removes the overlap between the two files. --- libavcodec/x86/vc1dsp_init.c | 36 +--- libavcodec/x86/vc1dsp_mmx.c | 27 --- 2 files changed, 25 insertions(+), 38 deletions(-) diff --git a/li

[FFmpeg-devel] [PATCH 1/4] x86: fpel: Move prototypes for 4-px block functions

2015-10-17 Thread Timothy Gu
--- libavcodec/x86/fpel.h | 6 ++ libavcodec/x86/h264_qpel.c | 4 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/fpel.h b/libavcodec/x86/fpel.h index 4d93959..625c47d 100644 --- a/libavcodec/x86/fpel.h +++ b/libavcodec/x86/fpel.h @@ -22,6 +22,10 @@ #in

[FFmpeg-devel] [PATCH 2/4] x86: fpel: Remove erroneous ff_put_pixels8_mmxext prototype

2015-10-17 Thread Timothy Gu
This function does not exist. --- libavcodec/x86/fpel.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/x86/fpel.h b/libavcodec/x86/fpel.h index 625c47d..4e83cf7 100644 --- a/libavcodec/x86/fpel.h +++ b/libavcodec/x86/fpel.h @@ -40,8 +40,6 @@ void ff_put_pixels4_mmx(uint8_t *block,

Re: [FFmpeg-devel] [PATCH 6/6] avutil/des: use EINVAL instead of -1 for the return code of av_des_init()

2015-10-17 Thread Ronald S. Bultje
Hi, On Sat, Oct 17, 2015 at 7:40 PM, Ganesh Ajjanagadde wrote: > On Sat, Oct 17, 2015 at 7:39 PM, Ganesh Ajjanagadde > wrote: > > Signed-off-by: Ganesh Ajjanagadde > > --- > > libavutil/des.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavutil/des.c b/liba

Re: [FFmpeg-devel] [PATCH 6/6] avutil/des: use EINVAL instead of -1 for the return code of av_des_init()

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 7:39 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/des.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/des.c b/libavutil/des.c > index c97158a..3ccbf89 100644 > --- a/libavutil/des.c > +++ b/libavu

[FFmpeg-devel] [PATCH 5/6] avutil/rc4: use EINVAL instead of -1 for the return code of av_rc4_init()

2015-10-17 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/rc4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/rc4.c b/libavutil/rc4.c index 6bd702c..ffcb112 100644 --- a/libavutil/rc4.c +++ b/libavutil/rc4.c @@ -36,7 +36,7 @@ int av_rc4_init(AVRC4 *r, const uint8_t *key, int

[FFmpeg-devel] [PATCH 6/6] avutil/des: use EINVAL instead of -1 for the return code of av_des_init()

2015-10-17 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/des.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/des.c b/libavutil/des.c index c97158a..3ccbf89 100644 --- a/libavutil/des.c +++ b/libavutil/des.c @@ -292,7 +292,7 @@ AVDES *av_des_alloc(void) int av_des_init(AV

[FFmpeg-devel] [PATCH 4/6] avutil/twofish: use EINVAL instead of -1 for the return code of av_twofish_init()

2015-10-17 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/twofish.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/twofish.c b/libavutil/twofish.c index f735a1f..162069b 100644 --- a/libavutil/twofish.c +++ b/libavutil/twofish.c @@ -273,7 +273,7 @@ av_cold int av_twofish_init

[FFmpeg-devel] [PATCH 3/6] avutil/aes: use EINVAL instead of -1 for the return code of av_aes_init()

2015-10-17 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/aes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/aes.c b/libavutil/aes.c index 8d4..b59e7de 100644 --- a/libavutil/aes.c +++ b/libavutil/aes.c @@ -223,7 +223,7 @@ int av_aes_init(AVAES *a, const uint8_t *key, i

[FFmpeg-devel] [PATCH 2/6] avutil/ripemd: use EINVAL instead of -1 for the return code of av_ripemd_init()

2015-10-17 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/ripemd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/ripemd.c b/libavutil/ripemd.c index 0084860..d247fb4 100644 --- a/libavutil/ripemd.c +++ b/libavutil/ripemd.c @@ -504,7 +504,7 @@ av_cold int av_ripemd_init(AVRIP

[FFmpeg-devel] [PATCH 1/6] avutil/sha512: use EINVAL instead of -1 for the return code of av_sha512_init()

2015-10-17 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/sha512.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/sha512.c b/libavutil/sha512.c index 66a864f..e2fc58a 100644 --- a/libavutil/sha512.c +++ b/libavutil/sha512.c @@ -233,7 +233,7 @@ av_cold int av_sha512_init(AVSHA

Re: [FFmpeg-devel] [PATCH] Stream specifier enhancement

2015-10-17 Thread Marton Balint
On Thu, 15 Oct 2015, Bodecs Bela wrote: [...] My enhancement does not alter the current behaviour in any way. Are you sure? What if somebody matched a semicolon, or a string which contained a semicolon in a metadata value? E.g.: m:timecode:00:00:00:00 This question still stands. Will th

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/internal: Doxygen for ff_fmt_is_in

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 6:44 PM, Ganesh Ajjanagadde wrote: > On Sat, Oct 17, 2015 at 6:34 PM, Timothy Gu wrote: >> On Sat, Oct 17, 2015 at 7:59 AM Ganesh Ajjanagadde >> wrote: >>> >>> On Thu, Oct 15, 2015 at 6:26 AM, Ganesh Ajjanagadde >>> wrote: >>> > On Thu, Oct 15, 2015 at 1:45 AM, Timothy G

Re: [FFmpeg-devel] [PATCH 3/5] ffmpeg: factorize checking decoder result

2015-10-17 Thread Michael Niedermayer
On Sun, Oct 18, 2015 at 12:24:05AM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > ffmpeg.c | 27 --- > 1 file changed, 12 insertions(+), 15 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Th

Re: [FFmpeg-devel] [PATCH 2/5] ffmpeg: exit on av_write_trailer failure if exit_on_error is set

2015-10-17 Thread Michael Niedermayer
On Sun, Oct 18, 2015 at 12:38:51AM +0200, Michael Niedermayer wrote: > On Sun, Oct 18, 2015 at 12:24:04AM +0200, Marton Balint wrote: > > Signed-off-by: Marton Balint > > --- > > ffmpeg.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/ffmpeg.c b/ffmpeg.c > > index 95f7e2f..94df

Re: [FFmpeg-devel] [PATCH 2/2] avformat/genh: Remove unused array coef_splitted

2015-10-17 Thread Paul B Mahol
On 10/17/15, Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > libavformat/genh.c |5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavformat/genh.c b/libavformat/genh.c > index 3a4faf9..5d34491 100644 > --- a/

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/internal: Doxygen for ff_fmt_is_in

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 6:34 PM, Timothy Gu wrote: > On Sat, Oct 17, 2015 at 7:59 AM Ganesh Ajjanagadde > wrote: >> >> On Thu, Oct 15, 2015 at 6:26 AM, Ganesh Ajjanagadde >> wrote: >> > On Thu, Oct 15, 2015 at 1:45 AM, Timothy Gu >> > wrote: >> >> On Wed, Oct 14, 2015 at 8:05 PM Ganesh Ajjanaga

Re: [FFmpeg-devel] [PATCH 1/2] avformat/vag: Remove unused variable pos

2015-10-17 Thread Paul B Mahol
On 10/17/15, Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > libavformat/vag.c |2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavformat/vag.c b/libavformat/vag.c > index 2209711..d3cd5ba 100644 > --- a/libavformat/vag.c > +++

Re: [FFmpeg-devel] [PATCH 2/5] ffmpeg: exit on av_write_trailer failure if exit_on_error is set

2015-10-17 Thread Michael Niedermayer
On Sun, Oct 18, 2015 at 12:24:04AM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > ffmpeg.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ffmpeg.c b/ffmpeg.c > index 95f7e2f..94dfb04 100644 > --- a/ffmpeg.c > +++ b/ffmpeg.c > @@ -4106,6 +4106,8 @@ static int trans

Re: [FFmpeg-devel] [PATCH 1/5] ffmpeg: log failed av_write_trailer

2015-10-17 Thread Michael Niedermayer
On Sun, Oct 18, 2015 at 12:24:03AM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > ffmpeg.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ffmpeg.c b/ffmpeg.c > index 36a68fb..95f7e2f 100644 > --- a/ffmpeg.c > +++ b/ffmpeg.c > @@ -4104,7 +4104,9 @@

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/internal: Doxygen for ff_fmt_is_in

2015-10-17 Thread Timothy Gu
On Sat, Oct 17, 2015 at 7:59 AM Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 6:26 AM, Ganesh Ajjanagadde > wrote: > > On Thu, Oct 15, 2015 at 1:45 AM, Timothy Gu > wrote: > >> On Wed, Oct 14, 2015 at 8:05 PM Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > >> wrote: > >>> This clarifies

[FFmpeg-devel] [PATCH 4/5] ffmpeg: exit on corrupt packets or decoded frames if exit_on_error flag is present

2015-10-17 Thread Marton Balint
Signed-off-by: Marton Balint --- ffmpeg.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 3a36af7..f6947f8 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -1925,13 +1925,20 @@ int guess_input_channel_layout(InputStream *ist) return

[FFmpeg-devel] [PATCH 5/5] ffmpeg: add abort_on option to allow aborting on empty output

2015-10-17 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/ffmpeg.texi | 8 ffmpeg.c| 7 +++ ffmpeg.h| 3 +++ ffmpeg_opt.c| 21 + 4 files changed, 39 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index de49618..022304d 100644 --- a/doc/ffmpeg.texi

[FFmpeg-devel] [PATCH 3/5] ffmpeg: factorize checking decoder result

2015-10-17 Thread Marton Balint
Signed-off-by: Marton Balint --- ffmpeg.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 94dfb04..3a36af7 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -1925,6 +1925,15 @@ int guess_input_channel_layout(InputStream *ist)

[FFmpeg-devel] [PATCH 2/5] ffmpeg: exit on av_write_trailer failure if exit_on_error is set

2015-10-17 Thread Marton Balint
Signed-off-by: Marton Balint --- ffmpeg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ffmpeg.c b/ffmpeg.c index 95f7e2f..94dfb04 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -4106,6 +4106,8 @@ static int transcode(void) os = output_files[i]->ctx; if ((ret = av_write_trailer

[FFmpeg-devel] [PATCH 1/5] ffmpeg: log failed av_write_trailer

2015-10-17 Thread Marton Balint
Signed-off-by: Marton Balint --- ffmpeg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index 36a68fb..95f7e2f 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -4104,7 +4104,9 @@ static int transcode(void) /* write the trailer if needed and close file */

[FFmpeg-devel] [PATCH 2/2] avformat/genh: Remove unused array coef_splitted

2015-10-17 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavformat/genh.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/genh.c b/libavformat/genh.c index 3a4faf9..5d34491 100644 --- a/libavformat/genh.c +++ b/libavformat/genh.c @@ -40,7 +40,6

[FFmpeg-devel] [PATCH 1/2] avformat/vag: Remove unused variable pos

2015-10-17 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavformat/vag.c |2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/vag.c b/libavformat/vag.c index 2209711..d3cd5ba 100644 --- a/libavformat/vag.c +++ b/libavformat/vag.c @@ -34,7 +34,6 @@ static int vag_probe(A

Re: [FFmpeg-devel] [PATCHv2] avformat/movenc: suppress -Wstrict-overflow warnings

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 3:57 PM, Mark Harris wrote: >> -if (cluster_idx >= track->entry) >> +/* GCC 5.2 wants to "optimize" cluster_idx >= track->entry to the below >> + * expression. We actually mean cluster_idx >= track->entry. */ >> +if (cluster_idx - track->entry >= 0) >>

[FFmpeg-devel] [PATCH 3/3] WIP: lavf/utils: try to avoid decoding a frame to get the codec parameters

2015-10-17 Thread Matthieu Bouron
From: Matthieu Bouron Avoid decoding twice images such as jpeg and png, once in the avformat_find_stream_info and once when the actual decode is made. The decoder must honor the skip_frame option in order to skip decoding. For now the AVDISCARD_ALL flag is only set for the mjpeg and png decoders

[FFmpeg-devel] [PATCH 2/3] lavc/mjpegdec: honor skip_frame option

2015-10-17 Thread Matthieu Bouron
From: Matthieu Bouron --- libavcodec/mjpegdec.c | 20 1 file changed, 20 insertions(+) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 1a86b7b..8a90e94 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@ -2038,6 +2038,21 @@ int ff_mjpeg_decode

[FFmpeg-devel] [PATCH 1/3] lavc/pngdec: honor skip_frame option

2015-10-17 Thread Matthieu Bouron
From: Matthieu Bouron --- libavcodec/pngdec.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 4cfdc58..5b2befe 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -1087,6 +1087,13 @@ static int deco

[FFmpeg-devel] WIP/RFC: Try to avoid decoding a frame to get the codec parameters

2015-10-17 Thread Matthieu Bouron
Hello, As of now, avformat_find_info_stream decodes a frame in order to get the codec parameters (width, height, pix_fmt (mandatory) and more depending on the codec) which leads to having images decoded twice. The following patchset addresses this issue: * by using the AVCodecContext skip_fram

[FFmpeg-devel] [PATCH] avformat: add msf demuxer

2015-10-17 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/msf.c| 88 3 files changed, 90 insertions(+) create mode 100644 libavformat/msf.c diff --git a/libavformat/Makefile b/libavforma

Re: [FFmpeg-devel] [PATCHv2] avformat/movenc: suppress -Wstrict-overflow warnings

2015-10-17 Thread Mark Harris
> -if (cluster_idx >= track->entry) > +/* GCC 5.2 wants to "optimize" cluster_idx >= track->entry to the below > + * expression. We actually mean cluster_idx >= track->entry. */ > +if (cluster_idx - track->entry >= 0) > return 0; On Sat, Oct 17, 2015 at 11:04 AM, Ganesh Aj

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-17 Thread wm4
On Sat, 17 Oct 2015 21:28:50 +0200 Hendrik Leppkes wrote: > On Sat, Oct 17, 2015 at 9:27 PM, Hendrik Leppkes wrote: > > --- > > libavcodec/utils.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > Above patch is submitted as an RFC, however I strongly believe its the > only way to keep

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-17 Thread Hendrik Leppkes
On Sat, Oct 17, 2015 at 9:27 PM, Hendrik Leppkes wrote: > --- > libavcodec/utils.c | 6 ++ > 1 file changed, 6 insertions(+) > Above patch is submitted as an RFC, however I strongly believe its the only way to keep hwaccels sane in the future. There are several known problems when a hwaccel

[FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-17 Thread Hendrik Leppkes
--- libavcodec/utils.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 0e4f3c0..52b480a 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1006,6 +1006,12 @@ static int setup_hwaccel(AVCodecContext *avctx, AVHWAccel *hwa = find

Re: [FFmpeg-devel] [PATCH 2/2] lavc/samidec: support Hulu subtitle encryption

2015-10-17 Thread Michael Niedermayer
On Sat, Oct 10, 2015 at 11:05:50PM -0500, Rodger Combs wrote: > hex_to_data should probably move to lavu before this is merged. > > This is probably a good case for sub_charenc to run _after_ the decoder. > > I could see an argument that this should go in the demuxer instead. Thoughts? > --- > l

Re: [FFmpeg-devel] [PATCH 1/2] lavc/samidec: support multiple paragraphs in a packet

2015-10-17 Thread Michael Niedermayer
On Sat, Oct 10, 2015 at 11:05:49PM -0500, Rodger Combs wrote: > --- > libavcodec/samidec.c | 20 ++-- > 1 file changed, 14 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/samidec.c b/libavcodec/samidec.c > index 95f35ab..8dd2749 100644 > --- a/libavcodec/samidec.c > +++

Re: [FFmpeg-devel] [PATCH] avcodec/xface: suppress -Wstrict-overflow warnings

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Sep 26, 2015 at 11:05 AM, Ganesh Ajjanagadde wrote: > On Fri, Sep 18, 2015 at 5:31 PM, Ganesh Ajjanagadde > wrote: >> This patch results in identical behavior of xface, and suppresses >> -Wstrict-overflow >> warnings observed in GCC 5.2. >> I have manually checked that this usage is safe

Re: [FFmpeg-devel] [PATCHv2] avformat/movenc: suppress -Wstrict-overflow warnings

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 1:51 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Oct 16, 2015 at 8:45 PM, Ganesh Ajjanagadde > wrote: > >> On Fri, Oct 16, 2015 at 8:34 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Fri, Oct 16, 2015 at 8:18 PM, Ganesh Ajjanagadde >> > wrote: >> > >> >> On Fri,

Re: [FFmpeg-devel] [PATCH 3/3] doc/muxers: Document range for mpegts periods

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 1:49 PM, Michael Niedermayer wrote: > On Sat, Oct 17, 2015 at 12:43:32PM -0400, Ganesh Ajjanagadde wrote: >> On Sat, Oct 17, 2015 at 12:33 PM, Michael Niedermayer >> wrote: >> > On Fri, Oct 16, 2015 at 03:09:21PM -0400, Derek Buitenhuis wrote: >> >> Signed-off-by: Derek Bu

Re: [FFmpeg-devel] [PATCHv2] avformat/movenc: suppress -Wstrict-overflow warnings

2015-10-17 Thread Ronald S. Bultje
Hi, On Fri, Oct 16, 2015 at 8:45 PM, Ganesh Ajjanagadde wrote: > On Fri, Oct 16, 2015 at 8:34 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Fri, Oct 16, 2015 at 8:18 PM, Ganesh Ajjanagadde > > wrote: > > > >> On Fri, Oct 16, 2015 at 8:05 PM, Ronald S. Bultje > >> wrote: > >> > Hi, > >> > >

Re: [FFmpeg-devel] [PATCH 3/3] doc/muxers: Document range for mpegts periods

2015-10-17 Thread Michael Niedermayer
On Sat, Oct 17, 2015 at 12:43:32PM -0400, Ganesh Ajjanagadde wrote: > On Sat, Oct 17, 2015 at 12:33 PM, Michael Niedermayer > wrote: > > On Fri, Oct 16, 2015 at 03:09:21PM -0400, Derek Buitenhuis wrote: > >> Signed-off-by: Derek Buitenhuis > >> --- > >> doc/muxers.texi | 4 ++-- > >> 1 file chan

Re: [FFmpeg-devel] [PATCH 02/11] avdevice/pulse_audio_common: add av_warn_unused_result

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 12:36 PM, Michael Niedermayer wrote: > On Thu, Oct 15, 2015 at 10:22:16PM -0400, Ganesh Ajjanagadde wrote: >> This does not trigger any warnings, but adds robustness. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavdevice/pulse_audio_common.h | 2 ++ >> 1 file chan

Re: [FFmpeg-devel] [PATCH] concatdec: fix file_start_time calculation regression

2015-10-17 Thread Marton Balint
On Sat, 17 Oct 2015, Nicolas George wrote: Le duodi 22 vendémiaire, an CCXXIV, Marton Balint a écrit : Fixes ticket #4924. Found-by: Jaroslav Šnajdr Signed-off-by: Marton Balint --- libavformat/concatdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Sorry I missed it for a few

Re: [FFmpeg-devel] [PATCH 3/3] doc/muxers: Document range for mpegts periods

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 12:33 PM, Michael Niedermayer wrote: > On Fri, Oct 16, 2015 at 03:09:21PM -0400, Derek Buitenhuis wrote: >> Signed-off-by: Derek Buitenhuis >> --- >> doc/muxers.texi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/doc/muxers.texi b/doc/muxe

Re: [FFmpeg-devel] [PATCH 02/11] avdevice/pulse_audio_common: add av_warn_unused_result

2015-10-17 Thread Michael Niedermayer
On Thu, Oct 15, 2015 at 10:22:16PM -0400, Ganesh Ajjanagadde wrote: > This does not trigger any warnings, but adds robustness. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavdevice/pulse_audio_common.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavdevice/pulse_audio_common

Re: [FFmpeg-devel] [PATCH 3/3] doc/muxers: Document range for mpegts periods

2015-10-17 Thread Michael Niedermayer
On Fri, Oct 16, 2015 at 03:09:21PM -0400, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > doc/muxers.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index 06483fa..cef04e1 100644 > --- a/doc/muxers.texi > +++

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/internal: add av_warn_unused_result

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 12:05 PM, Michael Niedermayer wrote: > On Wed, Oct 14, 2015 at 11:02:45PM -0400, Ganesh Ajjanagadde wrote: >> av_warn_unused_result is added to functions whose return status should >> be checked. Currently does not trigger any warnings, but should be >> useful for future ro

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/internal: add av_warn_unused_result

2015-10-17 Thread Michael Niedermayer
On Wed, Oct 14, 2015 at 11:02:45PM -0400, Ganesh Ajjanagadde wrote: > av_warn_unused_result is added to functions whose return status should > be checked. Currently does not trigger any warnings, but should be > useful for future robustness. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavfil

Re: [FFmpeg-devel] [PATCH] avutil/opt: display a better default value for int/int64 options

2015-10-17 Thread Moritz Barsnick
On Sat, Oct 17, 2015 at 14:54:31 +0200, Clément Bœsch wrote: > % ./ffmpeg -h encoder=aac > -aac_coder E...A... Coding algorithm (from -1 to 3) > (default twoloop) > faac E...A... FAAC-inspired method > anmr E...A... ANMR m

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/internal: Doxygen for ff_fmt_is_in

2015-10-17 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:26 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 1:45 AM, Timothy Gu wrote: >> On Wed, Oct 14, 2015 at 8:05 PM Ganesh Ajjanagadde >> wrote: >>> This clarifies and Doxygen's the comment for ff_fmt_is_in. >> >> ^ >> gajjanag.c:1:23: error: u

Re: [FFmpeg-devel] [PATCH] chromakey: Use the pixel descriptor API for chroma subsampling info

2015-10-17 Thread Timothy Gu
On Tue, Oct 13, 2015 at 9:33 PM Timothy Gu wrote: > --- > libavfilter/vf_chromakey.c | 25 + > 1 file changed, 17 insertions(+), 8 deletions(-) > Reviewed by Timo on IRC and pushed. Timothy ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: improve junk skipping heuristic

2015-10-17 Thread Michael Niedermayer
On Sat, Oct 17, 2015 at 04:18:14PM +0200, wm4 wrote: > On Sat, 17 Oct 2015 14:02:09 +0200 > Michael Niedermayer wrote: > > > On Fri, Oct 16, 2015 at 08:04:08PM +0200, wm4 wrote: > > > Commit 2b3e9bbfb529e6bde238aeb511b55ebe461664c8 caused problems for a > > > certain API user: > > > > > > https:

Re: [FFmpeg-devel] [PATCH] avutil/opt: display a better default value for int/int64 options

2015-10-17 Thread Michael Niedermayer
On Sat, Oct 17, 2015 at 02:54:31PM +0200, Clément Bœsch wrote: > Example: > > % ./ffmpeg -h encoder=aac > -aac_coder E...A... Coding algorithm (from -1 to 3) > (default twoloop) > faac E...A... FAAC-inspired method > anmr

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: improve junk skipping heuristic

2015-10-17 Thread wm4
On Sat, 17 Oct 2015 14:02:09 +0200 Michael Niedermayer wrote: > On Fri, Oct 16, 2015 at 08:04:08PM +0200, wm4 wrote: > > Commit 2b3e9bbfb529e6bde238aeb511b55ebe461664c8 caused problems for a > > certain API user: > > > > https://code.google.com/p/chromium/issues/detail?id=537725 > > https://code

Re: [FFmpeg-devel] [PATCH 2/3] mpegts: Make the sdt_period a double

2015-10-17 Thread Michael Niedermayer
On Fri, Oct 16, 2015 at 03:09:20PM -0400, Derek Buitenhuis wrote: > Having it as a float didn't even allow enough precision to check > for INT_MAX/2. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/mpegtsenc.c | 4 ++-- > libavformat/version.h | 2 +- > 2 files changed, 3 insertions(+)

Re: [FFmpeg-devel] [PATCH 1/3] mpegts: Make the pat_period a double

2015-10-17 Thread Michael Niedermayer
On Fri, Oct 16, 2015 at 03:09:19PM -0400, Derek Buitenhuis wrote: > Having it as a float didn't even allow enough precision to check > for INT_MAX/2. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/mpegtsenc.c | 4 ++-- > libavformat/version.h | 2 +- > 2 files changed, 3 insertions(+)

Re: [FFmpeg-devel] [PATCH] libavformat/Makefile: remove unnecessary object file from wtv demuxer

2015-10-17 Thread Hendrik Leppkes
On Fri, Oct 16, 2015 at 12:25 AM, Hendrik Leppkes wrote: > The wtv demuxer doesn't reference any functionality from asfdec or asfcrypt > --- > Found another one.. > > libavformat/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/Makefile b/libavformat/Ma

[FFmpeg-devel] [PATCH] avutil/opt: display a better default value for int/int64 options

2015-10-17 Thread Clément Bœsch
Example: % ./ffmpeg -h encoder=aac -aac_coder E...A... Coding algorithm (from -1 to 3) (default twoloop) faac E...A... FAAC-inspired method anmr E...A... ANMR method twoloop E...A... Two loop sea

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: improve junk skipping heuristic

2015-10-17 Thread Michael Niedermayer
On Fri, Oct 16, 2015 at 08:04:08PM +0200, wm4 wrote: > Commit 2b3e9bbfb529e6bde238aeb511b55ebe461664c8 caused problems for a > certain API user: > > https://code.google.com/p/chromium/issues/detail?id=537725 > https://code.google.com/p/chromium/issues/detail?id=542032 > > The problem seems rather

Re: [FFmpeg-devel] [PATCH] concatdec: fix file_start_time calculation regression

2015-10-17 Thread Nicolas George
Le duodi 22 vendémiaire, an CCXXIV, Marton Balint a écrit : > Fixes ticket #4924. > > Found-by: Jaroslav Šnajdr > Signed-off-by: Marton Balint > --- > libavformat/concatdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Sorry I missed it for a few days. It looks good to me according