Re: [FFmpeg-devel] [PATCH 03/10] avcodec/aacps_tablegen: use hypot()

2015-11-22 Thread Rostislav Pehlivanov
LGTM, feel free to apply. On Sun, 2015-11-22 at 12:05 -0500, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- >  libavcodec/aacps_tablegen.h | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/aacps_tablegen.h >

[FFmpeg-devel] acrossfade duration accuracy

2015-11-22 Thread Ryan Williams
I am getting an unexpected number of samples in the output of the 'acrossfade' filter. In the following example I would expect acrossfade.wav to contain 72,000 samples but it only contains 70,976 samples. Am I doing something wrong? [root@ryan ff]# ffmpeg \ -y \ -vn \ -filter_complex " \

[FFmpeg-devel] Undocumented filter: afifo

2015-11-22 Thread Ryan Williams
The filter 'afifo' is missing from http://ffmpeg.org/ffmpeg-filters.html ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffmpeg: do not mark outputs as finished unless AVERROR_EOF

2015-11-22 Thread Nicolas George
Le duodi 2 frimaire, an CCXXIV, Mort Yao a écrit : > Whenever an error occurred in get_input_packet(), process_input() used to > attempt to mark all outputs that didn't go through lavfi as finished. However, > for a concat demuxer, doing so might drop the rest of input streams (in case > of > an

Re: [FFmpeg-devel] [PATCH] patcheck: Fix false detection of 'mergeable calls' when line is removed

2015-11-22 Thread Michael Niedermayer
On Sun, Nov 22, 2015 at 12:54:56AM +0100, Hagen Schmidt wrote: > --- > tools/patcheck | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ever know the Truth, for even if they

Re: [FFmpeg-devel] [PATCH] mpegtsenc: Support AAC packet which does not contain extradata

2015-11-22 Thread Hendrik Leppkes
Am 22.11.2015 22:50 schrieb "Hagen Schmidt" : > > extradata_size is checked by adts_write_header(). > Fixes ticket 279. > --- > libavformat/mpegtsenc.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavformat/mpegtsenc.c

Re: [FFmpeg-devel] [PATCH] oggparsespeex: Fix unchecked malloc

2015-11-22 Thread Michael Niedermayer
On Sun, Nov 22, 2015 at 06:10:57PM +, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/oggparsespeex.c | 2 ++ > 1 file changed, 2 insertions(+) probably ok [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH] ffmpeg: When streamcopying, only add the input seek position when copying timestamps.

2015-11-22 Thread Simon Thelen
Using -ss as an input option shifts timestamps down by the seek, so it doesn't have to be added to the recording time when checking whether to stop. Fixes #977 Signed-off-by: Simon Thelen --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-22 Thread Michael Niedermayer
On Sun, Nov 22, 2015 at 11:40:24AM +0100, Clément Bœsch wrote: > On Sun, Nov 22, 2015 at 03:24:55AM +0100, Michael Niedermayer wrote: > [...] > > > diff --git a/libavcodec/snowdec.c b/libavcodec/snowdec.c > > > index 1b288dd..5eb775a 100644 > > > --- a/libavcodec/snowdec.c > > > +++

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-22 Thread Clément Bœsch
On Sun, Nov 22, 2015 at 03:24:55AM +0100, Michael Niedermayer wrote: [...] > > diff --git a/libavcodec/snowdec.c b/libavcodec/snowdec.c > > index 1b288dd..5eb775a 100644 > > --- a/libavcodec/snowdec.c > > +++ b/libavcodec/snowdec.c > > @@ -104,8 +104,11 @@ static av_always_inline void > >

[FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: Remove slice structured mode from H.263 as well as the code automatically enabing it

2015-11-22 Thread Michael Niedermayer
From: Michael Niedermayer There is no such thing as a slice structured mode in the original version 1 H.263, that mode was added in H.263+ in 1998. Also the headers for slice structured mode are not part of the older version 1 and this would result in unplayable files

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-22 Thread Nicolas George
Le septidi 27 brumaire, an CCXXIV, Stefano Sabatini a écrit : > Fix demuxing of files for which the demuxer returns AVERROR(EAGAIN) at > some point. Also returns error code to the caller in case of different > non EOF error. I do not know if it was what wm4 was trying to say, but ffprobe does not

Re: [FFmpeg-devel] avformat/flvdec: Change packet loop to return EAGAIN instead of looping until a valid packet is foud

2015-11-22 Thread Nicolas George
Le nonidi 19 vendémiaire, an CCXXIV, Michael Niedermayer a écrit : > Yes, they simplified the loop and EAGAIN was used before these changes > in flvdec. Also other demuxers use EAGAIN to no other reason then to > simplify their main loop. > > They also provide much more fine grained access for >

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-22 Thread Michael Niedermayer
On Sun, Nov 22, 2015 at 12:05:49PM -0500, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/vsrc_mandelbrot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vsrc_mandelbrot.c

Re: [FFmpeg-devel] [PATCH 01/10] avformat/mov: use hypot()

2015-11-22 Thread Michael Niedermayer
On Sun, Nov 22, 2015 at 12:05:41PM -0500, Ganesh Ajjanagadde wrote: > This simplifies the code. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/mov.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavformat/mov.c

[FFmpeg-devel] [PATCH] oggparsespeex: Fix unchecked malloc

2015-11-22 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- libavformat/oggparsespeex.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/oggparsespeex.c b/libavformat/oggparsespeex.c index 9b5c65f..c86b127 100644 --- a/libavformat/oggparsespeex.c +++

Re: [FFmpeg-devel] [PATCH] ffserver: Fix memory leak and uncheked av_strdup return

2015-11-22 Thread Derek Buitenhuis
On 11/22/2015 6:09 PM, Hendrik Leppkes wrote: > I'm slightly confused by this. If the API doesn't take over the value, > then you don't need to strdup it, and if it does, you don't need to > free it? I don't know about the existing code, I just made sure not to leak after av_strdup, since:

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-22 Thread Nicolas George
Le decadi 30 brumaire, an CCXXIV, wm4 a écrit : > I never claimed otherwise. So basically, you were just rude utterly ignoring all the arguments I gave against polling. >But the topic of the discussion is whether > Stefano's patch adds or fixes a bug. This was

Re: [FFmpeg-devel] [PATCH 5/5] lavfi/select: add support for concatdec_select option

2015-11-22 Thread Nicolas George
Le sextidi 26 brumaire, an CCXXIV, Marton Balint a écrit : > No, the reason behind the return value is based on how the select filter > works which is: > - negative or NaN - frame is sent to the first output > - zero - frame is discarded > - positive - frame is sent to the output with index

Re: [FFmpeg-devel] [PATCH 2/5] concatdec: calculate duration early if outpoint is known

2015-11-22 Thread Nicolas George
Sorry, missed this reply. > In read_header, duration is only set if both inpoint and outpoint is set by > the user. > > In open_file duration is set if outpoint is set by the user which is the > superset of the first case. Ok, I think I was confused by the similar inpoint / file_inpoint field

Re: [FFmpeg-devel] [PATCH] avfilter: add deflash filter

2015-11-22 Thread Moritz Barsnick
On Fri, Nov 20, 2015 at 20:13:11 +0100, Paul B Mahol wrote: Trivial, but: > +{ "0fd", "set flash threshold detection for 1st color component", > OFFSET(fthrd[0]), AV_OPT_TYPE_FLOAT, {.dbl=0.2}, 0, 5, FLAGS }, > +{ "0fr", "set ammount of flash reduction for 1st color component", >

Re: [FFmpeg-devel] [PATCH] ffserver: Fix memory leak and uncheked av_strdup return

2015-11-22 Thread wm4
On Sun, 22 Nov 2015 19:09:58 +0100 Hendrik Leppkes wrote: > On Sun, Nov 22, 2015 at 5:16 PM, Derek Buitenhuis > wrote: > > Signed-off-by: Derek Buitenhuis > > --- > > ffserver.c | 10 +++--- > > 1 file changed, 7

[FFmpeg-devel] [PATCH 00/10] use hypot throughout FFmpeg

2015-11-22 Thread Ganesh Ajjanagadde
Turns out hypot fallback added recently is currently not needed in the sense that no regressions have been observed from earlier commit fa972dcf1a36805de4aaa031331061a0a334996d. However, I do not consider this sufficient justification for reverting associated configure checks and fallback, simply

[FFmpeg-devel] [PATCH 08/10] avfilter/vf_colorkey: avoid unnecessary floating point multiply

2015-11-22 Thread Ganesh Ajjanagadde
Normalization can be pulled outside the sqrt. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_colorkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_colorkey.c b/libavfilter/vf_colorkey.c index 2f670d9..4daf2f5 100644 ---

[FFmpeg-devel] [PATCH 04/10] avfilter/af_compand: use hypot()

2015-11-22 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavfilter/af_compand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_compand.c b/libavfilter/af_compand.c index 3848d67..a64778e 100644 --- a/libavfilter/af_compand.c +++

[FFmpeg-devel] [PATCH 07/10] avfilter/vf_codecview: use hypot()

2015-11-22 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_codecview.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_codecview.c b/libavfilter/vf_codecview.c index df45f55..94b5e56 100644 --- a/libavfilter/vf_codecview.c +++

[FFmpeg-devel] [PATCH 05/10] avfilter/avf_showcqt: use hypot()

2015-11-22 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavfilter/avf_showcqt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avf_showcqt.c b/libavfilter/avf_showcqt.c index d6e2928..cd90c88 100644 --- a/libavfilter/avf_showcqt.c +++

[FFmpeg-devel] [PATCH 03/10] avcodec/aacps_tablegen: use hypot()

2015-11-22 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavcodec/aacps_tablegen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacps_tablegen.h b/libavcodec/aacps_tablegen.h index ca1112d..0bd51cc 100644 --- a/libavcodec/aacps_tablegen.h +++

[FFmpeg-devel] [PATCH 02/10] ffplay: use hypot()

2015-11-22 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- ffplay.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ffplay.c b/ffplay.c index 2c1817e..36da8a5 100644 --- a/ffplay.c +++ b/ffplay.c @@ -1115,9 +1115,9 @@ static void video_audio_display(VideoState *s)

[FFmpeg-devel] [PATCH 01/10] avformat/mov: use hypot()

2015-11-22 Thread Ganesh Ajjanagadde
This simplifies the code. Signed-off-by: Ganesh Ajjanagadde --- libavformat/mov.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 8493de9..5fc48cb 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@

[FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-22 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vsrc_mandelbrot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vsrc_mandelbrot.c b/libavfilter/vsrc_mandelbrot.c index 950c5c8..a0c101e 100644 --- a/libavfilter/vsrc_mandelbrot.c +++

[FFmpeg-devel] [PATCH 10/10] avfilter/vsrc_mptestsrc: use hypot()

2015-11-22 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vsrc_mptestsrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vsrc_mptestsrc.c b/libavfilter/vsrc_mptestsrc.c index bc5b2cd..668a001 100644 --- a/libavfilter/vsrc_mptestsrc.c +++

Re: [FFmpeg-devel] [PATCH] ffserver: Fix memory leak and uncheked av_strdup return

2015-11-22 Thread Hendrik Leppkes
On Sun, Nov 22, 2015 at 5:16 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > ffserver.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/ffserver.c b/ffserver.c > index

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-22 Thread Ganesh Ajjanagadde
On Sun, Nov 22, 2015 at 3:07 PM, Michael Niedermayer wrote: > On Sun, Nov 22, 2015 at 12:05:49PM -0500, Ganesh Ajjanagadde wrote: >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavfilter/vsrc_mandelbrot.c | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH 01/10] avformat/mov: use hypot()

2015-11-22 Thread Ganesh Ajjanagadde
On Sun, Nov 22, 2015 at 3:28 PM, Michael Niedermayer wrote: > On Sun, Nov 22, 2015 at 12:05:41PM -0500, Ganesh Ajjanagadde wrote: >> This simplifies the code. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavformat/mov.c | 3 +-- >> 1 file

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-22 Thread Ganesh Ajjanagadde
On Fri, Nov 20, 2015 at 8:35 AM, Ganesh Ajjanagadde wrote: > On Thu, Nov 19, 2015 at 2:35 PM, Paul B Mahol wrote: >> On 11/19/15, Ganesh Ajjanagadde wrote: >>> On Thu, Nov 19, 2015 at 12:35 PM, Nicolas George wrote: Le

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dct32_template: use M_SQRT1_2 instead of actual literal

2015-11-22 Thread Clément Bœsch
On Sun, Nov 22, 2015 at 10:24:49PM +0100, Ganesh Ajjanagadde wrote: > ffmpeg | branch: master | Ganesh Ajjanagadde | Tue > Nov 10 22:26:25 2015 -0500| [ccf3c694032bd84c7672979fa89f437980d717ba] | > committer: Ganesh Ajjanagadde > > avcodec/dct32_template: use M_SQRT1_2

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dct32_template: use M_SQRT1_2 instead of actual literal

2015-11-22 Thread Clément Bœsch
On Sun, Nov 22, 2015 at 10:38:35PM +0100, Clément Bœsch wrote: > On Sun, Nov 22, 2015 at 10:24:49PM +0100, Ganesh Ajjanagadde wrote: > > ffmpeg | branch: master | Ganesh Ajjanagadde | Tue > > Nov 10 22:26:25 2015 -0500| [ccf3c694032bd84c7672979fa89f437980d717ba] | > >

[FFmpeg-devel] [PATCH] patcheck: Fix false detection of 'mergeable calls' when line is removed

2015-11-22 Thread Hagen Schmidt
--- tools/patcheck | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/patcheck b/tools/patcheck index cbdbf8d..06482e2 100755 --- a/tools/patcheck +++ b/tools/patcheck @@ -143,7 +143,7 @@ fi $GREP '^+++ .*Changelog' $* >/dev/null || printf "\nMissing changelog entry

[FFmpeg-devel] [PATCH] mpegtsenc: Support AAC packet which does not contain extradata

2015-11-22 Thread Hagen Schmidt
extradata_size is checked by adts_write_header(). Fixes ticket 279. --- libavformat/mpegtsenc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 468bad4..b1ac627 100644 --- a/libavformat/mpegtsenc.c +++

[FFmpeg-devel] [PATCH] ffmpeg: do not mark outputs as finished unless AVERROR_EOF

2015-11-22 Thread Mort Yao
For now, the concat demuxer summarily drops the whole output streams in case of an error (e.g. EINVAL), which might not be the ideal behavior if the rest of input has yet to be processed and concatenated. To reproduce, $ ffmpeg -y -f concat -i filelist.txt -c copy output.mp4 On example input:

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dct32_template: use M_SQRT1_2 instead of actual literal

2015-11-22 Thread Ganesh Ajjanagadde
On Sun, Nov 22, 2015 at 4:38 PM, Clément Bœsch wrote: > On Sun, Nov 22, 2015 at 10:24:49PM +0100, Ganesh Ajjanagadde wrote: >> ffmpeg | branch: master | Ganesh Ajjanagadde | Tue >> Nov 10 22:26:25 2015 -0500| [ccf3c694032bd84c7672979fa89f437980d717ba] | >>

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dct32_template: use M_SQRT1_2 instead of actual literal

2015-11-22 Thread Ganesh Ajjanagadde
On Sun, Nov 22, 2015 at 4:39 PM, Clément Bœsch wrote: > On Sun, Nov 22, 2015 at 10:38:35PM +0100, Clément Bœsch wrote: >> On Sun, Nov 22, 2015 at 10:24:49PM +0100, Ganesh Ajjanagadde wrote: >> > ffmpeg | branch: master | Ganesh Ajjanagadde | >> > Tue Nov 10