Re: [FFmpeg-devel] [PATCH 02/11] avutil/mips: header asmdefs.h add some PTR_ macros for loongson

2016-05-13 Thread Michael Niedermayer
On Fri, May 13, 2016 at 06:02:28PM +0800, 周晓勇 wrote: > From f4c3f97c7dc130433b7acf674ff03d7500c7236a Mon Sep 17 00:00:00 2001 > From: ZhouXiaoyong > Date: Sat, 7 May 2016 13:56:17 +0800 > Subject: [PATCH 02/11] avutil/mips: header asmdefs.h add some PTR_ macros for >

[FFmpeg-devel] [PATCH] avformat/avlanguage: deprecate av_convert_lang_to and make it internal

2016-05-13 Thread James Almer
The header was never installed and the function is only used in libavformat Signed-off-by: James Almer --- libavformat/asfdec_f.c| 2 +- libavformat/asfdec_o.c| 2 +- libavformat/asfenc.c | 2 +- libavformat/avienc.c | 2 +- libavformat/avlanguage.c |

Re: [FFmpeg-devel] [PATCH] swresample/arm: add ff_resample_common_apply_filter_{x4, x8}_{float, s16}_neon

2016-05-13 Thread Matthieu Bouron
On Thu, May 12, 2016 at 3:50 PM, Benoit Fouet wrote: > Hi, > > > On 12/05/2016 15:22, Matthieu Bouron wrote: > >> On Thu, May 12, 2016 at 10:01 AM, Benoit Fouet >> wrote: >> >> Hi, >>> >>> I mostly have nits remarks. >>> >>> On 11/05/2016 18:39,

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-05-13 Thread Davinder Singh
should fix fate :) On Wed, May 11, 2016 at 6:32 PM Michael Niedermayer wrote: > On Wed, May 11, 2016 at 12:41:43PM +, Davinder Singh wrote: > > single patch > > > > On Sun, May 8, 2016 at 1:18 AM Davinder Singh > wrote: > > > > > separated

[FFmpeg-devel] [PATCH] avformat: Add Pro-MPEG CoP #3-R2 FEC protocol

2016-05-13 Thread Vlad Tarca
Pro-MPEG Code of Practice #3 release 2 forward error correction for rtp_mpegts streams Signed-off-by: Vlad Tarca --- Changelog | 1 + doc/general.texi| 1 + doc/protocols.texi | 38 libavformat/Makefile| 1 + libavformat/prompeg.c

Re: [FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-13 Thread Andrey Turkin
> No: this part of the patch does nothing because it's already unreffed in the > avcodec_close() called immediately above. Maybe the unref should actually be in > avcodec_free_context() only (if treating it like rc_override and those fields), > but it shouldn't be in both. I missed that, thank

Re: [FFmpeg-devel] [PATCH] Const src in av_packet_clone declaration

2016-05-13 Thread Michael Niedermayer
On Fri, May 13, 2016 at 03:24:50PM +0300, Andriy Lysnevych wrote: > > Anyway, example how this change can break: > > > > typedef struct AVPacket AVPacket; > > > > AVPacket *av_packet_clone_old(AVPacket *src); > > AVPacket *av_packet_clone_new(const AVPacket *src); > > > > AVPacket

Re: [FFmpeg-devel] [PATCH] Const src in av_packet_clone declaration

2016-05-13 Thread wm4
On Fri, 13 May 2016 15:24:50 +0300 Andriy Lysnevych wrote: > > Anyway, example how this change can break: > > > > typedef struct AVPacket AVPacket; > > > > AVPacket *av_packet_clone_old(AVPacket *src); > > AVPacket *av_packet_clone_new(const AVPacket *src); > > > >

Re: [FFmpeg-devel] [PATCH] Const src in av_packet_clone declaration

2016-05-13 Thread Andriy Lysnevych
> Anyway, example how this change can break: > > typedef struct AVPacket AVPacket; > > AVPacket *av_packet_clone_old(AVPacket *src); > AVPacket *av_packet_clone_new(const AVPacket *src); > > AVPacket *(*unsuspecting_api_user)(AVPacket *src); > > void set(void) > { > unsuspecting_api_user =

[FFmpeg-devel] [PATCH] Respect payload offset in av_grow_packet

2016-05-13 Thread Andriy Lysnevych
The patch fixes the function when used with reference-counted packets that have payload offset. Also this function is dangerous for not reference-counted packets because it just overwrites pkt->data. Probably it is better to restrict using it with not referenced-counted packets because you simply

[FFmpeg-devel] [PATCH 11/11] avcodec/mips: loongson optimize idctdsp with mmi v2

2016-05-13 Thread 周晓勇
From 37d9b61f529064a6a78c99f86ff371fefa2b357a Mon Sep 17 00:00:00 2001 From: ZhouXiaoyong Date: Fri, 13 May 2016 16:51:14 +0800 Subject: [PATCH 11/11] avcodec/mips: loongson optimize idctdsp with mmi v2 --- libavcodec/mips/idctdsp_mmi.c | 290

Re: [FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-13 Thread wm4
On Fri, 13 May 2016 10:58:02 +0100 Mark Thompson wrote: > On 13/05/16 10:42, wm4 wrote: > > On Fri, 13 May 2016 10:54:17 +0300 > > Andrey Turkin wrote: > > > >> 2016-05-13 10:35 GMT+03:00 wm4 : > >> > >>> On Thu, 12 May 2016

[FFmpeg-devel] [PATCH 09/11] avcodec/mips: loongson optimize blockdsp with mmi v2

2016-05-13 Thread 周晓勇
From 9e5ade4c99eb23f72a89f0054f8b5626c9acceb3 Mon Sep 17 00:00:00 2001 From: ZhouXiaoyong Date: Fri, 13 May 2016 14:30:10 +0800 Subject: [PATCH 09/11] avcodec/mips: loongson optimize blockdsp with mmi v2 --- libavcodec/mips/blockdsp_mmi.c | 195

[FFmpeg-devel] [PATCH 05/11] avcodec/mips: loongson optimize mpegvideo with mmi v2

2016-05-13 Thread 周晓勇
From cb8887caf25b300ef2f307f930593e9edf394977 Mon Sep 17 00:00:00 2001 From: Zhou Xiaoyong Date: Thu, 12 May 2016 01:48:03 +0800 Subject: [PATCH 05/11] avcodec/mips: loongson optimize mpegvideo with mmi v2 --- libavcodec/mips/mpegvideo_mmi.c | 667

[FFmpeg-devel] [PATCH 04/11] avcodec/mips: loongson optimize h264chroma with mmi v2

2016-05-13 Thread 周晓勇
From 157e001724cdb1461ecfff2f02d0a7b0d6335943 Mon Sep 17 00:00:00 2001 From: ZhouXiaoyong Date: Sat, 7 May 2016 14:20:49 +0800 Subject: [PATCH 04/11] avcodec/mips: loongson optimize h264chroma with mmi v2 --- libavcodec/mips/h264chroma_mmi.c | 1123

[FFmpeg-devel] [PATCH 01/11] configure: remove option -fno-expensive-optimizations for loongson

2016-05-13 Thread 周晓勇
From c0f8c4e1bbe39216ba8f6df118703ad2c72a45e1 Mon Sep 17 00:00:00 2001 From: Zhou Xiaoyong Date: Thu, 12 May 2016 17:45:08 +0800 Subject: [PATCH 01/11] configure: remove option -fno-expensive-optimizations for loongson 1. gcc-4.9.3-5.fc21.loongson.2.mips64el in

Re: [FFmpeg-devel] [PATCH 04/10] avcodec/dca: don't set initial sample_fmt

2016-05-13 Thread Hendrik Leppkes
On Fri, May 13, 2016 at 11:48 AM, foo86 wrote: > Valid sample_fmt will be set by dcadec_decode_frame() based on stream > type. > --- > libavcodec/dcadec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c > index

[FFmpeg-devel] [PATCH 06/10] avcodec/dca_parser: improve frame end search

2016-05-13 Thread foo86
Parse core frame size directly when searching for frame end instead of using value extracted from previous frame. Account for unused bits when calculating sync word distance for 14-bit streams to avoid alias sync detection. Parse EXSS frame size and skip over EXSS frame to avoid alias sync

[FFmpeg-devel] [PATCH 05/10] avcodec/dca: use LUT for LBR frequency ranges

2016-05-13 Thread foo86
Values for unsupported frequencies > 48000 Hz are still included (parser will make use of them). Also convert sampling frequencies array to unsigned. --- libavcodec/dca_lbr.c | 15 +-- libavcodec/dcadata.c | 6 +- libavcodec/dcadata.h | 3 ++- 3 files changed, 12 insertions(+),

[FFmpeg-devel] [PATCH 08/10] avcodec/dca: require checked bitstream reader

2016-05-13 Thread foo86
Remove half-working attempt at supporting unchecked bitstream reader by always copying input data into intermediate buffer with large amount of padding at the end. Convert LBR decoder to checked bitstream reader. Convert dcadec_decode_frame() to parse input data directly if possible. ---

[FFmpeg-devel] [PATCH 10/10] avcodec/dca: remove useless debug message

2016-05-13 Thread foo86
Most DTS-in-WAV streams trigger this, making debug output hard to read. --- libavcodec/dca_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/dca_core.c b/libavcodec/dca_core.c index f6c22ca..46825ed 100644 --- a/libavcodec/dca_core.c +++

[FFmpeg-devel] [PATCH 07/10] avcodec/dca_parser: set duration for core-less streams

2016-05-13 Thread foo86
This requires parsing EXSS in dca_parse(). Adapt ff_dca_exss_parse() signature and disable header CRC check when avctx->priv_data is NULL. --- libavcodec/dca_exss.c | 2 +- libavcodec/dca_exss.h | 2 +- libavcodec/dca_parser.c | 70 ++---

[FFmpeg-devel] [PATCH 02/10] avcodec/dca: simplify 'residual ok' flag tracking

2016-05-13 Thread foo86
Move this from separate structure field to a packet flag. Behavior should be equivalent, except that residual flag is now properly cleared when packet has no core frame at all. Also print a message when forcing recovery mode due to invalid residual to make debugging easier. ---

[FFmpeg-devel] [PATCH 01/10] avcodec/dca: remove Rice code length limit

2016-05-13 Thread foo86
Limit the maximum length of unary part of Rice code by the number of available bits instead of using an arbitrary constant that happens to be just large enough to work. --- libavcodec/dca_xll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dca_xll.c

Re: [FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-13 Thread Andrey Turkin
2016-05-13 10:35 GMT+03:00 wm4 : > On Thu, 12 May 2016 22:35:48 +0300 > Andrey Turkin wrote: > > > Few functions didn't handle hw_frames_ctx references causing resources > leaks and even crashes. > > --- > > libavcodec/options.c | 10 ++ >

Re: [FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-13 Thread wm4
On Thu, 12 May 2016 22:35:48 +0300 Andrey Turkin wrote: > Few functions didn't handle hw_frames_ctx references causing resources leaks > and even crashes. > --- > libavcodec/options.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git