Re: [FFmpeg-devel] [PATCH] af_hdcd: Improve HDCD detection

2016-07-21 Thread Carl Eugen Hoyos
Burt P gmail.com> writes: > HDCD is only "detected" if a valid code is active in both > channels simultaneously Does your patch fix ticket #5727? You don't mention this in the ticket... Thank you for looking at this, Carl Eugen ___ ffmpeg-devel maili

Re: [FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread Carl Eugen Hoyos
Carlos Fernandez Sanz ccextractor.org> writes: > -if (segment) { This change looks unrelated and should be part of a separate patch. Or is it related? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/lis

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc, cosmetics: rename common fns vp8 -> vpx

2016-07-21 Thread James Zern
On Thu, Jul 21, 2016 at 4:22 AM, Michael Niedermayer wrote: > On Wed, Jul 20, 2016 at 09:05:15PM -0700, James Zern wrote: >> + the context struct >> >> Signed-off-by: James Zern >> --- >> libavcodec/libvpxenc.c | 60 >> +- >> 1 file changed, 30 in

Re: [FFmpeg-devel] [PATCH] vp9: add mxext versions of the single-block (w=8, npx=8) h/v loopfilters.

2016-07-21 Thread James Almer
On 7/19/2016 4:55 PM, Ronald S. Bultje wrote: > Each takes about 0.1% of runtime in my profiles, and they didn't have > any SIMD yet so far (we only had simd for npx=16 double-block versions). > --- > libavcodec/x86/vp9dsp_init.c | 3 ++ > libavcodec/x86/vp9lpf.asm| 99 >

Re: [FFmpeg-devel] [PATCH] vp9: add mxext versions of the single-block (w=4, npx=8) h/v loopfilters.

2016-07-21 Thread James Almer
On 7/19/2016 1:06 PM, Ronald S. Bultje wrote: > Each takes about 0.5% of runtime in my profiles, and they didn't have > any SIMD yet so far (we only had simd for npx=16 double-block versions). > --- > libavcodec/x86/vp9dsp_init.c | 3 + > libavcodec/x86/vp9lpf.asm| 149 > +++

Re: [FFmpeg-devel] [PATCH 1/2] libvpxdec, cosmetics: rename common fns vp8 -> vpx

2016-07-21 Thread James Zern
On Thu, Jul 21, 2016 at 4:22 AM, Michael Niedermayer wrote: > On Wed, Jul 20, 2016 at 09:05:14PM -0700, James Zern wrote: >> + the context struct >> >> Signed-off-by: James Zern >> --- >> libavcodec/libvpxdec.c | 28 ++-- >> 1 file changed, 14 insertions(+), 14 deletions(

Re: [FFmpeg-devel] [PATCH 0/3] bump libvpx-vp9 minimum to 1.4.0

2016-07-21 Thread James Zern
On Fri, Jul 15, 2016 at 7:31 PM, James Almer wrote: > On 7/15/2016 10:15 PM, James Zern wrote: >> This compiles against 0.9.0->1.5.0 and tip of tree with checks at each for >> expected encoder/decoder availability and colorspaces. >> Note libvpxdec's ifdefs are within shared code, splitting set_pi

Re: [FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread James Almer
On 7/21/2016 7:31 PM, Carlos Fernandez Sanz wrote: > From: carlos > > Signed-off-by: carlos > --- > libavformat/Makefile | 1 + > libavformat/hlsenc.c | 179 +++--- > libavformat/scte_35.c | 489 > ++ > libavformat/scte_35.h | 76

[FFmpeg-devel] [PATCH] libx264: Increase x264 opts character limit to 4096

2016-07-21 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavcodec/libx264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index c8f2380..b730c91 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -777,8 +777,8 @@ FF_ENABLE_DEPRECATION_WAR

Re: [FFmpeg-devel] [PATCH] avformat: Add multi protocol

2016-07-21 Thread James Almer
On 7/19/2016 1:42 PM, Michael Niedermayer wrote: > fixed > > applied > > thx CC libavformat/teeproto.o src/libavformat/teeproto.c: In function ‘tee_open’: src/libavformat/teeproto.c:105:52: warning: argument to "sizeof" in "memset" call is the same expression as the destination; did yo

Re: [FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread Steven Liu
2016-07-22 6:31 GMT+08:00 Carlos Fernandez Sanz : > From: carlos > > Signed-off-by: carlos > --- > libavformat/Makefile | 1 + > libavformat/hlsenc.c | 179 +++--- > libavformat/scte_35.c | 489 > ++ > libavformat/scte_35.h | 76 +

Re: [FFmpeg-devel] [PATCH] beautify: add space between #include and filename.

2016-07-21 Thread Michael Niedermayer
On Thu, Jul 21, 2016 at 03:32:23PM -0700, Yong Lei wrote: > --- > libavcodec/huffman.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break thro

Re: [FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread Michael Niedermayer
On Thu, Jul 21, 2016 at 03:31:32PM -0700, Carlos Fernandez Sanz wrote: > From: carlos > > Signed-off-by: carlos > --- > libavformat/Makefile | 1 + > libavformat/hlsenc.c | 179 +++--- > libavformat/scte_35.c | 489 > ++ > libavfo

[FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread Carlos Fernandez Sanz
From: carlos Signed-off-by: carlos --- libavformat/Makefile | 1 + libavformat/hlsenc.c | 179 +++--- libavformat/scte_35.c | 489 ++ libavformat/scte_35.h | 76 4 files changed, 680 insertions(+), 65 deletions(-) create

Re: [FFmpeg-devel] [PATCH] avfilter: Add max stats to PSNR log

2016-07-21 Thread Lucas Cooper
> Also that different information should possibly be optional > as in version 2 format, and with that the first line could specify > the version of the format Given that this would be a backwards incompatible change (anything assuming every line is a stat line would break on the header), should I

Re: [FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

2016-07-21 Thread Michael Niedermayer
On Thu, Jul 21, 2016 at 03:31:32PM -0700, Carlos Fernandez Sanz wrote: > From: carlos > 2 quick comments, not a full review [...] > @@ -147,69 +156,55 @@ static int hls_delete_old_segments(HLSContext *hls) { > playlist_duration -= segment->duration; > previous_segment = segment

[FFmpeg-devel] [PATCH 0/2] SCTE-35 support

2016-07-21 Thread Carlos Fernandez Sanz
These two patches add support for SCTE-35. First, parse it correct from MPEG, then segment appropiately. Carlos (1): SCTE extraction from mpegts carlos (1): SCTE-35 support in hlsenc libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 6 + libavformat/Makefile| 1 + libavfor

[FFmpeg-devel] [PATCH] beautify: add space between #include and filename.

2016-07-21 Thread Yong Lei
--- libavcodec/huffman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/huffman.c b/libavcodec/huffman.c index a3d3920..df1141b 100644 --- a/libavcodec/huffman.c +++ b/libavcodec/huffman.c @@ -27,7 +27,7 @@ #include #include "libavutil/qsort.h" -#include"libavu

[FFmpeg-devel] [PATCH 1/2] SCTE extraction from mpegts

2016-07-21 Thread Carlos Fernandez Sanz
From: Carlos Signed-off-by: carlos --- libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 6 ++ libavformat/mpegts.c| 46 -- 3 files changed, 47 insertions(+), 6 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h in

Re: [FFmpeg-devel] [PATCH 2/2] doc/examples/muxing: Fix packet duration

2016-07-21 Thread Michael Niedermayer
On Sun, Jul 17, 2016 at 04:10:39AM +0200, Michael Niedermayer wrote: > Set needed fields in st->codec > > Fixes Ticket5684 > > Signed-off-by: Michael Niedermayer nevcairiel can you comment on this ? is this ok or should i add teh fields to codecpar or do you see some other solution ? [...] --

Re: [FFmpeg-devel] [FFmpeg-cvslog] mov: Support prores with multiple stsd

2016-07-21 Thread Michael Niedermayer
On Thu, Jul 14, 2016 at 04:26:09PM -0400, compn wrote: > On Wed, 13 Jul 2016 17:06:43 +0200 (CEST) > g...@videolan.org (Vittorio Giovara) wrote: > > > ffmpeg | branch: master | Vittorio Giovara > > | Thu Jun 9 18:55:19 2016 -0400| > > [846a3e78a535f05ee61bb23a160f3378f041f751] | committer: Vitto

Re: [FFmpeg-devel] Fix for aviobuf.c::fill_buffer

2016-07-21 Thread code bythepound
Here is what seems to trigger this bug: 1) You have to be using an AVIOContext buffer size larger than aviobuf.c::IO_BUFFER_SIZE (32768) or otherwise larger than AVIOContext::max_packet_size. 2) Your AVIOContext can not provide a seek method (ie: not seekable) 3) You have to be using a file format

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec: fix unsigned overflow to improve seeking

2016-07-21 Thread Chris Cunningham
You can demonstrate the overflow using ffplay and this opus file: https://storage.googleapis.com/chcunningham-chrome-shared/bear-opus.webm Before patching, try: ffplay -ss 2 bear-opus.webm Notice that, in spite of the seek to 2 seconds, the file plays back from time 0. After patching, re-run and

Re: [FFmpeg-devel] ffprobe missing string in code

2016-07-21 Thread Michael Niedermayer
On Fri, Jul 15, 2016 at 09:02:09AM +0300, Dmitry Vagin wrote: > Hello, FFmpeg-devel! > > ffprobe not show tags when set only '-show_entries programs' > > Patch in attachment. > > /Dmitry > ffprobe.c |1 + > 1 file changed, 1 insertion(+) > bd733fe54031475470a40316396028bb91b735e2 patch-ff

[FFmpeg-devel] [PATCH] libavformat/matroskadec: fix unsigned overflow to improve seeking

2016-07-21 Thread Chris Cunningham
When seeking a file where codec delay is greater than 0, the timecode can become negative after offsetting by the codec delay. Failing to cast to a signed int64 will cause the check against skip_to_timecode to evaluate true for these negative values. This breaks the "skip_to" seek mechanism. --- l

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-21 Thread Michael Niedermayer
On Thu, Jul 21, 2016 at 11:14:03PM +0530, Umair Khan wrote: > On Thu, Jul 21, 2016 at 6:18 PM, Michael Niedermayer > wrote: > > On Sun, Jul 17, 2016 at 12:06:03AM +0530, Umair Khan wrote: > >> Hi, > >> > >> Patch attached. > >> > >> - Umair > > > >> libavcodec/Makefile |2 > >> liba

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-21 Thread Umair Khan
On Thu, Jul 21, 2016 at 6:18 PM, Michael Niedermayer wrote: > On Sun, Jul 17, 2016 at 12:06:03AM +0530, Umair Khan wrote: >> Hi, >> >> Patch attached. >> >> - Umair > >> libavcodec/Makefile |2 >> libavcodec/alsdec.c | 284 >> +- >>

Re: [FFmpeg-devel] Fix for aviobuf.c::fill_buffer

2016-07-21 Thread code bythepound
I will see if I can put together a test case that exposes the problem. The comment for this block says "make buffer smaller in case it ended up large after probing" - I'm not 100% certain what that means. I put prints inside this block and after the ffio_set_buf_size() call, this block is never e

[FFmpeg-devel] [PATCH] vp9: add 32x32 idct AVX2 implementation.

2016-07-21 Thread Ronald S. Bultje
About 1.8x speedup compared to AVX version for full IDCT. Other sub-IDCT scenarios also see speedups. Full --bench output for idct_32x32_add_{bpp}_${subidct}_${opt} (50k cycles): nop: 16.5 vp9_inv_dct_dct_32x32_add_8_1_c: 2284.4 vp9_inv_dct_dct_32x32_add_8_1_sse2: 145.0 vp9_inv_dct_dct_32x32_add_8

[FFmpeg-devel] [PATCH] vp9: add 32x32 idct AVX2 implementation.

2016-07-21 Thread Ronald S. Bultje
About 1.8x speedup compared to AVX version for full IDCT. Other sub-IDCT scenarios also see speedups. Full --bench output for idct_32x32_add_{bpp}_${subidct}_${opt} (50k cycles): nop: 16.5 vp9_inv_dct_dct_32x32_add_8_1_c: 2284.4 vp9_inv_dct_dct_32x32_add_8_1_sse2: 145.0 vp9_inv_dct_dct_32x32_add_8

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-21 Thread Michael Niedermayer
On Sun, Jul 17, 2016 at 12:06:03AM +0530, Umair Khan wrote: > Hi, > > Patch attached. > > - Umair > libavcodec/Makefile |2 > libavcodec/alsdec.c | 284 > +- > libavcodec/mlz.c | 171 + > li

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc, cosmetics: rename common fns vp8 -> vpx

2016-07-21 Thread Michael Niedermayer
On Wed, Jul 20, 2016 at 09:05:15PM -0700, James Zern wrote: > + the context struct > > Signed-off-by: James Zern > --- > libavcodec/libvpxenc.c | 60 > +- > 1 file changed, 30 insertions(+), 30 deletions(-) LGTM thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 1/2] libvpxdec, cosmetics: rename common fns vp8 -> vpx

2016-07-21 Thread Michael Niedermayer
On Wed, Jul 20, 2016 at 09:05:14PM -0700, James Zern wrote: > + the context struct > > Signed-off-by: James Zern > --- > libavcodec/libvpxdec.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147E

Re: [FFmpeg-devel] [PATCH] tests/fate/dnxhd: add dnxhr prefix tests

2016-07-21 Thread Michael Niedermayer
On Wed, Jul 20, 2016 at 06:15:38PM -0700, Mark Reid wrote: > The data offset value in the prefix increases as the heights increases. > This test adds a tests for some common dnxhr heights. > > can somebody add the following test footage to fate/dnxhd? > https://dl.dropboxusercontent.com/u/170952/

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/rawenc: add dnxhr raw format extension

2016-07-21 Thread Michael Niedermayer
On Wed, Jul 20, 2016 at 06:22:20PM -0700, Mark Reid wrote: > --- > libavformat/rawenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place to spit but h

Re: [FFmpeg-devel] [PATCH] avfilter/vf_psnr: Fix rounding error in average_max

2016-07-21 Thread Michael Niedermayer
On Thu, Jul 21, 2016 at 10:41:10AM +0200, Paul B Mahol wrote: > On 7/21/16, Michael Niedermayer wrote: > > The intermediate was rounded to an integer > > > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/vf_psnr.c |5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_psnr: Fix rounding error in average_max

2016-07-21 Thread Paul B Mahol
On 7/21/16, Michael Niedermayer wrote: > The intermediate was rounded to an integer > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_psnr.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c > index f3dff62..

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-21 Thread Thilo Borgmann
Am 21.07.16 um 04:17 schrieb Umair Khan: > On Tue, Jul 19, 2016 at 11:17 PM, Umair Khan wrote: >> >> Updated patch. >> >> On Tue, Jul 19, 2016 at 8:19 PM, Thilo Borgmann >> wrote: >>> Am 19.07.16 um 15:42 schrieb Umair Khan: On Tue, Jul 19, 2016 at 5:20 PM, Thilo Borgmann wrote: