Re: [FFmpeg-devel] [PATCH] DXVA2: Fix crash releasing IDirect3D9Surface's with av_buffer_default_free instead of Release

2016-09-29 Thread Hendrik Leppkes
On Fri, Sep 30, 2016 at 7:48 AM, Min wrote: > diff --git a/libavutil/hwcontext_dxva2.c b/libavutil/hwcontext_dxva2.c > index e79254b..17d8eb5 100644 > --- a/libavutil/hwcontext_dxva2.c > +++ b/libavutil/hwcontext_dxva2.c > @@ -101,6 +101,11 @@ static void dxva2_frames_uninit(AVHWFramesContext *ctx

[FFmpeg-devel] [PATCH] DXVA2: Fix crash releasing IDirect3D9Surface's with av_buffer_default_free instead of Release

2016-09-29 Thread Min
diff --git a/libavutil/hwcontext_dxva2.c b/libavutil/hwcontext_dxva2.c index e79254b..17d8eb5 100644 --- a/libavutil/hwcontext_dxva2.c +++ b/libavutil/hwcontext_dxva2.c @@ -101,6 +101,11 @@ static void dxva2_frames_uninit(AVHWFramesContext *ctx) } } +void dxva2_pool_free(void *opaque, uint8_

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: add flv live stream flag

2016-09-29 Thread Steven Liu
2016-09-30 0:53 GMT+08:00 Michael Niedermayer : > On Thu, Sep 29, 2016 at 09:25:35PM +0800, Steven Liu wrote: > > patch update > > > > merge 1/2 and 2/2 into one patch > > > doc/muxers.texi |5 + > > libavformat/flvenc.c | 50 +- > >

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Michael Niedermayer
On Thu, Sep 29, 2016 at 08:12:14PM -0300, James Almer wrote: > On 9/29/2016 7:21 PM, Michael Niedermayer wrote: > > On Thu, Sep 29, 2016 at 09:54:42PM +0100, Josh de Kock wrote: [...] > > > if libfaac support is droped, muxers wont be tested against it anymore > > most likely. It could be done w

Re: [FFmpeg-devel] [RFC]Changelog: Compress slightly

2016-09-29 Thread James Almer
On 9/29/2016 7:08 PM, Carl Eugen Hoyos wrote: > Hi! > > I consider the Changelog more readable with attached patch. > > I wonder if the ogv line should be dropped... No, the alias muxer reports a different mimetype than when .ogv is mapped to the Ogg Muxer and has different defaults (VP8 when li

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread James Almer
On 9/29/2016 7:21 PM, Michael Niedermayer wrote: > On Thu, Sep 29, 2016 at 09:54:42PM +0100, Josh de Kock wrote: >> There is really no need for two aac wrappers, we already have >> libfdk-aac which is better. Not to mention that faac doesn't >> even support HEv1, or HEv2. It's also under a license

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Lou Logan
On Fri, 30 Sep 2016 01:17:47 +0200, Carl Eugen Hoyos wrote: > The two last sentences seem to contradict each other, no? No. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Carl Eugen Hoyos
2016-09-30 1:15 GMT+02:00 Lou Logan : > On Fri, 30 Sep 2016 00:33:54 +0200, wm4 wrote: > >> I highly doubt anyone will bother with installing and compiling with >> libfaac at all. > > Agreed. > > From my observations encountering a user with a modern ffmpeg > actually encoding with libfaac is a ver

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Lou Logan
On Fri, 30 Sep 2016 00:33:54 +0200, wm4 wrote: > I highly doubt anyone will bother with installing and compiling with > libfaac at all. Agreed. From my observations encountering a user with a modern ffmpeg actually encoding with libfaac is a very rare occurance. Compared to other encoders it is

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Josh de Kock
On 30/09/2016 00:11, Carl Eugen Hoyos wrote: 2016-09-30 0:51 GMT+02:00 wm4 : On Fri, 30 Sep 2016 00:42:11 +0200 Carl Eugen Hoyos wrote: 2016-09-30 0:33 GMT+02:00 wm4 : On Fri, 30 Sep 2016 00:21:56 +0200 Michael Niedermayer wrote: Also this argument is highly shady Am I correct that it

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Carl Eugen Hoyos
2016-09-30 0:51 GMT+02:00 wm4 : > On Fri, 30 Sep 2016 00:42:11 +0200 > Carl Eugen Hoyos wrote: > >> 2016-09-30 0:33 GMT+02:00 wm4 : >> > On Fri, 30 Sep 2016 00:21:56 +0200 >> > Michael Niedermayer wrote: >> >> > Also this argument is highly shady >> >> Am I correct that it is just a language erro

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread wm4
On Fri, 30 Sep 2016 00:42:11 +0200 Carl Eugen Hoyos wrote: > 2016-09-30 0:33 GMT+02:00 wm4 : > > On Fri, 30 Sep 2016 00:21:56 +0200 > > Michael Niedermayer wrote: > > > Also this argument is highly shady > > Am I correct that it is just a language error that makes you > attack another deve

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Josh de Kock
On 29/09/2016 23:42, Carl Eugen Hoyos wrote: 2016-09-30 0:33 GMT+02:00 wm4 : On Fri, 30 Sep 2016 00:21:56 +0200 Michael Niedermayer wrote: Also this argument is highly shady Am I correct that it is just a language error that makes you attack another developer personally? wm4 didn't attac

[FFmpeg-devel] [PATCH] lavf/segment: provide a virtual AVIOContext representing all the segments

2016-09-29 Thread Rodger Combs
This allows the use of muxers like matroska, which attempt to seek even when an AVIOContext doesn't set `seekable`, without concern for a rouge seek leading the muxer to overwrite the wrong data in a later segment. --- doc/muxers.texi | 17 libavformat/segment.c | 276 +

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Carl Eugen Hoyos
2016-09-30 0:33 GMT+02:00 wm4 : > On Fri, 30 Sep 2016 00:21:56 +0200 > Michael Niedermayer wrote: > Also this argument is highly shady Am I correct that it is just a language error that makes you attack another developer personally? Carl Eugen ___ ffm

[FFmpeg-devel] Improved SAMI support

2016-09-29 Thread Jehan Pagès
Hello! So I posted a patch about SAMI support (https://trac.ffmpeg.org/ticket/3118), but I was told it would be ignored on the bug tracker, therefore to use the dev mailing list. So patch attached, and a small description: SAMI subtitles can have several languages (as explained in the spec: https

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread wm4
On Fri, 30 Sep 2016 00:21:56 +0200 Michael Niedermayer wrote: > On Thu, Sep 29, 2016 at 09:54:42PM +0100, Josh de Kock wrote: > > There is really no need for two aac wrappers, we already have > > libfdk-aac which is better. Not to mention that faac doesn't > > even support HEv1, or HEv2. It's als

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-29 Thread wm4
On Thu, 29 Sep 2016 23:35:49 +0200 Michael Niedermayer wrote: > On Thu, Sep 29, 2016 at 08:25:18PM +0200, wm4 wrote: > > This is a bit messy, mainly due to timestamp handling. > > > > decode_video() relied on the fact that it could set dts on a flush/drain > > packet. This is not possible with t

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Michael Niedermayer
On Thu, Sep 29, 2016 at 09:54:42PM +0100, Josh de Kock wrote: > There is really no need for two aac wrappers, we already have > libfdk-aac which is better. Not to mention that faac doesn't > even support HEv1, or HEv2. It's also under a license which is > unusable for distribution, so it would only

[FFmpeg-devel] [RFC]Changelog: Compress slightly

2016-09-29 Thread Carl Eugen Hoyos
Hi! I consider the Changelog more readable with attached patch. I wonder if the ogv line should be dropped... Please comment, Carl Eugen From 01b62bd9f7da4c991144dfa4039f168d20612f06 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 30 Sep 2016 00:06:12 +0200 Subject: [PATCH] Changelog

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-29 Thread Michael Niedermayer
On Thu, Sep 29, 2016 at 08:25:18PM +0200, wm4 wrote: > This is a bit messy, mainly due to timestamp handling. > > decode_video() relied on the fact that it could set dts on a flush/drain > packet. This is not possible with the old API, and won't be. (I think > doing this was very questionable with

[FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-29 Thread Josh de Kock
There is really no need for two aac wrappers, we already have libfdk-aac which is better. Not to mention that faac doesn't even support HEv1, or HEv2. It's also under a license which is unusable for distribution, so it would only be useful to people who will compile their own ffmpeg, only use it th

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-09-29 Thread Nicolas George
L'octidi 8 vendémiaire, an CCXXV, wm4 a écrit : > This seems like a rather special use case. Why does it have a demuxer, > and can't be in your own C code using libavcodec/libavformat? Of course, it can. It just takes more effort overall. You do not believe that Stefano and I both started working

Re: [FFmpeg-devel] [PATCH 2/2] avformat/tee: Add FATE tests for tee

2016-09-29 Thread Michael Niedermayer
On Thu, Sep 29, 2016 at 12:49:37AM +0200, sebechlebsky...@gmail.com wrote: > From: Jan Sebechlebsky > > This commit also adds new diff option for fate tests allowing do compare > multiple tuples of files. > > Signed-off-by: Jan Sebechlebsky > --- > tests/Makefile| 1 +

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-09-29 Thread Josh de Kock
On 29/09/2016 00:21, Stefano Sabatini wrote: On date Monday 2016-09-26 18:55:47 +0200, wm4 encoded: On Sun, 25 Sep 2016 19:32:37 +0200 Stefano Sabatini wrote: [...] My use case: I need to build a data stream with scripting/manual editing. Since I don't want to have to rely on a binary forma

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-09-29 Thread wm4
On Thu, 29 Sep 2016 01:21:01 +0200 Stefano Sabatini wrote: > On date Monday 2016-09-26 18:55:47 +0200, wm4 encoded: > > On Sun, 25 Sep 2016 19:32:37 +0200 > > Stefano Sabatini wrote: > [...] > > > > > My use case: I need to build a data stream with scripting/manual > > > > > editing. Since I d

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/mov: Read display aspect ratio from ares atom also for dnxhd.

2016-09-29 Thread Michael Niedermayer
On Thu, Sep 29, 2016 at 03:57:12PM +0200, Carl Eugen Hoyos wrote: > ffmpeg | branch: master | Carl Eugen Hoyos | Thu Sep 29 > 15:29:03 2016 +0200| [fcce25ee5d2f3fbe4848dee4c3d11b195d2d8126] | committer: > Carl Eugen Hoyos > > lavf/mov: Read display aspect ratio from ares atom also for dnxhd. >

[FFmpeg-devel] [PATCH 3/3] ffmpeg: use new encode API

2016-09-29 Thread wm4
--- ffmpeg.c | 71 +--- 1 file changed, 46 insertions(+), 25 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index e7ac5c9..9de8507 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -830,7 +830,7 @@ static void do_audio_out(AVFormatContext *s, Outpu

[FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-29 Thread wm4
This is a bit messy, mainly due to timestamp handling. decode_video() relied on the fact that it could set dts on a flush/drain packet. This is not possible with the old API, and won't be. (I think doing this was very questionable with the old API. Flush packets should not contain any information;

[FFmpeg-devel] [PATCH 1/3] ffmpeg: move subframe warning to libavcodec

2016-09-29 Thread wm4
With the new decode API, doing this in ffmpeg.c is impractical. There was resistance against removing the warning, so put it into libavcodec. Not bothering with reducing the warning to verbose log level for subsequent wanrings. The warning should be rare, and only happen when developing new codecs

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: add flv live stream flag

2016-09-29 Thread Michael Niedermayer
On Thu, Sep 29, 2016 at 09:25:35PM +0800, Steven Liu wrote: > patch update > > merge 1/2 and 2/2 into one patch > doc/muxers.texi |5 + > libavformat/flvenc.c | 50 > +- > 2 files changed, 34 insertions(+), 21 deletions(-) > f2c4c83

[FFmpeg-devel] [PATCH]lavf/aiffdec: Default to full rate qcelp as QT does.

2016-09-29 Thread Carl Eugen Hoyos
Hi! Attached patch allows playback of some qcelp aiff files, just as QT plays them. Please comment, Carl Eugen From 66829d7a98aa87ff685a728d01b41be697c8de8a Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 29 Sep 2016 17:36:38 +0200 Subject: [PATCH] lavf/aiffdec: Default to full rate

[FFmpeg-devel] [PATCH]lavf/aiffenc: Write extradata also for qcelp.

2016-09-29 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #4009. Please comment, Carl Eugen From 6dd591f72775785dfd8e3109aa0933c0017dc843 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 29 Sep 2016 17:31:16 +0200 Subject: [PATCH] lavf/aiffenc: Write extradata also for qcelp. Fixes ticket #4009. --- libavform

Re: [FFmpeg-devel] [PATCH 1/2] avformat/tee: Copy interrupt callback and flags to slave

2016-09-29 Thread Jan Sebechlebsky
On 09/29/2016 09:03 AM, Nicolas George wrote: L'octidi 8 vendémiaire, an CCXXV, sebechlebsky...@gmail.com a écrit : From: Jan Sebechlebsky Copy interrupt callback to slave format context to allow user to interrupt IO. Copy format flags as well. Signed-off-by: Jan Sebechlebsky --- libavfor

[FFmpeg-devel] [PATCH]lavf/matroskaenc: Always write V_QUICKTIME extradata.

2016-09-29 Thread Carl Eugen Hoyos
Hi! Attached patch should fix ticket #5872. Please comment, Carl Eugen From 46e8d6919abdeb3d6153878fc815de9202b7eec1 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 29 Sep 2016 16:23:14 +0200 Subject: [PATCH] lavf/matroskaenc: Always write V_QUICKTIME extradata. Fixes ticket #5872. -

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-29 Thread Carl Eugen Hoyos
2016-09-19 13:28 GMT+02:00 Carl Eugen Hoyos : > We read a display aspect ratio from ARES atom because of several > user-provided samples, I believe it makes sense to also write the > width value into the ares atom depending on the aspect ratio. Patch applied, Carl Eugen __

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-29 Thread Carl Eugen Hoyos
2016-09-23 1:08 GMT+02:00 Paul B Mahol : >> Log message changed locally to "lavf/mov: Read display >> aspect ratio from ares atom also for dnxhd." > > LGTM Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.or

[FFmpeg-devel] [PATCH] avformat/flvenc: add flv live stream flag

2016-09-29 Thread Steven Liu
patch update merge 1/2 and 2/2 into one patch 0001-avformat-flvenc-add-flv-live-stream-flag.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/4] lavc/libmp3lame: set trailing_padding after flushing encoder

2016-09-29 Thread Carl Eugen Hoyos
2016-09-28 20:21 GMT+02:00 Jon Toohill : > On Tue, Sep 27, 2016 at 1:04 AM, Carl Eugen Hoyos > wrote: > >> 2016-09-26 19:13 GMT+02:00 Jon Toohill > >: >> >> > +avctx->trailing_padding = FFMAX(lame_get_encoder_padding(s->gfp) >> - 528 - 1, 0); >> >> Can you confirm that this function exists

Re: [FFmpeg-devel] [PATCH 2/2] doc/muxers: add flvenc living_stream flag doc

2016-09-29 Thread Carl Eugen Hoyos
Why is this a separate patch? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: add flv living stream flag

2016-09-29 Thread Carl Eugen Hoyos
2016-09-29 11:56 GMT+02:00 Steven Liu : > +FLV_LIVING_STREAM = (1 << 2), Should this be FLV_LIVE_STREAM? > -if (avio_seek(pb, flv->duration_offset, SEEK_SET) < 0) > -av_log(s, AV_LOG_WARNING, "Failed to update header with correct > duration.\n"); > -else > -put_amf_

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: add flv living stream flag

2016-09-29 Thread Steven Liu
2016-09-29 11:20 GMT+08:00 Steven Liu : > > patch update 0001-avformat-flvenc-add-flv-living-stream-flag.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] movenc: Add support for writing language codes into ISML manifests

2016-09-29 Thread Josh de Kock
On 26/09/2016 23:10, Jan Ekström wrote: Streaming servers appear to ignore all other language metadata. Signed-off-by: Jan Ekström --- libavformat/movenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index d5ed1dd..28edb18 100644 --- a/li

Re: [FFmpeg-devel] [PATCH 1/2] avformat/tee: Copy interrupt callback and flags to slave

2016-09-29 Thread Nicolas George
L'octidi 8 vendémiaire, an CCXXV, sebechlebsky...@gmail.com a écrit : > From: Jan Sebechlebsky > > Copy interrupt callback to slave format context to allow > user to interrupt IO. Copy format flags as well. > > Signed-off-by: Jan Sebechlebsky > --- > libavformat/tee.c | 2 ++ > 1 file changed,