Re: [FFmpeg-devel] [PATCH] doc: drawtext options update

2017-02-21 Thread Lou Logan
On Tue, Feb 21, 2017, at 07:53 PM, Mulvya V wrote: > Hi Lou, > > Did you mean the trailing whitespace throughout or only at the end of the > patch file? In any case, I trimmed those from the attached patch. I meant the trailing whitespace throughout. The patch appears to be corrupt:

Re: [FFmpeg-devel] [PATCH] avcodec/wrapped_avframe: allocate a buffer with padding

2017-02-21 Thread wm4
On Wed, 22 Feb 2017 00:14:32 +0100 Marton Balint wrote: > This ensures that the wrapped avframe will not get reallocated later, which > would invalidate internal references such as extended data. > > Signed-off-by: Marton Balint > --- >

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-02-21 Thread wm4
On Tue, 21 Feb 2017 10:48:37 -0800 Aman Gupta wrote: > From: Aman Gupta > > The way videotoolbox hooks in as a hwaccel is pretty hacky. The VT decode > API is not invoked until end_frame(), so alloc_frame() returns a dummy > frame with a 1-byte buffer. When

Re: [FFmpeg-devel] [PATCH] doc: drawtext options update

2017-02-21 Thread Mulvya V
Hi Lou, Did you mean the trailing whitespace throughout or only at the end of the patch file? In any case, I trimmed those from the attached patch. Regards, mulvya On Wed, Feb 22, 2017 at 1:35 AM, Lou Logan wrote: > On Tue, 21 Feb 2017 12:26:55 +0530, Mulvya V wrote: > > > Hi,

Re: [FFmpeg-devel] [PATCH] avutil/tests/lfg.c: added proper normality test

2017-02-21 Thread Thomas Turner
On 02/17/2017 02:15 PM, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 08:29:38PM -0800, Thomas Turner wrote: >> The Chen-Shapiro(CS) test was used to test normality for >> Lagged Fibonacci PRNG. >> >> Normality Hypothesis Test: >> >> The null hypothesis formally tests if the population >>

[FFmpeg-devel] [PATCH] avcodec/h264: enable sse2 chroma deblock/loop filter functions

2017-02-21 Thread James Darnley
--- libavcodec/x86/h264_deblock.asm | 1 + libavcodec/x86/h264dsp_init.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/libavcodec/x86/h264_deblock.asm b/libavcodec/x86/h264_deblock.asm index 32aa3d3..6702ae9 100644 --- a/libavcodec/x86/h264_deblock.asm +++

[FFmpeg-devel] enabling sse2

2017-02-21 Thread James Darnley
libavcodec/x86/h264_deblock.asm | 1 + libavcodec/x86/h264dsp_init.c | 10 ++ 2 files changed, 11 insertions(+) Okay, enabling sse2 gets me the results below. It turns out I should allow sse2 despite some previous testing. Should I leave avx? Sometimes it is a few percentage

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: fix hls_flags temp_file bug

2017-02-21 Thread Steven Liu
refer to ticket id: #6170 rename file from temp to origin name after complete current segment Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 55 ++-- 1 file changed, 27 insertions(+), 28 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 Thread Carl Eugen Hoyos
2017-02-21 17:41 GMT+01:00 Ronald S. Bultje : >> My English language capabilities are not sufficient to explain "worse" >> better > > But you can decode the file before/after patch as well as with a reference > decoder and open the decoded files in a wave editor and visualize

Re: [FFmpeg-devel] [PATCH] aacdec: When ignoring a PCE restore the previous config

2017-02-21 Thread Alex Converse
On Thu, Feb 16, 2017 at 3:21 PM, Carl Eugen Hoyos wrote: > 2017-02-16 22:13 GMT+01:00 Alex Converse : >> This is related to, but doesn't solve ticker 6152. >> --- >> libavcodec/aacdec_template.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff

Re: [FFmpeg-devel] [PATCH]lavd/opengl: Support BGR48

2017-02-21 Thread Carl Eugen Hoyos
2017-02-21 2:07 GMT+01:00 Carl Eugen Hoyos : > Hi! > > Will apply if I there are no objections. Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCHv3 2/3] mov: Export bounds and padding from spherical metadata

2017-02-21 Thread James Almer
On 2/21/2017 7:35 PM, Vittorio Giovara wrote: > Update the fate test as needed. > --- > libavformat/mov.c | 28 +++- > tests/ref/fate/mov-spherical-mono | 6 +- > 2 files changed, 32 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mov.c

[FFmpeg-devel] [PATCH] avcodec/wrapped_avframe: allocate a buffer with padding

2017-02-21 Thread Marton Balint
This ensures that the wrapped avframe will not get reallocated later, which would invalidate internal references such as extended data. Signed-off-by: Marton Balint --- libavcodec/wrapped_avframe.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff

Re: [FFmpeg-devel] [PATCHv2] avcodec/utils: do not reallocate packet buffer for AV_CODEC_ID_WRAPPED_AVFRAME

2017-02-21 Thread Marton Balint
On Tue, 21 Feb 2017, wm4 wrote: On Mon, 20 Feb 2017 21:11:50 +0100 (CET) Marton Balint wrote: On Sun, 19 Feb 2017, Hendrik Leppkes wrote: > On Sun, Feb 19, 2017 at 2:41 PM, wm4 wrote: >> On Sun, 19 Feb 2017 14:35:42 +0100 >> Marton Balint

[FFmpeg-devel] [PATCHv3 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-21 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- This leaves bounds unchanged, simplifying future muxing code. Add a convenience function where human-readable values are needed. Update mov and mkv in subsequent patches. Vittorio doc/APIchanges | 5 +++

[FFmpeg-devel] [PATCHv3 3/3] mkv: Export bounds and padding from spherical metadata

2017-02-21 Thread Vittorio Giovara
--- libavformat/matroskadec.c | 64 -- tests/ref/fate/matroska-spherical-mono | 6 +++- 2 files changed, 66 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 7223e94..0a02237 100644 ---

[FFmpeg-devel] [PATCHv3 2/3] mov: Export bounds and padding from spherical metadata

2017-02-21 Thread Vittorio Giovara
Update the fate test as needed. --- libavformat/mov.c | 28 +++- tests/ref/fate/mov-spherical-mono | 6 +- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 7b0bbcc..d798336 100644 ---

Re: [FFmpeg-devel] [PATCH v2 2/8] ffmpeg: do packet ts rescaling in write_packet()

2017-02-21 Thread Michael Niedermayer
On Wed, Feb 15, 2017 at 10:24:17AM +0100, wm4 wrote: > From: Anton Khirnov > > This will be useful in the following commit, after which the muxer > timebase is not always available when encoding. > > This merges Libav commit 3e265ca. It was previously skipped. > > There is a

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-02-21 Thread Aman Gupta
On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, Feb 21, 2017 at 1:48 PM, Aman Gupta wrote: > >> diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c >> index 41c0964392..a0ae632fed 100644 >> --- a/libavcodec/h264dec.c >> +++

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-21 Thread Vittorio Giovara
On Thu, Feb 16, 2017 at 3:41 PM, Aaron Colwell wrote: > After sleeping on this, I think what you have will be fine. Resizing a > cubemap w/ padding is just going to have to be handled in a special way > because fractional pixel padding isn't going to work right on the GPU.

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-02-21 Thread Ronald S. Bultje
Hi, On Tue, Feb 21, 2017 at 1:48 PM, Aman Gupta wrote: > diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c > index 41c0964392..a0ae632fed 100644 > --- a/libavcodec/h264dec.c > +++ b/libavcodec/h264dec.c > @@ -850,7 +850,12 @@ static int output_frame(H264Context *h,

Re: [FFmpeg-devel] [PATCH] doc: drawtext options update

2017-02-21 Thread Lou Logan
On Tue, 21 Feb 2017 12:26:55 +0530, Mulvya V wrote: > Hi, > > Revised patch to include basetime option. > > Thanks, > mulvya Thanks for the update, but the patch contains trailing whitespaces which are to be avoided and are causing the patch to fail to be applied. Also, please break long

[FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-02-21 Thread Aman Gupta
From: Aman Gupta The way videotoolbox hooks in as a hwaccel is pretty hacky. The VT decode API is not invoked until end_frame(), so alloc_frame() returns a dummy frame with a 1-byte buffer. When end_frame() is eventually called, the dummy buffer is replaced with the actual decoded

Re: [FFmpeg-devel] [PATCH] avformat/sierravmd: Support for Shivers 2 stereo tracks

2017-02-21 Thread Michael Niedermayer
On Tue, Feb 21, 2017 at 10:11:37AM +0100, Paul B Mahol wrote: > On 2/18/17, Nicolas Roy-Renaud wrote: > > Signed-off-by: Nicolas Roy-Renaud > > --- > > libavformat/sierravmd.c | 20 +--- > > 1 file changed,

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/qdrw: add support for decoding rgb555

2017-02-21 Thread Michael Niedermayer
On Tue, Feb 21, 2017 at 12:22:06PM +0100, Paul B Mahol wrote: > ffmpeg | branch: master | Paul B Mahol | Tue Feb 21 > 12:17:21 2017 +0100| [f4777d1b89c65166394a459399704fc034a782d6] | committer: > Paul B Mahol > > avcodec/qdrw: add support for decoding rgb555 > >

Re: [FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: fix use-after-free of AVFrame buffer when VT decoder fails

2017-02-21 Thread Aman Gupta
On Mon, Feb 13, 2017 at 6:04 PM, Aman Gupta wrote: > From: Aman Gupta > > The videotoolbox hwaccel returns a dummy frame with a 1-byte buffer from > alloc_frame(). In end_frame(), this buffer is replaced with the actual > decoded data from

Re: [FFmpeg-devel] [PATCH v7] - Added Turing codec interface for ffmpeg

2017-02-21 Thread Saverio Blasi
Hi all, We have recently circulated this new iteration (see below) of our work towards integrating our HEVC Turing codec within FFMpeg. Assuming that there are no more requests for changes, we would like to understand what is the timeline for integration within the project. Thanks a lot, All

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix hls_flags temp_file bug

2017-02-21 Thread Aman Gupta
On Tue, Feb 21, 2017 at 7:13 AM, Steven Liu wrote: > refer to ticket id: #6170 > > rename file from temp to origin name after complete current segment > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 40

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 Thread Ronald S. Bultje
Hi, On Tue, Feb 21, 2017 at 8:07 AM, Carl Eugen Hoyos wrote: > 2017-02-21 13:47 GMT+01:00 Ronald S. Bultje : > > For the rest of us, this isn't helpful. What differences are you seeing? > > I don't see a difference, I hear a difference. > [..] > My

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix cid 1401346 Dereferencing pointer error

2017-02-21 Thread Steven Liu
2017-02-20 17:03 GMT+08:00 Steven Liu : > check if proto is null before av_strcasecmp > CID: 1401346 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix hls_flags temp_file bug

2017-02-21 Thread Steven Liu
refer to ticket id: #6170 rename file from temp to origin name after complete current segment Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git

[FFmpeg-devel] Q: QSV filters (state of implementation)

2017-02-21 Thread Haris Zukanovic
Hi everyone, The last record of an attempt to introduce QSV filters in the mailing list would be the thread titled lavf/vpp: Enable vpp filter, an Intel GPU accelerated scaler from 8/25/16. ...but I understand the hwaccell sharing context was not at all ready at that point... Since now ffmpeg

Re: [FFmpeg-devel] [PATCH] hlsenc: don't use %s for strftime on msvc

2017-02-21 Thread Steven Liu
2017-02-21 15:26 GMT+08:00 Hendrik Leppkes : > On Tue, Feb 21, 2017 at 8:24 AM, Hendrik Leppkes > wrote: > > MSVC doesn't support the %s time format, and instead of returning an > > error the invalid parameter handler is invoked which (by default) > >

[FFmpeg-devel] [PATCH]Makefile: Clean compat subdirectory

2017-02-21 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #5546 here. Please comment, Carl Eugen From 175f3ba7b6034670965e62beef26294efdbc858f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 21 Feb 2017 14:36:15 +0100 Subject: [PATCH] Makefile: Clean compat subdirectory. Fixes ticket #5546.

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 Thread Carl Eugen Hoyos
2017-02-21 13:47 GMT+01:00 Ronald S. Bultje : > For the rest of us, this isn't helpful. What differences are you seeing? I don't see a difference, I hear a difference. Since this isn't mentioned in the commit message, I was wondering if the difference is intended. My English

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 Thread Ronald S. Bultje
Hi, On Tue, Feb 21, 2017 at 6:22 AM, Carl Eugen Hoyos wrote: > 2017-02-21 12:21 GMT+01:00 Paul B Mahol : > > On 2/21/17, Carl Eugen Hoyos wrote: > >> 2017-02-21 12:07 GMT+01:00 Paul B Mahol : > >>> On 2/21/17, Carl

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 Thread Carl Eugen Hoyos
2017-02-21 12:21 GMT+01:00 Paul B Mahol : > On 2/21/17, Carl Eugen Hoyos wrote: >> 2017-02-21 12:07 GMT+01:00 Paul B Mahol : >>> On 2/21/17, Carl Eugen Hoyos wrote: 2017-02-21 10:59 GMT+01:00 Paul B Mahol

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 Thread Paul B Mahol
On 2/21/17, Carl Eugen Hoyos wrote: > 2017-02-21 12:07 GMT+01:00 Paul B Mahol : >> On 2/21/17, Carl Eugen Hoyos wrote: >>> 2017-02-21 10:59 GMT+01:00 Paul B Mahol : Fixes #1849. >>> >>> The patch changes output for

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 Thread Carl Eugen Hoyos
2017-02-21 12:07 GMT+01:00 Paul B Mahol : > On 2/21/17, Carl Eugen Hoyos wrote: >> 2017-02-21 10:59 GMT+01:00 Paul B Mahol : >>> Fixes #1849. >> >> The patch changes output for the sample from ticket #1848, is >> this intended? > > Yes.

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 Thread Paul B Mahol
On 2/21/17, Carl Eugen Hoyos wrote: > 2017-02-21 10:59 GMT+01:00 Paul B Mahol : >> Fixes #1849. > > The patch changes output for the sample from ticket #1848, is > this intended? Yes. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 Thread Carl Eugen Hoyos
2017-02-21 10:59 GMT+01:00 Paul B Mahol : > Fixes #1849. The patch changes output for the sample from ticket #1848, is this intended? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 Thread Paul B Mahol
Fixes #1849. Signed-off-by: Paul B Mahol --- libavcodec/amrnbdec.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/libavcodec/amrnbdec.c b/libavcodec/amrnbdec.c index ea299ac..e75df23 100644 --- a/libavcodec/amrnbdec.c +++

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: fix directly setting channel layout

2017-02-21 Thread wm4
On Tue, 21 Feb 2017 10:08:45 +0100 Paul B Mahol wrote: > On 2/21/17, Rostislav Pehlivanov wrote: > > When setting the channel layout directly using AVBufferSrcParameters > > the channel layout was correctly set however the init function still > > expected

Re: [FFmpeg-devel] [PATCH v6] - Added Turing codec interface for ffmpeg

2017-02-21 Thread Saverio Blasi
 > Vertical indentation please. Thanks for this feedback. We have recently circulated a new version of the patch (v7) which fixes these indentation issues. All the best, Saverio Blasi, PhD Senior Research Engineer BBC Research & Development

Re: [FFmpeg-devel] [PATCH v6] - Added Turing codec interface for ffmpeg

2017-02-21 Thread Saverio Blasi
> OK I guess. Could be further beautified, but I'm ok with the current state. This is very good news. We have recently circulated a new version of the patch which fixed some indentation issues. Thanks a lot for the time spent to review our patch. All the best,

Re: [FFmpeg-devel] [PATCH] avformat/sierravmd: Support for Shivers 2 stereo tracks

2017-02-21 Thread Paul B Mahol
On 2/18/17, Nicolas Roy-Renaud wrote: > Signed-off-by: Nicolas Roy-Renaud > --- > libavformat/sierravmd.c | 20 +--- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: fix directly setting channel layout

2017-02-21 Thread Paul B Mahol
On 2/21/17, Rostislav Pehlivanov wrote: > When setting the channel layout directly using AVBufferSrcParameters > the channel layout was correctly set however the init function still > expected the old string format to set the number of channels (when it > hadn't already been

Re: [FFmpeg-devel] [PATCHv2] avcodec/utils: do not reallocate packet buffer for AV_CODEC_ID_WRAPPED_AVFRAME

2017-02-21 Thread wm4
On Mon, 20 Feb 2017 21:11:50 +0100 (CET) Marton Balint wrote: > On Sun, 19 Feb 2017, Hendrik Leppkes wrote: > > > On Sun, Feb 19, 2017 at 2:41 PM, wm4 wrote: > >> On Sun, 19 Feb 2017 14:35:42 +0100 > >> Marton Balint wrote: > >> > >>>