Re: [FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-07-23 Thread Aaron Boxer
On Sun, Jul 23, 2017 at 6:16 PM, Carl Eugen Hoyos wrote: > 2017-07-22 15:39 GMT+02:00 Aaron Boxer : > > > GStreamer project now has a working muxer/demuxer for J2K over MPEG TS. > > Did you test it? > Hi Carl. muxer+demuxer pipeline has been tested in GStreamer. Not tested with any other project

Re: [FFmpeg-devel] [PATCH] avcodec/vorbisdec: Check for legal version, window and transform types

2017-07-23 Thread Tyler Jones
On Mon, Jul 24, 2017 at 02:54:01AM +0200, Carl Eugen Hoyos wrote: > 2017-07-24 2:46 GMT+02:00 Tyler Jones : > > On Mon, Jul 24, 2017 at 01:52:20AM +0200, Carl Eugen Hoyos wrote: > >> 2017-07-24 0:33 GMT+02:00 Tyler Jones : > >> > Vorbis I specification requires that the version number as well as th

Re: [FFmpeg-devel] [PATCH] avcodec/vorbisdec: Check for legal version, window and transform types

2017-07-23 Thread Carl Eugen Hoyos
2017-07-24 2:46 GMT+02:00 Tyler Jones : > On Mon, Jul 24, 2017 at 01:52:20AM +0200, Carl Eugen Hoyos wrote: >> 2017-07-24 0:33 GMT+02:00 Tyler Jones : >> > Vorbis I specification requires that the version number as well as the >> > window and transform types in the setup header be equal to 0. >> >

Re: [FFmpeg-devel] [PATCH] avcodec/vorbisdec: Check for legal version, window and transform types

2017-07-23 Thread Tyler Jones
On Mon, Jul 24, 2017 at 01:52:20AM +0200, Carl Eugen Hoyos wrote: > 2017-07-24 0:33 GMT+02:00 Tyler Jones : > > Vorbis I specification requires that the version number as well as the > > window and transform types in the setup header be equal to 0. > > > > Signed-off-by: Tyler Jones > > --- > > l

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpegvideo_enc: Use intra/inter scantable matching mb type in quantization

2017-07-23 Thread Michael Niedermayer
On Tue, Jun 20, 2017 at 12:37:41AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo_enc.c | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611

Re: [FFmpeg-devel] [PATCH 1/2] fate: add fate-sws-pixdesc-query

2017-07-23 Thread Carl Eugen Hoyos
2017-03-19 15:00 GMT+01:00 Clément Bœsch : > Test the pixel format querying within libswscale. Afaict, this broke fate on big-endian: $ make fate-sws-pixdesc-query TESTsws-pixdesc-query --- ./tests/ref/fate/sws-pixdesc-query 2017-07-23 16:42:59.0 -0700 +++ tests/data/fate/sws-pixdesc-

Re: [FFmpeg-devel] [PATCH] avcodec/vorbisdec: Check for legal version, window and transform types

2017-07-23 Thread Carl Eugen Hoyos
2017-07-24 0:33 GMT+02:00 Tyler Jones : > Vorbis I specification requires that the version number as well as the > window and transform types in the setup header be equal to 0. > > Signed-off-by: Tyler Jones > --- > libavcodec/vorbisdec.c | 18 +++--- > 1 file changed, 15 insertions(+

[FFmpeg-devel] [PATCH] avcodec/vorbisdec: Check for legal version, window and transform types

2017-07-23 Thread Tyler Jones
Vorbis I specification requires that the version number as well as the window and transform types in the setup header be equal to 0. Signed-off-by: Tyler Jones --- libavcodec/vorbisdec.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/libavcodec/vorbisdec.

Re: [FFmpeg-devel] [PATCH] lavfi/testsrc2: fix completely transparent alpha.

2017-07-23 Thread Carl Eugen Hoyos
2017-07-21 15:51 GMT+02:00 Nicolas George : > Le tridi 3 thermidor, an CCXXV, Carl Eugen Hoyos a écrit : >> alpha_value = x * 255 / width; >> or >> alpha_value = y * 255 / height; >> >> Sorry for being unclear, Carl Eugen > > Oh, you mean a gradient on the alpha channel. It is not really possible >

Re: [FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-07-23 Thread Carl Eugen Hoyos
2017-07-22 15:39 GMT+02:00 Aaron Boxer : > GStreamer project now has a working muxer/demuxer for J2K over MPEG TS. Did you test it? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-23 Thread Carl Eugen Hoyos
2017-07-21 20:16 GMT+02:00 Reimar Döffinger : > On 21.07.2017, at 16:26, Paras Chadha wrote: > >> On Fri, Jul 21, 2017 at 3:27 AM, Carl Eugen Hoyos >> wrote: >> >>> 2017-07-20 21:46 GMT+02:00 Paras Chadha : >>> +case AV_PIX_FMT_RGB24: +case AV_PIX_FMT_RGBA:

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Michael Niedermayer
On Sun, Jul 23, 2017 at 02:53:25PM +0200, Reimar Döffinger wrote: > On 23.07.2017, at 13:32, Michael Niedermayer wrote: > > > On Sun, Jul 23, 2017 at 09:35:12AM +0200, Reimar Döffinger wrote: > >> > >> > >> Btw the comodo certificate Michael mentioned is a domain-validation > >> certificate fo

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Maksym Veremeyenko
On 23.07.2017 14:53, Marton Balint wrote: [...] @@ -3012,6 +3014,10 @@ decklink_indev_deps="decklink threads" decklink_indev_extralibs="-lstdc++" decklink_outdev_deps="decklink threads" decklink_outdev_extralibs="-lstdc++" +ndi_indev_deps="ndi pthreads" you only need threads not pthreads.

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Maksym Veremeyenko
On 23.07.2017 18:07, Nicolas George wrote: [...] Maybe it's just me, but I am not sure what kind of probing are you referring to. Could you explain in a bit more detail how the changed code should work? The same way it works for formats without global header, for example MPEG-PS: read_header()

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Maksym Veremeyenko
On 23.07.2017 15:43, Marton Balint wrote: [...] But I think it would be better if you tried to use AVThreadMessageQueue instead. You can extend it if necessary. That is copied from decklink_dec as far as I see. Maybe better to factorize first, and move it to AVThreadMessageQueue as a second ste

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Maksym Veremeyenko
On 23.07.2017 13:20, Nicolas George wrote: Le quintidi 5 thermidor, an CCXXV, Maksym Veremeyenko a écrit : [...] Subject: [PATCH] Implement NewTek NDI support Nit: "lavf: implement..." would it be ok: Subject: [PATCH] lavf: implement NewTek NDI support [...] I would prefer libndi_new

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Nicolas George
Le quintidi 5 thermidor, an CCXXV, Marton Balint a écrit : > That is copied from decklink_dec as far as I see. Maybe better to factorize > first, and move it to AVThreadMessageQueue as a second step? I had not noticed it was copied from decklink_dec. If so, then it must absolutely be shared betwee

Re: [FFmpeg-devel] [PATCH] avfilter/w3fdif: do not write to line before start line

2017-07-23 Thread Muhammad Faiz
On Sat, Jul 22, 2017 at 8:49 PM, Paul B Mahol wrote: > On 7/22/17, Muhammad Faiz wrote: >> That line has been written by previous job. >> Fix tsan warning. >> >> Signed-off-by: Muhammad Faiz >> --- >> libavfilter/vf_w3fdif.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> dif

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Gerion Entrup
Am Sonntag, 23. Juli 2017, 09:27:06 CEST schrieb Reimar Döffinger: > On 21.07.2017, at 15:31, Ricardo Constantino wrote: > > > On 18 July 2017 at 02:12, Gerion Entrup > > wrote: > >> Am Dienstag, 18. Juli 2017, 01:52:53 CEST schrieb Reimar Döffinger: > >>> On 18.07.2017, at 00:59, James Almer

Re: [FFmpeg-devel] patch: typo in doc/filters.texi

2017-07-23 Thread Michael Niedermayer
On Sat, Jul 22, 2017 at 12:42:02AM +0200, Brice Waegenire wrote: > The environment variable used by frei0r filter is named FREI0R_PATH > not FREIOR_PATH. > filters.texi |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 330e0dbdbcc714a9a37819a910f29e7e457ba952 > 0001-doc-filters-typo-

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Reimar Döffinger
On 23.07.2017, at 13:32, Michael Niedermayer wrote: > On Sun, Jul 23, 2017 at 09:35:12AM +0200, Reimar Döffinger wrote: >> >> >> Btw the comodo certificate Michael mentioned is a domain-validation >> certificate for 7x the price of what startcom asked for a personal >> validation certificate

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Reimar Döffinger
On 23.07.2017, at 12:20, Nicolas George wrote: > >> +if (!q->last_pkt) { >> +q->first_pkt = pkt1; >> +} else { >> +q->last_pkt->next = pkt1; >> +} If kept, I would invert the condition, otherwise the else is essentially a double-negation. >> +q->last_pkt = p

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Marton Balint
On Sun, 23 Jul 2017, Nicolas George wrote: [..] +int abort_request; +pthread_mutex_t mutex; +pthread_cond_t cond; +AVFormatContext *avctx; +} AVPacketQueue; This whole API looks duplicated in the encoder. Not acceptable. You need to move it into a pair of .c/.h files, with th

Re: [FFmpeg-devel] [PATCH 2/2] pngdec: decode and expose iCCP chunks as side data

2017-07-23 Thread Michael Niedermayer
On Sat, Jul 22, 2017 at 09:15:53PM +0100, Rostislav Pehlivanov wrote: > On 21 July 2017 at 14:11, Michael Niedermayer > wrote: > > > On Thu, Jul 20, 2017 at 09:46:22PM +0100, Rostislav Pehlivanov wrote: > > > Signed-off-by: Rostislav Pehlivanov > > > --- > > > libavcodec/pngdec.c | 45 +

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Nicolas George
Le quintidi 5 thermidor, an CCXXV, Marton Balint a écrit : > >+if (ctx->video_st || ctx->audio_st) > >+{ > >+ctx->f_started = 1; > >+pthread_create(&ctx->reader, NULL, ndi_reader, ctx); > >+} > > else > ret = AVERROR(EIO); EINVAL, I think. Regards, -- Nicolas

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Marton Balint
On Sun, 23 Jul 2017, Maksym Veremeyenko wrote: Hi, attached patched for HEAD and n3.3 that implemented NewTek NDI, standard created by NewTek to make it easy to develop video-related products that share video on a local Ethernet network. Thanks! Below are some comments. From: Maksym Vere

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Michael Niedermayer
On Sun, Jul 23, 2017 at 09:35:12AM +0200, Reimar Döffinger wrote: > On 23.07.2017, at 09:27, Reimar Döffinger wrote: > > > On 21.07.2017, at 15:31, Ricardo Constantino wrote: > > > >> On 18 July 2017 at 02:12, Gerion Entrup > >> wrote: > >>> Am Dienstag, 18. Juli 2017, 01:52:53 CEST schrieb R

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-23 Thread Nicolas George
Le quartidi 4 thermidor, an CCXXV, Michael Niedermayer a écrit : > we might be able to get away with strings and lower precission. We might be lucky like that, but we cannot expect it to work always: the value always has a small chance to be too near the cutoff value between two rounded numbers.

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Michael Niedermayer
On Sun, Jul 23, 2017 at 11:08:17AM +0300, Maksym Veremeyenko wrote: > Hi, > > attached patched for HEAD and n3.3 that implemented NewTek NDI, > standard created by NewTek to make it easy to develop video-related > products that share video on a local Ethernet network. > > -- > Maksym Veremeyenko

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: Fix decoding regression due to height check

2017-07-23 Thread Michael Niedermayer
On Sat, Jul 22, 2017 at 05:14:10PM +, Kieran Kunhya wrote: > > > > LGTM. Look at Libav repo, it is checked with a_height. > > > > Thank's. > > > > Patch OK. As author of this code I would highly recommend not looking at > libav repo because they broke a ton of stuff. will be in my next git pu

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Nicolas George
Le quintidi 5 thermidor, an CCXXV, Maksym Veremeyenko a écrit : > attached patched for HEAD and n3.3 that implemented NewTek NDI, standard Thanks for the patch. It looks promising. No need to keep the patch for n3.3, new features only go in Git master. And see comments below. > created by NewTe

[FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Maksym Veremeyenko
Hi, attached patched for HEAD and n3.3 that implemented NewTek NDI, standard created by NewTek to make it easy to develop video-related products that share video on a local Ethernet network. -- Maksym Veremeyenko >From d5df13750d029d5314be24c9b1cb7306947507c1 Mon Sep 17 00:00:00 2001 From: M

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Reimar Döffinger
On 23.07.2017, at 09:27, Reimar Döffinger wrote: > On 21.07.2017, at 15:31, Ricardo Constantino wrote: > >> On 18 July 2017 at 02:12, Gerion Entrup wrote: >>> Am Dienstag, 18. Juli 2017, 01:52:53 CEST schrieb Reimar Döffinger: On 18.07.2017, at 00:59, James Almer wrote: > On 7/

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Reimar Döffinger
On 21.07.2017, at 15:31, Ricardo Constantino wrote: > On 18 July 2017 at 02:12, Gerion Entrup wrote: >> Am Dienstag, 18. Juli 2017, 01:52:53 CEST schrieb Reimar Döffinger: >>> On 18.07.2017, at 00:59, James Almer wrote: >>> On 7/17/2017 7:49 PM, Moritz Barsnick wrote: > On Mon, Jul 10