Re: [FFmpeg-devel] [PATCH v2 1/1] avformat/hlsenc: closed caption tags in the master playlist

2018-01-14 Thread Dixit, Vishwanath
On 1/14/18 8:38 PM, Liu Steven wrote: > >> 在 2018年1月9日,下午5:54,Dixit, Vishwanath 写道: >> >> >> >> On 1/9/18 3:05 PM, 刘歧 wrote: >> > > > I cannot sure use -cc_stream_map_ccgroup option is ok, because the > ccgroup string is not standard, maybe it can be defined bu user. > M

Re: [FFmpeg-devel] [PATCH 1/5] lavfi: VAAPI VPP common infrastructure.

2018-01-14 Thread Jun Zhao
On 2018/1/15 6:16, Mark Thompson wrote: > Whole series generally looks good, specific comments follow for each patch. > > Thanks, > > - Mark Thanks the great review for whole series patches, Mark, will follow the comments , Thanks. > > > On 08/01/18 08:33, Jun Zhao wrote: >> From 17278f4481338265

[FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-01-14 Thread Nablet Developer
protocol requires libsrt (https://github.com/Haivision/srt) to be installed Signed-off-by: Nablet Developer --- configure | 9 + doc/protocols.texi | 116 + libavformat/Makefile| 1 + libavformat/opensrt.c | 622 +++

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-01-14 Thread Nablet Developer
On 1/13/2018 4:40 AM, Michael Niedermayer wrote: On Wed, Dec 13, 2017 at 03:31:04PM +0700, Nablet Developer wrote: [...] this is commented out ? yes, looks like leftover, thanks for pointing. will send updated patch soon. ___ ffmpeg-devel mailing li

[FFmpeg-devel] [PATCH] avcodec/snowdec: Fix integer overflow before htaps check

2018-01-14 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: -1094995529 * 2 cannot be represented in type 'int' Fixes: 4828/clusterfuzz-testcase-minimized-5100849937252352 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer -

Re: [FFmpeg-devel] GSoC 2018

2018-01-14 Thread Michael Niedermayer
On Sun, Jan 14, 2018 at 09:28:58PM -0200, Pedro Arthur wrote: > 2018-01-13 23:32 GMT-02:00 Michael Niedermayer : > > > On Fri, Jan 12, 2018 at 11:56:07AM -0200, Pedro Arthur wrote: > > > 2018-01-12 0:06 GMT-02:00 Michael Niedermayer : > > > > > > > if pedro is up to date on this stuff, then maybe

Re: [FFmpeg-devel] [PATCH 6/7] avformat: migrate to AVFormatContext->url

2018-01-14 Thread Michael Niedermayer
On Sun, Jan 14, 2018 at 11:34:03PM +0100, Marton Balint wrote: > > On Sun, 14 Jan 2018, Michael Niedermayer wrote: > > >On Sat, Jan 06, 2018 at 09:50:31PM +0100, Marton Balint wrote: > >>Signed-off-by: Marton Balint > >>--- > >> libavformat/concatdec.c | 4 ++-- > >> libavformat/dashenc

Re: [FFmpeg-devel] GSoC 2018

2018-01-14 Thread Pedro Arthur
2018-01-13 23:32 GMT-02:00 Michael Niedermayer : > On Fri, Jan 12, 2018 at 11:56:07AM -0200, Pedro Arthur wrote: > > 2018-01-12 0:06 GMT-02:00 Michael Niedermayer : > > > > > if pedro is up to date on this stuff, then maybe he wants to mentor > this > > > > > > either way, links to relevant resear

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-01-14 Thread Carl Eugen Hoyos
2017-12-23 23:15 GMT+01:00 Tomas Härdin : > +//check for 0xC0DEC2, return non-zero if it doesn't match > +static int check_magic(uint8_t *ptr) { > +return memcmp(ptr, avpriv_codec2_magic, 3); AV_RB24(), or do I miss something? > +static int codec2_probe(AVProbeData *p) > +{ > +int score

Re: [FFmpeg-devel] [PATCH 4/5] lavfi: add ProcAmp(color balance) vaapi video filter.

2018-01-14 Thread Carl Eugen Hoyos
2018-01-15 0:14 GMT+01:00 Mark Thompson : > On 14/01/18 22:59, Carl Eugen Hoyos wrote: >>> On 08/01/18 08:35, Jun Zhao wrote: >> +VAStatus vas; >> +av_log(avctx, AV_LOG_ERROR, "Failed to Query procamp " + "query caps: %d (%s).\n", vas, vaErrorStr(vas)); >> >

Re: [FFmpeg-devel] [PATCH 4/5] lavfi: add ProcAmp(color balance) vaapi video filter.

2018-01-14 Thread Mark Thompson
On 14/01/18 22:59, Carl Eugen Hoyos wrote: >> On 08/01/18 08:35, Jun Zhao wrote: > >>> +VAStatus vas; > >>> +av_log(avctx, AV_LOG_ERROR, "Failed to Query procamp " >>> + "query caps: %d (%s).\n", vas, vaErrorStr(vas)); > > Is "%d" what it's supposed to be? Why is VAStat

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: add misc(denoise/sharpness) VPP video filter.

2018-01-14 Thread Mark Thompson
On 08/01/18 08:35, Jun Zhao wrote: >> From 5be7c9c55e1ad092223a13f465da3b1a2f1d01b3 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Mon, 8 Jan 2018 16:19:17 +0800 > Subject: [PATCH 5/5] lavfi: add misc(denoise/sharpness) VPP video filter. > > add misc(denoise/sharpness) VPP video filter. > >

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_framerate: add SIMD functions for frame blending

2018-01-14 Thread Marton Balint
On Sun, 14 Jan 2018, Henrik Gramner wrote: On Sat, Jan 13, 2018 at 10:57 PM, Marton Balint wrote: +.loop: +movum0, [src1q + xq] +movum1, [src2q + xq] +punpckl%1%2 m5, m0, m2 ; 0e0f0g0h +punpckh%1%2 m0, m2

Re: [FFmpeg-devel] [PATCH] avfilter: add dumpwave filter.

2018-01-14 Thread Dmytro Humeniuk
Hi > On 14 Jan 2018, at 04:04, Michael Niedermayer wrote: > > On Sat, Jan 13, 2018 at 11:59:59PM +0100, Dmytro Humeniuk wrote: >> Hi, >>> On 12 Jan 2018, at 00:20, Dmitry Gumenyuk wrote: >>> -- >>> Best regards, >>> Dmytro >>> On 11 Jan 2018, at 23:57, Paul B Mahol wrote: > On 1

Re: [FFmpeg-devel] [PATCH 4/5] lavfi: add ProcAmp(color balance) vaapi video filter.

2018-01-14 Thread Carl Eugen Hoyos
> On 08/01/18 08:35, Jun Zhao wrote: >> +VAStatus vas; >> +av_log(avctx, AV_LOG_ERROR, "Failed to Query procamp " >> + "query caps: %d (%s).\n", vas, vaErrorStr(vas)); Is "%d" what it's supposed to be? Why is VAStatus needed then? Carl Eugen ___

Re: [FFmpeg-devel] [PATCH 4/5] lavfi: add ProcAmp(color balance) vaapi video filter.

2018-01-14 Thread Mark Thompson
On 08/01/18 08:35, Jun Zhao wrote: > > From 72b242449086d7366ee524e608bb8f178c15b8cf Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Mon, 8 Jan 2018 16:12:41 +0800 > Subject: [PATCH 4/5] lavfi: add ProcAmp(color balance) vaapi video filter. > > add ProcAmp(color balance) vaapi video filter,

Re: [FFmpeg-devel] [PATCH 3/5] lavfi: use common VPP infrastructure for vf_deinterlace_vaapi.

2018-01-14 Thread Mark Thompson
On 08/01/18 08:35, Jun Zhao wrote: > > From 0274a13bc933e4d82a937afb6886b4132834ecff Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Mon, 8 Jan 2018 16:07:38 +0800 > Subject: [PATCH 3/5] lavfi: use common VPP infrastructure for > vf_deinterlace_vaapi. > > Use the common VPP infrastructure re-

Re: [FFmpeg-devel] [PATCH 6/7] avformat: migrate to AVFormatContext->url

2018-01-14 Thread Marton Balint
On Sun, 14 Jan 2018, Michael Niedermayer wrote: On Sat, Jan 06, 2018 at 09:50:31PM +0100, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/concatdec.c | 4 ++-- libavformat/dashenc.c| 16 libavformat/fifo.c | 8

Re: [FFmpeg-devel] [PATCH 2/5] lavfi: use common VPP infrastructure for vf_scale_vaapi.

2018-01-14 Thread Mark Thompson
On 08/01/18 08:35, Jun Zhao wrote: > > From 24f60485868087906aa479ebf039590338320754 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Mon, 8 Jan 2018 16:02:35 +0800 > Subject: [PATCH 2/5] lavfi: use common VPP infrastructure for vf_scale_vaapi. > > Use the common VPP infrastructure re-work vf_s

Re: [FFmpeg-devel] [PATCH] fix: added more YUVA formats to idet query_formats

2018-01-14 Thread Michael Niedermayer
On Sat, Jan 13, 2018 at 04:51:43PM +0100, Robert Nagy wrote: > --- > libavfilter/vf_idet.c | 2 ++ > 1 file changed, 2 insertions(+) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the de

Re: [FFmpeg-devel] [PATCH 5/5] aptx: add raw muxer and demuxer for aptX HD

2018-01-14 Thread Carl Eugen Hoyos
2018-01-14 14:08 GMT+01:00 Aurelien Jacobs : > Here is an updated version to match the single codec ID > version of the encoder / decoder, by using codec_tag. Please do not set the codec_tag field in the context that a value that was invented within FFmpeg. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH 1/5] lavfi: VAAPI VPP common infrastructure.

2018-01-14 Thread Mark Thompson
Whole series generally looks good, specific comments follow for each patch. Thanks, - Mark On 08/01/18 08:33, Jun Zhao wrote: > From 17278f448133826593941ac6b105a4e81cc8b255 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Mon, 8 Jan 2018 15:56:43 +0800 > Subject: [PATCH 1/5] lavfi: VAAPI VP

Re: [FFmpeg-devel] [PATCH 6/7] avformat: migrate to AVFormatContext->url

2018-01-14 Thread Michael Niedermayer
On Sat, Jan 06, 2018 at 09:50:31PM +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavformat/concatdec.c | 4 ++-- > libavformat/dashenc.c| 16 > libavformat/fifo.c | 8 > libavformat/flvenc.c | 4 ++-

Re: [FFmpeg-devel] [PATCH 4/7] avdevice: migrate to AVFormatContext->url

2018-01-14 Thread Michael Niedermayer
On Sat, Jan 06, 2018 at 09:50:29PM +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavdevice/alsa.c | 4 ++-- > libavdevice/avfoundation.m | 2 +- > libavdevice/bktr.c | 2 +- > libavdevice/caca.c | 2 +- > libavdevice/decklink_

Re: [FFmpeg-devel] [PATCH 7/7] avformat: deprecate AVFormatContext filename field

2018-01-14 Thread Michael Niedermayer
On Sat, Jan 06, 2018 at 09:50:32PM +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > doc/APIchanges | 4 > libavformat/avformat.h | 5 + > libavformat/mux.c | 10 ++ > libavformat/utils.c| 8 > libavformat/version.h | 3 +++ > 5 fil

Re: [FFmpeg-devel] [PATCH 2/7] avformat: add url field to AVFormatContext

2018-01-14 Thread Michael Niedermayer
On Sat, Jan 06, 2018 at 09:50:27PM +0100, Marton Balint wrote: > This will replace the 1024 character limited filename field. Compatiblity for > output contexts are provided by copying filename field to URL if URL is unset > and by providing an internal function for muxers to set both url and filen

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-14 Thread Carl Eugen Hoyos
2018-01-14 14:06 GMT+01:00 Aurelien Jacobs : > Well, here is an updated patch which uses codec tags for the decoder and > profile for the encoder. Sorry but I object to this patch: We should not invent codec_tags. Carl Eugen ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-14 Thread Rostislav Pehlivanov
On 14 January 2018 at 13:06, Aurelien Jacobs wrote: > On Tue, Jan 09, 2018 at 02:21:02PM +, Rostislav Pehlivanov wrote: > > On 9 January 2018 at 14:07, Rostislav Pehlivanov > > wrote: > > > > > > > > > > > On 9 January 2018 at 09:00, Hendrik Leppkes > wrote: > > > > > >> On Tue, Jan 9, 2018

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat/hlsenc: closed caption tags in the master playlist

2018-01-14 Thread Liu Steven
> 在 2018年1月9日,下午5:54,Dixit, Vishwanath 写道: > > > > On 1/9/18 3:05 PM, 刘歧 wrote: > I cannot sure use -cc_stream_map_ccgroup option is ok, because the ccgroup string is not standard, maybe it can be defined bu user. Maybe two ways: 1. use -cc_stream_map_ccgr

Re: [FFmpeg-devel] [PATCH 6/6] dashdec: Support SegmentTemplate inside Period

2018-01-14 Thread Liu Steven
> 在 2018年1月8日,上午2:46,Stefan _ 写道: > > > <0006-dashdec-Support-SegmentTemplate-inside-Period.patch>___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Patchset pushed Thanks __

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-14 Thread Martin Vignali
Hello, new patch in attach no more segfault if i remove movsxdifnidn, after change in the "declare_func_emms" part I also modify the checkasm test, following your comments Martin 0001-avcodec-utvideoenc-add-SIMD-avx-for-sub_left_predict.patch Description: Binary data 0002-checkasm-add-test-f

Re: [FFmpeg-devel] [PATCH] avformat/adtsenc - allow only AAC streams

2018-01-14 Thread James Almer
On 1/14/2018 9:06 AM, Gyan Doshi wrote: > From c3da268449ca4677958856d99b0d1ce4695f0924 Mon Sep 17 00:00:00 2001 > From: Gyan Doshi > Date: Sun, 14 Jan 2018 17:30:23 +0530 > Subject: [PATCH] avformat/adtsenc - allow only AAC streams > > The ADTS muxer will silently (attempt to) mux any audio stre

Re: [FFmpeg-devel] [PATCH 5/5] aptx: add raw muxer and demuxer for aptX HD

2018-01-14 Thread Aurelien Jacobs
On Sun, Jan 07, 2018 at 04:55:43PM +0100, Aurelien Jacobs wrote: > On Sun, Jan 07, 2018 at 12:53:27AM +0100, Michael Niedermayer wrote: > > On Sat, Jan 06, 2018 at 05:48:08PM +0100, Aurelien Jacobs wrote: > > > --- > > > Changelog| 2 +- > > > libavformat/Makefile | 2 ++ > >

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-14 Thread Aurelien Jacobs
On Tue, Jan 09, 2018 at 02:21:02PM +, Rostislav Pehlivanov wrote: > On 9 January 2018 at 14:07, Rostislav Pehlivanov > wrote: > > > > > > > On 9 January 2018 at 09:00, Hendrik Leppkes wrote: > > > >> On Tue, Jan 9, 2018 at 9:33 AM, Hendrik Leppkes > >> wrote: > >> > On Tue, Jan 9, 2018 at 5

[FFmpeg-devel] [PATCH] avformat/adtsenc - allow only AAC streams

2018-01-14 Thread Gyan Doshi
From c3da268449ca4677958856d99b0d1ce4695f0924 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sun, 14 Jan 2018 17:30:23 +0530 Subject: [PATCH] avformat/adtsenc - allow only AAC streams The ADTS muxer will silently (attempt to) mux any audio stream passed to it. Patch adds a codec check. --- liba

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-14 Thread James Almer
On 1/14/2018 7:46 AM, Henrik Gramner wrote: > On Sat, Jan 13, 2018 at 5:22 PM, Martin Vignali > wrote: >> +#define randomize_buffers(buf, size) \ >> +do { \ >> +int j; \ >> +uint8_t *tmp_buf = (uint8_t *)buf;\ >> +

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-14 Thread Henrik Gramner
On Sat, Jan 13, 2018 at 5:22 PM, Martin Vignali wrote: > +#define randomize_buffers(buf, size) \ > +do { \ > +int j; \ > +uint8_t *tmp_buf = (uint8_t *)buf;\ > +for (j = 0; j < size; j++) \ > +

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_framerate: add SIMD functions for frame blending

2018-01-14 Thread Henrik Gramner
On Sat, Jan 13, 2018 at 10:57 PM, Marton Balint wrote: > +.loop: > +movum0, [src1q + xq] > +movum1, [src2q + xq] > +punpckl%1%2 m5, m0, m2 ; 0e0f0g0h > +punpckh%1%2 m0, m2 ; 0a0b0c0d > +punpckl%1%2