Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Don't return error if the underlying driver doesn't support B frame

2018-03-06 Thread Xiang, Haihao
Hi Mark, Do you have any comment to this patch? FFmpeg-vaapi fails to use low power mode for H.264 encoding. Thanks Haihao > On Wed, 2018-02-07 at 10:31 +0800, Jun Zhao wrote: > > > > On 2018/2/6 16:17, Haihao Xiang wrote: > > > It is possible B frame is not supported for VAEntrypointEncSliceL

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Don't pass VAConfigAttribEncPackedHeaders with value set to 0

2018-03-06 Thread Xiang, Haihao
On Tue, 2018-03-06 at 14:42 +, Mark Thompson wrote: > On 06/03/18 06:04, Eoff, Ullysses A wrote: > > > -Original Message- > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > > > Mark Thompson > > > Sent: Tuesday, February 13, 2018 11:54 AM > > > To: FFmpeg d

[FFmpeg-devel] h.264 and h.265 bitstream consultant needed

2018-03-06 Thread Alex Day
Hello, Our company has need of some consulting services to support some development potentially including direct bitstream modifications to h.264 and h.265 bit streams. Would anyone be able to provide these sort of consultancy services? If so, what are your normal arrangements for this kind of

[FFmpeg-devel] [PATCH v2] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-06 Thread Yingming Fan
From: Yingming Fan --- Previous patch test 8 9 and 10 bit depth, because i consult codes from hevc_idct and hevc_add_res. While this patch test 8 10 and 12 bit depth like what VP9 does. I will submit another patch fix these issue in hevc_idct and hevc_add_res. This patch also refined randomi

Re: [FFmpeg-devel] GSoC

2018-03-06 Thread Dylan Fernando
Thanks, it works now Would trying to implement an OpenCL version of vf_fade be a good idea for a qualification task, or would it be a better idea to try a different filter? Regards, Dylan On Wed, Mar 7, 2018 at 1:20 AM, Mark Thompson wrote: > On 06/03/18 12:37, Dylan Fernando wrote: > > Hi, >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: free existing extradata before trying to allocate a new one

2018-03-06 Thread James Almer
On 3/6/2018 11:40 PM, Michael Niedermayer wrote: > On Tue, Mar 06, 2018 at 11:27:54PM -0300, James Almer wrote: >> On 3/6/2018 11:03 PM, James Almer wrote: >>> On 3/6/2018 10:47 PM, Michael Niedermayer wrote: On Tue, Mar 06, 2018 at 01:42:36AM -0300, James Almer wrote: > This prevents leak

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: free existing extradata before trying to allocate a new one

2018-03-06 Thread Michael Niedermayer
On Tue, Mar 06, 2018 at 11:27:54PM -0300, James Almer wrote: > On 3/6/2018 11:03 PM, James Almer wrote: > > On 3/6/2018 10:47 PM, Michael Niedermayer wrote: > >> On Tue, Mar 06, 2018 at 01:42:36AM -0300, James Almer wrote: > >>> This prevents leaks in the rare cases the function is called when > >

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-06 Thread Yingming Fan
Hi James, I agree with what you said, we should test 8 10 and 12 bit. But i noticed that hevc_idct and hevc_add_res also not test 12 bit. I think we should also add 12 bit for these checkasm codes. 2018-03-06 21:55 GMT+08:00 James Almer : > On 3/3/2018 12:15 AM, Yingming Fan wrote: > > --- > >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: free existing extradata before trying to allocate a new one

2018-03-06 Thread James Almer
On 3/6/2018 11:29 PM, Michael Niedermayer wrote: > On Tue, Mar 06, 2018 at 11:03:55PM -0300, James Almer wrote: >> On 3/6/2018 10:47 PM, Michael Niedermayer wrote: >>> On Tue, Mar 06, 2018 at 01:42:36AM -0300, James Almer wrote: This prevents leaks in the rare cases the function is called when

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: free existing extradata before trying to allocate a new one

2018-03-06 Thread Michael Niedermayer
On Tue, Mar 06, 2018 at 11:03:55PM -0300, James Almer wrote: > On 3/6/2018 10:47 PM, Michael Niedermayer wrote: > > On Tue, Mar 06, 2018 at 01:42:36AM -0300, James Almer wrote: > >> This prevents leaks in the rare cases the function is called when extradata > >> already exists. > >> > >> Signed-off

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: free existing extradata before trying to allocate a new one

2018-03-06 Thread James Almer
On 3/6/2018 11:03 PM, James Almer wrote: > On 3/6/2018 10:47 PM, Michael Niedermayer wrote: >> On Tue, Mar 06, 2018 at 01:42:36AM -0300, James Almer wrote: >>> This prevents leaks in the rare cases the function is called when extradata >>> already exists. >>> >>> Signed-off-by: James Almer >>> ---

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: free existing extradata before trying to allocate a new one

2018-03-06 Thread James Almer
On 3/6/2018 10:47 PM, Michael Niedermayer wrote: > On Tue, Mar 06, 2018 at 01:42:36AM -0300, James Almer wrote: >> This prevents leaks in the rare cases the function is called when extradata >> already exists. >> >> Signed-off-by: James Almer >> --- >> libavformat/utils.c | 1 + >> 1 file changed

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: free existing extradata before trying to allocate a new one

2018-03-06 Thread Michael Niedermayer
On Tue, Mar 06, 2018 at 01:42:36AM -0300, James Almer wrote: > This prevents leaks in the rare cases the function is called when extradata > already exists. > > Signed-off-by: James Almer > --- > libavformat/utils.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/utils.c b/

Re: [FFmpeg-devel] [PATCH 1/5] CodeAi generated fix for CWE 476 Null Pointer Dereference

2018-03-06 Thread Michael Niedermayer
On Tue, Mar 06, 2018 at 05:42:19PM -0500, C0deAi wrote: > Tighten condition to prevent possible Null Dereference from > access to field 'pts' loaded from variable 'in'. > > Signed-off-by: C0deAi > --- > libavfilter/af_afade.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) breaks fate-f

Re: [FFmpeg-devel] [PATCH] reitnerlace - tinterlace-like filter under LGPL

2018-03-06 Thread Thomas Mundt
2018-03-07 0:49 GMT+01:00 Carl Eugen Hoyos : > 2018-03-06 19:38 GMT+01:00, Thomas Mundt : > > > > 2018-03-05 13:48 GMT+01:00 Carl Eugen Hoyos : > > > >> 2018-03-05 12:37 GMT+01:00, Paul B Mahol : > >> > On 3/5/18, Vasile Toncu wrote: > >> >> Hello, > >> >> > >> >> Thanks for the review. I've made

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_*_vaapi: Add missing AV_OPT_FLAG_FILTERING_PARAM

2018-03-06 Thread Michael Niedermayer
On Wed, Mar 07, 2018 at 08:08:52AM +0800, Jun Zhao wrote: > > > On 2018/3/6 22:43, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/vf_misc_vaapi.c| 2 +- > > libavfilter/vf_procamp_vaapi.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH 2/3] mpegvideo_parser: parse the output picture number

2018-03-06 Thread Michael Niedermayer
On Sun, Feb 11, 2018 at 08:31:40PM +0200, Jan Ekström wrote: > On Sun, Feb 11, 2018 at 7:52 PM, Michael Niedermayer > wrote: > > > > should be ok unless its intended to also restore the MSB > > > > The value seemed to be 10bit and if the pointer is at the position > right after the picture_start_

Re: [FFmpeg-devel] [PATCH 3/3] mpegvideo_parser: fix indentation of an if statement

2018-03-06 Thread Jan Ekström
On Tue, Mar 6, 2018 at 10:39 AM, Paul B Mahol wrote: > LGTM Cheers, pushed. Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_*_vaapi: Add missing AV_OPT_FLAG_FILTERING_PARAM

2018-03-06 Thread Jun Zhao
On 2018/3/6 22:43, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_misc_vaapi.c| 2 +- > libavfilter/vf_procamp_vaapi.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_misc_vaapi.c b/libavfilter/vf_misc_vaapi.

Re: [FFmpeg-devel] [PATCH v2] libavformat/tls: pass numeric hostnames to tls_connect_cbs()

2018-03-06 Thread Jan Ekström
On Sat, Mar 3, 2018 at 10:30 PM, Jan Ekström wrote: > On Wed, Feb 21, 2018 at 7:57 PM, Stefan _ wrote: >> Hadn't seen that one, it does indeed describe this exact problem. >> I've included it in the commit message, new patch attached. >> > > Generally LGTM after checking the patch on patchwork >

Re: [FFmpeg-devel] [PATCH] reitnerlace - tinterlace-like filter under LGPL

2018-03-06 Thread Carl Eugen Hoyos
2018-03-06 19:38 GMT+01:00, Thomas Mundt : > > 2018-03-05 13:48 GMT+01:00 Carl Eugen Hoyos : > >> 2018-03-05 12:37 GMT+01:00, Paul B Mahol : >> > On 3/5/18, Vasile Toncu wrote: >> >> Hello, >> >> >> >> Thanks for the review. I've made changes according to your guidance. >> >> >> >> It would be gre

Re: [FFmpeg-devel] [PATCH 4/5] CodeAi generated fix for CWE 561 Dead Code

2018-03-06 Thread Mark Thompson
On 06/03/18 22:42, C0deAi wrote: > Signed-off-by: C0deAi > --- > libavcodec/h264_metadata_bsf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c > index 89bdedf..09b3f1a 100644 > --- a/libavcodec/h264_metadata_bsf.c > +++ b/l

Re: [FFmpeg-devel] [PATCH] reitnerlace - tinterlace-like filter under LGPL

2018-03-06 Thread Carl Eugen Hoyos
2018-03-05 13:53 GMT+01:00, Paul B Mahol : > On 3/5/18, Carl Eugen Hoyos wrote: >> 2018-03-05 12:37 GMT+01:00, Paul B Mahol : >>> On 3/5/18, Vasile Toncu wrote: Hello, Thanks for the review. I've made changes according to your guidance. It would be great to know if the co

[FFmpeg-devel] [PATCH]lavfi/drawutils: Do not claim to support P016

2018-03-06 Thread Carl Eugen Hoyos
Hi! Attached patch fixes fate on big-endian, I failed to fix drawutils for P016. Please comment (or fix the underlying issue), Carl Eugen From 5254acb48a67adc10e2651c6be449e11ecd8cb74 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 7 Mar 2018 00:36:21 +0100 Subject: [PATCH] lavfi/draw

Re: [FFmpeg-devel] [PATCH 3/5] CodeAi generated fix for CWE 457 Uninitialized Variable

2018-03-06 Thread Nicolas George
C0deAi (2018-03-06): > Prevent passing of uninitialized value 'buf[i]' as function > call argument on line 222. > > Signed-off-by: C0deAi > --- > libavutil/hash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Nack. buf[i] cannot be unitialized at this point. Also, the first line of c

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec_wrapper: fix false positives in swdec blacklist

2018-03-06 Thread Jan Ekström
On Wed, Mar 7, 2018 at 12:19 AM, Stefan _ wrote: > Hi, > > attached patch fixes an issue with the previous mediacodec patch. > LGTM. `strstr(name, "OMX.SEC") && strstr(name, ".sw.")` ..will most likely have less false positives as OMX.SEC seems to be utilized for HW decoders on some Exynos SoCs

[FFmpeg-devel] [PATCH 4/5] CodeAi generated fix for CWE 561 Dead Code

2018-03-06 Thread C0deAi
Signed-off-by: C0deAi --- libavcodec/h264_metadata_bsf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 89bdedf..09b3f1a 100644 --- a/libavcodec/h264_metadata_bsf.c +++ b/libavcodec/h264_metadata_bsf.c @@ -344,7 +344,6 @@ s

[FFmpeg-devel] [PATCH 0/5] CodeAi fixes: 1 Null Deref, 2 Dead Code, 2 Uninitialized Variables

2018-03-06 Thread C0deAi
CodeAI (www.mycode.ai) found 233 defects and fixed 205 in FFmpeg. It wants to merge commits fixing 5 of these issues- 1 Null Pointer Dereference, 2 Dead Code, and 2 Uninitialized Variables. A screenshot of the results as well as the Dockerfile used to build and run your project in CodeAI can be

[FFmpeg-devel] [PATCH 3/5] CodeAi generated fix for CWE 457 Uninitialized Variable

2018-03-06 Thread C0deAi
Prevent passing of uninitialized value 'buf[i]' as function call argument on line 222. Signed-off-by: C0deAi --- libavutil/hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hash.c b/libavutil/hash.c index 75edb6d..593176c 100644 --- a/libavutil/hash.c +++ b/lib

[FFmpeg-devel] [PATCH 5/5] CodeAi generated fix for CWE 561 Dead Code

2018-03-06 Thread C0deAi
Signed-off-by: C0deAi --- libavcodec/indeo3.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/indeo3.c b/libavcodec/indeo3.c index 71d478c..ebd8ab9 100644 --- a/libavcodec/indeo3.c +++ b/libavcodec/indeo3.c @@ -657,7 +657,6 @@ static int decode_cell(Indeo3DecodeContext *ctx, AVCode

[FFmpeg-devel] [PATCH 1/5] CodeAi generated fix for CWE 476 Null Pointer Dereference

2018-03-06 Thread C0deAi
Tighten condition to prevent possible Null Dereference from access to field 'pts' loaded from variable 'in'. Signed-off-by: C0deAi --- libavfilter/af_afade.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_afade.c b/libavfilter/af_afade.c index 285b5b6..7f5106e

[FFmpeg-devel] [PATCH 2/5] CodeAi generated fix for CWE 457 Uninitialized Variable

2018-03-06 Thread C0deAi
Prevent uninitialized value 'pb[1]' being passed as an argument on line 143. Signed-off-by: C0deAi --- libavformat/img2enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index a09cc8e..6cfbaa2 100644 --- a/libavformat/img2enc.c

[FFmpeg-devel] [PATCH] avcodec/mpeg12dec: ignore scte20 captions when a53 data is also present

2018-03-06 Thread Aman Gupta
From: Aman Gupta Some streams include both a53 and scte20 data. Before this commit, the scte20 data would be used instead of the a53 data. See https://s3.amazonaws.com/tmm1/ccaptions/scte20plusa53.ts, which produced garbage captions since 3f1a540204a8c187f77b3805d. --- libavcodec/mpeg12dec.c |

Re: [FFmpeg-devel] Fix stts_data memory allocation

2018-03-06 Thread 王消寒
kingly ping! On Tue, Feb 13, 2018 at 4:08 PM, Xiaohan Wang (王消寒) wrote: > "unsigned" is perfectly fine. Just trying to be consistent with the line > above. > > On Tue, Feb 13, 2018 at 4:06 PM, Carl Eugen Hoyos > wrote: > >> 2018-02-13 23:48 GMT+01:00 Xiaohan Wang (王消寒) : >> >> Thank you for the

[FFmpeg-devel] [PATCH] avcodec/mediacodec_wrapper: fix false positives in swdec blacklist

2018-03-06 Thread Stefan _
Hi, attached patch fixes an issue with the previous mediacodec patch. From b6a8721679483900b4f824504fdb1f7944ec268f Mon Sep 17 00:00:00 2001 From: sfan5 Date: Tue, 6 Mar 2018 23:14:09 +0100 Subject: [PATCH] avcodec/mediacodec_wrapper: fix false positives in swdec blacklist 'OMX.SEC.avc.dec' is

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: free existing extradata before trying to allocate a new one

2018-03-06 Thread James Almer
On 3/6/2018 11:29 AM, Paul B Mahol wrote: > On 3/6/18, James Almer wrote: >> This prevents leaks in the rare cases the function is called when extradata >> already exists. >> >> Signed-off-by: James Almer >> --- >> libavformat/utils.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/l

[FFmpeg-devel] [PATCH 1/2] libavformat/oggparsevorbis: Fix memleak on multiple headers

2018-03-06 Thread Michael Niedermayer
Fixes: Chromium bug 800123 Reported-by: Matt Wolenetz Reviewed-by: Matt Wolenetz Signed-off-by: Michael Niedermayer --- libavformat/oggparsevorbis.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c index 29b1ab514e..bcfd246b8d 1

[FFmpeg-devel] [PATCH 2/2] avformat/oggdec: Fix metadata memleak on multiple headers

2018-03-06 Thread Michael Niedermayer
Fixes: Chromium bug 800123 Reported-by: Matt Wolenetz Reviewed-by: Matt Wolenetz Signed-off-by: Michael Niedermayer --- libavformat/oggdec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c index 38f60653f9..27d16a3e4e 100644 --

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec_wrapper: blacklist more software decoders

2018-03-06 Thread Matthieu Bouron
On Tue, Mar 06, 2018 at 06:00:27PM +, Stefan _ wrote: > Hi, > > for hwdec on Android the wrapper attempts to blacklist known software > decoders also provided through the mediacodec API. The list isn't complete > however and ffmpeg might e.g. prefer slower "external" HEVC software decoding

Re: [FFmpeg-devel] [PATCH 2/2] MAINTAINERS: add myself to mediacodec

2018-03-06 Thread Matthieu Bouron
On Tue, Mar 06, 2018 at 01:33:20PM -0800, Aman Gupta wrote: > From: Aman Gupta > > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index cc4c23df6f..3c54ad6781 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -268,7 +268,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec: reduce loglevel for per-frame logging

2018-03-06 Thread Matthieu Bouron
On Tue, Mar 06, 2018 at 01:33:19PM -0800, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/mediacodecdec_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mediacodecdec_common.c > b/libavcodec/mediacodecdec_common.c > index 929db78361..0bd660

[FFmpeg-devel] [PATCH 2/2] MAINTAINERS: add myself to mediacodec

2018-03-06 Thread Aman Gupta
From: Aman Gupta --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cc4c23df6f..3c54ad6781 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -268,7 +268,7 @@ Hardware acceleration: crystalhd.c Philip Langda

[FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec: reduce loglevel for per-frame logging

2018-03-06 Thread Aman Gupta
From: Aman Gupta --- libavcodec/mediacodecdec_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c index 929db78361..0bd660f7c9 100644 --- a/libavcodec/mediacodecdec_common.c +++ b/libavcodec/mediacode

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec_wrapper: blacklist more software decoders

2018-03-06 Thread Aman Gupta
On Tue, Mar 6, 2018 at 10:00 AM, Stefan _ wrote: > Hi, > > for hwdec on Android the wrapper attempts to blacklist known software > decoders also provided through the mediacodec API. The list isn't complete > however and ffmpeg might e.g. prefer slower "external" HEVC software > decoding over its

[FFmpeg-devel] [PATCH 2/2] avcodec/mediacodecdec: add more trace logging of input/output buffers

2018-03-06 Thread Aman Gupta
From: Aman Gupta --- libavcodec/mediacodec.c | 1 + libavcodec/mediacodecdec_common.c | 4 libavcodec/mediacodecdec_common.h | 1 + 3 files changed, 6 insertions(+) diff --git a/libavcodec/mediacodec.c b/libavcodec/mediacodec.c index bf1b7477f1..5cb96d2b65 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 1/2] avcodec/mediacodecdec: add delay_flush option

2018-03-06 Thread Aman Gupta
From: Aman Gupta The default behavior of the mediacodec decoder before this commit was to delay flushes until all pending hardware frames were returned to the decoder. This was useful for certain types of applications, but was unexpected behavior for others. The new default behavior with this co

[FFmpeg-devel] [PATCH] avcodec/noise_bsf: Add keyframes option.

2018-03-06 Thread Josh Allmann
--- doc/bitstream_filters.texi | 5 + libavcodec/noise_bsf.c | 12 libavcodec/version.h | 2 +- 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index cfd81fa12d..a9f17f32ec 100644 --- a/doc/bitstrea

[FFmpeg-devel] [PATCH] avcodec/aacdec: log configuration change details

2018-03-06 Thread Aman Gupta
From: Aman Gupta --- libavcodec/aacdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 44352764a7..d394700cdc 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -318,8 +318,8 @@ static int latm_decode_audio_spec

[FFmpeg-devel] [PATCH] lavc: Add filter_units bitstream filter

2018-03-06 Thread Mark Thompson
This can remove units with types in or not in a given set from a stream. For example, it can be used to remove all non-VCL NAL units from an H.264 or H.265 stream. --- On 06/03/18 17:27, Hendrik Leppkes wrote: > On Tue, Mar 6, 2018 at 3:51 PM, Eran Kornblau > wrote: >> Hi all, >> >> The attached

Re: [FFmpeg-devel] [PATCH] reitnerlace - tinterlace-like filter under LGPL

2018-03-06 Thread Thomas Mundt
Hi, 2018-03-05 13:48 GMT+01:00 Carl Eugen Hoyos : > 2018-03-05 12:37 GMT+01:00, Paul B Mahol : > > On 3/5/18, Vasile Toncu wrote: > >> Hello, > >> > >> Thanks for the review. I've made changes according to your guidance. > >> > >> It would be great to know if the community will go on with our in

[FFmpeg-devel] [PATCH] avcodec/mediacodec_wrapper: blacklist more software decoders

2018-03-06 Thread Stefan _
Hi, for hwdec on Android the wrapper attempts to blacklist known software decoders also provided through the mediacodec API. The list isn't complete however and ffmpeg might e.g. prefer slower "external" HEVC software decoding over its own software decoder. This patch completes the list of kno

Re: [FFmpeg-devel] ALS encoder

2018-03-06 Thread Umair Khan
On Tue, Mar 6, 2018 at 8:14 PM, Paul B Mahol wrote: > On 3/5/18, Oleg Khokhlov wrote: >> Hi all. >> >> I am student and my name is Oleg. I work on qualification task for GSoC >> 2018. >> I should implement float-point support to als encoder. > > Isn't that a little too much for qualification task

Re: [FFmpeg-devel] [PATCH] lavf/oggparseflac: Free flac extradata before reallocating.

2018-03-06 Thread Matthew Wolenetz
SGTM. Thanks James. On Tue, Mar 6, 2018 at 6:23 AM, James Almer wrote: > On 3/5/2018 10:04 PM, Matthew Wolenetz wrote: > > Perhaps true, but there are a ton of paths to ff_alloc_extradata that are > > not included in Chromium. Such a wider, general, fix seems more > appropriate > > to land upstr

Re: [FFmpeg-devel] avformat/movenc: add param for filtering nal types

2018-03-06 Thread Hendrik Leppkes
On Tue, Mar 6, 2018 at 3:51 PM, Eran Kornblau wrote: > Hi all, > > The attached patch adds a parameter that enables the user to choose which > AVC/HEVC NAL units to include in the output. > The parameter is supplied as a bitmask in order to keep things simple. > > A short background on why we nee

[FFmpeg-devel] avformat/movenc: add param for filtering nal types

2018-03-06 Thread Eran Kornblau
Hi all, The attached patch adds a parameter that enables the user to choose which AVC/HEVC NAL units to include in the output. The parameter is supplied as a bitmask in order to keep things simple. A short background on why we need it - in our transcoding process, we partition the video in chun

[FFmpeg-devel] [PATCH 2/2] avformat/mov: Fix integer overflow in mov_get_stsc_samples()

2018-03-06 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: 5 * -2147483647 cannot be represented in type 'int' Fixes: Chromium bug 817338 Reviewed-by: Matt Wolenetz Reported-by: Matt Wolenetz Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions

Re: [FFmpeg-devel] ALS encoder

2018-03-06 Thread Paul B Mahol
On 3/5/18, Oleg Khokhlov wrote: > Hi all. > > I am student and my name is Oleg. I work on qualification task for GSoC > 2018. > I should implement float-point support to als encoder. Isn't that a little too much for qualification task? > > A have some questions: > 1)In documentation was written

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_*_vaapi: Add missing AV_OPT_FLAG_FILTERING_PARAM

2018-03-06 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/vf_misc_vaapi.c| 2 +- libavfilter/vf_procamp_vaapi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_misc_vaapi.c b/libavfilter/vf_misc_vaapi.c index 8b179fe215..30b808a993 100644 --- a/libavfilter/vf_mi

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Don't pass VAConfigAttribEncPackedHeaders with value set to 0

2018-03-06 Thread Mark Thompson
On 06/03/18 06:04, Eoff, Ullysses A wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Mark Thompson >> Sent: Tuesday, February 13, 2018 11:54 AM >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATC

Re: [FFmpeg-devel] [PATCH 2/2] avformat/utils: simplify ff_alloc_extradata()

2018-03-06 Thread Paul B Mahol
On 3/6/18, James Almer wrote: > Cosmetic refactor > > Signed-off-by: James Almer > --- > libavformat/utils.c | 26 +++--- > 1 file changed, 11 insertions(+), 15 deletions(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 31340a484b..3ca1ca2441 100644 > ---

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: free existing extradata before trying to allocate a new one

2018-03-06 Thread Paul B Mahol
On 3/6/18, James Almer wrote: > This prevents leaks in the rare cases the function is called when extradata > already exists. > > Signed-off-by: James Almer > --- > libavformat/utils.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 7253

Re: [FFmpeg-devel] [PATCH] lavf/oggparseflac: Free flac extradata before reallocating.

2018-03-06 Thread James Almer
On 3/5/2018 10:04 PM, Matthew Wolenetz wrote: > Perhaps true, but there are a ton of paths to ff_alloc_extradata that are > not included in Chromium. Such a wider, general, fix seems more appropriate > to land upstream first with more testing. The function allocates a buffer and overwrites the poi

Re: [FFmpeg-devel] GSoC

2018-03-06 Thread Mark Thompson
On 06/03/18 12:37, Dylan Fernando wrote: > Hi, > > I am Dylan Fernando. I am a Computer Science student from Australia. I am > new to FFmpeg and I wish to apply for GSoC this year. > I would like to do the Video filtering with OpenCL project and I have a few > questions. Would trying to implement

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-06 Thread James Almer
On 3/3/2018 12:15 AM, Yingming Fan wrote: > --- > tests/checkasm/Makefile | 2 +- > tests/checkasm/checkasm.c | 1 + > tests/checkasm/checkasm.h | 1 + > tests/checkasm/hevc_sao.c | 158 > ++ > tests/fate/checkasm.mak | 1 + > 5 files change

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-06 Thread Yingming Fan
Hi there. We are working on add some neon optimization for hevc decoder. But before submit neon codes, i'd like to submit some checkasm codes. First one will be checkasm codes of SAO. I tested this path under MacOS 10.13.3 and Debian, all FATE case passed. So will anyone review this patch? Yi

[FFmpeg-devel] GSoC

2018-03-06 Thread Dylan Fernando
Hi, I am Dylan Fernando. I am a Computer Science student from Australia. I am new to FFmpeg and I wish to apply for GSoC this year. I would like to do the Video filtering with OpenCL project and I have a few questions. Would trying to implement an opencl version of vf_fade be a good idea for the q

Re: [FFmpeg-devel] [PATCH v2 1/1] libavformat/hlsenc: Option to set timeout for socket I/O operation

2018-03-06 Thread Steven Liu
> On 5 Mar 2018, at 17:41, rpata...@akamai.com wrote: > > From: Ravindra > > --- > doc/muxers.texi | 3 +++ > libavformat/hlsenc.c | 5 - > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index c156ec0..3a63da7 100644 > --- a/doc/mux

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: disable h264 look_ahead by default

2018-03-06 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Tuesday, March 6, 2018 8:32 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: disable h264 look_ahead > by default > > On 01/03/18 05:20, Zhong Li wrote: > > Look_ah

Re: [FFmpeg-devel] [PATCH 3/3] mpegvideo_parser: fix indentation of an if statement

2018-03-06 Thread Paul B Mahol
On 3/6/18, Jan Ekstroem wrote: > On Sun, Feb 11, 2018 at 4:37 PM, Jan Ekstroem wrote: >> From: Masaki Tanaka >> >> --- >> libavcodec/mpegvideo_parser.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/mpegvideo_parser.c b/libavcodec/mpegvideo_parser.c >> in