[FFmpeg-devel] [PATCH] avformat/flacenc: support writing attached pictures

2018-04-14 Thread James Almer
From: Rodger Combs Signed-off-by: James Almer --- Changed to not try to mux any kind of video as cover art and instead only bother with streams marked as attached pictures. Also using each stream's priv_data to hold the picture instead of an array in

Re: [FFmpeg-devel] [PATCH 5/5] amfenc: Remove spurious initialisations

2018-04-14 Thread Alexander Kravchenko
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark > Thompson > Sent: Saturday, April 14, 2018 6:54 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 5/5] amfenc: Remove spurious initialisations > Hi Mark, I reviewed

[FFmpeg-devel] [PATCH] avdevice/decklink_commmon: enhance error messages when iterator creation fails

2018-04-14 Thread Marton Balint
Show a more useful error message which specifies the required driver version for the build, and use the correct context in the error message for WIN32. Signed-off-by: Marton Balint --- libavdevice/decklink_common.cpp | 28 ++-- 1 file changed, 14

[FFmpeg-devel] [PATCH] swresample/arm: avoid conditional branch to PLT in THUMB-2.

2018-04-14 Thread Rahul Chaudhry
When compiling for THUMB-2, the conditional branch to PLT results in a R_ARM_THM_JUMP19 relocation. Some linkers don't support this relocation in THUMB-2 (ld.gold), while others can end up truncating the relocation to fit (ld.bfd). Adding an "it eq" before the branch converts it into an

Re: [FFmpeg-devel] [PATCH] use bcrypt instead of the old wincrypt API

2018-04-14 Thread Michael Niedermayer
On Sat, Apr 14, 2018 at 07:10:40PM -0300, James Almer wrote: > On 4/3/2018 8:49 PM, Michael Niedermayer wrote: > > On Tue, Apr 03, 2018 at 11:44:25AM +0200, Steve Lhomme wrote: > >> Remove the wincrypt API calls since we don't support XP anymore and bcrypt > >> is > >> available since Vista, even

Re: [FFmpeg-devel] [PATCH] use bcrypt instead of the old wincrypt API

2018-04-14 Thread James Almer
On 4/3/2018 8:49 PM, Michael Niedermayer wrote: > On Tue, Apr 03, 2018 at 11:44:25AM +0200, Steve Lhomme wrote: >> Remove the wincrypt API calls since we don't support XP anymore and bcrypt is >> available since Vista, even on Windows Store builds. >> --- >> configure | 6 +++--- >>

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-14 Thread Paul B Mahol
On 4/14/18, Martin Vignali wrote: >> >> Please use short name for options, max 2 characters. >> >> The log scale shows nothing even thought there is no silence. Perhaps >> use ceil()? >> > Doesn't understand this part. > Do you mean, you think the log scale display

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-14 Thread Martin Vignali
> > Please use short name for options, max 2 characters. > > The log scale shows nothing even thought there is no silence. Perhaps > use ceil()? > Doesn't understand this part. Do you mean, you think the log scale display option is not a good idea ? Or doesn't work in some case ? In my test, the

Re: [FFmpeg-devel] [PATCH] lavc/amfenc: DXVA2 textures support implementation by AMF encoder

2018-04-14 Thread Alexander Kravchenko
> -Original Message- > From: Alexander Kravchenko [mailto:akravchenko...@gmail.com] > Sent: Sunday, April 15, 2018 12:02 AM > To: 'FFmpeg development discussions and patches' > Subject: RE: [FFmpeg-devel] [PATCH] lavc/amfenc: DXVA2 textures support >

Re: [FFmpeg-devel] [PATCH] lavc/amfenc: DXVA2 textures support implementation by AMF encoder

2018-04-14 Thread Alexander Kravchenko
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark > Thompson > Sent: Saturday, April 14, 2018 7:15 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/amfenc: DXVA2 textures support > implementation by AMF

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-14 Thread Paul B Mahol
On 4/11/18, Martin Vignali wrote: > Hello, > > Thanks for the comments. > > New patchs in attach : > > 001 : Add display_scale volume > Change since prev patch : > - use enum for the value > - move the max_draw calc part to an inline func (avoid code duplication). > >

Re: [FFmpeg-devel] [PATCH] avcodec/dxv: add support for "high" quality mode

2018-04-14 Thread Rostislav Pehlivanov
On 14 April 2018 at 20:46, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/dxv.c | 815 ++ > ++--- > 1 file changed, 780 insertions(+), 35 deletions(-) > > diff --git a/libavcodec/dxv.c

Re: [FFmpeg-devel] [PATCH] ffprobe: report unavailable SAR correctly in stream info

2018-04-14 Thread Rostislav Pehlivanov
On 12 April 2018 at 09:07, Timo Teräs wrote: > av_guess_sample_aspect_ratio() will return undefined or missing > value as {0,1}. This fixes show_stream() to check numerator to > display 'N/A' when appropriate. show_frame() does this already > correctly. > > Signed-off-by: Timo

[FFmpeg-devel] [PATCH] avcodec/dxv: add support for "high" quality mode

2018-04-14 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/dxv.c | 815 --- 1 file changed, 780 insertions(+), 35 deletions(-) diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c index 529e211258..101fe78481 100644 --- a/libavcodec/dxv.c +++

Re: [FFmpeg-devel] [PATCH] avcodec/dxv: add support for "high" quality mode

2018-04-14 Thread Paul B Mahol
On 4/14/18, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/dxv.c | 815 > --- > 1 file changed, 780 insertions(+), 35 deletions(-) > Ignore this one. It introduces artifacts.

[FFmpeg-devel] [PATCH] avcodec/dxv: add support for "high" quality mode

2018-04-14 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/dxv.c | 815 --- 1 file changed, 780 insertions(+), 35 deletions(-) diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c index 529e211258..a0a3ff0595 100644 --- a/libavcodec/dxv.c +++

[FFmpeg-devel] [PATCH v2] avformat/movenc: support writing iTunes cover image

2018-04-14 Thread Timo Teräs
Fixes https://trac.ffmpeg.org/ticket/2798 This makes movenc handle AV_DISPOSITION_ATTACHED_PIC and write the associated pictures in iTunes cover atom. This corresponds to how 'mov' demuxer parses and exposes the cover images when reading. Most of the existing track handling loops properly ignore

Re: [FFmpeg-devel] [PATCH] avcodec/dxv: add support for "high" quality mode

2018-04-14 Thread Rostislav Pehlivanov
On 12 April 2018 at 17:00, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/dxv.c | 1038 ++ > ++-- > 1 file changed, 1003 insertions(+), 35 deletions(-) > > diff --git a/libavcodec/dxv.c

Re: [FFmpeg-devel] [PATCH] lavc/amfenc: DXVA2 textures support implementation by AMF encoder

2018-04-14 Thread Mark Thompson
On 13/04/18 10:21, Alexander Kravchenko wrote: > > This patch contains DXVA2 textures support implementation by AMF encoder (in > addition of D3D11 textures) > > Samples of usage: > DXVA2 decoder -> dxva2_vld texture -> AMF Encoder: > ffmpeg -hwaccel dxva2 -hwaccel_output_format dxva2_vld

[FFmpeg-devel] [PATCH 4/5] amfenc: Add DXVA2 hardware frame input support

2018-04-14 Thread Mark Thompson
From: Alexander Kravchenko Adds support for AMF initialisation from a DXVA2 (Direct3D9) device, and then allows passing DXVA2 surfaces into an AMF encoder. Signed-off-by: Mark Thompson --- libavcodec/amfenc.c | 79

[FFmpeg-devel] [PATCH 1/5] amfenc: Fail to open if the user-supplied device is not usable

2018-04-14 Thread Mark Thompson
If the user supplies a device or frames context then it is an error not to use it; this is consistent with other hardware components. Also factorise out the D3D11 initialisation and improve error messages. --- libavcodec/amfenc.c | 130 1 file

[FFmpeg-devel] [PATCH 3/5] amfenc: Ensure that the software format of hardware frames is valid

2018-04-14 Thread Mark Thompson
From: Alexander Kravchenko Signed-off-by: Mark Thompson --- libavcodec/amfenc.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index d1a28f13e2..b761cd74bf 100644 ---

[FFmpeg-devel] [PATCH 5/5] amfenc: Remove spurious initialisations

2018-04-14 Thread Mark Thompson
Also minor cosmetics. --- libavcodec/amfenc.c | 70 - 1 file changed, 26 insertions(+), 44 deletions(-) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index e641048532..93fcee9480 100644 --- a/libavcodec/amfenc.c +++

[FFmpeg-devel] [PATCH 2/5] amfenc: Do not automatically download/upload unknown hardware input frames

2018-04-14 Thread Mark Thompson
Supplying a hardware input frame which is not in the input hardware frames context is not allowed by the API, so additional code to handle it is not necessary. Handling it automatically results in very low performance - it is more appropriate to fail immediately so that the user can fix their

Re: [FFmpeg-devel] [PATCH] tests/checkasm/checkasm: Provide verbose failure information on float_near_abs_eps() failures

2018-04-14 Thread James Almer
On 4/14/2018 9:21 AM, Michael Niedermayer wrote: > On Fri, Apr 13, 2018 at 12:19:38AM -0300, James Almer wrote: >> On 4/12/2018 9:34 PM, Michael Niedermayer wrote: >>> This will make understanding failures and adjusting EPS easier >>> >>> Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] tests/checkasm/checkasm: Provide verbose failure information on float_near_abs_eps() failures

2018-04-14 Thread Michael Niedermayer
On Fri, Apr 13, 2018 at 12:19:38AM -0300, James Almer wrote: > On 4/12/2018 9:34 PM, Michael Niedermayer wrote: > > This will make understanding failures and adjusting EPS easier > > > > Signed-off-by: Michael Niedermayer > > --- > > tests/checkasm/checkasm.c | 6 +-

Re: [FFmpeg-devel] FFmpeg 3.5 / 4.0

2018-04-14 Thread Michael Niedermayer
On Fri, Apr 13, 2018 at 12:53:08AM +0200, Michael Niedermayer wrote: > On Mon, Feb 19, 2018 at 02:50:08AM +0100, Michael Niedermayer wrote: > > Hi > > > > Its 4 months since 3.4 was branched so its time for a new major release > > > > Is 4.0 or 3.5 preferred ? > > Any name suggestions ? > > > >

Re: [FFmpeg-devel] [PATCH] avformat/utils: Stream specifier enhancement 2.

2018-04-14 Thread Michael Niedermayer
On Fri, Apr 13, 2018 at 10:03:18PM +0200, Bodecs Bela wrote: > > > 2018.04.13. 20:54 keltezéssel, Michael Niedermayer írta: > >On Fri, Apr 13, 2018 at 12:16:52PM +0200, Bodecs Bela wrote: > >>Dear All, > >> > >>In some cases, mainly working with multiprogram mpeg-ts containers as > >>input, it

Re: [FFmpeg-devel] avcodec/prores_ks : use official quant matrix

2018-04-14 Thread Martin Vignali
> > > > For the proxy chroma version is also the same matrix use in prores_aw > > Patch is OK then, assumming FATE still passes. > > > Ok thanks for comments. It passes fate test for me (but prores_ks have few fate test !) I will wait few days, if someone else have comments, before apply. Martin

Re: [FFmpeg-devel] avdevice/sdl output : fix window_size and add new option (WIP)

2018-04-14 Thread Martin Vignali
2018-04-08 17:28 GMT+02:00 Martin Vignali : > Hello, > > In attach patchs to improve SDL Output device > (Missing doc update) > > - 001 : Fix -window_size option > Before this patch, window_size is always set to the source size > In other word, -window_size option have