Re: [FFmpeg-devel] [PATCH] avformat/vpcc: fix values in VP9 level detection heuristics

2018-09-14 Thread James Zern
On Fri, Sep 14, 2018 at 6:39 PM James Almer wrote: > > On 8/27/2018 10:59 PM, James Almer wrote: > > The levels are stored as decimal values, not hexadecimal. > > > > Signed-off-by: James Almer > > --- > > libavformat/vpcc.c | 28 ++-- > > 1 file changed, 14

Re: [FFmpeg-devel] [PATCH] avformat/vpcc: fix values in VP9 level detection heuristics

2018-09-14 Thread James Almer
On 8/27/2018 10:59 PM, James Almer wrote: > The levels are stored as decimal values, not hexadecimal. > > Signed-off-by: James Almer > --- > libavformat/vpcc.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/libavformat/vpcc.c

[FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4videodec: Fix undefined shift in get_amv()

2018-09-14 Thread Michael Niedermayer
Fixes: runtime error: shift exponent -1 is negative Fixes: 9938/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5653783529914368 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 1/3] avcodec/shorten: Fix bitstream end check in read_header()

2018-09-14 Thread Michael Niedermayer
Fixes: Timeout Fixes: 9961/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SHORTEN_fuzzer-5687856176562176 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/shorten.c | 2 +- 1 file changed,

[FFmpeg-devel] [PATCH 2/3] avcodec/mpeg4videodec: Check rice_prefix_code

2018-09-14 Thread Michael Niedermayer
Fixes: out of array read Fixes: 10064/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5766801384800256 Fixes: 10225/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5071833448054784 Fixes:

Re: [FFmpeg-devel] [PATCH] libavcodec/libaomenc.c: Added code for computing PSNR/SSIM for libaom encoder.

2018-09-14 Thread James Almer
On 9/14/2018 5:53 PM, Sam John wrote: > James, > >> Did you copy this chunk from the libvpxenc wrapper? Because I don't >> think this is valid at all for libaom. A quick grep on their tree shows >> that AOM_FRAME_IS_INVISIBLE is never set anywhere. It looks like a >> leftover flag they forgot to

Re: [FFmpeg-devel] [PATCH] libavcodec/libaomenc.c: Added code for computing PSNR/SSIM for libaom encoder.

2018-09-14 Thread Sam John
James, > Did you copy this chunk from the libvpxenc wrapper? Because I don't >think this is valid at all for libaom. A quick grep on their tree shows >that AOM_FRAME_IS_INVISIBLE is never set anywhere. It looks like a >leftover flag they forgot to remove from the libvpx codebase I used the same

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dvdsubdec: Avoid branch in decode_run_8bit()

2018-09-14 Thread Paul B Mahol
On 9/13/18, Michael Niedermayer wrote: > Speed improvment 35.5 sec -> 34.7sec > > Signed-off-by: Michael Niedermayer > --- > libavcodec/dvdsubdec.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > lgtm ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/2] Fix typos

2018-09-14 Thread Carl Eugen Hoyos
2018-08-30 8:56 GMT+02:00, Michael Bunk : > --- > libavcodec/qsvenc_h264.c | 2 +- > libavutil/avassert.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c > index 7aa65e9..dfa4666 100644 > ---

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: fix dnxhr ul typo

2018-09-14 Thread Paul B Mahol
On 9/13/18, Jason Stevens wrote: > byte 8 of dnxhr codec ul should be 0x0D > > Signed-off-by: Jason Stevens > --- > libavformat/mxfenc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > lgtm ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] configure: split the libaom check into decoder and encoder

2018-09-14 Thread James Almer
libaom can be built with either of the two modules alone, and a generic check for aom_codec_version would blindly enable both wrappers. Check directly for the modules instead, and print a more descriptive error when one is requested but not available. Signed-off-by: James Almer --- configure |

Re: [FFmpeg-devel] [PATCH 2/2] avutil/float_dsp: add ff_vector_dmul_{sse2, avx}

2018-09-14 Thread James Almer
On 9/14/2018 11:57 AM, Henrik Gramner wrote: > On Fri, Sep 14, 2018 at 4:51 PM, Henrik Gramner wrote: >> I can't really think of any scenario where using a 32-bit register >> address operand with a 64-bit destination for LEA is not a mistake. > > To clarify on this, using a 32-bit memory operand

[FFmpeg-devel] [RFC][WIP][PATCH] avcodec: add IMM5 decoder

2018-09-14 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 5 libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/h264dec.c| 58 - libavcodec/h264dec.h| 3 +++ libavformat/riff.c

Re: [FFmpeg-devel] [RFC][WIP][PATCH] avcodec: add IMM5 decoder

2018-09-14 Thread Paul B Mahol
On 9/14/18, Moritz Barsnick wrote: > On Fri, Sep 14, 2018 at 14:24:04 +0200, Paul B Mahol wrote: >> This decodes more or less single sample we have. > > Which sample would that be? This one?: > https://samples.ffmpeg.org/V-codecs/IMM5/20120917072000_CH05_330672916.avi > > After your patch, it

Re: [FFmpeg-devel] [PATCH 2/2] avutil/float_dsp: add ff_vector_dmul_{sse2, avx}

2018-09-14 Thread Henrik Gramner
On Fri, Sep 14, 2018 at 3:26 PM, James Almer wrote: > On 9/14/2018 9:57 AM, Henrik Gramner wrote: >> Also if you want a 32-bit result from lea it should be written as "lea >> lend, [lenq*8 - mmsize*4]" which is equivalent but has a shorter >> opcode (e.g. always use native sizes within brackets).

Re: [FFmpeg-devel] [PATCH 2/2] avutil/float_dsp: add ff_vector_dmul_{sse2, avx}

2018-09-14 Thread Henrik Gramner
On Fri, Sep 14, 2018 at 4:51 PM, Henrik Gramner wrote: > I can't really think of any scenario where using a 32-bit register > address operand with a 64-bit destination for LEA is not a mistake. To clarify on this, using a 32-bit memory operand means the calculated effective address will be

Re: [FFmpeg-devel] [RFC][WIP][PATCH] avcodec: add IMM5 decoder

2018-09-14 Thread Moritz Barsnick
On Fri, Sep 14, 2018 at 14:24:04 +0200, Paul B Mahol wrote: > This decodes more or less single sample we have. Which sample would that be? This one?: https://samples.ffmpeg.org/V-codecs/IMM5/20120917072000_CH05_330672916.avi After your patch, it fails to decode with > Too many packets buffered

Re: [FFmpeg-devel] [PATCH 2/2] avutil/float_dsp: add ff_vector_dmul_{sse2, avx}

2018-09-14 Thread James Almer
On 9/14/2018 9:57 AM, Henrik Gramner wrote: > On Thu, Sep 13, 2018 at 3:08 PM, James Almer wrote: >> +lea lenq, [lend*8 - mmsize*4] > > Is len guaranteed to be a multiple of mmsize/8? Otherwise this would > cause misalignment. It will also break if len < mmsize/2. len must be a

Re: [FFmpeg-devel] [PATCH] avdevice/pulse_audio_dec: set channel map

2018-09-14 Thread Paul B Mahol
On 9/12/18, Paul B Mahol wrote: > This fixes opening devices with >6 channels. > > Signed-off-by: Paul B Mahol > --- > libavdevice/pulse_audio_dec.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Will apply. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/2] avutil/float_dsp: add ff_vector_dmul_{sse2, avx}

2018-09-14 Thread Henrik Gramner
On Thu, Sep 13, 2018 at 3:08 PM, James Almer wrote: > +lea lenq, [lend*8 - mmsize*4] Is len guaranteed to be a multiple of mmsize/8? Otherwise this would cause misalignment. It will also break if len < mmsize/2. Also if you want a 32-bit result from lea it should be written as "lea

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: only write video streams into HLS master playlist

2018-09-14 Thread Jian Yang
Agree! Audio-only stream should be supported. Just tested adding the missed audio group for audio stream. Tool mediastreamvalidator doesn't report error message any more, and the playlist can be played in Safari. Could you please help to add audio group for audio streams? I can update the patch

[FFmpeg-devel] [RFC][WIP][PATCH] avcodec: add IMM5 decoder

2018-09-14 Thread Paul B Mahol
This decodes more or less single sample we have. Why inter frame decoding looks bad? Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 5 ++ libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/h264dec.c| 103

[FFmpeg-devel] [PATCH] avformat/dashenc: Reduce Muxing overhead for chunked CMAF format

2018-09-14 Thread Karthick J
From: Karthick Jeyapal SIDX atom being inserted for every MOOF atom increases the muxing overhead. This behaviour can be disabled for chunked CMAF format by enabling Global SIDX option of mov muxer. --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: only write video streams into HLS master playlist

2018-09-14 Thread Jeyapal, Karthick
On 9/14/18 12:38 PM, Jian Yang wrote: > Tool mediastreamvalidator reports error "Variant media_[N].m3u8 is > missing audio group" for audio streams in HLS master playlist. As audio > streams are already listed in audio group, skip them as variant media > streams in master playlist. Skipping the

[FFmpeg-devel] [PATCH] avcodec/vaapi:free slice_buffers when decoding failed

2018-09-14 Thread Linjie Fu
If vaEndPicture failed in ff_vaapi_decode_issue, free the pic->slice_buffer. Fix the memory leak issue in ticket #7385 Signed-off-by: Linjie Fu --- libavcodec/vaapi_decode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index

[FFmpeg-devel] [PATCH] avformat/dashenc: only write video streams into HLS master playlist

2018-09-14 Thread Jian Yang
Tool mediastreamvalidator reports error "Variant media_[N].m3u8 is missing audio group" for audio streams in HLS master playlist. As audio streams are already listed in audio group, skip them as variant media streams in master playlist. --- libavformat/dashenc.c | 4 +++- 1 file changed, 3