[FFmpeg-devel] [PATCH] lavfi/atempo: fix tempo range limit inconsistency

2018-10-03 Thread Pavel Koshevoy
yae_set_tempo was overlooked when max tempo limit was raised to 100. tested with: ./ffmpeg_g -i Delerium/SemanticSpaces/Gateway.mp3 \ -af asendcmd=f=asendcmd.cfg,atempo=1.0 -y /tmp/asendcmd-atempo.wav where asendcmd.cfg was: 15.0-45.0 [enter] atempo tempo 2.0, [leave] atempo tempo 0.5;

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread James Almer
On 10/3/2018 8:26 PM, Mark Thompson wrote: > On 03/10/18 02:44, James Almer wrote: >> Simple parser to set keyframes, frame type, structure, width, height, and >> pixel >> format, plus stream profile and level. >> >> Signed-off-by: James Almer >> --- >> Missing Changelog entry and version bump st

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread Mark Thompson
On 03/10/18 02:44, James Almer wrote: > Simple parser to set keyframes, frame type, structure, width, height, and > pixel > format, plus stream profile and level. > > Signed-off-by: James Almer > --- > Missing Changelog entry and version bump still. > > configure | 1 + > libav

Re: [FFmpeg-devel] [PATCH 2/2] avformat/ivfenc: use the av1_metadata bsf to insert Temporal Delimiter OBUs if needed

2018-10-03 Thread James Almer
On 10/3/2018 8:01 PM, Mark Thompson wrote: > On 03/10/18 01:18, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavformat/ivfenc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c >> index 66441a2a43..adf72117e9 100644 >> --- a

Re: [FFmpeg-devel] [PATCH 2/2] avformat/ivfenc: use the av1_metadata bsf to insert Temporal Delimiter OBUs if needed

2018-10-03 Thread Mark Thompson
On 03/10/18 01:18, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/ivfenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c > index 66441a2a43..adf72117e9 100644 > --- a/libavformat/ivfenc.c > +++ b/libavformat/ivfenc.c >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/av1_metadata: add an option to insert and remove Temporal Delimiter OBUs

2018-10-03 Thread Mark Thompson
On 03/10/18 01:18, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/av1_metadata_bsf.c | 37 ++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/av1_metadata_bsf.c b/libavcodec/av1_metadata_bsf.c > index ed2f018fb6..

[FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-03 Thread bananaman255
From: bnnm Improves trac issue #6722. Fixes truncated XMA output (was missing 128 samples) and applies bitstream gapless info (partially for XMA, fully for WMAPRO). Applying XMA end_skip would require some extra changes in the XMA multi-stream handling, so end samples are slightly bigger than

Re: [FFmpeg-devel] [PATCH 2/2] avdevice/sdl2 : add option to set window position

2018-10-03 Thread Dave Rice
> On Oct 2, 2018, at 1:32 AM, Gyan wrote: > > On Tue, Oct 2, 2018 at 2:47 AM Dave Rice wrote: > >> Allows arrangement of multiple windows such as: >> ffmpeg -re -f lavfi -i mandelbrot -f sdl -window_x 1 -window_y 1 >> mandelbrot -vf waveform,format=yuv420p -f sdl -window_x 641 -window_y 1 >> w

[FFmpeg-devel] [PATCHv2 1/2] ffplay: options to specify window position

2018-10-03 Thread Dave Rice
Thanks Marton for comments. Here is a revision to the first patch. From 3fe6a9e5279a280af9a06843621737ddc44529cc Mon Sep 17 00:00:00 2001 From: Dave Rice Date: Mon, 1 Oct 2018 17:07:44 -0400 Subject: [PATCHv2 1/2] ffplay: options to specify window position --- doc/ffplay.texi | 4 fftools

Re: [FFmpeg-devel] [PATCH v2] avcodec: libdav1d AV1 decoder wrapper.

2018-10-03 Thread Ricardo Constantino
On Mon, 1 Oct 2018 at 01:08, James Almer wrote: > From: Ronald S. Bultje > > Originally written by Ronald S. Bultje, with fixes, optimizations and > improvements by James Almer. > > Signed-off-by: James Almer > --- > Updated with some refactoring and to use a few new public facing fields > rece

[FFmpeg-devel] [PATCH] avformat/xwma: fix WMAv2 with incorrect bit rate

2018-10-03 Thread bananaman255
From: bnnm Fixes trac issue #7215 Output for files created by xWMAEncode and various videogames is correct now. 1ch 32000hz files are still broken, would need fixes in WMA decoder. Signed-off-by: bnnm --- libavformat/xwma.c | 38 +++--- 1 file changed, 31 inse

Re: [FFmpeg-devel] [PATCHv2 1/2] avfilter/filters: add ff_inlink_peek_frame and ff_inlink_queued_frames to access frames in the inlink fifo

2018-10-03 Thread Marton Balint
On Wed, 3 Oct 2018, Nicolas George wrote: Marton Balint (2018-10-01): Signed-off-by: Marton Balint --- libavfilter/avfilter.c | 10 ++ libavfilter/filters.h | 13 + 2 files changed, 23 insertions(+) LGTM, thanks. Thanks, pushed the series. Regards, Marton _

Re: [FFmpeg-devel] [PATCHv2 1/7] avformat/ip: factorize some IP filtering and resolving functions to a new file

2018-10-03 Thread Marton Balint
On Sun, 30 Sep 2018, Marton Balint wrote: On Mon, 24 Sep 2018, Michael Niedermayer wrote: On Mon, Sep 24, 2018 at 08:49:27AM +0200, Marton Balint wrote: These are based on the very similar UDP and RTP protocol functions. Signed-off-by: Marton Balint --- libavformat/ip.c | 159

[FFmpeg-devel] [PATCH] avcodec/vp9_parser: export profile and pixel format

2018-10-03 Thread James Almer
Signed-off-by: James Almer --- libavcodec/vp9_parser.c | 82 - 1 file changed, 80 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c index 9531f34a32..d4110f20bf 100644 --- a/libavcodec/vp9_parser.c +++ b/libavcode

Re: [FFmpeg-devel] [PATCHv2 1/2] avfilter/filters: add ff_inlink_peek_frame and ff_inlink_queued_frames to access frames in the inlink fifo

2018-10-03 Thread Nicolas George
Marton Balint (2018-10-01): > Signed-off-by: Marton Balint > --- > libavfilter/avfilter.c | 10 ++ > libavfilter/filters.h | 13 + > 2 files changed, 23 insertions(+) LGTM, thanks. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCHv2 1/2] avfilter/filters: add ff_inlink_peek_frame and ff_inlink_queued_frames to access frames in the inlink fifo

2018-10-03 Thread Paul B Mahol
On 10/1/18, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavfilter/avfilter.c | 10 ++ > libavfilter/filters.h | 13 + > 2 files changed, 23 insertions(+) > Probably ok. ___ ffmpeg-devel mailing list ffmpeg-devel@

[FFmpeg-devel] [PATCH 2/4] avfilter/af_asetnsamples: use lavfi internal queue

2018-10-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/af_asetnsamples.c | 146 -- 1 file changed, 32 insertions(+), 114 deletions(-) diff --git a/libavfilter/af_asetnsamples.c b/libavfilter/af_asetnsamples.c index ecb76e64db..30fabede26 100644 --- a/libavfilter/af_asetnsamp

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: fix range check if tempo is set by command

2018-10-03 Thread Nicolas George
Wang Bin (2018-10-03): > Less mistakes. For example the author forgot to change this line. This > function is not frequently called. The consistency must be ensured, but it must be static, not dynamic by looking up the option. Just use two constant macros. > av_opt_set or avfilter_process_comman

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: fix range check if tempo is set by command

2018-10-03 Thread Wang Bin
Nicolas George 于2018年10月3日周三 下午11:05写道: > wbse...@gmail.com (2018-10-03): > > From: wang-bin > > > > --- > > libavfilter/af_atempo.c | 11 ++- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c > > index 52f15f2769.

Re: [FFmpeg-devel] [PATCH] libavdevice: allow cropping avfoundation screen capture

2018-10-03 Thread Alan.Birtles
> I've developed a patch to add an option to allow cropping of the > avfoundation screen capture. > Note that if the captured width is not a multiple of 16 then > https://trac.ffmpeg.org/ticket/5654 will be triggered. Is there anything more I need to do to get this patch applied? _

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: fix range check if tempo is set by command

2018-10-03 Thread Nicolas George
wbse...@gmail.com (2018-10-03): > From: wang-bin > > --- > libavfilter/af_atempo.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c > index 52f15f2769..1a004212a7 100644 > --- a/libavfilter/af_atempo.c > +++ b

[FFmpeg-devel] [PATCH] lavfi/atempo: fix range check if tempo is set by command

2018-10-03 Thread wbsecg1
From: wang-bin --- libavfilter/af_atempo.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index 52f15f2769..1a004212a7 100644 --- a/libavfilter/af_atempo.c +++ b/libavfilter/af_atempo.c @@ -331,9 +331,10 @@ static

Re: [FFmpeg-devel] [PATCH 1/4] avfilter: add ff_inlink_queued_samples()

2018-10-03 Thread Nicolas George
Paul B Mahol (2018-10-03): > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 5 + > libavfilter/filters.h | 7 +++ > 2 files changed, 12 insertions(+) LGTM. Please coordinate with Marton so that this function and the ones he is about to add are in a logical order. Regards,

Re: [FFmpeg-devel] [PATCH 2/4] avfilter/af_asetnsamples: use lavfi internal queue

2018-10-03 Thread Nicolas George
Paul B Mahol (2018-10-03): > Signed-off-by: Paul B Mahol > --- > libavfilter/af_asetnsamples.c | 156 +- > 1 file changed, 42 insertions(+), 114 deletions(-) > > diff --git a/libavfilter/af_asetnsamples.c b/libavfilter/af_asetnsamples.c > index ecb76e64db..6efa6f3

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread Derek Buitenhuis
On 03/10/2018 14:43, James Almer wrote: > That's in Metadata OBUs and/or in container defined structures. It's > meant to be propagated internally as stream/packet/frame side data, > which the parser API can't handle. > > The demuxer and/or the decoder are the ones that need to handle that. OK.

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread James Almer
On 10/3/2018 10:38 AM, Derek Buitenhuis wrote: > On 03/10/2018 14:26, James Almer wrote: >>> Shouldn't this be set at the bottom of this block (since parsing can fail)? >> >> If extradata parsing fails and we bail out without setting this first, >> no packet will ever be parsed since this runs firs

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread Derek Buitenhuis
On 03/10/2018 14:26, James Almer wrote: >> Shouldn't this be set at the bottom of this block (since parsing can fail)? > > If extradata parsing fails and we bail out without setting this first, > no packet will ever be parsed since this runs first thing every time. > > A better API would allow us

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread James Almer
On 10/3/2018 9:53 AM, Derek Buitenhuis wrote: > Hi, > > Apologies if you've covered any of these comments before. > > On 03/10/2018 02:44, James Almer wrote: >> Simple parser to set keyframes, frame type, structure, width, height, and >> pixel >> format, plus stream profile and level. >> >> Sign

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread Derek Buitenhuis
On 03/10/2018 13:53, Derek Buitenhuis wrote: > Won't this break horribly on e.g. 4:4:0? Woops, there's no such thing in AV1. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread Derek Buitenhuis
Hi, Apologies if you've covered any of these comments before. On 03/10/2018 02:44, James Almer wrote: > Simple parser to set keyframes, frame type, structure, width, height, and > pixel > format, plus stream profile and level. > > Signed-off-by: James Almer > --- > Missing Changelog entry and

Re: [FFmpeg-devel] [PATCH] lavf/utils: change truncating packet log to a warning

2018-10-03 Thread Hendrik Leppkes
On Wed, Oct 3, 2018 at 11:55 AM Michael Niedermayer wrote: > > On Sun, Sep 30, 2018 at 06:08:47AM +0100, Rostislav Pehlivanov wrote: > > Some scene files do this intentionally for the sake of having a nice > > checksum. > > I think this is a bit terse and hard to understand what is meant exactly

[FFmpeg-devel] [PATCH 4/4] avfilter/af_afir: use internal lavfi queue

2018-10-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/af_afir.c | 46 --- 1 file changed, 13 insertions(+), 33 deletions(-) diff --git a/libavfilter/af_afir.c b/libavfilter/af_afir.c index bdca9033cf..a36f1881e3 100644 --- a/libavfilter/af_afir.c +++ b/libavfilter/a

[FFmpeg-devel] [PATCH 2/4] avfilter/af_asetnsamples: use lavfi internal queue

2018-10-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/af_asetnsamples.c | 156 +- 1 file changed, 42 insertions(+), 114 deletions(-) diff --git a/libavfilter/af_asetnsamples.c b/libavfilter/af_asetnsamples.c index ecb76e64db..6efa6f3f69 100644 --- a/libavfilter/af_asetnsamp

[FFmpeg-devel] [PATCH 3/4] avfilter/af_headphone: use lavfi internal queue instead

2018-10-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/af_headphone.c | 56 -- 1 file changed, 12 insertions(+), 44 deletions(-) diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c index 6b210e1436..760b97b733 100644 --- a/libavfilter/af_headphone.c +++

[FFmpeg-devel] [PATCH 1/4] avfilter: add ff_inlink_queued_samples()

2018-10-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avfilter.c | 5 + libavfilter/filters.h | 7 +++ 2 files changed, 12 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 85eff0aa1d..49046f4ede 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -1

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_headphone: use lavfi internal queue instead

2018-10-03 Thread Paul B Mahol
On 10/2/18, Paul B Mahol wrote: > On 10/2/18, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/af_headphone.c | 46 -- >> 1 file changed, 9 insertions(+), 37 deletions(-) >> > > Unfortunately this asserts for unexplained reason. > > Is

Re: [FFmpeg-devel] [PATCH] lavf/utils: change truncating packet log to a warning

2018-10-03 Thread Michael Niedermayer
On Sun, Sep 30, 2018 at 06:08:47AM +0100, Rostislav Pehlivanov wrote: > Some scene files do this intentionally for the sake of having a nice checksum. I think this is a bit terse and hard to understand what is meant exactly maybe you can expand this commit message a bit thx [...] -- Michael

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/tiff: check remaining packet size for strips

2018-10-03 Thread Michael Niedermayer
On Tue, Oct 02, 2018 at 09:53:16AM +0200, Paul B Mahol wrote: > On 10/2/18, Michael Niedermayer wrote: > > Fixes: Timeout > > Fixes: > > 10280/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-5676217211027456 > > > > Found-by: continuous fuzzing process > > https://github.com/google/o

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rasc: Fix off by 1 error in vertical coordinate

2018-10-03 Thread Michael Niedermayer
On Tue, Oct 02, 2018 at 09:52:31AM +0200, Paul B Mahol wrote: > On 10/2/18, Michael Niedermayer wrote: > > Fixes: out of array read > > Fixes: > > 10311/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-4856330905452544 > > > > Found-by: continuous fuzzing process > > https://github.co

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/rasc: unref both frames on reinit

2018-10-03 Thread Michael Niedermayer
On Tue, Oct 02, 2018 at 09:27:40AM +0200, Paul B Mahol wrote: > On 10/2/18, Michael Niedermayer wrote: > > Fixes: integer overflow > > Fixes: inconsistent frame dimensions > > Fixes: > > 10454/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-5656301162463232 > > > > Found-by: continuo

Re: [FFmpeg-devel] [PATCH] lavf/utils: change truncating packet log to a warning

2018-10-03 Thread Rostislav Pehlivanov
On Sun, 30 Sep 2018 at 06:08, Rostislav Pehlivanov wrote: > Some scene files do this intentionally for the sake of having a nice > checksum. > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index c973