Re: [FFmpeg-devel] [PATCH 1/5] avutil: Add YUV444P10_LSB and YUV444P12_LSB pixel formats

2018-10-07 Thread Hendrik Leppkes
On Sun, Oct 7, 2018 at 7:51 PM Philip Langdale wrote: > > Currently, ffmpeg defines a set of YUV444P formats for use where > the bits-per-pixel are between 8 and 16 bits. In these formats, > the bits are packed in the MSBs of the 16 bits of available storage. > > On the other hand, all the hardwar

Re: [FFmpeg-devel] H.264 SEI Display Orientation Message support in ffplay

2018-10-07 Thread Kirill Gavrilov
Omer Iqbal wrote: > I'm curious, does anyone know why this is not implemented in video players? > Considering it is part of the H.264 specification, and ffmpeg supports > decoding it? > I believe that changing frame orientation within a stream is very awkward and rare situation, which should be

Re: [FFmpeg-devel] [PATCH 2/2] avdevice/sdl2 : add option to set window position

2018-10-07 Thread Gyan
On Thu, Oct 4, 2018 at 2:33 AM Dave Rice wrote: > > > I attempted to add an error message but am uncertain how to access the > width and height of the canvas used. Any advice? > I believe you need to call SDL_GetCurrentDisplayMode. See https://wiki.libsdl.org/SDL_GetCurrentDisplayMode Gyan ___

Re: [FFmpeg-devel] Mentoring project: music test source

2018-10-07 Thread Mina
On 10/04/2018 11:40 AM, Nicolas George wrote: Hi. No need to Cc people who are on the list. Actually replied only to you initially, sorry about that. Mina (2018-09-30): Do you mean by "look like music" to just follow music theory rules or actually sound like real music. Just curious. In

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/f_cue: always check the return value of ff_inlink_consume_frame

2018-10-07 Thread Nicolas George
Marton Balint (2018-10-07): > Fixes Coverity CID 1439936. > > Signed-off-by: Marton Balint > --- > libavfilter/f_cue.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) LGTM, sorry for having missed it. Regards, -- Nicolas George signature.asc Description: Digital signature

[FFmpeg-devel] [PATCH 5/5] libavfilter/ebur128: add scale parameter

2018-10-07 Thread Daniel Molkentin
This allows switching between absolute (LUFS) and relativ (LU) display in the status line. Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- doc/filters.texi| 8 libavfilter/f_ebur128.c | 42 - 2 files changed, 37 insertion

[FFmpeg-devel] [PATCH 3/5] libavfilter/ebur128: add gauge option

2018-10-07 Thread Daniel Molkentin
Allow to show short-term instead of momentary in gauge. Useful for monitoring whilst live mixing. Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- doc/filters.texi| 9 - libavfilter/f_ebur128.c | 21 +++-- 2 files changed, 27 insertions(+), 3 dele

[FFmpeg-devel] [PATCH 0/5] Improvements for EBU R128 plugin (second round)

2018-10-07 Thread Daniel Molkentin
Changes over first patchset: Mainly wording. Use full words as a parameter values. Switch to constants instead of strings for parameters. Also: - "mabsolute" bool parameter renamed "scale" as per reviewer suggestion - "gaugetype" parameter renamed to "gauge" for consistency with scale - typo fixe

[FFmpeg-devel] [PATCH 1/5] libavfilter/ebur128: add target level option for EBUR128 visualization filter

2018-10-07 Thread Daniel Molkentin
Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- doc/filters.texi| 6 ++ libavfilter/f_ebur128.c | 6 -- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index b523877cf3..86ea25bda8 100644 --- a/doc/filters.texi +

[FFmpeg-devel] [PATCH 2/5] libavfilter/ebur128: add target value to statistics line

2018-10-07 Thread Daniel Molkentin
Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- libavfilter/f_ebur128.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index dfccbff5ec..89bfcb0b3e 100644 --- a/libavfilter/f_ebur128.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH 4/5] libavfilter/ebur128: introduce target range

2018-10-07 Thread Daniel Molkentin
This eases meeting the target level during live mixing. Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- doc/filters.texi| 8 libavfilter/f_ebur128.c | 33 +++-- 2 files changed, 31 insertions(+), 10 deletions(-) diff --git a/doc/fil

Re: [FFmpeg-devel] [PATCH 5/5] libavfilter/ebur128: add mabsolute parameter

2018-10-07 Thread Marton Balint
On Sun, 7 Oct 2018, Daniel Molkentin wrote: On 07.10.2018 21:37, Marton Balint wrote: On Sun, 7 Oct 2018, Daniel Molkentin wrote: On 07.10.2018 18:02, Daniel Molkentin wrote: This allows switching between absolute (LUFS) and relativ (LU) display in the status line. Signed-off-by: Dani

[FFmpeg-devel] [PATCH 3/3] avfilter/af_asetnsamples: do not leak frame on ENOMEM

2018-10-07 Thread Marton Balint
Fixes Coverity CID 1416352. Signed-off-by: Marton Balint --- libavfilter/af_asetnsamples.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_asetnsamples.c b/libavfilter/af_asetnsamples.c index 30fabede26..e8daec8d8f 100644 --- a/libavfilter/af_asetnsamples.c

[FFmpeg-devel] [PATCH 1/3] avfilter/f_cue: always check the return value of ff_inlink_consume_frame

2018-10-07 Thread Marton Balint
Fixes Coverity CID 1439936. Signed-off-by: Marton Balint --- libavfilter/f_cue.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavfilter/f_cue.c b/libavfilter/f_cue.c index 9cf710c6d2..b48dfc9d49 100644 --- a/libavfilter/f_cue.c +++ b/libavfilter/f_cue.c @@ -51,7

[FFmpeg-devel] [PATCH 2/3] ffmpeg: check return value of avcodec_parameters_from_context

2018-10-07 Thread Marton Balint
Fixes Coverity CID 1427273. Signed-off-by: Marton Balint --- fftools/ffmpeg.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 934dc71a74..aa495b5d9e 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -3072,7 +3072,13 @@ st

Re: [FFmpeg-devel] [PATCH 3/5] libavfilter/ebur128: add gaugetype option

2018-10-07 Thread Moritz Barsnick
On Sun, Oct 07, 2018 at 18:02:27 +0200, Daniel Molkentin wrote: > +to instead display short-term loundness (see @var{gaugetype}). ^ loudness > +Set the value displayed by the gauge. Valid values are m (momentary) and s > (short-term).

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/avf_showspectrum: add fps option

2018-10-07 Thread Moritz Barsnick
On Sat, Oct 06, 2018 at 14:30:11 +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/avf_showspectrum.c | 31 +++ > 1 file changed, 23 insertions(+), 8 deletions(-) doc/filters.texi needs to be adapted as well. Moritz

Re: [FFmpeg-devel] [PATCH 5/5] libavfilter/ebur128: add mabsolute parameter

2018-10-07 Thread Daniel Molkentin
On 07.10.2018 21:37, Marton Balint wrote: > > > On Sun, 7 Oct 2018, Daniel Molkentin wrote: > >> >> On 07.10.2018 18:02, Daniel Molkentin wrote: >>> This allows switching between absolute (LUFS) and relativ (LU) display >>> in the status line. >>> >>> Signed-off-by: Daniel Molkentin >>> Signed-of

Re: [FFmpeg-devel] [PATCH 1/5] avutil: Add YUV444P10_LSB and YUV444P12_LSB pixel formats

2018-10-07 Thread Timo Rothenpieler
On 07.10.2018 19:50, Philip Langdale wrote: Currently, ffmpeg defines a set of YUV444P formats for use where the bits-per-pixel are between 8 and 16 bits. In these formats, the bits are packed in the MSBs of the 16 bits of available storage. On the other hand, all the hardware vendors have defin

Re: [FFmpeg-devel] [PATCH 5/5] libavfilter/ebur128: add mabsolute parameter

2018-10-07 Thread Marton Balint
On Sun, 7 Oct 2018, Daniel Molkentin wrote: On 07.10.2018 18:02, Daniel Molkentin wrote: This allows switching between absolute (LUFS) and relativ (LU) display in the status line. Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- doc/filters.texi| 4 libavfilt

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/cuviddec: Add support for decoding HEVC 4:4:4 content

2018-10-07 Thread Philip Langdale
On Sun, 7 Oct 2018 10:50:56 -0700 Philip Langdale wrote: > This is the equivalent change for cuviddec after the previous change > for nvdec. I made similar changes to the copying routines to handle > pixel formats in a more generic way. > > Note that unlike with nvdec, there is no confusion abo

Re: [FFmpeg-devel] [PATCH 5/5] libavfilter/ebur128: add mabsolute parameter

2018-10-07 Thread Paul B Mahol
On 10/7/18, Daniel Molkentin wrote: > > On 07.10.2018 18:02, Daniel Molkentin wrote: >> This allows switching between absolute (LUFS) and relativ (LU) display >> in the status line. >> >> Signed-off-by: Daniel Molkentin >> Signed-off-by: Conrad Zelck >> --- >> doc/filters.texi| 4

Re: [FFmpeg-devel] [PATCH 3/5] libavfilter/ebur128: add gaugetype option

2018-10-07 Thread Paul B Mahol
On 10/7/18, Daniel Molkentin wrote: > Allow to show short term instead of momentary. Useful for monitoring > whilst live mixing. > > Signed-off-by: Daniel Molkentin > Signed-off-by: Conrad Zelck > --- > doc/filters.texi| 9 - > libavfilter/f_ebur128.c | 21 +++--

Re: [FFmpeg-devel] [PATCH 5/5] libavfilter/ebur128: add mabsolute parameter

2018-10-07 Thread Daniel Molkentin
On 07.10.2018 18:02, Daniel Molkentin wrote: > This allows switching between absolute (LUFS) and relativ (LU) display > in the status line. > > Signed-off-by: Daniel Molkentin > Signed-off-by: Conrad Zelck > --- > doc/filters.texi| 4 > libavfilter/f_ebur128.c | 34 +++

[FFmpeg-devel] [PATCH 3/5] libavfilter/ebur128: add gaugetype option

2018-10-07 Thread Daniel Molkentin
Allow to show short term instead of momentary. Useful for monitoring whilst live mixing. Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- doc/filters.texi| 9 - libavfilter/f_ebur128.c | 21 +++-- 2 files changed, 27 insertions(+), 3 deletions(-)

Re: [FFmpeg-devel] [PATCHv3 1/2] ffplay: options to specify window position

2018-10-07 Thread Marton Balint
On Thu, 4 Oct 2018, Dave Rice wrote: From caa816d70e69f85d49556ff341addab24ebcd942 Mon Sep 17 00:00:00 2001 From: Dave Rice Date: Mon, 1 Oct 2018 17:07:44 -0400 Subject: [PATCH 1/2] ffplay: options to specify window position --- doc/ffplay.texi | 4 fftools/ffplay.c | 6 +- 2 files c

Re: [FFmpeg-devel] [PATCH 4/5] avutil/tests/parseutils: add some big duration tests

2018-10-07 Thread Marton Balint
On Wed, 3 Oct 2018, Michael Niedermayer wrote: On Sun, Sep 30, 2018 at 10:45:12PM +0200, Marton Balint wrote: These are buggy for now... Signed-off-by: Marton Balint --- libavutil/tests/parseutils.c | 4 tests/ref/fate/parseutils| 4 2 files changed, 8 insertions(+) This pa

[FFmpeg-devel] [PATCH 5/5] avcodec/nvenc: Accept YUV444P10_LSB and YUV444P12_LSB content

2018-10-07 Thread Philip Langdale
12bit is implicitly truncated to 10bit as part of doing this, but we already do that for P016 and YUV444P16. I've bundled a single version bump and changelog entry in this change to reflect the updates to all three of nvdec/nvenc/cuviddec. Signed-off-by: Philip Langdale --- Changelog

[FFmpeg-devel] [PATCH 3/5] avcodec/nvdec: Explicitly mark codecs that support 444 output formats

2018-10-07 Thread Philip Langdale
With the introduction of HEVC 444 support, we technically have two codecs that can handle 444 - HEVC and MJPEG. In the case of MJPEG, it can decode, but can only output one of the semi-planar formats. That means we need additional logic to decide whether to use a 444 output format or not. Signed-

[FFmpeg-devel] [PATCH 2/5] avcodec/nvdec: Add support for decoding HEVC 4:4:4 content

2018-10-07 Thread Philip Langdale
The latest generation video decoder on the Turing chips supports decoding HEVC 4:4:4. Supporting this is relatively straight-forward; we need to account for the different chroma format and pick the right output and sw formats at the right times. There was one bug which was the hard-coded assumptio

[FFmpeg-devel] [PATCH 4/5] avcodec/cuviddec: Add support for decoding HEVC 4:4:4 content

2018-10-07 Thread Philip Langdale
This is the equivalent change for cuviddec after the previous change for nvdec. I made similar changes to the copying routines to handle pixel formats in a more generic way. Note that unlike with nvdec, there is no confusion about the ability of a codec to output 444 formats. This is because the c

[FFmpeg-devel] [PATCH 0/5] Add nvidia hw decode support for HEVC 4:4:4 content

2018-10-07 Thread Philip Langdale
The new video decoder hardware on Turing GPUs supports HEVC 4:4:4 content. This patch series adds the necessary new pixel formats and implements support in nvdec/nvenc/cuviddec. Philip Langdale (5): avutil: Add YUV444P10_LSB and YUV444P12_LSB pixel formats avcodec/nvdec: Add support for decodi

[FFmpeg-devel] [PATCH 1/5] avutil: Add YUV444P10_LSB and YUV444P12_LSB pixel formats

2018-10-07 Thread Philip Langdale
Currently, ffmpeg defines a set of YUV444P formats for use where the bits-per-pixel are between 8 and 16 bits. In these formats, the bits are packed in the MSBs of the 16 bits of available storage. On the other hand, all the hardware vendors have defined their equivalent formats with the bits pack

Re: [FFmpeg-devel] H.264 SEI Display Orientation Message support in ffplay

2018-10-07 Thread Omer Iqbal
Thanks for the suggestion. I took a quick look at mpv. Sadly it does not seem to support H.264 SEI Display Orientation messages either :(. Please correct me if I am wrong. I also glanced at VLC. It doesn’t seem to use AV_FRAME_DATA_DISPLAYMATRIX either. I'm curious, does anyone know why this is not

Re: [FFmpeg-devel] H.264 SEI Display Orientation Message support in ffplay

2018-10-07 Thread Dennis Mungai
You might be better served by mpv. libmpv may be a better implementation for a video player than ffplay. On Sun, Oct 7, 2018, 19:04 Omer Iqbal wrote: > Hey everyone! > > I am developing a video streaming mobile application. In order to support > multiple orientations, I am currently using h.264'

Re: [FFmpeg-devel] [PATCH 3/5] libavfilter/ebur128: add gaugetype option

2018-10-07 Thread Paul B Mahol
On 10/7/18, Daniel Molkentin wrote: > Allow to show short term instead of momentary. Useful for monitoring > whilst live mixing. > > Signed-off-by: Daniel Molkentin > Signed-off-by: Conrad Zelck > --- > doc/filters.texi| 8 +++- > libavfilter/f_ebur128.c | 18 -- >

[FFmpeg-devel] H.264 SEI Display Orientation Message support in ffplay

2018-10-07 Thread Omer Iqbal
Hey everyone! I am developing a video streaming mobile application. In order to support multiple orientations, I am currently using h.264's SEI Display Orientation message in my H.264 bitstream. (For more context, my bitstream is transported over RTMP and packaged as FLV) I see that ffprobe can d

[FFmpeg-devel] [PATCH 5/5] libavfilter/ebur128: add mabsolute parameter

2018-10-07 Thread Daniel Molkentin
This allows switching between absolute (LUFS) and relativ (LU) display in the status line. Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- doc/filters.texi| 4 libavfilter/f_ebur128.c | 34 +- 2 files changed, 29 insertions(+), 9 del

[FFmpeg-devel] [PATCH 1/5] libavfilter/ebur128: add target level option for EBUR128 visualization filter

2018-10-07 Thread Daniel Molkentin
Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- doc/filters.texi| 6 ++ libavfilter/f_ebur128.c | 6 -- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 30a52c4fdb..bd5154f9be 100644 --- a/doc/filters.texi +

[FFmpeg-devel] [PATCH 2/5] libavfilter/ebur128: add target value to statistics line

2018-10-07 Thread Daniel Molkentin
Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- libavfilter/f_ebur128.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index dfccbff5ec..89bfcb0b3e 100644 --- a/libavfilter/f_ebur128.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH 4/5] libavfilter/ebur128: introduce target range

2018-10-07 Thread Daniel Molkentin
This eases meeting the target level during live mixing. Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- doc/filters.texi| 3 +++ libavfilter/f_ebur128.c | 33 +++-- 2 files changed, 26 insertions(+), 10 deletions(-) diff --git a/doc/filters.

[FFmpeg-devel] [PATCH 3/5] libavfilter/ebur128: add gaugetype option

2018-10-07 Thread Daniel Molkentin
Allow to show short term instead of momentary. Useful for monitoring whilst live mixing. Signed-off-by: Daniel Molkentin Signed-off-by: Conrad Zelck --- doc/filters.texi| 8 +++- libavfilter/f_ebur128.c | 18 -- 2 files changed, 23 insertions(+), 3 deletions(-) dif

[FFmpeg-devel] [PATCH 0/5] Improvements for EBU R128 plugin

2018-10-07 Thread Daniel Molkentin
Hi, we are using ffmpeg to monitor audio for use in online video production. In order to make this more practical, we added a couple of features to the ebur128 with the help from audio professionals. Please let me know if they are good for going into master, and if you would like to see any chang

[FFmpeg-devel] [PATCH] avcodec/aacdec_template: Allow duplicated elements

2018-10-07 Thread Michael Niedermayer
Such streams are invalid according to 4.5.2.1 Top level payloads for the audio object types AAC main, AAC SSR, AAC LC and AAC LTP 4.5.2.1.1 Definitions ...cIn the raw_data_block(), several instances of the same syntactic element may occur, but must have a different 4 bit element_instance_tag, exce

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: Add support for decoding HEVC 4:4:4 content

2018-10-07 Thread Timo Rothenpieler
On 07.10.2018 04:19, Philip Langdale wrote: The latest generation video decoder on the Turing chips supports decoding HEVC 4:4:4. Supporting this is relatively straight-forward; we need to account for the different chroma format and pick the right output and sw formats at the right times. There

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/aacdec_template: Check for duplicate elements

2018-10-07 Thread Hendrik Leppkes
On Sat, Jul 28, 2018 at 2:33 PM Michael Niedermayer wrote: > > Fixes: Timeout > Fixes: > 9552/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-6027842339995648 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off