Re: [FFmpeg-devel] patch for failing on WavPack DSD files

2018-11-20 Thread Peter Ross
On Tue, Nov 20, 2018 at 09:23:03PM -0800, David Bryant wrote: > Hi, > > Was made aware of this problem on Kodi: > > https://github.com/xbmc/xbmc/issues/14771 > > I'm going to try to add full WavPack DSD support, but thought in the meantime > it would be a good idea to detect and error out

[FFmpeg-devel] patch for failing on WavPack DSD files

2018-11-20 Thread David Bryant
Hi, Was made aware of this problem on Kodi: https://github.com/xbmc/xbmc/issues/14771 I'm going to try to add full WavPack DSD support, but thought in the meantime it would be a good idea to detect and error out early. Thanks! David >From c86aacdf98c3d34a3f8d63233e01c4a3ab55577e Mon Sep 17

[FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-20 Thread Haihao Xiang
This fixes the link errors below: LD ffmpeg_g libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_sse2' collect2: error: ld returned 1 exit status Makefile:108: recipe for target 'ffmpeg_g' failed make: ***

Re: [FFmpeg-devel] [PATCH] avcodec: add truehd_core bitstream filter

2018-11-20 Thread James Almer
On 11/20/2018 3:17 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/bitstream_filters.texi | 4 + > libavcodec/Makefile| 1 + > libavcodec/bitstream_filters.c | 1 + > libavcodec/truehd_core_bsf.c | 182 + > 4 files

[FFmpeg-devel] [PATCH V2 1/5] lavfi/buffersrc: Indent the code.

2018-11-20 Thread Jun Zhao
commit b0012de420f missed reindent. Signed-off-by: Jun Zhao --- libavfilter/buffersrc.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index cd56f8c..0c12650 100644 ---

[FFmpeg-devel] [PATCH V2 0/5] Misc change V2

2018-11-20 Thread Jun Zhao
V2: - fix max_bit_rate dump change break the fate test. (based on Micheal/Moritz's review) V1: - indet ffmpeg/buffersrc - add auto threads flag for kvazaar - delete the unused code from ffmpeg - fix max_bit_rate dump warning for ffprobe Jun Zhao (5): lavfi/buffersrc: Indent

[FFmpeg-devel] [PATCH V2 4/5] fftools/ffmpeg: delete the unused code.

2018-11-20 Thread Jun Zhao
There are come from 2012 ago and have never been used from this time. Signed-off-by: Jun Zhao --- fftools/ffmpeg.c |9 + 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index a12208c..085d6d2 100644 --- a/fftools/ffmpeg.c +++

[FFmpeg-devel] [PATCH V2 5/5] lavc/kvazaar: fix auto thread flag in kvazaar wrapper.

2018-11-20 Thread Jun Zhao
Now the kvazaar warpper didn't setting the threads for kvazaar API, and kavzaar will auto selecte the thread number. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c

[FFmpeg-devel] [PATCH V2 3/5] fftools/ffprobe: Indent the code.

2018-11-20 Thread Jun Zhao
commit 196765a7cc4 missed the reindet. Signed-off-by: Jun Zhao --- fftools/ffprobe.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index ab0dbff..f8c5f33 100644 --- a/fftools/ffprobe.c +++

[FFmpeg-devel] [PATCH V2 2/5] fftools/ffprobe: fix max_bit_rate dump.

2018-11-20 Thread Jun Zhao
‘codec’ is deprecated in AVStream, so used the dec_ctx to dump max_bit_rate in ffprobe. Clean the warning like: "warning: ‘codec’ is deprecated [-Wdeprecated-declarations]" Reviewed-by: Moritz Barsnick Signed-off-by: Jun Zhao --- fftools/ffprobe.c |6 ++ 1 files changed, 2

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffprobe: fix max_bit_rate dump.

2018-11-20 Thread myp...@gmail.com
On Tue, Nov 20, 2018 at 6:17 AM Michael Niedermayer wrote: > > On Mon, Nov 19, 2018 at 08:40:07AM +0800, myp...@gmail.com wrote: > > On Mon, Nov 19, 2018 at 6:03 AM Moritz Barsnick wrote: > > > > > > > +if (dec_ctx->rc_max_rate > 0) print_val ("max_bit_rate", > > > > dec_ctx->rc_max_rate,

Re: [FFmpeg-devel] [PATCH] avcodec/truemotion2: Check huffman code max bits

2018-11-20 Thread Michael Niedermayer
On Tue, Nov 20, 2018 at 12:09:50PM +0100, Tomas Härdin wrote: > mån 2018-11-19 klockan 23:47 +0100 skrev Michael Niedermayer: > > Fixes: Timeout > > Fixes: > > 10984/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-6643310750859264 > > > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 3/5] configure: memalign is broken on djgpp 2.05

2018-11-20 Thread Michael Niedermayer
On Tue, Nov 20, 2018 at 11:24:10PM +0100, Michael Niedermayer wrote: > On Wed, Nov 21, 2018 at 01:29:48AM +1100, Peter Ross wrote: > > djgpp 2.05 finally provides posix-compatible memalign, but it is broken, > > so use disable it if this version is detected. > > > > discussion: > >

Re: [FFmpeg-devel] [PATCH 5/5] fate-api-h264-slice: use the heap for nal buffer

2018-11-20 Thread Michael Niedermayer
On Wed, Nov 21, 2018 at 01:31:44AM +1100, Peter Ross wrote: > nal buffer is 512 kilobytes > --- > tests/api/api-h264-slice-test.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 3/5] configure: memalign is broken on djgpp 2.05

2018-11-20 Thread Michael Niedermayer
On Wed, Nov 21, 2018 at 01:29:48AM +1100, Peter Ross wrote: > djgpp 2.05 finally provides posix-compatible memalign, but it is broken, > so use disable it if this version is detected. > > discussion: > http://www.delorie.com/archives/browse.cgi?p=djgpp/2017/12/29/16:26:58 > --- > configure | 11

Re: [FFmpeg-devel] [PATCH] api-h264-slice-test: use av_be2ne16 instead of ntohs

2018-11-20 Thread Michael Niedermayer
On Tue, Nov 20, 2018 at 06:51:52PM +1100, Peter Ross wrote: > avformat/network.h is not required here. > --- > tests/api/api-h264-slice-test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

2018-11-20 Thread Thomas Tgames
Thanks for your fast answer. Yes i know ffmpeg is not capable of encoding to APC format. That’s why i ask if it can be Added in the development of ffmpeg. Best Regards. De : Marvin Scholz Envoyé le :mardi 20 novembre 2018 22:44 À : FFmpeg development discussions and

Re: [FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

2018-11-20 Thread Marvin Scholz
On 20 Nov 2018, at 22:09, Thomas Tgames wrote: Hi everyone ! I would like to convert a wav file of music into APC format (Atlantis The Lost Tales). I’m working on a new version of the game. I’m successfully able to convert all APC of the game to WAV. But i want to do the process backward

[FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

2018-11-20 Thread Thomas Tgames
Hi everyone ! I would like to convert a wav file of music into APC format (Atlantis The Lost Tales). I’m working on a new version of the game. I’m successfully able to convert all APC of the game to WAV. But i want to do the process backward for only one music here :

[FFmpeg-devel] [PATCH] avcodec: add truehd_core bitstream filter

2018-11-20 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/bitstream_filters.texi | 4 + libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/truehd_core_bsf.c | 182 + 4 files changed, 188 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH] lavf/dashenc: Fix segment duration overflow on fine time bases.

2018-11-20 Thread Andrey Semashev
When stream time bases are very fine grained (e.g. nanoseconds), 32-bit segment duration may overflow for even for rather small segment duration (about 4 seconds long). Therefore we use 64-bit values for segment duration. --- libavformat/dashenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [FFmpeg-devel] [PATCH] libavformat: add multiple PCR streams in MPEGTS muxer [v2]

2018-11-20 Thread msanders
Hi, Regarding Andrey Turkin's comments on my first version of the patch, here are some comments: - Multiple streams with PCR marks in the same program are **allowed**. ISO/IEC 13818-1: "Information technology — Generic coding of moving pictures and associated audio

[FFmpeg-devel] [PATCH] libavformat: add multiple PCR streams in MPEGTS muxer [v2]

2018-11-20 Thread msanders
This new patch adds three new options to the MPEG-TS muxer. You can use them to mark PCRs in additional VIDEO/AUDIO/DATA streams. It's useful when you will remux the output with pid filtering tools. For example, if you put PCR in all audio streams, then you can filter each audio stream to create a

[FFmpeg-devel] [PATCH 5/5] fate-api-h264-slice: use the heap for nal buffer

2018-11-20 Thread Peter Ross
nal buffer is 512 kilobytes --- tests/api/api-h264-slice-test.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/api/api-h264-slice-test.c b/tests/api/api-h264-slice-test.c index be03e80049..181bbe5a6f 100644 --- a/tests/api/api-h264-slice-test.c +++

[FFmpeg-devel] [PATCH 4/5] avpriv_tempfile: add djgpp fallback

2018-11-20 Thread Peter Ross
--- libavutil/file_open.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/file_open.c b/libavutil/file_open.c index a8da283583..cc302f2f76 100644 --- a/libavutil/file_open.c +++ b/libavutil/file_open.c @@ -138,7 +138,7 @@ int avpriv_tempfile(const char *prefix, char

[FFmpeg-devel] [PATCH 3/5] configure: memalign is broken on djgpp 2.05

2018-11-20 Thread Peter Ross
djgpp 2.05 finally provides posix-compatible memalign, but it is broken, so use disable it if this version is detected. discussion: http://www.delorie.com/archives/browse.cgi?p=djgpp/2017/12/29/16:26:58 --- configure | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH 2/5] additional math.h functions for djgpp

2018-11-20 Thread Peter Ross
--- compat/djgpp/math.c | 47 +++ compat/djgpp/math.h | 25 +++ configure | 2 ++ tests/ref/fate/source | 1 + 4 files changed, 75 insertions(+) create mode 100644 compat/djgpp/math.c create mode 100644

[FFmpeg-devel] [PATCH 1/5] configure: detect djgpp libc

2018-11-20 Thread Peter Ross
--- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index b4f944cfb0..9ceb4a0c76 100755 --- a/configure +++ b/configure @@ -5295,7 +5295,6 @@ case $target_os in network_extralibs="-lsocket" objformat="coff" enable

[FFmpeg-devel] [PATCH 0/5] djgpp patch set v2

2018-11-20 Thread Peter Ross
revised ffmpeg dos patch set. passes fate. Peter Ross (5): configure: detect djgpp libc additional math.h functions for djgpp configure: memalign is broken on djgpp 2.05 avpriv_tempfile: add djgpp fallback fate-api-h264-slice: use the heap for nal buffer compat/djgpp/math.c

Re: [FFmpeg-devel] [PATCH 4/4] lavf/dashenc: Fix AVDictionary leaks in case of various init errors.

2018-11-20 Thread Andrey Semashev
On 11/18/18 1:55 PM, Jeyapal, Karthick wrote: Thanks for sending these excellent patches. The entire patchset looks good to me. Also, many thanks for your patience and taking the earlier review comments in the right spirit. Ping for merging it then? On 11/17/18 11:10 PM, Andrey Semashev

Re: [FFmpeg-devel] [PATCH 2/4] avutil/buffer: Add av_fast_malloc equivalent

2018-11-20 Thread Hendrik Leppkes
On Tue, Nov 20, 2018 at 12:45 PM Andreas Rheinhardt wrote: > > A new function, avpriv_buffer_fast_alloc, is added. Its distinguishing > feature is that the content of the buffer is considered expendable > for the given reference, so that no data copying is performed. > > Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 0/4] cbs_h2645: Avoid memcpy when reading

2018-11-20 Thread Andreas Rheinhardt
The aim of this patchset is to avoid the memcpy that currently happens in cbs_h2645_fragment_add_nals during the reading stage of cbs_h2645. This is done by taking advantage of the way ff_h2645_packet_split (and internally ff_h2645_extract_rbsp) works: If the NAL initially didn't contain any 0x03

[FFmpeg-devel] [PATCH 1/4] cbs_h2645: Avoid memcpy when splitting fragment

2018-11-20 Thread Andreas Rheinhardt
Now memcpy is avoided for NAL units that don't contain 0x03 escape characters. Improves performance of cbs_h2645_fragment_add_nals from 36940 decicycles to 6364 decicycles based on 8 runs with a 5.1 Mb/s H.264 sample (262144 runs each). Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH 2/4] avutil/buffer: Add av_fast_malloc equivalent

2018-11-20 Thread Andreas Rheinhardt
A new function, avpriv_buffer_fast_alloc, is added. Its distinguishing feature is that the content of the buffer is considered expendable for the given reference, so that no data copying is performed. Signed-off-by: Andreas Rheinhardt --- libavutil/buffer.c | 37

[FFmpeg-devel] [PATCH 4/4] cbs_h2645: Avoid memcpy when splitting fragment #2

2018-11-20 Thread Andreas Rheinhardt
Now memcpy can be avoided for NAL units containing escapes, too. Particularly improves performance for files with hardcoded black bars. For such a file, time spent in cbs_h2645_split_fragment went down from 369410 decicycles to 327677 decicycles. (It were 379114 decicycles when every NAL unit was

[FFmpeg-devel] [PATCH 3/4] h2645_parse: Make ff_h2645_packet_split reference-compatible

2018-11-20 Thread Andreas Rheinhardt
This is in preparation for a patch for cbs_h2645. Now the packet's rbsp_buffer can be owned by an AVBuffer. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_h2645.c | 12 ++-- libavcodec/extract_extradata_bsf.c | 4 ++-- libavcodec/h2645_parse.c | 28

Re: [FFmpeg-devel] [PATCH] avcodec/truemotion2: Check huffman code max bits

2018-11-20 Thread Tomas Härdin
mån 2018-11-19 klockan 23:47 +0100 skrev Michael Niedermayer: > Fixes: Timeout > Fixes: > 10984/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-6643310750859264 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/truemotion2: fix integer overflows in tm2_low_chroma()

2018-11-20 Thread Tomas Härdin
tis 2018-11-20 klockan 00:04 +0100 skrev Michael Niedermayer: > On Mon, Nov 19, 2018 at 09:37:28AM +0100, Tomas Härdin wrote: > > mån 2018-11-19 klockan 02:02 +0100 skrev Michael Niedermayer: > > > On Sun, Nov 18, 2018 at 11:32:21PM +0100, Tomas Härdin wrote: > > > > lör 2018-11-17 klockan 03:01

Re: [FFmpeg-devel] [PATCHv2] avfilter/graphmonitor: use SIZE_SPECIFIER for size_t type

2018-11-20 Thread Carl Eugen Hoyos
2018-11-20 8:46 GMT+01:00, Peter Ross : > --- > libavfilter/f_graphmonitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/f_graphmonitor.c b/libavfilter/f_graphmonitor.c > index 7052c84d9b..c001835364 100644 > --- a/libavfilter/f_graphmonitor.c > +++