[FFmpeg-devel] [PATCH,v3] lavc/qsvenc: add VDENC support for H264

2018-11-26 Thread Linjie Fu
Add VDENC(lowpower mode) support for QSV H264. It's an experimental function(like lowpower in vaapi) with some limitations: - CBR/VBR require HuC which should be explicitly loaded via i915 module parameter(i915.enable_guc=2 for linux kernel version >= 4.16) use option "-low_power 1" to enable

Re: [FFmpeg-devel] [PATCH 4/4] lavf/dashenc: Fix AVDictionary leaks in case of various init errors.

2018-11-26 Thread Jeyapal, Karthick
On 11/26/18 4:31 PM, Andrey Semashev wrote: > On Wed, Nov 21, 2018 at 3:45 PM Jeyapal, Karthick wrote: > > On 11/20/18 6:01 PM, Andrey Semashev wrote: > > > On 11/18/18 1:55 PM, Jeyapal, Karthick wrote: > > > > Thanks for sending these excellent patches. The entire patchset looks > > > > good

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Fix integer overflows in left shift in init_image()

2018-11-26 Thread Michael Niedermayer
On Mon, Nov 26, 2018 at 12:08:27PM +0100, Tomas Härdin wrote: > mån 2018-11-26 klockan 02:57 +0100 skrev Michael Niedermayer: > > Fixes: left shift of 255 by 24 places cannot be represented in type 'int' > > Fixes: > >

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize yuv2plane1_8

2018-11-26 Thread Carl Eugen Hoyos
2018-11-21 18:19 GMT+01:00, Lauri Kasanen : > First I ran with THREADS=3, baseline blew up in > fate-h264-conformance-frext-hpcafl_bcrm_c I opened ticket #7570, thank you for the report! Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] avcodec/proresaw_enc : improvment (vendor and color properties, 4444Xq)

2018-11-26 Thread Michael Niedermayer
On Mon, Nov 26, 2018 at 04:19:20PM +0100, Martin Vignali wrote: > > > + > > > +switch (pict->colorspace) { > > > +case AVCOL_SPC_BT709: > > > +case AVCOL_SPC_UNSPECIFIED: > > > +case AVCOL_SPC_SMPTE170M: > > > +case AVCOL_SPC_BT2020_NCL: > > > +colorspace =

Re: [FFmpeg-devel] fate-rv20-1239 failure on power8, aliasing bug

2018-11-26 Thread Carl Eugen Hoyos
2018-11-26 23:35 GMT+01:00, Michael Niedermayer : > On Mon, Nov 26, 2018 at 12:45:26AM +0100, Carl Eugen Hoyos wrote: >> 2018-11-25 16:17 GMT+01:00, Lauri Kasanen : >> > Hi, >> > >> > The lone power8 fate failing test seems like an aliasing issue. >> > I've isolated it into the attached standalone

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize yuv2plane1_8

2018-11-26 Thread Carl Eugen Hoyos
2018-11-27 0:17 GMT+01:00, Carl Eugen Hoyos : > 2018-11-17 9:12 GMT+01:00, Lauri Kasanen : >> ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt >> yuv420p \ >> -f null -vframes 100 -v error -nostats - >> >> 1158 UNITS in planar1, 65528 runs, 8 skips >> >> -cpuflags 0 >>

Re: [FFmpeg-devel] [PATCH] libvmaf: update docs

2018-11-26 Thread Kyle Swanson
Hi, On 10/22/18, Kyle Swanson wrote: > From: Kyle Swanson > > For context: https://github.com/Netflix/vmaf/issues/237 > > Signed-off-by: Kyle Swanson > --- > > I'll push this sometime in the next 24hrs unless someone has an issue. Almost forgot about this. Pushed an updated version. Thanks.

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize yuv2plane1_8

2018-11-26 Thread Carl Eugen Hoyos
2018-11-17 9:12 GMT+01:00, Lauri Kasanen : > ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt > yuv420p \ > -f null -vframes 100 -v error -nostats - > > 1158 UNITS in planar1, 65528 runs, 8 skips > > -cpuflags 0 > > 19082 UNITS in planar1, 65533 runs, 3 skips > >

Re: [FFmpeg-devel] [PATCH] avutil/mem: Fix invalid use of av_alloc_size

2018-11-26 Thread Michael Niedermayer
On Sun, Nov 25, 2018 at 05:55:37PM -0800, Mark Harris wrote: > On 2018-11-25 17:29, James Almer wrote: > > On 11/25/2018 10:01 PM, Michael Niedermayer wrote: > >> On Sat, Nov 24, 2018 at 01:02:02PM -0800, Mark Harris wrote: > >>> The alloc_size attribute is valid only on functions that return a >

Re: [FFmpeg-devel] [PATCH] avformat/vivo: Don't log null value

2018-11-26 Thread Michael Niedermayer
On Sun, Nov 25, 2018 at 09:52:04AM +0100, Paul B Mahol wrote: > On 11/25/18, Mark Harris wrote: > > --- > > libavformat/vivo.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/vivo.c b/libavformat/vivo.c > > index c9e9c37f37..9b9189f307 100644 > > ---

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromashift: Fix mixed declaration and code

2018-11-26 Thread Michael Niedermayer
On Sun, Nov 25, 2018 at 09:52:58AM +0100, Paul B Mahol wrote: > On 11/25/18, Mark Harris wrote: > > --- > > libavfilter/vf_chromashift.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/libavfilter/vf_chromashift.c b/libavfilter/vf_chromashift.c > > index

Re: [FFmpeg-devel] fate-rv20-1239 failure on power8, aliasing bug

2018-11-26 Thread Michael Niedermayer
On Mon, Nov 26, 2018 at 12:45:26AM +0100, Carl Eugen Hoyos wrote: > 2018-11-25 16:17 GMT+01:00, Lauri Kasanen : > > Hi, > > > > The lone power8 fate failing test seems like an aliasing issue. > > I've isolated it into the attached standalone test case. Compiling it > > with > > gcc -std=c11

Re: [FFmpeg-devel] [PATCH] avformat/ac3dec: always skip junk bytes before sync bytes

2018-11-26 Thread Michael Niedermayer
On Sun, Nov 25, 2018 at 12:18:15PM +0100, Paul B Mahol wrote: > Fixes #7278. > > Signed-off-by: Paul B Mahol > --- > libavcodec/ac3dec.c | 19 --- > libavformat/ac3dec.c | 2 +- > 2 files changed, 17 insertions(+), 4 deletions(-) this seems to break TESTeac3-5 stddev:

Re: [FFmpeg-devel] [PATCH] avcodec: add PCM-DVD encoder

2018-11-26 Thread Carl Eugen Hoyos
2018-11-26 20:48 GMT+01:00, Paul B Mahol : > TODO: add >16 bit support, needs to muxer update. Please mention ticket #6784. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec: add PCM-DVD encoder

2018-11-26 Thread Paul B Mahol
TODO: add >16 bit support, needs to muxer update. Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/pcm-dvdenc.c | 159 3 files changed, 161 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH] libavfilter: scale_cuda filter adds dynamic command values

2018-11-26 Thread msanders
‐‐‐ Original Message ‐‐‐ On Monday, 26 de November de 2018 20:10, Timo Rothenpieler wrote: > On 26.11.2018 19:09, msanders wrote: > > > Hi, > > This patch adds command support for dynamic change the size in the > > “scale_cuda” resize filter. In fact, it’s the first GPU filter

Re: [FFmpeg-devel] [PATCH] libavfilter: scale_cuda filter adds dynamic command values

2018-11-26 Thread Timo Rothenpieler
On 26.11.2018 19:09, msanders wrote: Hi, This patch adds command support for dynamic change the size in the “scale_cuda” resize filter. In fact, it’s the first GPU filter accepting realtime commands. Using similar changes it’s possible to port it to other hwaccelerators. The only limitation

[FFmpeg-devel] [PATCH] libavfilter: scale_cuda filter adds dynamic command values

2018-11-26 Thread msanders
Hi, This patch adds command support for dynamic change the size in the “scale_cuda” resize filter. In fact, it’s the first GPU filter accepting realtime commands. Using similar changes it’s possible to port it to other hwaccelerators. The only limitation is that the values cannot exceed the

Re: [FFmpeg-devel] avdevice/v4l2-common: add Z16 pixel format

2018-11-26 Thread Carl Eugen Hoyos
2018-11-26 16:35 GMT+01:00, Pablo Rubio Fernández : > Simple patch to work with Z16 pixel format as gray16le. Doesn't this break gray16 recordings with your v4l2 device? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] avcodec/proresaw_enc : improvment (vendor and color properties, 4444Xq)

2018-11-26 Thread Martin Vignali
> > (alpha 12b encoding is probably > > easy to add) > > Are you sure alpha is 12 bit? As long as I remember, it is 16 bit. > > Alpha is stored in 16b, but like the input pix fmt is 10b or (later) 12b alpha, the alpha val is shift during encoding to obtain a 16b val. The right way will be to add

Re: [FFmpeg-devel] [INFO]AMD D3D11 to OpenCL interop extension for NV12 and P010 textures - split planes

2018-11-26 Thread Mironov, Mikhail
You assume that device ID returned from regular enumeration is the same as device ID returned from clGetDeviceIDsFromD3D11KHR. It is not guaranteed and I didn't try this. Also I would add tracing to ensure that CL_CONTEXT_D3D11_DEVICE_KHR is actually set and clGetDeviceIDsFromD3D11KHR is

[FFmpeg-devel] [PATCH] avdevice/v4l2-common: add Z16 pixel format

2018-11-26 Thread Pablo Rubio Fernández
Simple patch to work with Z16 pixel format as gray16le. From 39e24c9cbbdacc594e47112dabcaed777028d6b6 Mon Sep 17 00:00:00 2001 From: prubio Date: Mon, 26 Nov 2018 10:04:07 +0100 Subject: [PATCH] avdevice/v4l2-common: add Z16 pixel format Added Z16 pixel format. Works as gray16le. ---

[FFmpeg-devel] avdevice/v4l2-common: add Z16 pixel format

2018-11-26 Thread Pablo Rubio Fernández
Simple patch to work with Z16 pixel format as gray16le. From 39e24c9cbbdacc594e47112dabcaed777028d6b6 Mon Sep 17 00:00:00 2001 From: prubio Date: Mon, 26 Nov 2018 10:04:07 +0100 Subject: [PATCH] avdevice/v4l2-common: add Z16 pixel format Added Z16 pixel format. Works as gray16le. ---

Re: [FFmpeg-devel] avcodec/proresaw_enc : improvment (vendor and color properties, 4444Xq)

2018-11-26 Thread Reto Kromer
> On 26 Nov 2018, at 15:28, Martin Vignali wrote: > > (alpha 12b encoding is probably > easy to add) Are you sure alpha is 12 bit? As long as I remember, it is 16 bit. Best regards, Reto ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] avcodec/proresaw_enc : improvment (vendor and color properties, 4444Xq)

2018-11-26 Thread Martin Vignali
> > So I applied these patches and it appears that ffmpeg will encode XQ as > 10-bit, but it will decode as 12-bit. Is this intentional? I worry that I > might have applied the patches incorrectly. And is it possible to add > 12-bit encoding? > > Hello, Seems like you applied patch "add 12b

Re: [FFmpeg-devel] avcodec/proresaw_enc : improvment (vendor and color properties, 4444Xq)

2018-11-26 Thread Martin Vignali
> > + > > +switch (pict->colorspace) { > > +case AVCOL_SPC_BT709: > > +case AVCOL_SPC_UNSPECIFIED: > > +case AVCOL_SPC_SMPTE170M: > > +case AVCOL_SPC_BT2020_NCL: > > +colorspace = pict->colorspace; > > +break; > > +default: > > +av_log(avctx,

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-26 Thread Martin Vignali
> > +/* align height to 16, to avoid segfault */ > > +tframe.f->height = FFALIGN(avctx->height, 16); > > +tframe.f->width = FFALIGN(avctx->width, 16); > > +tframe.f->crop_bottom = tframe.f->height - avctx->height; > > + > > if ((ret = ff_thread_get_buffer(avctx, , 0)) < 0) > >

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-26 Thread Derek Buitenhuis
On 23/11/2018 02:16, Michael Niedermayer wrote: > do we have some sample flv files that require this patchset / that have > discontinuites. I have many. I've mailed you one privately, while I work on getting a public one. > another thing i just realize now, why is this discontinuity issues

[FFmpeg-devel] [PATCH 1/5] cbs: Add function to make content of a unit writable

2018-11-26 Thread Andreas Rheinhardt
This will enable us to change e.g. the parameter sets of H.2645 in ways that would change the parsing process of future units. An example of this is the h264_redundant_pps bsf. The actual implementation of the underlying codec-dependent make_writable functions is not contained in this commit.

[FFmpeg-devel] [PATCH 5/5] h264_redundant_pps: Make it reference-compatible

2018-11-26 Thread Andreas Rheinhardt
Since c6a63e11092c975b89d824f08682fe31948d3686, the parameter sets modified as content of PPS units were references shared with the CodedBitstreamH264Context, so modifying them alters the parsing process of future access units which meant that frames often got discarded because invalid values were

[FFmpeg-devel] [PATCH 3/5] cbs_h2645: Implement copy-functions for parameter sets

2018-11-26 Thread Andreas Rheinhardt
and use them to replace the context's parameter sets. This fixes a dangling pointers problem with the parameter sets held in the CodedBitstreamH26xContext that occurs when the parameter sets were not reference-counted initially. The functions to free the parameter sets that have a special free

[FFmpeg-devel] [PATCH 2/5] cbs: Add a macro to create functions for deep copying

2018-11-26 Thread Andreas Rheinhardt
Some structs in cbs (most importantly some of the parameter sets of H.264/HEVC) can contain external buffers so that shallow copies are not enough for them; furthermore, they need a special free-callback function. The macro provided in this commit can be used to easily create functions both for

[FFmpeg-devel] [PATCH 4/5] cbs_h2645: Implement functions to make a unit's content writable

2018-11-26 Thread Andreas Rheinhardt
These functions (which are only implemented for parameter sets) make it possible to change the contents of the parameter sets as one pleases without changing/breaking the parsing process of future access units. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_h2645.c | 65

[FFmpeg-devel] [PATCH v4] lavc/qsvenc: add forced_idr option

2018-11-26 Thread Zhong Li
This option can be used to repect original input I/IDR frame type. Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 7 +++ libavcodec/qsvenc.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 948751d..3946c1d 100644 ---

Re: [FFmpeg-devel] [PATCH] hwcontext_opencl: Only release command queue if it exists

2018-11-26 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Mark Thompson > Sent: Monday, November 26, 2018 3:16 AM > To: FFmpeg development discussions and patches > Subject: [FFmpeg-devel] [PATCH] hwcontext_opencl: Only release command > queue if

[FFmpeg-devel] [PATCH] swscale/ppc: Move VSX-using code to its own file

2018-11-26 Thread Lauri Kasanen
Passes fate on LE (with "lavc/jrevdct: Avoid an aliasing violation" applied). Can anyone test BE? Signed-off-by: Lauri Kasanen --- libswscale/ppc/Makefile | 1 + libswscale/ppc/swscale_altivec.c | 291 ++

[FFmpeg-devel] [PATCH] libavfilter: fix hwdownload dynamic resizing

2018-11-26 Thread msanders
This patch resolves dynamic resizing changes in the hwdownload filter. See more info at: https://trac.ffmpeg.org/ticket/7564 Regards. M. SandersFrom 2efeb454400db117af276cdfd6a98a00b80ca114 Mon Sep 17 00:00:00 2001 From: M. Sanders Date: Mon, 26 Nov 2018 11:56:14 + Subject: [PATCH]

Re: [FFmpeg-devel] fate-rv20-1239 failure on power8, aliasing bug

2018-11-26 Thread Lauri Kasanen
On Mon, 26 Nov 2018 00:45:26 +0100 Carl Eugen Hoyos wrote: > 2018-11-25 16:17 GMT+01:00, Lauri Kasanen : > > Hi, > > > > The lone power8 fate failing test seems like an aliasing issue. > > I've isolated it into the attached standalone test case. Compiling it > > with > > gcc -std=c11 -maltivec

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Fix integer overflows in left shift in init_image()

2018-11-26 Thread Tomas Härdin
mån 2018-11-26 klockan 02:57 +0100 skrev Michael Niedermayer: > Fixes: left shift of 255 by 24 places cannot be represented in type 'int' > Fixes: > 11377/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-5694319101476864 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 4/4] lavf/dashenc: Fix AVDictionary leaks in case of various init errors.

2018-11-26 Thread Andrey Semashev
On Wed, Nov 21, 2018 at 3:45 PM Jeyapal, Karthick wrote: > On 11/20/18 6:01 PM, Andrey Semashev wrote: > > On 11/18/18 1:55 PM, Jeyapal, Karthick wrote: > > > Thanks for sending these excellent patches. The entire patchset looks > > > good to me. > > > Also, many thanks for your patience and

Re: [FFmpeg-devel] avcodec/proresaw_enc : improvment (vendor and color properties, 4444Xq)

2018-11-26 Thread Kieran O Leary
On Mon, Nov 26, 2018 at 8:06 AM Kieran O Leary wrote: > > > On Sat, 24 Nov 2018, 22:11 Martin Vignali >> Hello, >> >> Patch in attach add some improvments to prores aw encoder >> >> 012 : Add vendor option (code come from prores_ks encoder) >> 013 : Only write color properties, if defined in

[FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Added an option to ignore io errors

2018-11-26 Thread Karthick J
When dashenc has to run for long duration(say 24x7 live stream), one can enable this option to ignore the io failure of few segment's upload due to an intermittent network issues. When the network connection recovers dashenc will continue with the upload of the current segments, leading to the

[FFmpeg-devel] [PATCH 1/2] avformat/dashenc: Handled the error from dashenc_io_open()

2018-11-26 Thread Karthick J
--- libavformat/dashenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 6ce70e0076..2f403257c0 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -527,8 +527,12 @@ static void

Re: [FFmpeg-devel] [PATCH] lavc/decode: allow users to shrink the hw frames pool size, if they so desire.

2018-11-26 Thread Timo Rothenpieler
On 25/11/2018 15:05, Mark Thompson wrote: I see what you're trying to do here, but I'm not sure that overloading this option is the best way to achieve it. This option has a specific meaning in terms of the consumer of the frames, and is intended to be negotiated (any consumers of hardware

Re: [FFmpeg-devel] [PATCH] hwcontext_opencl: Use correct function to enumerate devices

2018-11-26 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Mark Thompson > Sent: Monday, November 26, 2018 6:08 AM > To: FFmpeg development discussions and patches > Subject: [FFmpeg-devel] [PATCH] hwcontext_opencl: Use correct function to >

Re: [FFmpeg-devel] avcodec/proresaw_enc : improvment (vendor and color properties, 4444Xq)

2018-11-26 Thread Kieran O Leary
On Sat, 24 Nov 2018, 22:11 Martin Vignali Hello, > > Patch in attach add some improvments to prores aw encoder > > 012 : Add vendor option (code come from prores_ks encoder) > 013 : Only write color properties, if defined in rdd36 (other values are > "converted" to unspecified) > 014 : Add

Re: [FFmpeg-devel] [RFC] VDD FFmpeg session and community survey

2018-11-26 Thread Tobias Rapp
On 24.11.2018 16:32, Tomas Härdin wrote: [...] While I'm in here I have a small suggestion: talking is better than writing when it comes to interpersonal conflicts. Using Mumble or Jingle or whatever and getting the relevant people to talk can be a good way to avoid more drastic measures.

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize yuv2plane1_8

2018-11-26 Thread Lauri Kasanen
On Mon, 26 Nov 2018 11:03:55 +0300 Michael Kostylev wrote: > > http://fate.xffm.org/?sort=arch > /ppc Yeah, mentioned in the commit message. Follow-up patch coming today. - Lauri ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org