Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat: add vividas demuxer

2018-12-21 Thread Carl Eugen Hoyos
2018-12-20 19:33 GMT+01:00, Paul B Mahol : > ffmpeg | branch: master | Paul B Mahol | Mon Dec 10 > 12:15:50 2018 +0100| [d06aae732c16bd4c490c6dfa35cc2a35129c640f] | committer: > Paul B Mahol > > avformat: add vividas demuxer Crashes here on stream-copying a sample from

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Fri, Dec 21, 2018 at 11:24 AM James Almer wrote: > > On 12/21/2018 1:09 PM, James Zern wrote: > > On Thu, Dec 20, 2018 at 7:51 PM Rene Claus > > wrote: > >> > >> This commit adds configuration options to libvpxenc.c that can be used to > >> tune the sharpness parameter for VP8 and VP9. > >> >

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Fri, Dec 21, 2018 at 1:36 PM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 6 ++ > 2 files

Re: [FFmpeg-devel] [PATCH] Fix unnecessary buffer reallocotion in ffio_ensure_seekback().

2018-12-21 Thread Michael Niedermayer
On Thu, Dec 20, 2018 at 11:11:45AM +0200, Artyom Lebedev wrote: > On 12/19/18 8:49 PM, Michael Niedermayer wrote: > >On Wed, Dec 19, 2018 at 02:33:49PM +0200, Artyom Lebedev wrote: > >>It was reallocated even if the exisiting buffer is larger than needed one, > >>thus unnecessary shrinking it. >

Re: [FFmpeg-devel] [PATCH 1/2] fate: add dst decoder test

2018-12-21 Thread Peter Ross
On Sat, Dec 22, 2018 at 12:26:05AM +0100, Carl Eugen Hoyos wrote: > 2018-12-21 3:32 GMT+01:00, Peter Ross : > > --- > > the dst sample file is 40 kilobytes. > > You could attach it... here is the file. cheers, -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) dst-64fs44-2ch.dff

Re: [FFmpeg-devel] [PATCH 1/2] fate: add dst decoder test

2018-12-21 Thread Carl Eugen Hoyos
2018-12-21 3:32 GMT+01:00, Peter Ross : > --- > the dst sample file is 40 kilobytes. You could attach it... Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-21 Thread Carl Eugen Hoyos
2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos : > The Opus struct RawBitsContext is used in both the decoder and the encoder. > The fact that *position is const avoids warnings in the decoder where > it points into the bitstream. The encoder writes into the same > pointer, attached cast silences

Re: [FFmpeg-devel] [PATCH 1/2] add support for ROI-based encoding

2018-12-21 Thread Carl Eugen Hoyos
2018-12-21 17:36 GMT+01:00, Derek Buitenhuis : > On 12/12/2018 16:26, Guo, Yejun wrote: >> +if (frame->rois_buf != NULL) { >> +if (x4->params.rc.i_aq_mode == X264_AQ_NONE) { >> +av_log(ctx, AV_LOG_ERROR, "Adaptive quantization >> must be enabled to use ROI

[FFmpeg-devel] [PATCH]configure: Make sure libpostproc can be found if -rpath-link doesn't work

2018-12-21 Thread Carl Eugen Hoyos
Hi! Attached patch fixes running fate with "--enable-shared --enable-gpl" on Solaris, the linker searches "libpostproc" in a directory"-link=libpostproc". Only tested on Solaris. Please comment, Carl Eugen From d69f1fcee41e803e5208bbfabdeb37a19e73814b Mon Sep 17 00:00:00 2001 From: Carl Eugen

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-21 Thread Steinar H. Gunderson
On Fri, Dec 21, 2018 at 05:07:45PM +0100, Paul B Mahol wrote: > The colors that PhotoCD uses predates color space definitions. Really? It looks fairly well-defined to me, though esoteric (the gamma ramp is basically like sRGB but with a much bigger constant, and the 8-bit Y'CbCr scaling seems

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-21 Thread Carl Eugen Hoyos
2018-12-20 0:52 GMT+01:00, Peter Ross : > also where can i find a sample to fuzz test? See http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket5923/ Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-21 Thread Carl Eugen Hoyos
2018-12-21 19:48 GMT+01:00, Paul B Mahol : > +if (s->luma) { > +ptr = p->data[0]; > + > +for (int y = 0; y < avctx->height; y++) { > +for (int x = 0; x < avctx->width; x++) { > +ptr[x] = av_clip_uint8(ptr[x] * 1.35); > +} Without this

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: unset DTS/PTS for subtitle PES packets if PCR not available

2018-12-21 Thread Jan Ekström
On Fri, Dec 21, 2018 at 9:04 PM Jan Ekström wrote: > > On Wed, Dec 19, 2018 at 8:56 PM Michael Niedermayer > wrote: > > > > On Sat, Dec 15, 2018 at 08:50:41PM +0200, Jan Ekström wrote: > > > Fixes issues when a subtitle packet is received before PCR for the > > > program has been received,

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: unset DTS/PTS for subtitle PES packets if PCR not available

2018-12-21 Thread Jan Ekström
On Wed, Dec 19, 2018 at 8:56 PM Michael Niedermayer wrote: > > On Sat, Dec 15, 2018 at 08:50:41PM +0200, Jan Ekström wrote: > > Fixes issues when a subtitle packet is received before PCR for the > > program has been received, leading to wildly jumping timestamps > > on the lavf client side as

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-21 Thread Paul B Mahol
On 12/20/18, Peter Ross wrote: > also where can i find a sample to fuzz test? You can create small samples with ImageMagick/GraphicsMagick otherwise use google skills. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-21 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/photocd.c| 493 5 files changed, 503 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread Rene Claus
This commit adds configuration options to libvpxenc.c that can be used to tune the sharpness parameter for VP8 and VP9. Signed-off-by: Rene Claus --- doc/encoders.texi | 4 libavcodec/libvpxenc.c | 6 ++ 2 files changed, 10 insertions(+) diff --git a/doc/encoders.texi

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-21 Thread Paul B Mahol
On 12/21/18, Paul B Mahol wrote: > On 12/21/18, Carl Eugen Hoyos wrote: >> >> >>> Am 21.12.2018 um 16:43 schrieb Paul B Mahol : >>> On 12/21/18, Carl Eugen Hoyos wrote: 2018-12-20 10:02 GMT+01:00, Paul B Mahol : >> On 12/20/18, Carl Eugen Hoyos wrote: >> 2018-12-19 21:32

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SMPTE 2094-40) to libavutil.

2018-12-21 Thread Vittorio Giovara
On Thu, Dec 20, 2018 at 8:14 PM Mohammad Izadi wrote: > From: Mohammad Izadi > > The dynamic metadata contains data for color volume transform - > application 4 of SMPTE 2094-40:2016 standard. The data comes from HEVC in > the SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35. > > pushed, thanks --

Re: [FFmpeg-devel] [PATCH 1/2] add support for ROI-based encoding

2018-12-21 Thread Derek Buitenhuis
A few comments below. On 12/12/2018 16:26, Guo, Yejun wrote: > +if (frame->rois_buf != NULL) { > +if (x4->params.rc.i_aq_mode == X264_AQ_NONE) { > +av_log(ctx, AV_LOG_ERROR, "Adaptive quantization must be > enabled to use ROI encoding, skipping ROI.\n"); This

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Almer
On 12/21/2018 1:09 PM, James Zern wrote: > On Thu, Dec 20, 2018 at 7:51 PM Rene Claus > wrote: >> >> This commit adds configuration options to libvpxenc.c that can be used to >> tune the sharpness parameter for VP8 and VP9. >> >> Signed-off-by: Rene Claus >> --- >> doc/encoders.texi | 4

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Thu, Dec 20, 2018 at 7:51 PM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 6 ++ > 2 files

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-21 Thread Paul B Mahol
On 12/21/18, Carl Eugen Hoyos wrote: > > >> Am 21.12.2018 um 16:43 schrieb Paul B Mahol : >> >>> On 12/21/18, Carl Eugen Hoyos wrote: >>> 2018-12-20 10:02 GMT+01:00, Paul B Mahol : > On 12/20/18, Carl Eugen Hoyos wrote: > 2018-12-19 21:32 GMT+01:00, Paul B Mahol : > >> +static

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-21 Thread Carl Eugen Hoyos
> Am 21.12.2018 um 16:43 schrieb Paul B Mahol : > >> On 12/21/18, Carl Eugen Hoyos wrote: >> 2018-12-20 10:02 GMT+01:00, Paul B Mahol : On 12/20/18, Carl Eugen Hoyos wrote: 2018-12-19 21:32 GMT+01:00, Paul B Mahol : > +static av_cold int photocd_decode_init(AVCodecContext

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-21 Thread Nicolas George
Paul B Mahol (2018-12-21): > I will ignore your comments as there is misunderstanding from your side. Unacceptable. If somebody has misunderstood something you wrote, then you need to explain better. -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-21 Thread Paul B Mahol
On 12/21/18, Carl Eugen Hoyos wrote: > 2018-12-20 10:02 GMT+01:00, Paul B Mahol : >> On 12/20/18, Carl Eugen Hoyos wrote: >>> 2018-12-19 21:32 GMT+01:00, Paul B Mahol : >>> +static av_cold int photocd_decode_init(AVCodecContext *avctx) +{ +avctx->pix_fmt=

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-21 Thread Carl Eugen Hoyos
2018-12-20 10:02 GMT+01:00, Paul B Mahol : > On 12/20/18, Carl Eugen Hoyos wrote: >> 2018-12-19 21:32 GMT+01:00, Paul B Mahol : >> >>> +static av_cold int photocd_decode_init(AVCodecContext *avctx) >>> +{ >>> +avctx->pix_fmt= AV_PIX_FMT_YUV420P; >> >> I very much welcome this patch but it

Re: [FFmpeg-devel] h264_v4l2m2m encoder segmentation fault (Samsung Exynos5422)

2018-12-21 Thread Roland Singer
Second thing I noticed is that flushing is broken for v4l2m2m encoders. > avcodec_send_frame(enc_ctx, NULL); should return AVERROR_EOF instead of continuing with an empty AVPacket with size=0. Hope we can get this fixed. Roland ___ ffmpeg-devel

Re: [FFmpeg-devel] h264_v4l2m2m encoder segmentation fault (Samsung Exynos5422)

2018-12-21 Thread Roland Singer
After some investigation I came to the conclusion, that av_frame_get_buffer does not allocate the buffers correctly. 1. frame->pix_fmt=AV_PIX_FMT_NV12 frame->width=64 frame->height=64 2. so we need a buffer with 2 planes of same size. First plane holds Y and second plane holds U and V

Re: [FFmpeg-devel] h264_v4l2m2m encoder segmentation fault (Samsung Exynos5422)

2018-12-21 Thread Roland Singer
I compiled ffmpeg with debug flags: > ./configure --prefix="/opt/ffmpeg" \ >--pkg-config-flags="--static" --disable-programs --disable-doc \ >--enable-gpl --enable-static --enable-pic --enable-v4l2_m2m \ >--disable-optimizations --disable-mmx --disable-stripping

Re: [FFmpeg-devel] h264_v4l2m2m encoder segmentation fault (Samsung Exynos5422)

2018-12-21 Thread Roland Singer
> Run: > $ gdb -ex r --args ./encode_video out h264_v4l2m2m > > At the core dump, type "bt" and press return. Post that backtrace. Or > analyze it, if you know what you are doing. Hi Moritz, thanks for the quick reply. I tried to debug the problem already, but the problem lies within

[FFmpeg-devel] [PATCH v2] avcodec/fft_template: libavcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-21 Thread Steven Liu
Before patch: init nbits = 17, get 1 samples, average cost: 16105 us After patch: init nbits = 17, get 1 samples, average cost: 15221 us Signed-off-by: Steven Liu --- libavcodec/fft_template.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] fate: add dst decoder test

2018-12-21 Thread Paul B Mahol
On 12/21/18, Peter Ross wrote: > --- > the dst sample file is 40 kilobytes. > i don't have write access to fate-suite to upload it. > > Please provide way to access it. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org