Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-02-27 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of myp...@gmail.com > Sent: Thursday, February 28, 2019 11:26 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI

Re: [FFmpeg-devel] [PATCH 4/5] vaapi_encode: Add ROI support

2019-02-27 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Thursday, February 28, 2019 6:00 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 4/5] vaapi_encode: Add ROI support > > --- > libavcodec/vaapi_encode

[FFmpeg-devel] The log level of "co located POCs unavailable" should not be ERROR

2019-02-27 Thread Yukun Guo
The error message "co located POCs unavailable" is reported when the co-located picture of an H.264 B frame is missing during spatial direct predition. It comes from this line: https://github.com/FFmpeg/FFmpeg/blob/n4.1.1/libavcodec/h264_direct.c#L156 and was originally commited for solving an issu

Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-02-27 Thread myp...@gmail.com
On Thu, Feb 28, 2019 at 10:53 AM Guo, Yejun wrote: > > > > > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Mark Thompson > > Sent: Thursday, February 28, 2019 6:00 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH 2/

Re: [FFmpeg-devel] [PATCH 3/5] libx265: Update ROI behaviour to match documentation

2019-02-27 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Thursday, February 28, 2019 6:00 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 3/5] libx265: Update ROI behaviour to > match documentation > > Equiv

Re: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-02-27 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Thursday, February 28, 2019 6:00 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to > match documentation > > Fix t

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: addroi filter

2019-02-27 Thread Mark Thompson
On 27/02/2019 23:42, Moritz Barsnick wrote: > On Wed, Feb 27, 2019 at 22:00:23 +, Mark Thompson wrote: >> +static const AVOption addroi_options[] = { >> +{ "top","Region distance from top edge of frame", >> + OFFSET(region_str[TOP]),AV_OPT_TYPE_STRING, { .str = "0" }, >> .flag

[FFmpeg-devel] [PATCH v3 1/2] lavfi/vaapi: Improve support for colour properties

2019-02-27 Thread Mark Thompson
Attempts to pick the set of supported colour properties best matching the input. Output is then set with the same values, except for the colour matrix which may change when converting between RGB and YUV. --- Not much change since the version sent two months ago - rebased, and the transpose filte

[FFmpeg-devel] [PATCH v3 2/2] vf_scale_vaapi: Add options to configure output colour properties

2019-02-27 Thread Mark Thompson
The "out_color_matrix" and "out_range" properties match the same options in vf_scale; the others attempt to follow the same pattern. --- libavfilter/vf_scale_vaapi.c | 70 1 file changed, 70 insertions(+) diff --git a/libavfilter/vf_scale_vaapi.c b/libavfilter

[FFmpeg-devel] [PATCH] avcodec/scpr: Fix use of uninitialized variable

2019-02-27 Thread Michael Niedermayer
Fixes: Undefined shift Fixes: 12911/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-5677102915911680 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/scpr.c | 2 +- 1 file changed

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: addroi filter

2019-02-27 Thread Moritz Barsnick
On Wed, Feb 27, 2019 at 22:00:23 +, Mark Thompson wrote: > +static const AVOption addroi_options[] = { > +{ "top","Region distance from top edge of frame", > + OFFSET(region_str[TOP]),AV_OPT_TYPE_STRING, { .str = "0" }, .flags > = FLAGS }, > +{ "bottom", "Region distance f

[FFmpeg-devel] [PATCH] avformat/westwood_aud: Adds PCM format demux.

2019-02-27 Thread Aidan R
PCM format AUD files are found in Westwood's Blade Runner game. --- libavformat/westwood_aud.c | 80 -- 1 file changed, 63 insertions(+), 17 deletions(-) diff --git a/libavformat/westwood_aud.c b/libavformat/westwood_aud.c index 9c2d35cb8a..5d7e827bc1 1

[FFmpeg-devel] [PATCH 1/5] lavu/frame: Expand ROI documentation

2019-02-27 Thread Mark Thompson
Clarify and add examples for the behaviour of the quantisation offset, and define how multiple ranges should be handled. --- libavutil/frame.h | 62 +++ 1 file changed, 46 insertions(+), 16 deletions(-) diff --git a/libavutil/frame.h b/libavutil/frame.h

[FFmpeg-devel] [PATCH 3/5] libx265: Update ROI behaviour to match documentation

2019-02-27 Thread Mark Thompson
Equivalent to the previous patch for libx264. --- libavcodec/libx265.c | 41 - 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 98415366da..af1a2b2287 100644 --- a/libavcodec/libx265.c +++ b/li

[FFmpeg-devel] [PATCH 4/5] vaapi_encode: Add ROI support

2019-02-27 Thread Mark Thompson
--- libavcodec/vaapi_encode.c | 129 libavcodec/vaapi_encode.h | 9 +++ libavcodec/vaapi_encode_h264.c | 2 + libavcodec/vaapi_encode_h265.c | 2 + libavcodec/vaapi_encode_mpeg2.c | 2 + libavcodec/vaapi_encode_vp8.c | 2 + libavcodec/vaap

[FFmpeg-devel] [PATCH 2/5] libx264: Update ROI behaviour to match documentation

2019-02-27 Thread Mark Thompson
Fix the quantisation offset - use the whole range, and don't change the offset size based on bit depth. Use correct bottom/right edge locations (they are offsets from bottom/right, not from top/left). Iterate the list in reverse order. The regions are in order of decreasing importance, so the mo

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Mark Thompson
On 27/02/2019 10:22, Gyan wrote: > On 27-02-2019 01:57 PM, Guo, Yejun wrote: >> >>> -Original Message- >>> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >>> Of Guo, Yejun >>> Sent: Thursday, February 28, 2019 12:13 AM >>> To: ffmpeg-devel@ffmpeg.org >>> Subject: [FFm

[FFmpeg-devel] [PATCH 5/5] lavfi: addroi filter

2019-02-27 Thread Mark Thompson
This can be used to add region of interest side data to video frames. --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_addroi.c | 237 +++ 3 files changed, 239 insertions(+) create mode 100644 libavfilter/vf_addroi.c diff

Re: [FFmpeg-devel] [PATCH 0/5] Clean up CUDA SDK usage and remove non-free requirement

2019-02-27 Thread Timo Rothenpieler
On 21.02.2019 04:57, Philip Langdale wrote: I've been thinking about this for a while, but I only recently made the realisation that compiling cuda kernels to the ptx format does not introduce any non-free dependencies - the ptx files are an intermediate assembly code format that is actually comp

Re: [FFmpeg-devel] Blackfin optimizations

2019-02-27 Thread Lou Logan
On Wed, Feb 27, 2019, at 10:03 AM, Michael Noel wrote: > Hello, > > Can you pls. send me more details about the Blackfin optimizisations for > the ffmpeg? > > Thanks > Miki Blackfin optimization was removed from the ffmpeg years ago:

[FFmpeg-devel] Blackfin optimizations

2019-02-27 Thread Michael Noel
Hello, Can you pls. send me more details about the Blackfin optimizisations for the ffmpeg? Thanks Miki ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] ffmpeg dylibs for OSX

2019-02-27 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2019-02-27 08:12, Patrick Cusack wrote: > Does anyone have any experience building ffmpeg dylibs for Xcode? I > want to include ffmpeg shared libraries in my macOS binary bundle > for easy distribution. I think you have to be a bit more specific.

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Derek Buitenhuis
On 27/02/2019 17:57, Derek Buitenhuis wrote: > You're assuming a single ROI, though, which is only one case. Plenty of things > would need >1. Also note that sets of ROIs are per-frame. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Derek Buitenhuis
On 27/02/2019 17:31, Gyan wrote: > Yes, a string. 4 integers and qp offset so either two more, in rational > form, or a float. You're assuming a single ROI, though, which is only one case. Plenty of things would need >1. > There's already multiple interfaces accepting long multi-entry > multi-v

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Gyan
On 27-02-2019 10:32 PM, Derek Buitenhuis wrote: On 27/02/2019 13:48, Gyan wrote: Huh. I haven't suggested removing anything. I suggested *adding* a way for this feature to be useful for ffmpeg users in the near-term. Who knows how long will it take for a decent per-frame ROI filter, like the

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Derek Buitenhuis
On 27/02/2019 16:12, Guo, Yejun wrote: > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 132 > + > 1 file changed, 132 insertions(+) Do these APIs exist for all supported libvpx versions? > +if (!sd) { > +if (vpx_codec_con

Re: [FFmpeg-devel] GSoC 2019

2019-02-27 Thread Martin Vignali
Hello, I don't have knowledge to mentor a project, But two idea : - Swscale improvement : YAP8, YAP16 : useful to switch some decoder/encoder to planar Float/half float pixel format support - Open Exr Decoder : Add DWA decoder support 4:2:0 mode Martin _

Re: [FFmpeg-devel] fate/proresenc_aw : Add fate test for interlace and 444 encoding

2019-02-27 Thread Martin Vignali
> works here > > Pushed, thanks. Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Derek Buitenhuis
On 27/02/2019 13:48, Gyan wrote: > Huh. I haven't suggested removing anything. > > I suggested *adding* a way for this feature to be useful for ffmpeg > users in the near-term. Who knows how long will it take for a decent > per-frame ROI filter, like the facedetect example mentioned in the > in

Re: [FFmpeg-devel] avcodec/proresenc_aw : improve speed by replacing PutBitContext for codeword encoding

2019-02-27 Thread Martin Vignali
> > Shouldn’t there be a 64Bit PutBitContext instead so other encoders can > also profit? > > Carl Eugen > I only use here a small part of putbitcontext, and in an "unsafe" mode (the buffer of the prores aw encoder is big enough to not check it, and write 64 bits during the flush even if less can

Re: [FFmpeg-devel] [PATCH] Parallelize vf_lut

2019-02-27 Thread Michael Niedermayer
On Mon, Feb 25, 2019 at 03:25:30PM -0500, Britt Cyr wrote: > --- > libavfilter/vf_lut.c | 106 --- > 1 file changed, 70 insertions(+), 36 deletions(-) > > diff --git a/libavfilter/vf_lut.c b/libavfilter/vf_lut.c > index c815ddc194..14386938be 100644 > --- a

Re: [FFmpeg-devel] [PATCH] Fix sdp size check on fmtp integer parameters

2019-02-27 Thread Nicolas George
Michael Niedermayer (12019-02-27): > > if (attr_names[i].type == ATTR_NAME_TYPE_INT) { > > -int val = atoi(value); > > -if (val > 32) { > > +long int val = strtol(value, NULL, 10); > > +if (errno == ERA

Re: [FFmpeg-devel] [PATCH] Fix sdp size check on fmtp integer parameters

2019-02-27 Thread Michael Niedermayer
On Mon, Feb 25, 2019 at 02:54:50PM +0100, Olivier Maignial wrote: > --- > libavformat/rtpdec_mpeg4.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c > index 4f70599..f632ebf 100644 > --- a/libavformat/rtpdec_

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Gyan
On 27-02-2019 07:07 PM, Derek Buitenhuis wrote: On 27/02/2019 10:22, Gyan wrote: Looks like, at present, the only way to effect ROI is via side data, and no filter or other in-tree mechanism at present can convey or generate it. Life exists outside of ffmpeg.c, and it's an extremely useful AP

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Derek Buitenhuis
On 27/02/2019 10:22, Gyan wrote: > Looks like, at present, the only way to effect ROI is via side data, and > no filter or other in-tree mechanism at present can convey or generate it. Life exists outside of ffmpeg.c, and it's an extremely useful API to have. > Are there any near-term plans to a

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-02-27 Thread Michael Niedermayer
On Mon, Feb 25, 2019 at 07:07:27PM +0800, C.H.Liu wrote: > Would you mind share your input file? I still can’t reproduce the OOM. i belive i cannot share this sample, but the patch really needs to be fully reviewed not just one bug that was found by chance fixed otherwise we might be missing othe

[FFmpeg-devel] ffmpeg dylibs for OSX

2019-02-27 Thread Patrick Cusack
Does anyone have any experience building ffmpeg dylibs for Xcode? I want to include ffmpeg shared libraries in my macOS binary bundle for easy distribution. Patrick ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listi

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Gyan
On 27-02-2019 01:57 PM, Guo, Yejun wrote: -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Guo, Yejun Sent: Thursday, February 28, 2019 12:13 AM To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support fo

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Guo, Yejun > Sent: Thursday, February 28, 2019 12:13 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for > ROI-based encoding > > Signed

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- libavcodec/libvpxenc.c | 132 + 1 file changed, 132 insertions(+) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index c823b8a..e3de547 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@